92086 2012-07-24 02:28:49 -0700 [Qt][ARM]ARMAssembler needs buildfix afert r123417 2012-07-26 05:29:37 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 91788 1 ossy webkit-unassigned cmarcelo fpizlo ggaren lauro.neto webkit.review.bot zherczeg oldest_to_newest 676561 0 ossy 2012-07-24 02:28:49 -0700 After r123417 ARM build is broken with the following error: /home/webkitbuildbot/slaves/armv7Release/buildslave/qt-linux-armv7-release/build/Source/JavaScriptCore/dfg/DFGRepatch.cpp: In function 'bool JSC::DFG::tryCacheGetByID(JSC::ExecState*, JSC::JSValue, const JSC::Identifier&, const JSC::PropertySlot&, JSC::StructureStubInfo&)': /home/webkitbuildbot/slaves/armv7Release/buildslave/qt-linux-armv7-release/build/Source/JavaScriptCore/dfg/DFGRepatch.cpp:305: error: 'isCompactPtrAlignedAddressOffset' is not a member of 'JSC::MacroAssembler' Zoltán, could you check it, please? 679109 1 154596 zherczeg 2012-07-26 03:07:44 -0700 Created attachment 154596 patch 679129 2 154596 ossy 2012-07-26 03:44:51 -0700 Comment on attachment 154596 patch rs=me 679199 3 154596 webkit.review.bot 2012-07-26 05:29:33 -0700 Comment on attachment 154596 patch Clearing flags on attachment: 154596 Committed r123735: <http://trac.webkit.org/changeset/123735> 679200 4 webkit.review.bot 2012-07-26 05:29:37 -0700 All reviewed patches have been landed. Closing bug. 154596 2012-07-26 03:07:44 -0700 2012-07-26 05:29:33 -0700 patch 0001-buildfix.patch text/plain 5074 zherczeg RnJvbSAzN2QwNDY5NWNmMDAyMWZmMjJmMmI3ZDA3YTRjNDY1MjU0YzBhNzJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAd2Via2l0Lm9yZz4K RGF0ZTogVGh1LCAyNiBKdWwgMjAxMiAwMjo1MzoxNCAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIGJ1 aWxkZml4CgotLS0KIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgICAgIHwgICAyMSArKysrKysrKysrKysrKysrKysrCiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL0FSTUFzc2VtYmxlci5oICAgICB8ICAgMjIgKysrKysrKysrKysrLS0tLS0tLQog Li4uL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oICAgfCAgIDE0 ICsrKysrKysrKystLQogMyBmaWxlcyBjaGFuZ2VkLCA0NiBpbnNlcnRpb25zKCspLCAxMSBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAwZmZjYjk1Li4yMjEzYzc1IDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxMi0wNy0yNiAgWm9s dGFuIEhlcmN6ZWcgIDx6aGVyY3plZ0B3ZWJraXQub3JnPgorCisgICAgICAgIFtRdF1bQVJNXUFS TUFzc2VtYmxlciBuZWVkcyBidWlsZGZpeCBhZmVydCByMTIzNDE3CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjA4NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBBUk0gaW1wbGVtZW50YXRpb24gb2Yg dGhpcyBzaG91bGQgYmUgb3B0aW1pemVkIGNvZGUgcGF0aAorICAgICAgICBpcyBjb3ZlcmVkIGJ5 IGEgbm9uLW9wdGltaXplZCBjb2RlIHBhdGguIFRoaXMgcGF0Y2ggZml4ZXMgdGhpcywKKyAgICAg ICAgYW5kIGFkZHMgYSBuZXcgZnVuY3Rpb24gd2hpY2ggcmV0dXJucyB3aXRoIHRoZSBvZmZzZXQg cmFuZ2UuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvQVJNQXNzZW1ibGVyLmg6CisgICAgICAgIChK U0M6OkFSTUFzc2VtYmxlcjo6cmVhZFBvaW50ZXIpOgorICAgICAgICAoQVJNQXNzZW1ibGVyKToK KyAgICAgICAgKEpTQzo6QVJNQXNzZW1ibGVyOjpyZXBhdGNoSW50MzIpOgorICAgICAgICAoSlND OjpBUk1Bc3NlbWJsZXI6OnJlcGF0Y2hDb21wYWN0KToKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFj cm9Bc3NlbWJsZXJBUk0uaDoKKyAgICAgICAgKE1hY3JvQXNzZW1ibGVyQVJNKToKKyAgICAgICAg KEpTQzo6TWFjcm9Bc3NlbWJsZXJBUk06OmlzQ29tcGFjdFB0ckFsaWduZWRBZGRyZXNzT2Zmc2V0 KToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJBUk06OmxvYWQzMldpdGhDb21wYWN0QWRk cmVzc09mZnNldFBhdGNoKToKKwogMjAxMi0wNy0yNSAgTWFyayBIYWhuZW5iZXJnICA8bWhhaG5l bmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIEJ1aWxkIGZpeCBmb3IgMzItYml0IGFmdGVyIHIx MjM2ODIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNQXNz ZW1ibGVyLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTUFzc2VtYmxlci5o CmluZGV4IGEwZDdkMjcuLjg3YWVkODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvQVJNQXNzZW1ibGVyLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fz c2VtYmxlci9BUk1Bc3NlbWJsZXIuaApAQCAtODE3LDExICs4MTcsMTEgQEAgbmFtZXNwYWNlIEpT QyB7CiAgICAgICAgIC8vIFJlYWQgcG9pbnRlcnMKICAgICAgICAgc3RhdGljIHZvaWQqIHJlYWRQ b2ludGVyKHZvaWQqIGZyb20pCiAgICAgICAgIHsKLSAgICAgICAgICAgIEFSTVdvcmQqIGluc24g PSByZWludGVycHJldF9jYXN0PEFSTVdvcmQqPihmcm9tKTsKLSAgICAgICAgICAgIEFSTVdvcmQq IGFkZHIgPSBnZXRMZHJJbW1BZGRyZXNzKGluc24pOwotICAgICAgICAgICAgcmV0dXJuICpyZWlu dGVycHJldF9jYXN0PHZvaWQqKj4oYWRkcik7CisgICAgICAgICAgICBBUk1Xb3JkKiBpbnN0cnVj dGlvbiA9IHJlaW50ZXJwcmV0X2Nhc3Q8QVJNV29yZCo+KGZyb20pOworICAgICAgICAgICAgQVJN V29yZCogYWRkcmVzcyA9IGdldExkckltbUFkZHJlc3MoaW5zdHJ1Y3Rpb24pOworICAgICAgICAg ICAgcmV0dXJuICpyZWludGVycHJldF9jYXN0PHZvaWQqKj4oYWRkcmVzcyk7CiAgICAgICAgIH0K LSAgICAgICAgCisKICAgICAgICAgLy8gUGF0Y2ggcG9pbnRlcnMKIAogICAgICAgICBzdGF0aWMg dm9pZCBsaW5rUG9pbnRlcih2b2lkKiBjb2RlLCBBc3NlbWJsZXJMYWJlbCBmcm9tLCB2b2lkKiB0 bykKQEAgLTgyOSwxNCArODI5LDIwIEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICAgICAgcGF0 Y2hQb2ludGVySW50ZXJuYWwocmVpbnRlcnByZXRfY2FzdDxpbnRwdHJfdD4oY29kZSkgKyBmcm9t Lm1fb2Zmc2V0LCB0byk7CiAgICAgICAgIH0KIAotICAgICAgICBzdGF0aWMgdm9pZCByZXBhdGNo SW50MzIodm9pZCogZnJvbSwgaW50MzJfdCB0bykKKyAgICAgICAgc3RhdGljIHZvaWQgcmVwYXRj aEludDMyKHZvaWQqIHdoZXJlLCBpbnQzMl90IHRvKQogICAgICAgICB7Ci0gICAgICAgICAgICBw YXRjaFBvaW50ZXJJbnRlcm5hbChyZWludGVycHJldF9jYXN0PGludHB0cl90Pihmcm9tKSwgcmVp bnRlcnByZXRfY2FzdDx2b2lkKj4odG8pKTsKKyAgICAgICAgICAgIHBhdGNoUG9pbnRlckludGVy bmFsKHJlaW50ZXJwcmV0X2Nhc3Q8aW50cHRyX3Q+KHdoZXJlKSwgcmVpbnRlcnByZXRfY2FzdDx2 b2lkKj4odG8pKTsKICAgICAgICAgfQotICAgICAgICAKKwogICAgICAgICBzdGF0aWMgdm9pZCBy ZXBhdGNoQ29tcGFjdCh2b2lkKiB3aGVyZSwgaW50MzJfdCB2YWx1ZSkKICAgICAgICAgewotICAg ICAgICAgICAgcmVwYXRjaEludDMyKHdoZXJlLCB2YWx1ZSk7CisgICAgICAgICAgICBBUk1Xb3Jk KiBpbnN0cnVjdGlvbiA9IHJlaW50ZXJwcmV0X2Nhc3Q8QVJNV29yZCo+KHdoZXJlKTsKKyAgICAg ICAgICAgIEFTU0VSVCgoKmluc3RydWN0aW9uICYgMHgwZjcwMDAwMCkgPT0gTG9hZFVpbnQzMik7 CisgICAgICAgICAgICBpZiAodmFsdWUgPj0gMCkKKyAgICAgICAgICAgICAgICAqaW5zdHJ1Y3Rp b24gPSAoKmluc3RydWN0aW9uICYgMHhmZjdmZjAwMCkgfCBEVF9VUCB8IHZhbHVlOworICAgICAg ICAgICAgZWxzZQorICAgICAgICAgICAgICAgICppbnN0cnVjdGlvbiA9ICgqaW5zdHJ1Y3Rpb24g JiAweGZmN2ZmMDAwKSB8IC12YWx1ZTsKKyAgICAgICAgICAgIGNhY2hlRmx1c2goaW5zdHJ1Y3Rp b24sIHNpemVvZihBUk1Xb3JkKSk7CiAgICAgICAgIH0KIAogICAgICAgICBzdGF0aWMgdm9pZCBy ZXBhdGNoUG9pbnRlcih2b2lkKiBmcm9tLCB2b2lkKiB0bykKZGlmZiAtLWdpdCBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaCBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAppbmRleCAyNzczYjAyLi41 MzBmNjJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3Jv QXNzZW1ibGVyQVJNLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNy b0Fzc2VtYmxlckFSTS5oCkBAIC00MSw3ICs0MSw2IEBAIGNsYXNzIE1hY3JvQXNzZW1ibGVyQVJN IDogcHVibGljIEFic3RyYWN0TWFjcm9Bc3NlbWJsZXI8QVJNQXNzZW1ibGVyPiB7CiAgICAgQ09N UElMRV9BU1NFUlQoIShEb3VibGVDb25kaXRpb25CaXRTcGVjaWFsICYgRG91YmxlQ29uZGl0aW9u TWFzayksIERvdWJsZUNvbmRpdGlvbkJpdFNwZWNpYWxfc2hvdWxkX25vdF9pbnRlcmZlcmVfd2l0 aF9BUk1Bc3NlbWJsZXJfQ29uZGl0aW9uX2NvZGVzKTsKIHB1YmxpYzoKICAgICB0eXBlZGVmIEFS TVJlZ2lzdGVyczo6RlBSZWdpc3RlcklEIEZQUmVnaXN0ZXJJRDsKLSAgICBzdGF0aWMgY29uc3Qg aW50IE1heGltdW1Db21wYWN0UHRyQWxpZ25lZEFkZHJlc3NPZmZzZXQgPSAweDdGRkZGRkZGOwog CiAgICAgZW51bSBSZWxhdGlvbmFsQ29uZGl0aW9uIHsKICAgICAgICAgRXF1YWwgPSBBUk1Bc3Nl bWJsZXI6OkVRLApAQCAtNDA4LDExICs0MDcsMjAgQEAgcHVibGljOgogICAgICAgICBtX2Fzc2Vt Ymxlci5kdHJfdXIoQVJNQXNzZW1ibGVyOjpMb2FkVWludDMyLCBkZXN0LCBhZGRyZXNzLmJhc2Us IEFSTVJlZ2lzdGVyczo6UzApOwogICAgICAgICByZXR1cm4gZGF0YUxhYmVsOwogICAgIH0KLSAg ICAKKworICAgIHN0YXRpYyBib29sIGlzQ29tcGFjdFB0ckFsaWduZWRBZGRyZXNzT2Zmc2V0KHB0 cmRpZmZfdCB2YWx1ZSkKKyAgICB7CisgICAgICAgIHJldHVybiB2YWx1ZSA+PSAtNDA5NSAmJiB2 YWx1ZSA8PSA0MDk1OworICAgIH0KKwogICAgIERhdGFMYWJlbENvbXBhY3QgbG9hZDMyV2l0aENv bXBhY3RBZGRyZXNzT2Zmc2V0UGF0Y2goQWRkcmVzcyBhZGRyZXNzLCBSZWdpc3RlcklEIGRlc3Qp CiAgICAgewogICAgICAgICBEYXRhTGFiZWxDb21wYWN0IGRhdGFMYWJlbCh0aGlzKTsKLSAgICAg ICAgbG9hZDMyV2l0aEFkZHJlc3NPZmZzZXRQYXRjaChhZGRyZXNzLCBkZXN0KTsKKyAgICAgICAg QVNTRVJUKGlzQ29tcGFjdFB0ckFsaWduZWRBZGRyZXNzT2Zmc2V0KGFkZHJlc3Mub2Zmc2V0KSk7 CisgICAgICAgIGlmIChhZGRyZXNzLm9mZnNldCA+PSAwKQorICAgICAgICAgICAgbV9hc3NlbWJs ZXIuZHRyX3UoQVJNQXNzZW1ibGVyOjpMb2FkVWludDMyLCBkZXN0LCBhZGRyZXNzLmJhc2UsIGFk ZHJlc3Mub2Zmc2V0KTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgbV9hc3NlbWJsZXIuZHRy X2QoQVJNQXNzZW1ibGVyOjpMb2FkVWludDMyLCBkZXN0LCBhZGRyZXNzLmJhc2UsIGFkZHJlc3Mu b2Zmc2V0KTsKICAgICAgICAgcmV0dXJuIGRhdGFMYWJlbDsKICAgICB9CiAKLS0gCjEuNy4yLjUK Cg==