92054 2012-07-23 18:41:02 -0700 inline-table wrapper should be generated for display: inline element only 2012-07-24 10:44:52 -0700 1 1 1 Unclassified WebKit Tables 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jchaffraix jchaffraix inferno robert webkit.review.bot oldest_to_newest 676291 0 jchaffraix 2012-07-23 18:41:02 -0700 This is a follow-up of bug 15365. I misread the specification and allowed any inline formatting context to generate an inline-table wrapper. CSS 2.1 just takes the display into account: "If C's parent is an 'inline' box, then T must be an 'inline-table' box; otherwise it must be a 'table' box." (C is a proper table child) Patch forthcoming. 676883 1 154079 jchaffraix 2012-07-24 09:01:44 -0700 Created attachment 154079 Trivial patch. 676888 2 154079 inferno 2012-07-24 09:09:59 -0700 Comment on attachment 154079 Trivial patch. View in context: https://bugs.webkit.org/attachment.cgi?id=154079&action=review > Source/WebCore/ChangeLog:3 > + inline-table wrapper should be generated for display: inline element only Please add Regression(rXYZ): > LayoutTests/fast/table/inline-block-generates-table-wrapper-expected.html:9 > + display: table-cell; Is this display table ? in this expected testcase, we can even directly use the table and td tags. 676902 3 154079 jchaffraix 2012-07-24 09:21:11 -0700 Comment on attachment 154079 Trivial patch. View in context: https://bugs.webkit.org/attachment.cgi?id=154079&action=review >> Source/WebCore/ChangeLog:3 >> + inline-table wrapper should be generated for display: inline element only > > Please add Regression(rXYZ): It's not really a regression. The code was actually working due to another bug: we didn't check for table parts in RenderBlock::addChildIgnoringContinuation and thus would wrap table parts in an anonymous block, leading to the right behavior. This was confusing which is why I sided with fixing our check to match what the spec said. >> LayoutTests/fast/table/inline-block-generates-table-wrapper-expected.html:9 >> + display: table-cell; > > Is this display table ? in this expected testcase, we can even directly use the table and td tags. Good catch, it should be display: table or the test case is void. Using <td> or <table> is a not-so-great-an-idea due to the UA style sheet and the different behaviors between CSS and HTML tables. It's better to stick with CSS tables for consistency. 676934 4 154091 jchaffraix 2012-07-24 10:03:31 -0700 Created attachment 154091 Patch for landing 677005 5 154091 webkit.review.bot 2012-07-24 10:44:49 -0700 Comment on attachment 154091 Patch for landing Clearing flags on attachment: 154091 Committed r123492: <http://trac.webkit.org/changeset/123492> 677007 6 webkit.review.bot 2012-07-24 10:44:52 -0700 All reviewed patches have been landed. Closing bug. 154079 2012-07-24 09:01:44 -0700 2012-07-24 10:03:28 -0700 Trivial patch. bug-92054-20120724090136.patch text/plain 4975 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjQ5ODgxNjdlODljMjVk YTZjNDg1NDI3NjJkZWJlYTFhNmQ4MGMzNC4uMTg2YjJiODk3ZDZjYTVhMjkzOGNiODJiYmJjMzY5 YTYxMTBiMDZhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA3LTI0ICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIGlubGluZS10 YWJsZSB3cmFwcGVyIHNob3VsZCBiZSBnZW5lcmF0ZWQgZm9yIGRpc3BsYXk6IGlubGluZSBlbGVt ZW50IG9ubHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTkyMDU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q1NTIDIuMSBvbmx5IHRha2VzIGludG8gYWNjb3VudCB0aGUgZGlzcGxheSB3aGVuIGRldGVybWlu aW5nIGlmIHdlIHNob3VsZCBnZW5lcmF0ZQorICAgICAgICBhbiBpbmxpbmUtdGFibGUuIE15IG1p c3JlYWRpbmcgb2YgdGhlIHNwZWMgd291bGQgbWFrZSB1cyBnZW5lcmF0ZSBhbiBpbmxpbmUtdGFi bGUKKyAgICAgICAgd3JhcHBlciBmb3IgYW55IGlubGluZSBmb3JtYXR0aW5nIGNvbnRleHQuCisK KyAgICAgICAgVGVzdDogZmFzdC90YWJsZS9pbmxpbmUtYmxvY2stZ2VuZXJhdGVzLXRhYmxlLXdy YXBwZXIuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OlJlbmRlclRhYmxlOjpjcmVhdGVBbm9ueW1vdXNXaXRoUGFyZW50UmVuZGVy ZXIpOgorICAgICAgICBDaGFuZ2VkIHRvIHVzZSBkaXNwbGF5IGluc3RlYWQgb2YgaXNJbmxpbmUg dG8gcHJvcGVybHkgbWF0Y2ggdGhlIHNwZWMuCisKIDIwMTItMDctMjEgIFZpbmNlbnQgU2NoZWli ICA8c2NoZWliQGNocm9taXVtLm9yZz4KIAogICAgICAgICB3ZWJraXRGdWxsc2NyZWVuRWxlbWVu dCwgd2Via2l0Q3VycmVudEZ1bGxTY3JlZW5FbGVtZW50LCB3ZWJraXRQb2ludGVyTG9ja0VsZW1l bnQgYmxvY2sgY3Jvc3Mgb3JpZ2luIGFjY2Vzcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJUYWJsZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVGFibGUuY3BwCmluZGV4IDljMTE1YTAzNzZlZGU5YzQ4NzBjMWE2M2JiOGRmMzBhMTE5ZThm ODAuLjk0Nzg2MjVjY2FiMTZlMjE4NjUyNWJkNWY2ODc5ZWY3NTRmMTIyZTQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcApAQCAtMTI5Nyw3ICsxMjk3LDcgQEAgYm9v bCBSZW5kZXJUYWJsZTo6bm9kZUF0UG9pbnQoY29uc3QgSGl0VGVzdFJlcXVlc3QmIHJlcXVlc3Qs IEhpdFRlc3RSZXN1bHQmIHJlc3UKIFJlbmRlclRhYmxlKiBSZW5kZXJUYWJsZTo6Y3JlYXRlQW5v bnltb3VzV2l0aFBhcmVudFJlbmRlcmVyKGNvbnN0IFJlbmRlck9iamVjdCogcGFyZW50KQogewog ICAgIC8vIENTUyAyLjEsIHNlY3Rpb24gMTcuMi4xOiAiSWYgYSBwcm9wZXIgdGFibGUgY2hpbGQn cyBwYXJlbnQgaXMgYW4gJ2lubGluZScgYm94LCB0aGVuIHRoZSBnZW5lcmF0ZWQgYW5vbnltb3Vz IHRhYmxlIG11c3QgYmUgYW4gJ2lubGluZS10YWJsZScgYm94Ii4KLSAgICBFRGlzcGxheSB0YWJs ZURpc3BsYXkgPSBwYXJlbnQtPmlzSW5saW5lKCkgPyBJTkxJTkVfVEFCTEUgOiBUQUJMRTsKKyAg ICBFRGlzcGxheSB0YWJsZURpc3BsYXkgPSBwYXJlbnQtPnN0eWxlKCktPmRpc3BsYXkoKSA9PSBJ TkxJTkUgPyBJTkxJTkVfVEFCTEUgOiBUQUJMRTsKICAgICBSZWZQdHI8UmVuZGVyU3R5bGU+IG5l d1N0eWxlID0gUmVuZGVyU3R5bGU6OmNyZWF0ZUFub255bW91c1N0eWxlV2l0aERpc3BsYXkocGFy ZW50LT5zdHlsZSgpLCB0YWJsZURpc3BsYXkpOwogICAgIFJlbmRlclRhYmxlKiBuZXdUYWJsZSA9 IG5ldyAocGFyZW50LT5yZW5kZXJBcmVuYSgpKSBSZW5kZXJUYWJsZShwYXJlbnQtPmRvY3VtZW50 KCkgLyogaXMgYW5vbnltb3VzICovKTsKICAgICBuZXdUYWJsZS0+c2V0U3R5bGUobmV3U3R5bGUu cmVsZWFzZSgpKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRl c3RzL0NoYW5nZUxvZwppbmRleCAxMTM1YzUzMzE0ODRhZThhYjU4ODk0NzljYzY5YWE4ODU1ZTQx ZDFlLi5lYTU0NjM4M2IzNGM0NDkxZWYxM2IwYjI5ZDlhYWFkOTE2MGM2NmM5IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTYgQEAKKzIwMTItMDctMjQgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdl YmtpdC5vcmc+CisKKyAgICAgICAgaW5saW5lLXRhYmxlIHdyYXBwZXIgc2hvdWxkIGJlIGdlbmVy YXRlZCBmb3IgZGlzcGxheTogaW5saW5lIGVsZW1lbnQgb25seQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTIwNTQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb3Igc29tZSByZWFzb24sIHVzaW5nIGR1bXBB c1RleHQgZGlkbid0IGR1bXAgdGhlIDIgbGluZXMgcHJvcGVybHkgc28gdGhlIHRlc3QKKyAgICAg ICAgaXMgYSByZWZ0ZXN0IHRvIHdvcmstYXJvdW5kIHRoYXQuCisKKyAgICAgICAgKiBmYXN0L3Rh YmxlL2lubGluZS1ibG9jay1nZW5lcmF0ZXMtdGFibGUtd3JhcHBlci1leHBlY3RlZC5odG1sOiBB ZGRlZC4KKyAgICAgICAgKiBmYXN0L3RhYmxlL2lubGluZS1ibG9jay1nZW5lcmF0ZXMtdGFibGUt d3JhcHBlci5odG1sOiBBZGRlZC4KKwogMjAxMi0wNy0yMSAgVmluY2VudCBTY2hlaWIgIDxzY2hl aWJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIHdlYmtpdEZ1bGxzY3JlZW5FbGVtZW50LCB3ZWJr aXRDdXJyZW50RnVsbFNjcmVlbkVsZW1lbnQsIHdlYmtpdFBvaW50ZXJMb2NrRWxlbWVudCBibG9j ayBjcm9zcyBvcmlnaW4gYWNjZXNzLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC90YWJs ZS9pbmxpbmUtYmxvY2stZ2VuZXJhdGVzLXRhYmxlLXdyYXBwZXItZXhwZWN0ZWQuaHRtbCBiL0xh eW91dFRlc3RzL2Zhc3QvdGFibGUvaW5saW5lLWJsb2NrLWdlbmVyYXRlcy10YWJsZS13cmFwcGVy LWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTI0ZWM0MDc2ODUzZDI1NTEwMjg4NGFiNTMwNDIy NzAxM2Y2NDIzOQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvdGFibGUvaW5s aW5lLWJsb2NrLWdlbmVyYXRlcy10YWJsZS13cmFwcGVyLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCAr MSwyMiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxzdHlsZT4KKzxoZWFkPgorLndyYXBw ZXIgeworICAgIGRpc3BsYXk6IGlubGluZS1ibG9jazsKK30KKy50YWJsZSB7CisgICAgZGlzcGxh eTogdGFibGUtY2VsbDsKK30KKy5jZWxsIHsKKyAgICBkaXNwbGF5OiB0YWJsZS1jZWxsOworfQor PC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5PgorPHA+QnVnIDkyMDU0OiBpbmxpbmUtdGFibGUgd3Jh cHBlciBzaG91bGQgYmUgZ2VuZXJhdGVkIGZvciBkaXNwbGF5OiBpbmxpbmUgZWxlbWVudCBvbmx5 LjwvcD4KKzxwPlRoaXMgdGVzdCBjaGVja3MgdGhhdCB3ZSBkb24ndCBnZW5lcmF0ZSBhbiBpbmxp bmUtdGFibGUgd3JhcHBlciBpbnNpZGUgYW4gaW5saW5lLWJsb2NrLjwvcD4KKzxwPlRoaXMgdGVz dCBoYXMgUEFTU0VEIGlmIHRoZXJlIGlzIDIgbGluZXMgYmVsb3cuPC9wPgorPGRpdiBjbGFzcz0i d3JhcHBlciI+PHNwYW4+Rmlyc3QgbGluZS48L3NwYW4+PHNwYW4gY2xhc3M9InRhYmxlIj48c3Bh biBjbGFzcz0iY2VsbCI+U2Vjb25kIGxpbmUuPC9zcGFuPjwvc3Bhbj48L2Rpdj4KKzwvYm9keT4K KzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvdGFibGUvaW5saW5lLWJsb2Nr LWdlbmVyYXRlcy10YWJsZS13cmFwcGVyLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2lu bGluZS1ibG9jay1nZW5lcmF0ZXMtdGFibGUtd3JhcHBlci5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjkwZmMy NWFhNmY2Njc4NGVmNmJlYTM4YWE3YjM4MzA5NWExMzIyNGUKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L3RhYmxlL2lubGluZS1ibG9jay1nZW5lcmF0ZXMtdGFibGUtd3JhcHBl ci5odG1sCkBAIC0wLDAgKzEsMTkgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8c3R5bGU+ Cis8aGVhZD4KKy53cmFwcGVyIHsKKyAgICBkaXNwbGF5OiBpbmxpbmUtYmxvY2s7Cit9CisuY2Vs bCB7CisgICAgZGlzcGxheTogdGFibGUtY2VsbDsKK30KKzwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9k eT4KKzxwPkJ1ZyA5MjA1NDogaW5saW5lLXRhYmxlIHdyYXBwZXIgc2hvdWxkIGJlIGdlbmVyYXRl ZCBmb3IgZGlzcGxheTogaW5saW5lIGVsZW1lbnQgb25seS48L3A+Cis8cD5UaGlzIHRlc3QgY2hl Y2tzIHRoYXQgd2UgZG9uJ3QgZ2VuZXJhdGUgYW4gaW5saW5lLXRhYmxlIHdyYXBwZXIgaW5zaWRl IGFuIGlubGluZS1ibG9jay48L3A+Cis8cD5UaGlzIHRlc3QgaGFzIFBBU1NFRCBpZiB0aGVyZSBp cyAyIGxpbmVzIGJlbG93LjwvcD4KKzxkaXYgY2xhc3M9IndyYXBwZXIiPjxzcGFuPkZpcnN0IGxp bmUuPC9zcGFuPjxzcGFuIGNsYXNzPSJjZWxsIj5TZWNvbmQgbGluZS48L3NwYW4+PC9kaXY+Cis8 L2JvZHk+Cis8L2h0bWw+Cg== 154091 2012-07-24 10:03:31 -0700 2012-07-24 10:44:49 -0700 Patch for landing bug-92054-20120724100322.patch text/plain 4947 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNDg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmEzZTQwMjk5ODhiZmVk MWIxOGMxMDE5ZjYxOTBhZDQ2MzQwMjEwMC4uMTQ2MmUwZDAzNzdlNWI5MTI3YTczNDE5NWY5YTFl ODA4YjQ1YjBlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA3LTI0ICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIGlubGluZS10 YWJsZSB3cmFwcGVyIHNob3VsZCBiZSBnZW5lcmF0ZWQgZm9yIGRpc3BsYXk6IGlubGluZSBlbGVt ZW50IG9ubHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTkyMDU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWJoaXNoZWsgQXJ5YS4KKworICAgICAgICBD U1MgMi4xIG9ubHkgdGFrZXMgaW50byBhY2NvdW50IHRoZSBkaXNwbGF5IHdoZW4gZGV0ZXJtaW5p bmcgaWYgd2Ugc2hvdWxkIGdlbmVyYXRlCisgICAgICAgIGFuIGlubGluZS10YWJsZS4gTXkgbWlz cmVhZGluZyBvZiB0aGUgc3BlYyB3b3VsZCBtYWtlIHVzIGdlbmVyYXRlIGFuIGlubGluZS10YWJs ZQorICAgICAgICB3cmFwcGVyIGZvciBhbnkgaW5saW5lIGZvcm1hdHRpbmcgY29udGV4dC4KKwor ICAgICAgICBUZXN0OiBmYXN0L3RhYmxlL2lubGluZS1ibG9jay1nZW5lcmF0ZXMtdGFibGUtd3Jh cHBlci5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGFibGUuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UmVuZGVyVGFibGU6OmNyZWF0ZUFub255bW91c1dpdGhQYXJlbnRSZW5kZXJl cik6CisgICAgICAgIENoYW5nZWQgdG8gdXNlIGRpc3BsYXkgaW5zdGVhZCBvZiBpc0lubGluZSB0 byBwcm9wZXJseSBtYXRjaCB0aGUgc3BlYy4KKwogMjAxMi0wNy0yNCAgRGFuIEJlcm5zdGVpbiAg PG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMTk0NTEwMj4gUkVH UkVTU0lPTiAocjEwOTQ1MSk6IE92ZXJsYXkgc2Nyb2xsYmFycyBhbHdheXMgdXNlIHRoZSBkZWZh dWx0IHN0eWxlLCByZWdhcmRsZXNzIG9mIGJhY2tncm91bmQgY29sb3IKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyVGFibGUuY3BwCmluZGV4IDljMTE1YTAzNzZlZGU5YzQ4NzBjMWE2M2Ji OGRmMzBhMTE5ZThmODAuLjk0Nzg2MjVjY2FiMTZlMjE4NjUyNWJkNWY2ODc5ZWY3NTRmMTIyZTQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcApAQCAtMTI5Nyw3ICsx Mjk3LDcgQEAgYm9vbCBSZW5kZXJUYWJsZTo6bm9kZUF0UG9pbnQoY29uc3QgSGl0VGVzdFJlcXVl c3QmIHJlcXVlc3QsIEhpdFRlc3RSZXN1bHQmIHJlc3UKIFJlbmRlclRhYmxlKiBSZW5kZXJUYWJs ZTo6Y3JlYXRlQW5vbnltb3VzV2l0aFBhcmVudFJlbmRlcmVyKGNvbnN0IFJlbmRlck9iamVjdCog cGFyZW50KQogewogICAgIC8vIENTUyAyLjEsIHNlY3Rpb24gMTcuMi4xOiAiSWYgYSBwcm9wZXIg dGFibGUgY2hpbGQncyBwYXJlbnQgaXMgYW4gJ2lubGluZScgYm94LCB0aGVuIHRoZSBnZW5lcmF0 ZWQgYW5vbnltb3VzIHRhYmxlIG11c3QgYmUgYW4gJ2lubGluZS10YWJsZScgYm94Ii4KLSAgICBF RGlzcGxheSB0YWJsZURpc3BsYXkgPSBwYXJlbnQtPmlzSW5saW5lKCkgPyBJTkxJTkVfVEFCTEUg OiBUQUJMRTsKKyAgICBFRGlzcGxheSB0YWJsZURpc3BsYXkgPSBwYXJlbnQtPnN0eWxlKCktPmRp c3BsYXkoKSA9PSBJTkxJTkUgPyBJTkxJTkVfVEFCTEUgOiBUQUJMRTsKICAgICBSZWZQdHI8UmVu ZGVyU3R5bGU+IG5ld1N0eWxlID0gUmVuZGVyU3R5bGU6OmNyZWF0ZUFub255bW91c1N0eWxlV2l0 aERpc3BsYXkocGFyZW50LT5zdHlsZSgpLCB0YWJsZURpc3BsYXkpOwogICAgIFJlbmRlclRhYmxl KiBuZXdUYWJsZSA9IG5ldyAocGFyZW50LT5yZW5kZXJBcmVuYSgpKSBSZW5kZXJUYWJsZShwYXJl bnQtPmRvY3VtZW50KCkgLyogaXMgYW5vbnltb3VzICovKTsKICAgICBuZXdUYWJsZS0+c2V0U3R5 bGUobmV3U3R5bGUucmVsZWFzZSgpKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBlZGFlMzk1NjM4ZjdmMGE5MmE5MWZlN2Rj Yjc0MDIyOTNjZWVkZmY2Li5jOTdhZTNiNWI1ZjE0N2EyZDliMjg0NTRjYTE3MTA0MmYwYjk1OGY0 IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDctMjQgIEp1bGllbiBDaGFmZnJhaXggIDxq Y2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAgaW5saW5lLXRhYmxlIHdyYXBwZXIgc2hv dWxkIGJlIGdlbmVyYXRlZCBmb3IgZGlzcGxheTogaW5saW5lIGVsZW1lbnQgb25seQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTIwNTQKKworICAgICAg ICBSZXZpZXdlZCBieSBBYmhpc2hlayBBcnlhLgorCisgICAgICAgIEZvciBzb21lIHJlYXNvbiwg dXNpbmcgZHVtcEFzVGV4dCBkaWRuJ3QgZHVtcCB0aGUgMiBsaW5lcyBwcm9wZXJseSBzbyB0aGUg dGVzdAorICAgICAgICBpcyBhIHJlZnRlc3QgdG8gd29yay1hcm91bmQgdGhhdC4KKworICAgICAg ICAqIGZhc3QvdGFibGUvaW5saW5lLWJsb2NrLWdlbmVyYXRlcy10YWJsZS13cmFwcGVyLWV4cGVj dGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvdGFibGUvaW5saW5lLWJsb2NrLWdlbmVy YXRlcy10YWJsZS13cmFwcGVyLmh0bWw6IEFkZGVkLgorCiAyMDEyLTA3LTI0ICBOaWNvIFdlYmVy ICA8bmljb2xhc3dlYmVyQGdteC5kZT4KIAogICAgICAgICBbY2hyb21pdW1dIEFkZCBwaXhlbCBl eHBlY3RhdGlvbnMgZm9yIG5ldyB0ZXN0IHNjcm9sbGJhci10aWNrbWFya3Mtc3R5bGVkLmh0bWwK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvdGFibGUvaW5saW5lLWJsb2NrLWdlbmVyYXRl cy10YWJsZS13cmFwcGVyLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2lu bGluZS1ibG9jay1nZW5lcmF0ZXMtdGFibGUtd3JhcHBlci1leHBlY3RlZC5odG1sCm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLjBmYmQ2NDg3ZWUxNmExODFmNzAyNzU5M2Y3YjQ0Yjg3MWE3Mzg1N2UKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3RhYmxlL2lubGluZS1ibG9jay1nZW5lcmF0ZXMtdGFi bGUtd3JhcHBlci1leHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsMjIgQEAKKzwhRE9DVFlQRSBodG1s PgorPGh0bWw+Cis8c3R5bGU+Cis8aGVhZD4KKy53cmFwcGVyIHsKKyAgICBkaXNwbGF5OiBpbmxp bmUtYmxvY2s7Cit9CisudGFibGUgeworICAgIGRpc3BsYXk6IHRhYmxlOworfQorLmNlbGwgewor ICAgIGRpc3BsYXk6IHRhYmxlLWNlbGw7Cit9Cis8L3N0eWxlPgorPC9oZWFkPgorPGJvZHk+Cis8 cD5CdWcgOTIwNTQ6IGlubGluZS10YWJsZSB3cmFwcGVyIHNob3VsZCBiZSBnZW5lcmF0ZWQgZm9y IGRpc3BsYXk6IGlubGluZSBlbGVtZW50IG9ubHkuPC9wPgorPHA+VGhpcyB0ZXN0IGNoZWNrcyB0 aGF0IHdlIGRvbid0IGdlbmVyYXRlIGFuIGlubGluZS10YWJsZSB3cmFwcGVyIGluc2lkZSBhbiBp bmxpbmUtYmxvY2suPC9wPgorPHA+VGhpcyB0ZXN0IGhhcyBQQVNTRUQgaWYgdGhlcmUgaXMgMiBs aW5lcyBiZWxvdy48L3A+Cis8ZGl2IGNsYXNzPSJ3cmFwcGVyIj48c3Bhbj5GaXJzdCBsaW5lLjwv c3Bhbj48c3BhbiBjbGFzcz0idGFibGUiPjxzcGFuIGNsYXNzPSJjZWxsIj5TZWNvbmQgbGluZS48 L3NwYW4+PC9zcGFuPjwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC90YWJsZS9pbmxpbmUtYmxvY2stZ2VuZXJhdGVzLXRhYmxlLXdyYXBwZXIuaHRt bCBiL0xheW91dFRlc3RzL2Zhc3QvdGFibGUvaW5saW5lLWJsb2NrLWdlbmVyYXRlcy10YWJsZS13 cmFwcGVyLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTBmYzI1YWE2ZjY2Nzg0ZWY2YmVhMzhhYTdiMzgzMDk1 YTEzMjI0ZQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvdGFibGUvaW5saW5l LWJsb2NrLWdlbmVyYXRlcy10YWJsZS13cmFwcGVyLmh0bWwKQEAgLTAsMCArMSwxOSBAQAorPCFE T0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxzdHlsZT4KKzxoZWFkPgorLndyYXBwZXIgeworICAgIGRp c3BsYXk6IGlubGluZS1ibG9jazsKK30KKy5jZWxsIHsKKyAgICBkaXNwbGF5OiB0YWJsZS1jZWxs OworfQorPC9zdHlsZT4KKzwvaGVhZD4KKzxib2R5PgorPHA+QnVnIDkyMDU0OiBpbmxpbmUtdGFi bGUgd3JhcHBlciBzaG91bGQgYmUgZ2VuZXJhdGVkIGZvciBkaXNwbGF5OiBpbmxpbmUgZWxlbWVu dCBvbmx5LjwvcD4KKzxwPlRoaXMgdGVzdCBjaGVja3MgdGhhdCB3ZSBkb24ndCBnZW5lcmF0ZSBh biBpbmxpbmUtdGFibGUgd3JhcHBlciBpbnNpZGUgYW4gaW5saW5lLWJsb2NrLjwvcD4KKzxwPlRo aXMgdGVzdCBoYXMgUEFTU0VEIGlmIHRoZXJlIGlzIDIgbGluZXMgYmVsb3cuPC9wPgorPGRpdiBj bGFzcz0id3JhcHBlciI+PHNwYW4+Rmlyc3QgbGluZS48L3NwYW4+PHNwYW4gY2xhc3M9ImNlbGwi PlNlY29uZCBsaW5lLjwvc3Bhbj48L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4K