92051 2012-07-23 18:01:00 -0700 run-perf-tests --build-directory doesn't work 2012-09-13 14:34:16 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 77037 1 slewis rniwa abarth dpranke kbr ojan rniwa webkit.review.bot zoltan oldest_to_newest 676259 0 slewis 2012-07-23 18:01:00 -0700 It would be nice if run-perf-tests would let you specify the location a webkit build in addition --no-build. Then it would be easy to compare different revisions without having to rebuild/copy builds in between runs. 684064 1 zoltan 2012-08-01 04:04:40 -0700 (In reply to comment #0) > It would be nice if run-perf-tests would let you specify the location a webkit build in addition --no-build. Then it would be easy to compare different revisions without having to rebuild/copy builds in between runs. It makes sense. On Qt-port run-perf-tests --build-directory ... doesn't work for me. Can you verify that is working for you? 684241 2 155821 rniwa 2012-08-01 09:35:50 -0700 Created attachment 155821 Patch 684243 3 rniwa 2012-08-01 09:36:34 -0700 This was a mind-blowingly silly bug. 684276 4 rniwa 2012-08-01 10:22:14 -0700 It might make sense for --no-build to automatically turn on when --build-directory is specified. Otherwise we'll just fail after trying to build DRT. 684563 5 rniwa 2012-08-01 14:03:03 -0700 Committed r124366: <http://trac.webkit.org/changeset/124366> 719957 6 dpranke 2012-09-13 14:34:16 -0700 see https://bugs.webkit.org/show_bug.cgi?id=91890 and http://trac.webkit.org/changeset/123530 :). 155821 2012-08-01 09:35:50 -0700 2012-08-01 09:57:36 -0700 Patch bug-92051-20120801093532.patch text/plain 2343 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEyNDMzOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDEyLTA4LTAxICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIHJ1bi1wZXJmLXRlc3RzIC0tYnVpbGQtZGlyZWN0b3J5IGRvZXNuJ3Qgd29yawor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTIwNTEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYnVnIHdh cyBjYXVzZWQgYnkgbm90IHByZXBlbmRpbmcgYnVpbGRfZGlyZWN0b3J5IGV2ZW4gd2hlbiBvbmUg aXMgZGVmaW5lZC4KKyAgICAgICAgRml4ZWQgdGhhdC4KKworICAgICAgICAqIFNjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZS5weToKKyAgICAgICAgKFBvcnQuX2J1aWxkX3Bh dGgpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYmFzZV91 bml0dGVzdC5weToKKyAgICAgICAgKFBvcnRUZXN0LnRlc3RfYnVpbGRfcGF0aCk6CisKIDIwMTIt MDgtMDEgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjQzMjUuCkluZGV4OiBUb29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHkKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv U2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlLnB5CShyZXZpc2lvbiAxMjQz MzcpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2UucHkJ KHdvcmtpbmcgY29weSkKQEAgLTExNTEsNyArMTE1MSw3IEBAIGNsYXNzIFBvcnQob2JqZWN0KToK ICAgICAgICAgaWYgbm90IHJvb3RfZGlyZWN0b3J5OgogICAgICAgICAgICAgYnVpbGRfZGlyZWN0 b3J5ID0gc2VsZi5nZXRfb3B0aW9uKCdidWlsZF9kaXJlY3RvcnknKQogICAgICAgICAgICAgaWYg YnVpbGRfZGlyZWN0b3J5OgotICAgICAgICAgICAgICAgIHJvb3RfZGlyZWN0b3J5ID0gc2VsZi5f ZmlsZXN5c3RlbS5qb2luKHNlbGYuZ2V0X29wdGlvbignY29uZmlndXJhdGlvbicpKQorICAgICAg ICAgICAgICAgIHJvb3RfZGlyZWN0b3J5ID0gc2VsZi5fZmlsZXN5c3RlbS5qb2luKGJ1aWxkX2Rp cmVjdG9yeSwgc2VsZi5nZXRfb3B0aW9uKCdjb25maWd1cmF0aW9uJykpCiAgICAgICAgICAgICBl bHNlOgogICAgICAgICAgICAgICAgIHJvb3RfZGlyZWN0b3J5ID0gc2VsZi5fY29uZmlnLmJ1aWxk X2RpcmVjdG9yeShzZWxmLmdldF9vcHRpb24oJ2NvbmZpZ3VyYXRpb24nKSkKICAgICAgICAgICAg ICMgU2V0IC0tcm9vdCBzbyB0aGF0IHdlIGNhbiBwYXNzIHRoaXMgdG8gc3VicHJvY2Vzc2VzIGFu ZCBhdm9pZCBtYWtpbmcgdGhlCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9wb3J0L2Jhc2VfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9iYXNlX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAxMjQz MzcpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Jhc2VfdW5p dHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTQzNyw2ICs0MzcsMTAgQEAgY2xhc3MgUG9ydFRl c3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICBzZWxmLmFzc2VydEZhbHNlKCdwYXNzZXMv dGV4dC5odG1sJyBpbiB0ZXN0cykKICAgICAgICAgc2VsZi5hc3NlcnRUcnVlKCd2aXJ0dWFsL3Bh c3Nlcy90ZXh0Lmh0bWwnIGluIHRlc3RzKQogCisgICAgZGVmIHRlc3RfYnVpbGRfcGF0aChzZWxm KToKKyAgICAgICAgcG9ydCA9IHNlbGYubWFrZV9wb3J0KG9wdGlvbnM9b3B0cGFyc2UuVmFsdWVz KHsnYnVpbGRfZGlyZWN0b3J5JzogJy9teS1idWlsZC1kaXJlY3RvcnkvJ30pKQorICAgICAgICBz ZWxmLmFzc2VydEVxdWFsKHBvcnQuX2J1aWxkX3BhdGgoKSwgJy9teS1idWlsZC1kaXJlY3Rvcnkv UmVsZWFzZScpCisKIAogaWYgX19uYW1lX18gPT0gJ19fbWFpbl9fJzoKICAgICB1bml0dGVzdC5t YWluKCkK