92032 2012-07-23 14:49:09 -0700 Report the extra memory used by immutable StylePropertySet objects. 2012-07-23 15:57:02 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling cmarcelo macpherson menard webkit.review.bot oldest_to_newest 676028 0 kling 2012-07-23 14:49:09 -0700 If StylePropertySet::m_isMutable is false, the object is actually larger than sizeof(StylePropertySet) - it's sizeof(StylePropertySet) + m_arraySize * sizeof(CSSProperty). We should include this in reportMemoryUsage() to get more accurate numbers in the Inspector. 676038 1 153869 kling 2012-07-23 14:55:26 -0700 Created attachment 153869 Patch 676121 2 153869 kling 2012-07-23 15:56:56 -0700 Comment on attachment 153869 Patch Clearing flags on attachment: 153869 Committed r123396: <http://trac.webkit.org/changeset/123396> 676122 3 kling 2012-07-23 15:57:02 -0700 All reviewed patches have been landed. Closing bug. 153869 2012-07-23 14:55:26 -0700 2012-07-23 15:56:55 -0700 Patch bug-92032.diff text/plain 3357 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5ZDIwNjk0Li4yMjE2ZmRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQg QEAKIDIwMTItMDctMjMgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIFJlcG9ydCB0aGUgZXh0cmEgbWVtb3J5IHVzZWQgYnkgaW1tdXRhYmxlIFN0eWxlUHJvcGVy dHlTZXQgb2JqZWN0cy4KKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvOTIwMzI+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGFuIG9wdGlv bmFsIHBhcmFtZXRlciB0byB0aGUgTWVtb3J5Q2xhc3NJbmZvIGNvbnN0cnVjdG9yIGZvciBwYXNz aW5nIGluIGFkZGl0aW9uYWwgYmFzZSBvYmplY3QKKyAgICAgICAgc2l6ZSBvbiB0b3Agb2Ygc2l6 ZW9mKFQpLgorCisgICAgICAgIFVzZSB0aGlzIGluIFN0eWxlUHJvcGVydHlTZXQ6OnJlcG9ydE1l bW9yeVVzYWdlKCkgdG8gcHJvcGVybHkgYWNjb3VudCBmb3IgdGhlIENTU1Byb3BlcnR5IGFycmF5 CisgICAgICAgIHRhY2tlZCBvbnRvIHRoZSBlbmQgb2YgdGhlIG9iamVjdCB3aGVuIG1faXNNdXRh YmxlID09IGZhbHNlLgorCisgICAgICAgICogY3NzL1N0eWxlUHJvcGVydHlTZXQuaDoKKyAgICAg ICAgKFdlYkNvcmU6OlN0eWxlUHJvcGVydHlTZXQ6OnJlcG9ydE1lbW9yeVVzYWdlKToKKyAgICAg ICAgKiBkb20vTWVtb3J5SW5zdHJ1bWVudGF0aW9uLmg6CisgICAgICAgIChXZWJDb3JlOjpNZW1v cnlPYmplY3RJbmZvOjpyZXBvcnRPYmplY3RJbmZvKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lbW9y eUNsYXNzSW5mbzo6TWVtb3J5Q2xhc3NJbmZvKToKKworMjAxMi0wNy0yMyAgQW5kcmVhcyBLbGlu ZyAgPGtsaW5nQHdlYmtpdC5vcmc+CisKICAgICAgICAgTWFrZSBFbGVtZW50QXR0cmlidXRlRGF0 YSBhIHZhcmlhYmxlLXNpemVkIG9iamVjdCB0byByZWR1Y2UgbWVtb3J5IHVzZS4KICAgICAgICAg PGh0dHA6Ly93ZWJraXQub3JnL2IvODgyNDA+CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2Nzcy9TdHlsZVByb3BlcnR5U2V0LmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0 eVNldC5oCmluZGV4IGYyYmM1NDQuLmFjZDM3MGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2Nzcy9TdHlsZVByb3BlcnR5U2V0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJv cGVydHlTZXQuaApAQCAtMTE4LDcgKzExOCw3IEBAIHB1YmxpYzoKICAgICAKICAgICB2b2lkIHJl cG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVjdEluZm8qIG1lbW9yeU9iamVjdEluZm8pIGNvbnN0 CiAgICAgewotICAgICAgICBNZW1vcnlDbGFzc0luZm88U3R5bGVQcm9wZXJ0eVNldD4gaW5mbyht ZW1vcnlPYmplY3RJbmZvLCB0aGlzLCBNZW1vcnlJbnN0cnVtZW50YXRpb246OkNTUyk7CisgICAg ICAgIE1lbW9yeUNsYXNzSW5mbzxTdHlsZVByb3BlcnR5U2V0PiBpbmZvKG1lbW9yeU9iamVjdElu Zm8sIHRoaXMsIE1lbW9yeUluc3RydW1lbnRhdGlvbjo6Q1NTLCBtX2FycmF5U2l6ZSAqIHNpemVv ZihDU1NQcm9wZXJ0eSkpOwogICAgICAgICBpZiAobV9pc011dGFibGUpCiAgICAgICAgICAgICBp bmZvLmFkZE1lbWJlcihtX211dGFibGVQcm9wZXJ0eVZlY3Rvcik7CiAgICAgfQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvZG9tL01lbW9yeUluc3RydW1lbnRhdGlvbi5oIGIvU291cmNlL1dl YkNvcmUvZG9tL01lbW9yeUluc3RydW1lbnRhdGlvbi5oCmluZGV4IDExNGY5NmUuLjE1OTNhOTUg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9NZW1vcnlJbnN0cnVtZW50YXRpb24uaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTWVtb3J5SW5zdHJ1bWVudGF0aW9uLmgKQEAgLTE1Nywx MiArMTU3LDEyIEBAIHB1YmxpYzoKIHByaXZhdGU6CiAgICAgdGVtcGxhdGUgPHR5cGVuYW1lIFQ+ IGZyaWVuZCBjbGFzcyBNZW1vcnlDbGFzc0luZm87CiAKLSAgICB0ZW1wbGF0ZSA8dHlwZW5hbWUg VD4gdm9pZCByZXBvcnRPYmplY3RJbmZvKGNvbnN0IFQqLCBNZW1vcnlJbnN0cnVtZW50YXRpb246 Ok9iamVjdFR5cGUgb2JqZWN0VHlwZSkKKyAgICB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4gdm9pZCBy ZXBvcnRPYmplY3RJbmZvKGNvbnN0IFQqLCBNZW1vcnlJbnN0cnVtZW50YXRpb246Ok9iamVjdFR5 cGUgb2JqZWN0VHlwZSwgc2l6ZV90IGV4dHJhT2JqZWN0U2l6ZSkKICAgICB7CiAgICAgICAgIGlm IChtX29iamVjdFR5cGUgIT0gTWVtb3J5SW5zdHJ1bWVudGF0aW9uOjpPdGhlcikKICAgICAgICAg ICAgIHJldHVybjsKICAgICAgICAgbV9vYmplY3RUeXBlID0gb2JqZWN0VHlwZTsKLSAgICAgICAg bV9vYmplY3RTaXplID0gc2l6ZW9mKFQpOworICAgICAgICBtX29iamVjdFNpemUgPSBzaXplb2Yo VCkgKyBleHRyYU9iamVjdFNpemU7CiAgICAgfQogCiAgICAgTWVtb3J5SW5zdHJ1bWVudGF0aW9u KiBtX21lbW9yeUluc3RydW1lbnRhdGlvbjsKQEAgLTE5MSwxMSArMTkxLDExIEBAIHZvaWQgTWVt b3J5SW5zdHJ1bWVudGF0aW9uOjphZGRJbnN0cnVtZW50ZWRNZW1iZXJJbXBsKGNvbnN0IFQqIGNv bnN0JiBvYmplY3QsIE1lCiB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4KIGNsYXNzIE1lbW9yeUNsYXNz SW5mbyB7CiBwdWJsaWM6Ci0gICAgTWVtb3J5Q2xhc3NJbmZvKE1lbW9yeU9iamVjdEluZm8qIG1l bW9yeU9iamVjdEluZm8sIGNvbnN0IFQqIHB0ciwgTWVtb3J5SW5zdHJ1bWVudGF0aW9uOjpPYmpl Y3RUeXBlIG9iamVjdFR5cGUpCisgICAgTWVtb3J5Q2xhc3NJbmZvKE1lbW9yeU9iamVjdEluZm8q IG1lbW9yeU9iamVjdEluZm8sIGNvbnN0IFQqIHB0ciwgTWVtb3J5SW5zdHJ1bWVudGF0aW9uOjpP YmplY3RUeXBlIG9iamVjdFR5cGUsIHNpemVfdCBleHRyYU9iamVjdFNpemUgPSAwKQogICAgICAg ICA6IG1fbWVtb3J5T2JqZWN0SW5mbyhtZW1vcnlPYmplY3RJbmZvKQogICAgICAgICAsIG1fbWVt b3J5SW5zdHJ1bWVudGF0aW9uKG1lbW9yeU9iamVjdEluZm8tPm1lbW9yeUluc3RydW1lbnRhdGlv bigpKQogICAgIHsKLSAgICAgICAgbV9tZW1vcnlPYmplY3RJbmZvLT5yZXBvcnRPYmplY3RJbmZv KHB0ciwgb2JqZWN0VHlwZSk7CisgICAgICAgIG1fbWVtb3J5T2JqZWN0SW5mby0+cmVwb3J0T2Jq ZWN0SW5mbyhwdHIsIG9iamVjdFR5cGUsIGV4dHJhT2JqZWN0U2l6ZSk7CiAgICAgICAgIG1fb2Jq ZWN0VHlwZSA9IG1lbW9yeU9iamVjdEluZm8tPm9iamVjdFR5cGUoKTsKICAgICB9CiAK