92030 2012-07-23 14:47:38 -0700 [chromium] Fix unit tests in debug mode after r123375 2012-07-23 16:06:37 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shawnsingh shawnsingh enne webkit.review.bot oldest_to_newest 676024 0 shawnsingh 2012-07-23 14:47:38 -0700 A few unit tests were triggering assertions because of the refactoring done in r123375. That revision added an assertion to make sure that the root layer is not empty when given to calcDrawTransforms -- there is no reason to believe this assertion is too aggressive, and its good that it triggers. Patch coming in a moment that fixes the unit tests that trigger the assertion, they now use a non-zero size for the root layer. 676037 1 153868 shawnsingh 2012-07-23 14:55:13 -0700 Created attachment 153868 Patch 676042 2 shawnsingh 2012-07-23 14:59:46 -0700 I supposed it would help to CC a reviewer =) 676072 3 153868 enne 2012-07-23 15:22:41 -0700 Comment on attachment 153868 Patch R=me. 676131 4 153868 webkit.review.bot 2012-07-23 16:06:33 -0700 Comment on attachment 153868 Patch Clearing flags on attachment: 153868 Committed r123398: <http://trac.webkit.org/changeset/123398> 676132 5 webkit.review.bot 2012-07-23 16:06:37 -0700 All reviewed patches have been landed. Closing bug. 153868 2012-07-23 14:55:13 -0700 2012-07-23 16:06:33 -0700 Patch fix.patch text/plain 3361 shawnsingh ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggNzg4NWNkOC4uMzA1YzZkMCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wNy0yMyAgU2hhd24gU2lu Z2ggIDxzaGF3bnNpbmdoQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEZpeCB1 bml0IHRlc3RzIGluIGRlYnVnIG1vZGUgYWZ0ZXIgcjEyMzM3NQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTIwMzAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCB0d28gdW5pdCB0ZXN0cyB0aGF0IHdl cmUgY2F1c2luZyBkZWJ1ZyBhc3NlcnRpb25zIGJlY2F1c2UKKyAgICAgICAgdGhleSBnYXZlIGNh bGNEcmF3VHJhbnNmb3JtcyBhbiBlbXB0eSBzaXplZCByb290IGxheWVyLgorCisgICAgICAgICog dGVzdHMvQ0NMYXllclRyZWVIb3N0Q29tbW9uVGVzdC5jcHA6CisKIDIwMTItMDctMjMgIFNpbW9u IEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUGFydCAyIG9mOiBJ bXBsZW1lbnQgc3RpY2t5IHBvc2l0aW9uaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL3Rlc3RzL0NDTGF5ZXJUcmVlSG9zdENvbW1vblRlc3QuY3BwIGIvU291cmNlL1dlYktp dC9jaHJvbWl1bS90ZXN0cy9DQ0xheWVyVHJlZUhvc3RDb21tb25UZXN0LmNwcAppbmRleCAwZTNl M2VjLi43NzJmOTJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0ND TGF5ZXJUcmVlSG9zdENvbW1vblRlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v dGVzdHMvQ0NMYXllclRyZWVIb3N0Q29tbW9uVGVzdC5jcHAKQEAgLTE2MCwxNCArMTYwLDEyIEBA IFRFU1QoQ0NMYXllclRyZWVIb3N0Q29tbW9uVGVzdCwgdmVyaWZ5VHJhbnNmb3Jtc0Zvck5vT3BM YXllcikKICAgICBjaGlsZC0+YWRkQ2hpbGQoZ3JhbmRDaGlsZCk7CiAKICAgICBXZWJUcmFuc2Zv cm1hdGlvbk1hdHJpeCBpZGVudGl0eU1hdHJpeDsKLSAgICBzZXRMYXllclByb3BlcnRpZXNGb3JU ZXN0aW5nKHBhcmVudC5nZXQoKSwgaWRlbnRpdHlNYXRyaXgsIGlkZW50aXR5TWF0cml4LCBGbG9h dFBvaW50KDAsIDApLCBGbG9hdFBvaW50KDAsIDApLCBJbnRTaXplKDAsIDApLCBmYWxzZSk7Cisg ICAgc2V0TGF5ZXJQcm9wZXJ0aWVzRm9yVGVzdGluZyhwYXJlbnQuZ2V0KCksIGlkZW50aXR5TWF0 cml4LCBpZGVudGl0eU1hdHJpeCwgRmxvYXRQb2ludCgwLCAwKSwgRmxvYXRQb2ludCgwLCAwKSwg SW50U2l6ZSgxMDAsIDEwMCksIGZhbHNlKTsKICAgICBzZXRMYXllclByb3BlcnRpZXNGb3JUZXN0 aW5nKGNoaWxkLmdldCgpLCBpZGVudGl0eU1hdHJpeCwgaWRlbnRpdHlNYXRyaXgsIEZsb2F0UG9p bnQoMCwgMCksIEZsb2F0UG9pbnQoMCwgMCksIEludFNpemUoMCwgMCksIGZhbHNlKTsKICAgICBz ZXRMYXllclByb3BlcnRpZXNGb3JUZXN0aW5nKGdyYW5kQ2hpbGQuZ2V0KCksIGlkZW50aXR5TWF0 cml4LCBpZGVudGl0eU1hdHJpeCwgRmxvYXRQb2ludCgwLCAwKSwgRmxvYXRQb2ludCgwLCAwKSwg SW50U2l6ZSgwLCAwKSwgZmFsc2UpOwogCiAgICAgZXhlY3V0ZUNhbGN1bGF0ZURyYXdUcmFuc2Zv cm1zQW5kVmlzaWJpbGl0eShwYXJlbnQuZ2V0KCkpOwogCi0gICAgRVhQRUNUX1RSQU5TRk9STUFU SU9OX01BVFJJWF9FUShpZGVudGl0eU1hdHJpeCwgcGFyZW50LT5kcmF3VHJhbnNmb3JtKCkpOwot ICAgIEVYUEVDVF9UUkFOU0ZPUk1BVElPTl9NQVRSSVhfRVEoaWRlbnRpdHlNYXRyaXgsIHBhcmVu dC0+c2NyZWVuU3BhY2VUcmFuc2Zvcm0oKSk7CiAgICAgRVhQRUNUX1RSQU5TRk9STUFUSU9OX01B VFJJWF9FUShpZGVudGl0eU1hdHJpeCwgY2hpbGQtPmRyYXdUcmFuc2Zvcm0oKSk7CiAgICAgRVhQ RUNUX1RSQU5TRk9STUFUSU9OX01BVFJJWF9FUShpZGVudGl0eU1hdHJpeCwgY2hpbGQtPnNjcmVl blNwYWNlVHJhbnNmb3JtKCkpOwogICAgIEVYUEVDVF9UUkFOU0ZPUk1BVElPTl9NQVRSSVhfRVEo aWRlbnRpdHlNYXRyaXgsIGdyYW5kQ2hpbGQtPmRyYXdUcmFuc2Zvcm0oKSk7CkBAIC0xODMsOSAr MTgxLDExIEBAIFRFU1QoQ0NMYXllclRyZWVIb3N0Q29tbW9uVGVzdCwgdmVyaWZ5VHJhbnNmb3Jt c0ZvclNpbmdsZUxheWVyKQogICAgIC8vIENhc2UgMTogc2V0dGluZyB0aGUgc3VibGF5ZXIgdHJh bnNmb3JtIHNob3VsZCBub3QgYWZmZWN0IHRoaXMgbGF5ZXIncyBkcmF3IHRyYW5zZm9ybSBvciBz Y3JlZW4tc3BhY2UgdHJhbnNmb3JtLgogICAgIFdlYlRyYW5zZm9ybWF0aW9uTWF0cml4IGFyYml0 cmFyeVRyYW5zbGF0aW9uOwogICAgIGFyYml0cmFyeVRyYW5zbGF0aW9uLnRyYW5zbGF0ZSgxMCwg MjApOwotICAgIHNldExheWVyUHJvcGVydGllc0ZvclRlc3RpbmcobGF5ZXIuZ2V0KCksIGlkZW50 aXR5TWF0cml4LCBhcmJpdHJhcnlUcmFuc2xhdGlvbiwgRmxvYXRQb2ludCgwLCAwKSwgRmxvYXRQ b2ludCgwLCAwKSwgSW50U2l6ZSgwLCAwKSwgZmFsc2UpOworICAgIHNldExheWVyUHJvcGVydGll c0ZvclRlc3RpbmcobGF5ZXIuZ2V0KCksIGlkZW50aXR5TWF0cml4LCBhcmJpdHJhcnlUcmFuc2xh dGlvbiwgRmxvYXRQb2ludCgwLCAwKSwgRmxvYXRQb2ludCgwLCAwKSwgSW50U2l6ZSgxMDAsIDEw MCksIGZhbHNlKTsKICAgICBleGVjdXRlQ2FsY3VsYXRlRHJhd1RyYW5zZm9ybXNBbmRWaXNpYmls aXR5KGxheWVyLmdldCgpKTsKLSAgICBFWFBFQ1RfVFJBTlNGT1JNQVRJT05fTUFUUklYX0VRKGlk ZW50aXR5TWF0cml4LCBsYXllci0+ZHJhd1RyYW5zZm9ybSgpKTsKKyAgICBXZWJUcmFuc2Zvcm1h dGlvbk1hdHJpeCBleHBlY3RlZERyYXdUcmFuc2Zvcm0gPSBpZGVudGl0eU1hdHJpeDsKKyAgICBl eHBlY3RlZERyYXdUcmFuc2Zvcm0udHJhbnNsYXRlKDUwLCA1MCk7CisgICAgRVhQRUNUX1RSQU5T Rk9STUFUSU9OX01BVFJJWF9FUShleHBlY3RlZERyYXdUcmFuc2Zvcm0sIGxheWVyLT5kcmF3VHJh bnNmb3JtKCkpOwogICAgIEVYUEVDVF9UUkFOU0ZPUk1BVElPTl9NQVRSSVhfRVEoaWRlbnRpdHlN YXRyaXgsIGxheWVyLT5zY3JlZW5TcGFjZVRyYW5zZm9ybSgpKTsKIAogICAgIC8vIENhc2UgMjog c2V0dGluZyB0aGUgYm91bmRzIG9mIHRoZSBsYXllciBzaG91bGQgcmVzdWx0IGluIGEgZHJhdyB0 cmFuc2Zvcm0gdGhhdCB0cmFuc2xhdGVzIHRvIGhhbGYgdGhlIHdpZHRoIGFuZCBoZWlnaHQuCg==