92021 2012-07-23 12:54:25 -0700 [chromium] Fix build on Ubuntu Precise. 2012-07-24 03:03:19 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dcheng dcheng enne nayankk piman webkit.review.bot oldest_to_newest 675919 0 dcheng 2012-07-23 12:54:25 -0700 Otherwise, building ToT Chrome in debug mode with the components build results in the following warning: ../../third_party/WebKit/Source/WebKit/chromium/tests/CCResourceProviderTest.cpp: In member function 'virtual void {anonymous}::CCResourceProviderTest_DeleteOwnedResources_Test::TestBody()': ../../third_party/WebKit/Source/WebKit/chromium/tests/CCResourceProviderTest.cpp:242:36: error: vari able 'ids' set but not used [-Werror=unused-but-set-variable] cc1plus: all warnings being treated as errors 675925 1 153846 dcheng 2012-07-23 12:57:49 -0700 Created attachment 153846 Patch 675932 2 piman 2012-07-23 13:05:30 -0700 LGTM 675933 3 153846 enne 2012-07-23 13:09:21 -0700 Comment on attachment 153846 Patch R=me. 675942 4 153846 webkit.review.bot 2012-07-23 13:22:48 -0700 Comment on attachment 153846 Patch Clearing flags on attachment: 153846 Committed r123370: <http://trac.webkit.org/changeset/123370> 675943 5 webkit.review.bot 2012-07-23 13:22:51 -0700 All reviewed patches have been landed. Closing bug. 676590 6 nayankk 2012-07-24 03:03:19 -0700 *** Bug 91974 has been marked as a duplicate of this bug. *** 153846 2012-07-23 12:57:49 -0700 2012-07-23 13:22:47 -0700 Patch bug-92021-20120723125741.patch text/plain 1630 dcheng U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMzM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGRhMDU4ZmU1YjJjNmNlZjlkZDI1ODFiMjg0YmY4NDJkNDdmOTc5MDMuLjg0OGIyOGZmNDFjY2Yz YjNiMzYzMjJjYjBhYWNjY2FkZDAxNzAxMGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDctMjMgIERhbmllbCBDaGVuZyAgPGRjaGVuZ0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBGaXggYnVpbGQgb24gVWJ1bnR1IFByZWNpc2Uu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MjAyMQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBh biBhcnJheSB0aGF0J3Mgd3JpdHRlbiBidXQgbmV2ZXIgcmVhZC4KKworICAgICAgICAqIHRlc3Rz L0NDUmVzb3VyY2VQcm92aWRlclRlc3QuY3BwOgorICAgICAgICAoV2ViS2l0OjpURVNUX0YpOgor CiAyMDEyLTA3LTIzICBQZXRlciBCZXZlcmxvbyAgPHBldGVyQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBbQ2hyb21pdW1dIEJ1aWxkZml4IGZvciBmaXhpbmcgZ2NsaWVudCBvbiB0aGUgQ2hyb21p dW0gV2luZG93cyBib3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMv Q0NSZXNvdXJjZVByb3ZpZGVyVGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3Rz L0NDUmVzb3VyY2VQcm92aWRlclRlc3QuY3BwCmluZGV4IDU3MTY1ZTZjYTdmYzI1NDIxMmY5ZGQy YjcxNWQ0YjRiMzM3NDJjOTguLmIyYzQxZTUyNWRkOTVjZmY5YjZhYzBmNGVkMDVkZDI4MjAxNjAy ZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ0NSZXNvdXJjZVBy b3ZpZGVyVGVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9DQ1Jlc291 cmNlUHJvdmlkZXJUZXN0LmNwcApAQCAtMjM5LDkgKzIzOSw4IEBAIFRFU1RfRihDQ1Jlc291cmNl UHJvdmlkZXJUZXN0LCBEZWxldGVPd25lZFJlc291cmNlcykKICAgICBpbnQgcG9vbCA9IDE7CiAK ICAgICBjb25zdCBpbnQgY291bnQgPSAzOwotICAgIENDUmVzb3VyY2VQcm92aWRlcjo6UmVzb3Vy Y2VJZCBpZHNbY291bnRdID0gezB9OwogICAgIGZvciAoaW50IGkgPSAwOyBpIDwgY291bnQ7ICsr aSkKLSAgICAgICAgaWRzW2ldID0gbV9yZXNvdXJjZVByb3ZpZGVyLT5jcmVhdGVSZXNvdXJjZShw b29sLCBzaXplLCBmb3JtYXQsIENDUmVzb3VyY2VQcm92aWRlcjo6VGV4dHVyZVVzYWdlQW55KTsK KyAgICAgICAgbV9yZXNvdXJjZVByb3ZpZGVyLT5jcmVhdGVSZXNvdXJjZShwb29sLCBzaXplLCBm b3JtYXQsIENDUmVzb3VyY2VQcm92aWRlcjo6VGV4dHVyZVVzYWdlQW55KTsKICAgICBFWFBFQ1Rf RVEoMywgY29udGV4dCgpLT50ZXh0dXJlQ291bnQoKSk7CiAKICAgICBtX3Jlc291cmNlUHJvdmlk ZXItPmRlbGV0ZU93bmVkUmVzb3VyY2VzKHBvb2wrMSk7Cg==