91988 2012-07-23 06:32:47 -0700 [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing 2012-09-11 08:12:09 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 cmarcelo luciano.wolf luciano.wolf webkit.review.bot oldest_to_newest 675669 0 cmarcelo 2012-07-23 06:32:47 -0700 The TABs are not being added in the result. I didn't investigate it deeply, but it could be a problem with out eventSender.keyDown implementation for WK2. 716507 1 163208 luciano.wolf 2012-09-10 14:21:28 -0700 Created attachment 163208 Fix TAB problem setting QKeyEvent keyText value 716538 2 163208 cmarcelo 2012-09-10 14:45:04 -0700 Comment on attachment 163208 Fix TAB problem setting QKeyEvent keyText value View in context: https://bugs.webkit.org/attachment.cgi?id=163208&action=review Nice fixing that :) > Tools/ChangeLog:10 > + QKeyEvent must have keyText information. Doing an experiment with QWidget > + and intercepting it's keyPress event it's possible to notice that TAB key > + returns a keyCode (Qt::Key_Tab) + a keyText ("\t"). You can omit your experiment, and add that "Regular key events generated by Qt for the tab key fill both keyCode and keyText, so we should do the same for our fake events." > Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp:134 > + keyText = QString("\t"); Should we use QStringLiteral here? :-) http://woboq.com/blog/qstringliteral.html 716561 3 163217 luciano.wolf 2012-09-10 15:00:23 -0700 Created attachment 163217 Updated patch - after Caio's review 717178 4 163217 webkit.review.bot 2012-09-11 08:12:06 -0700 Comment on attachment 163217 Updated patch - after Caio's review Clearing flags on attachment: 163217 Committed r128189: <http://trac.webkit.org/changeset/128189> 717179 5 webkit.review.bot 2012-09-11 08:12:09 -0700 All reviewed patches have been landed. Closing bug. 163208 2012-09-10 14:21:28 -0700 2012-09-10 15:00:18 -0700 Fix TAB problem setting QKeyEvent keyText value bug-91988-20120910182104.patch text/plain 3097 luciano.wolf U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MDYwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTdlM2M0YTAyODQ4YzY1YjVlOGZlYjUwMWYwZGU1NTlh ODA3MzhkZC4uZmU4YjcxYWE2NjJiMjQyN2E5NmM2ZDRhZjFkODIyMzc2MTAxYzU5OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA5LTEwICBMdWNpYW5vIFdvbGYgIDxsdWNpYW5vLndvbGZAb3BlbmJvc3NhLm9y Zz4KKworICAgICAgICBbUXRdIFtXSzJdIGVkaXRpbmcvaW5zZXJ0aW5nL3R5cGluZy10YWItZGVz aWdubW9kZSB0ZXN0cyBhcmUgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTE5ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBRS2V5RXZlbnQgbXVzdCBoYXZlIGtleVRleHQgaW5mb3JtYXRpb24u IERvaW5nIGFuIGV4cGVyaW1lbnQgd2l0aCBRV2lkZ2V0CisgICAgICAgIGFuZCBpbnRlcmNlcHRp bmcgaXQncyBrZXlQcmVzcyBldmVudCBpdCdzIHBvc3NpYmxlIHRvIG5vdGljZSB0aGF0IFRBQiBr ZXkKKyAgICAgICAgcmV0dXJucyBhIGtleUNvZGUgKFF0OjpLZXlfVGFiKSArIGEga2V5VGV4dCAo Ilx0IikuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL3F0L0V2ZW50U2VuZGVyUHJveHlR dC5jcHA6CisgICAgICAgIChXVFI6OkV2ZW50U2VuZGVyUHJveHk6OmtleURvd24pOgorCiAyMDEy LTA5LTEwICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CiAK ICAgICAgICAgW0VGTF1bRFJUXSBFbmNvZGluZyBpc3N1ZSBpbiBwcmludGVkIGNvbnNvbGUgbWVz c2FnZXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvRXZlbnRTZW5kZXJQ cm94eVF0LmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvRXZlbnRTZW5kZXJQcm94eVF0 LmNwcAppbmRleCBmODg2OWQ4NGRjNzkyNDk3YTE5Mzk4NDgzMTRlMTc1YjYyMmQ5ZDE1Li5iMGNm YzIzZTU1MTMwZmEyOTRmZWUzYTViNmNjOWZlY2FhMjQzYjdlIDEwMDY0NAotLS0gYS9Ub29scy9X ZWJLaXRUZXN0UnVubmVyL3F0L0V2ZW50U2VuZGVyUHJveHlRdC5jcHAKKysrIGIvVG9vbHMvV2Vi S2l0VGVzdFJ1bm5lci9xdC9FdmVudFNlbmRlclByb3h5UXQuY3BwCkBAIC0xMzEsNyArMTMxLDcg QEAgdm9pZCBFdmVudFNlbmRlclByb3h5OjprZXlEb3duKFdLU3RyaW5nUmVmIGtleVJlZiwgV0tF dmVudE1vZGlmaWVycyBtb2RpZmllcnNSZWYKICAgICAgICAgICAgIGNvZGUgPSBRdDo6S2V5X1Rh YjsKICAgICAgICAgICAgIGlmIChtb2RpZmllcnMgPT0gUXQ6OlNoaWZ0TW9kaWZpZXIpCiAgICAg ICAgICAgICAgICAgY29kZSA9IFF0OjpLZXlfQmFja3RhYjsKLSAgICAgICAgICAgIGtleVRleHQg PSBRU3RyaW5nKCk7CisgICAgICAgICAgICBrZXlUZXh0ID0gUVN0cmluZygiXHQiKTsKICAgICAg ICAgfSBlbHNlIGlmIChjb2RlID09IEtFWUNPREVfREVMIHx8IGNvZGUgPT0gS0VZQ09ERV9CQUNL U1BBQ0UpIHsKICAgICAgICAgICAgIGNvZGUgPSBRdDo6S2V5X0JhY2tzcGFjZTsKICAgICAgICAg ICAgIGlmIChtb2RpZmllcnMgPT0gUXQ6OkFsdE1vZGlmaWVyKQpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDYwNGE4ODA1Y2Jk MDk4YmE1MmFkMTFhNWNiOGExZTA4OTFkNDg0ZGMuLmJjZjVmYzUxMjMyMDM4MjVjNmJmZDM2MWQx ZTMxMTA0MjA5MWIxN2QgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMi0wOS0xMCAgTHVjaWFu byBXb2xmICA8bHVjaWFuby53b2xmQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW1F0XSBbV0sy XSBlZGl0aW5nL2luc2VydGluZy90eXBpbmctdGFiLWRlc2lnbm1vZGUgdGVzdHMgYXJlIGZhaWxp bmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxOTg4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVW5za2lw IHJlbGF0ZWQgdGVzdHMuIAorCisgICAgICAgICogcGxhdGZvcm0vcXQtNS4wLXdrMi9Ta2lwcGVk OgorCiAyMDEyLTA5LTEwICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAg ICAgUkVHUkVTU0lPTiAocjEyODAwNik6IFRocmVlIHNwYXRpYWwgbmF2aWdhdGlvbiB0ZXN0cyBh cmUgZmFpbGluZwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQtNS4wLXdrMi9T a2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQtNS4wLXdrMi9Ta2lwcGVkCmluZGV4IGVj ZTg0M2QzMzkxNTBkN2VmMjU0ZDhkMmEzMTczMzQ1ZDVlM2Q3NjMuLmNmOTI0NTJhY2E0NDQ0NDgw MmZjY2ZmNjBkMGQ2MjBjMzYyZWNlMDYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3Jt L3F0LTUuMC13azIvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC01LjAtd2sy L1NraXBwZWQKQEAgLTQ0NiwxMSArNDQ2LDYgQEAgZmFzdC9yZXBsYWNlZC93aWR0aDEwMHBlcmNl bnQtdGV4dGZpZWxkLmh0bWwKIGZhc3QvdHJhbnNmb3Jtcy90cmFuc2Zvcm1lZC1mb2N1c2VkLXRl eHQtaW5wdXQuaHRtbAogZWRpdGluZy9zZWxlY3Rpb24vMTQ5NzEuaHRtbAogCi0jIFtRdF0gW1dL Ml0gZWRpdGluZy9pbnNlcnRpbmcvdHlwaW5nLXRhYi1kZXNpZ25tb2RlIHRlc3RzIGFyZSBmYWls aW5nCi0jIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTk4OAotZWRp dGluZy9pbnNlcnRpbmcvdHlwaW5nLXRhYi1kZXNpZ25tb2RlLWZvcm1zLmh0bWwKLWVkaXRpbmcv aW5zZXJ0aW5nL3R5cGluZy10YWItZGVzaWdubW9kZS5odG1sCi0KICMgU2l6ZSBvZiBzZWxlY3Qg aXMgZGlmZmVyZW50IHdoZW4gcnVubmluZyBEUlQvV1RSCiBmYXN0L3JlcGxhY2VkL3RocmVlLXNl bGVjdHMtYnJlYWsuaHRtbAogCg== 163217 2012-09-10 15:00:23 -0700 2012-09-11 08:12:06 -0700 Updated patch - after Caio's review bug-91988-20120910185959.patch text/plain 3022 luciano.wolf U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MDYwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTdlM2M0YTAyODQ4YzY1YjVlOGZlYjUwMWYwZGU1NTlh ODA3MzhkZC4uNDVjMzJlNDk1NDVlNWU5OWE3YTg3MTdhMjZiNzQwYWIzZWVhNjI3MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA5LTEwICBMdWNpYW5vIFdvbGYgIDxsdWNpYW5vLndvbGZAb3BlbmJvc3NhLm9y Zz4KKworICAgICAgICBbUXRdIFtXSzJdIGVkaXRpbmcvaW5zZXJ0aW5nL3R5cGluZy10YWItZGVz aWdubW9kZSB0ZXN0cyBhcmUgZmFpbGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTE5ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSZWd1bGFyIGtleSBldmVudHMgZ2VuZXJhdGVkIGJ5IFF0IGZvciB0 aGUgdGFiIGtleSBmaWxsIGJvdGgKKyAgICAgICAga2V5Q29kZSBhbmQga2V5VGV4dCwgc28gd2Ug c2hvdWxkIGRvIHRoZSBzYW1lIGZvciBvdXIgZmFrZSBldmVudHMuCisKKyAgICAgICAgKiBXZWJL aXRUZXN0UnVubmVyL3F0L0V2ZW50U2VuZGVyUHJveHlRdC5jcHA6CisgICAgICAgIChXVFI6OkV2 ZW50U2VuZGVyUHJveHk6OmtleURvd24pOgorCiAyMDEyLTA5LTEwICBDaHJpc3RvcGhlIER1bWV6 ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CiAKICAgICAgICAgW0VGTF1bRFJUXSBFbmNv ZGluZyBpc3N1ZSBpbiBwcmludGVkIGNvbnNvbGUgbWVzc2FnZXMKZGlmZiAtLWdpdCBhL1Rvb2xz L1dlYktpdFRlc3RSdW5uZXIvcXQvRXZlbnRTZW5kZXJQcm94eVF0LmNwcCBiL1Rvb2xzL1dlYktp dFRlc3RSdW5uZXIvcXQvRXZlbnRTZW5kZXJQcm94eVF0LmNwcAppbmRleCBmODg2OWQ4NGRjNzky NDk3YTE5Mzk4NDgzMTRlMTc1YjYyMmQ5ZDE1Li4yN2JjY2E0ZGY5MDNjMTEyMjQwNWU5NmRjN2E2 OWYxZTliNjkwN2RjIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL3F0L0V2ZW50 U2VuZGVyUHJveHlRdC5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9FdmVudFNl bmRlclByb3h5UXQuY3BwCkBAIC0xMzEsNyArMTMxLDcgQEAgdm9pZCBFdmVudFNlbmRlclByb3h5 OjprZXlEb3duKFdLU3RyaW5nUmVmIGtleVJlZiwgV0tFdmVudE1vZGlmaWVycyBtb2RpZmllcnNS ZWYKICAgICAgICAgICAgIGNvZGUgPSBRdDo6S2V5X1RhYjsKICAgICAgICAgICAgIGlmIChtb2Rp ZmllcnMgPT0gUXQ6OlNoaWZ0TW9kaWZpZXIpCiAgICAgICAgICAgICAgICAgY29kZSA9IFF0OjpL ZXlfQmFja3RhYjsKLSAgICAgICAgICAgIGtleVRleHQgPSBRU3RyaW5nKCk7CisgICAgICAgICAg ICBrZXlUZXh0ID0gUVN0cmluZ0xpdGVyYWwoIlx0Iik7CiAgICAgICAgIH0gZWxzZSBpZiAoY29k ZSA9PSBLRVlDT0RFX0RFTCB8fCBjb2RlID09IEtFWUNPREVfQkFDS1NQQUNFKSB7CiAgICAgICAg ICAgICBjb2RlID0gUXQ6OktleV9CYWNrc3BhY2U7CiAgICAgICAgICAgICBpZiAobW9kaWZpZXJz ID09IFF0OjpBbHRNb2RpZmllcikKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA2MDRhODgwNWNiZDA5OGJhNTJhZDExYTVjYjhh MWUwODkxZDQ4NGRjLi5kM2FhOTcyMzA2NjM1NjJhNDFlZWNkM2IxYjM3MWE1ZjEyNGVjYWUxIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDktMTAgIEx1Y2lhbm8gV29sZiAgPGx1Y2lhbm8u d29sZkBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFtRdF0gW1dLMl0gZWRpdGluZy9pbnNlcnRp bmcvdHlwaW5nLXRhYi1kZXNpZ25tb2RlIHRlc3RzIGFyZSBmYWlsaW5nCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTk4OAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVuc2tpcCByZWxhdGVkIHRlc3RzLgor CisgICAgICAgICogcGxhdGZvcm0vcXQtNS4wLXdrMi9Ta2lwcGVkOgorCiAyMDEyLTA5LTEwICBE YW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjEy ODAwNik6IFRocmVlIHNwYXRpYWwgbmF2aWdhdGlvbiB0ZXN0cyBhcmUgZmFpbGluZwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQtNS4wLXdrMi9Ta2lwcGVkIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vcXQtNS4wLXdrMi9Ta2lwcGVkCmluZGV4IGVjZTg0M2QzMzkxNTBkN2VmMjU0 ZDhkMmEzMTczMzQ1ZDVlM2Q3NjMuLmNmOTI0NTJhY2E0NDQ0NDgwMmZjY2ZmNjBkMGQ2MjBjMzYy ZWNlMDYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0LTUuMC13azIvU2tpcHBl ZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC01LjAtd2syL1NraXBwZWQKQEAgLTQ0Niwx MSArNDQ2LDYgQEAgZmFzdC9yZXBsYWNlZC93aWR0aDEwMHBlcmNlbnQtdGV4dGZpZWxkLmh0bWwK IGZhc3QvdHJhbnNmb3Jtcy90cmFuc2Zvcm1lZC1mb2N1c2VkLXRleHQtaW5wdXQuaHRtbAogZWRp dGluZy9zZWxlY3Rpb24vMTQ5NzEuaHRtbAogCi0jIFtRdF0gW1dLMl0gZWRpdGluZy9pbnNlcnRp bmcvdHlwaW5nLXRhYi1kZXNpZ25tb2RlIHRlc3RzIGFyZSBmYWlsaW5nCi0jIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTk4OAotZWRpdGluZy9pbnNlcnRpbmcvdHlw aW5nLXRhYi1kZXNpZ25tb2RlLWZvcm1zLmh0bWwKLWVkaXRpbmcvaW5zZXJ0aW5nL3R5cGluZy10 YWItZGVzaWdubW9kZS5odG1sCi0KICMgU2l6ZSBvZiBzZWxlY3QgaXMgZGlmZmVyZW50IHdoZW4g cnVubmluZyBEUlQvV1RSCiBmYXN0L3JlcGxhY2VkL3RocmVlLXNlbGVjdHMtYnJlYWsuaHRtbAog Cg==