91987 2012-07-23 06:25:58 -0700 [BlackBerry] Remove unused variable in BackingStore.cpp 2012-07-24 08:51:44 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anilsson anilsson mifenton tonikitoo webkit.review.bot oldest_to_newest 675663 0 anilsson 2012-07-23 06:25:58 -0700 dirtyContentsRect is ultimately not used for anything. 675664 1 anilsson 2012-07-23 06:26:58 -0700 I would associate this with PR 141439 675670 2 153789 anilsson 2012-07-23 06:32:56 -0700 Created attachment 153789 Patch 676794 3 153789 webkit.review.bot 2012-07-24 07:33:21 -0700 Comment on attachment 153789 Patch Rejecting attachment 153789 from commit-queue. anilsson@rim.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 676874 4 153789 webkit.review.bot 2012-07-24 08:51:41 -0700 Comment on attachment 153789 Patch Clearing flags on attachment: 153789 Committed r123484: <http://trac.webkit.org/changeset/123484> 676875 5 webkit.review.bot 2012-07-24 08:51:44 -0700 All reviewed patches have been landed. Closing bug. 153789 2012-07-23 06:32:56 -0700 2012-07-24 08:51:40 -0700 Patch bug-91987-20120723153248.patch text/plain 1830 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMjY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA4Y2E5ZjYwNmQ2ZWY2MjY0MDI0Yzg4NDZkNTRkNDkyZjM4NTk4ZmI0Li5iOGU1NmZkNzZl MWRlM2FlYTNmZWRjZjY0ZGUyODg5MWFmZWY2ZDhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wNy0yMyAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxz c29uQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFJlbW92ZSB1bnVzZWQgdmFyaWFi bGUgaW4gQmFja2luZ1N0b3JlLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTE5ODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBQUjogMTQxNDM5CisgICAgICAgIFRoaXMgaXMgZG9uZSBhcyBwYXJ0IG9m IHNvbWUgZ2VuZXJhbCBCYWNraW5nU3RvcmVQcml2YXRlOjpyZW5kZXIoKQorICAgICAgICBjbGVh bnVwIGluIFBSIDE0MTQzOS4KKworICAgICAgICAqIEFwaS9CYWNraW5nU3RvcmUuY3BwOgorICAg ICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpCYWNraW5nU3RvcmVQcml2YXRlOjpyZW5kZXIpOgor CiAyMDEyLTA3LTIwICBKYWNreSBKaWFuZyAgPHpoYWppYW5nQHJpbS5jb20+CiAKICAgICAgICAg W0JsYWNrQmVycnldIGNsb2NrX2dldHRpbWUoKSBpbiBCYWNraW5nU3RvcmUuY3BwIHNob3VsZCB1 c2UgQ0xPQ0tfTU9OT1RPTklDCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv QXBpL0JhY2tpbmdTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0JhY2tp bmdTdG9yZS5jcHAKaW5kZXggMjMyNThhNmI2YWRlZGIzZWNjODBkODU5OGViMTAwMDg0NzY5MmVh ZS4uN2IzZDE2MWYwYzI3YmJlZWQ0NWJhNDY2M2U3ZDJmMWJkYTVhMzQ0MyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9CYWNraW5nU3RvcmUuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcApAQCAtMTA3NCw4ICsxMDc0 LDYgQEAgYm9vbCBCYWNraW5nU3RvcmVQcml2YXRlOjpyZW5kZXIoY29uc3QgUGxhdGZvcm06Oklu dFJlY3QmIHJlY3QpCiAgICAgQmFja2luZ1N0b3JlR2VvbWV0cnkqIGN1cnJlbnRTdGF0ZSA9IGZy b250U3RhdGUoKTsKICAgICBUaWxlTWFwIGN1cnJlbnRNYXAgPSBjdXJyZW50U3RhdGUtPnRpbGVN YXAoKTsKIAotICAgIFBsYXRmb3JtOjpJbnRSZWN0IGRpcnR5Q29udGVudHNSZWN0OwotCiAgICAg Zm9yIChzaXplX3QgaSA9IDA7IGkgPCB0aWxlUmVjdExpc3Quc2l6ZSgpOyArK2kpIHsKICAgICAg ICAgVGlsZVJlY3QgdGlsZVJlY3QgPSB0aWxlUmVjdExpc3RbaV07CiAgICAgICAgIFRpbGVJbmRl eCBpbmRleCA9IHRpbGVSZWN0LmZpcnN0OwpAQCAtMTE2Miw3ICsxMTYwLDYgQEAgYm9vbCBCYWNr aW5nU3RvcmVQcml2YXRlOjpyZW5kZXIoY29uc3QgUGxhdGZvcm06OkludFJlY3QmIHJlY3QpCiAg ICAgICAgICAgICB0aWxlLT5iYWNrQnVmZmVyKCktPmNsZWFyUmVuZGVyZWRSZWdpb24oKTsKICAg ICAgICAgfQogCi0gICAgICAgIGRpcnR5Q29udGVudHNSZWN0ID0gUGxhdGZvcm06OnVuaW9uT2ZS ZWN0cyhkaXJ0eUNvbnRlbnRzUmVjdCwgZGlydHlSZWN0KTsKICAgICB9CiAKICAgICByZXR1cm4g dHJ1ZTsK