91983 2012-07-23 04:50:14 -0700 [EFL][WK2] Add unit tests for custom text encoding setting 2012-07-24 15:54:28 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis cdumez gyuyoung.kim lucas.de.marchi sw0524.lee tmpsantos webkit.review.bot oldest_to_newest 675624 0 naginenis 2012-07-23 04:50:14 -0700 Add unit tests for custom text encoding setting. 675643 1 153781 naginenis 2012-07-23 05:24:25 -0700 Created attachment 153781 Patch 675941 2 153850 naginenis 2012-07-23 13:22:17 -0700 Created attachment 153850 Patch Add unit tests for set/get custom text encoding. 675946 3 153850 cdumez 2012-07-23 13:26:22 -0700 Comment on attachment 153850 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153850&action=review > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:39 > + ASSERT_STREQ(ewk_view_setting_encoding_custom_get(webView()), 0); Should we really use ASSERT_STREQ() for 0? Why not use ASSERT_FALSE(ewk_view_setting_encoding_custom_get(webView())); ? > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:40 > + ewk_view_setting_encoding_custom_set(webView(), "UTF-8"); Would be nice to test the return value. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:43 > + ewk_view_setting_encoding_custom_set(webView(), 0); Ditto. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:44 > + ASSERT_STREQ(ewk_view_setting_encoding_custom_get(webView()), 0); Should we really use ASSERT_STREQ() for 0? Why not use ASSERT_FALSE(ewk_view_setting_encoding_custom_get(webView())); ? 675982 4 153850 naginenis 2012-07-23 14:02:07 -0700 Comment on attachment 153850 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153850&action=review >> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:39 >> + ASSERT_STREQ(ewk_view_setting_encoding_custom_get(webView()), 0); > > Should we really use ASSERT_STREQ() for 0? Why not use ASSERT_FALSE(ewk_view_setting_encoding_custom_get(webView())); ? ASSERT_FALSE also works in this case, but is there anything wrong in using ASSERT_STREQ() here? *_get() returns a C string and I want to assert if C string is NULL(like explained in docs ASSERT_STREQ(NULL, c_string)). But, style checker pushed me to use 0 instead of NULL. >> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:40 >> + ewk_view_setting_encoding_custom_set(webView(), "UTF-8"); > > Would be nice to test the return value. I wonder how much it makes sense to test the return value of set function, because it returns always true(except in case of invalid input arg). That's the reason I am calling get immediately after set and comparing the C string. 675993 5 153850 cdumez 2012-07-23 14:14:08 -0700 Comment on attachment 153850 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153850&action=review >>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:39 >>> + ASSERT_STREQ(ewk_view_setting_encoding_custom_get(webView()), 0); >> >> Should we really use ASSERT_STREQ() for 0? Why not use ASSERT_FALSE(ewk_view_setting_encoding_custom_get(webView())); ? > > ASSERT_FALSE also works in this case, but is there anything wrong in using ASSERT_STREQ() here? *_get() returns a C string and I want to assert if C string is NULL(like explained in docs ASSERT_STREQ(NULL, c_string)). But, style checker pushed me to use 0 instead of NULL. I don't know if it's wrong but at least it is confusing. >>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:40 >>> + ewk_view_setting_encoding_custom_set(webView(), "UTF-8"); >> >> Would be nice to test the return value. > > I wonder how much it makes sense to test the return value of set function, because it returns always true(except in case of invalid input arg). That's the reason I am calling get immediately after set and comparing the C string. Well, better safe than sorry. Just because the current implementation always returns TRUE, does not mean the code will stay this way. It is always a good idea to test as much as possible. In this case, it is very easy to add an ASSERT_TRUE() and make sure the return value is really true (and stays that way in the future). 676013 6 153850 naginenis 2012-07-23 14:31:35 -0700 Comment on attachment 153850 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153850&action=review >>>> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:40 >>>> + ewk_view_setting_encoding_custom_set(webView(), "UTF-8"); >>> >>> Would be nice to test the return value. >> >> I wonder how much it makes sense to test the return value of set function, because it returns always true(except in case of invalid input arg). That's the reason I am calling get immediately after set and comparing the C string. > > Well, better safe than sorry. Just because the current implementation always returns TRUE, does not mean the code will stay this way. It is always a good idea to test as much as possible. In this case, it is very easy to add an ASSERT_TRUE() and make sure the return value is really true (and stays that way in the future). Yes, it is easy to add and I don't mind adding, but I'm just trying to understand the real use of it with the current implementation. Isn't it true that we should update the test code when we change the APIs implementation? 676063 7 153874 naginenis 2012-07-23 15:17:18 -0700 Created attachment 153874 Patch Fix review comment #3. 676306 8 153874 gyuyoung.kim 2012-07-23 18:55:35 -0700 Comment on attachment 153874 Patch LGTM. 677303 9 153874 webkit.review.bot 2012-07-24 15:54:23 -0700 Comment on attachment 153874 Patch Clearing flags on attachment: 153874 Committed r123545: <http://trac.webkit.org/changeset/123545> 677304 10 webkit.review.bot 2012-07-24 15:54:28 -0700 All reviewed patches have been landed. Closing bug. 153781 2012-07-23 05:24:25 -0700 2012-07-23 13:22:17 -0700 Patch 91983.patch text/plain 2491 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBlMTg1NWEzLi4yMTI1ZDk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMDctMjMgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBBZGQgdW5pdCB0ZXN0cyBmb3Ig Y3VzdG9tIHRleHQgZW5jb2Rpbmcgc2V0dGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE5ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgdW5pdCB0ZXN0cyBmb3IgZ2V0IGFuZCBzZXQgY3VzdG9t IHRleHQgZW5jb2RpbmcgbWV0aG9kcy4gQWxzbywgZml4CisgICAgICAgIGEgc3R5bGUgbml0IGZv ciByMTIzMTc3LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwOgor ICAgICAgICAoZXdrX3ZpZXdfc2V0dGluZ19lbmNvZGluZ19jdXN0b21fc2V0KTogRml4IGEgc3R5 bGUgbml0IC0gYWRkIG5ld2xpbmUKKyAgICAgICAgYmVmb3JlIHJldHVybi4KKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHA6CisgICAgICAgIChURVNU X0YpOgorCiAyMDEyLTA3LTIzICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZW5hbWUgRU5BQkxFX01FVEVSX1RBRyBhbmQgRU5BQkxFX1BST0dSRVNTX1RBRyB0 byBFTkFCTEVfTUVURVJfRUxFTUVOVCBhbmQgRU5BQkxFX1BST0dSRVNTX0VMRU1FTlQgcmVzcGVj dGl2ZWx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tf dmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAK aW5kZXggM2Y4MGFhMS4uYWM5OGQ2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvZWZsL2V3a192aWV3LmNwcApAQCAtOTg2LDUgKzk4Niw2IEBAIEVpbmFfQm9vbCBld2tfdmll d19zZXR0aW5nX2VuY29kaW5nX2N1c3RvbV9zZXQoRXZhc19PYmplY3QqIGV3a1ZpZXcsIGNvbnN0 IGNoYXIqCiAgICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IHdrRW5jb2RpbmdOYW1lID0gZW5j b2RpbmcgPyBhZG9wdFdLKFdLU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKGVuY29kaW5nKSkg OiAwOwogICAgIGlmIChlaW5hX3N0cmluZ3NoYXJlX3JlcGxhY2UoJnByaXYtPmN1c3RvbUVuY29k aW5nLCBlbmNvZGluZykpCiAgICAgICAgIFdLUGFnZVNldEN1c3RvbVRleHRFbmNvZGluZ05hbWUo dG9BUEkocHJpdi0+cGFnZUNsaWVudC0+cGFnZSgpKSwgd2tFbmNvZGluZ05hbWUuZ2V0KCkpOwor CiAgICAgcmV0dXJuIHRydWU7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAKaW5kZXggOGVlMTM0ZC4uYjY3 ZjgzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMv dGVzdF9ld2syX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs L3Rlc3RzL3Rlc3RfZXdrMl92aWV3LmNwcApAQCAtMzMsMyArMzMsMTMgQEAgVEVTVF9GKEVXSzJV bml0VGVzdEJhc2UsIGV3a192aWV3X3VyaV9nZXQpCiAgICAgbG9hZFVybFN5bmMoZW52aXJvbm1l bnQtPmRlZmF1bHRUZXN0UGFnZVVybCgpKTsKICAgICBFWFBFQ1RfU1RSRVEoZXdrX3ZpZXdfdXJp X2dldCh3ZWJWaWV3KCkpLCBlbnZpcm9ubWVudC0+ZGVmYXVsdFRlc3RQYWdlVXJsKCkpOwogfQor CitURVNUX0YoRVdLMlVuaXRUZXN0QmFzZSwgZXdrX3ZpZXdfc2V0dGluZ19lbmNvZGluZ19jdXN0 b20pCit7CisgICAgRVhQRUNUX1NUUkVRKGV3a192aWV3X3NldHRpbmdfZW5jb2RpbmdfY3VzdG9t X2dldCh3ZWJWaWV3KCkpLCAwKTsKKyAgICBld2tfdmlld19zZXR0aW5nX2VuY29kaW5nX2N1c3Rv bV9zZXQod2ViVmlldygpLCAiVVRGLTgiKTsKKyAgICBFWFBFQ1RfU1RSRVEoZXdrX3ZpZXdfc2V0 dGluZ19lbmNvZGluZ19jdXN0b21fZ2V0KHdlYlZpZXcoKSksICJVVEYtOCIpOworICAgIC8vIFNl dCB0aGUgZGVmYXVsdCBjaGFyc2V0LgorICAgIGV3a192aWV3X3NldHRpbmdfZW5jb2RpbmdfY3Vz dG9tX3NldCh3ZWJWaWV3KCksIDApOworICAgIEVYUEVDVF9TVFJFUShld2tfdmlld19zZXR0aW5n X2VuY29kaW5nX2N1c3RvbV9nZXQod2ViVmlldygpKSwgMCk7Cit9Cg== 153850 2012-07-23 13:22:17 -0700 2012-07-23 15:17:18 -0700 Patch 91983.patch text/plain 2438 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjMjI3ZDM1Li5hMTY4OTk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMDctMjMgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBBZGQgdW5pdCB0ZXN0cyBmb3Ig Y3VzdG9tIHRleHQgZW5jb2Rpbmcgc2V0dGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE5ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgdW5pdCB0ZXN0cyBmb3IgZ2V0IGFuZCBzZXQgY3VzdG9t IHRleHQgZW5jb2RpbmcgbWV0aG9kcy4gQWxzbywgZml4CisgICAgICAgIGEgc3R5bGUgbml0IGZv ciByMTIzMTc3LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwOgor ICAgICAgICAoZXdrX3ZpZXdfc2V0dGluZ19lbmNvZGluZ19jdXN0b21fc2V0KTogRml4IGEgc3R5 bGUgbml0IC0gYWRkIG5ld2xpbmUKKyAgICAgICAgYmVmb3JlIHJldHVybi4KKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHA6CisgICAgICAgIChURVNU X0YpOgorCiAyMDEyLTA3LTIzICBQaWVycmUgUm9zc2kgIDxwaWVycmUucm9zc2lAZ21haWwuY29t PgogCiAgICAgICAgIFtRdF0gRW5hYmxlIHRvdWNoIHNsaWRlciB3aGVuIHRvdWNoIGV2ZW50cyBh cmUgZW5hYmxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv ZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcu Y3BwCmluZGV4IDNmODBhYTEuLmFjOThkNjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKQEAgLTk4Niw1ICs5ODYsNiBAQCBFaW5hX0Jvb2wgZXdr X3ZpZXdfc2V0dGluZ19lbmNvZGluZ19jdXN0b21fc2V0KEV2YXNfT2JqZWN0KiBld2tWaWV3LCBj b25zdCBjaGFyKgogICAgIFdLUmV0YWluUHRyPFdLU3RyaW5nUmVmPiB3a0VuY29kaW5nTmFtZSA9 IGVuY29kaW5nID8gYWRvcHRXSyhXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZyhlbmNvZGlu ZykpIDogMDsKICAgICBpZiAoZWluYV9zdHJpbmdzaGFyZV9yZXBsYWNlKCZwcml2LT5jdXN0b21F bmNvZGluZywgZW5jb2RpbmcpKQogICAgICAgICBXS1BhZ2VTZXRDdXN0b21UZXh0RW5jb2RpbmdO YW1lKHRvQVBJKHByaXYtPnBhZ2VDbGllbnQtPnBhZ2UoKSksIHdrRW5jb2RpbmdOYW1lLmdldCgp KTsKKwogICAgIHJldHVybiB0cnVlOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwCmluZGV4IDhlZTEzNGQu LjQ0MzEwMDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rl c3RzL3Rlc3RfZXdrMl92aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAKQEAgLTMzLDMgKzMzLDEzIEBAIFRFU1RfRihF V0syVW5pdFRlc3RCYXNlLCBld2tfdmlld191cmlfZ2V0KQogICAgIGxvYWRVcmxTeW5jKGVudmly b25tZW50LT5kZWZhdWx0VGVzdFBhZ2VVcmwoKSk7CiAgICAgRVhQRUNUX1NUUkVRKGV3a192aWV3 X3VyaV9nZXQod2ViVmlldygpKSwgZW52aXJvbm1lbnQtPmRlZmF1bHRUZXN0UGFnZVVybCgpKTsK IH0KKworVEVTVF9GKEVXSzJVbml0VGVzdEJhc2UsIGV3a192aWV3X3NldHRpbmdfZW5jb2Rpbmdf Y3VzdG9tKQoreworICAgIEFTU0VSVF9TVFJFUShld2tfdmlld19zZXR0aW5nX2VuY29kaW5nX2N1 c3RvbV9nZXQod2ViVmlldygpKSwgMCk7CisgICAgZXdrX3ZpZXdfc2V0dGluZ19lbmNvZGluZ19j dXN0b21fc2V0KHdlYlZpZXcoKSwgIlVURi04Iik7CisgICAgQVNTRVJUX1NUUkVRKGV3a192aWV3 X3NldHRpbmdfZW5jb2RpbmdfY3VzdG9tX2dldCh3ZWJWaWV3KCkpLCAiVVRGLTgiKTsKKyAgICAv LyBTZXQgdGhlIGRlZmF1bHQgY2hhcnNldC4KKyAgICBld2tfdmlld19zZXR0aW5nX2VuY29kaW5n X2N1c3RvbV9zZXQod2ViVmlldygpLCAwKTsKKyAgICBBU1NFUlRfU1RSRVEoZXdrX3ZpZXdfc2V0 dGluZ19lbmNvZGluZ19jdXN0b21fZ2V0KHdlYlZpZXcoKSksIDApOworfQo= 153874 2012-07-23 15:17:18 -0700 2012-07-24 15:54:22 -0700 Patch 91983.patch text/plain 2458 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjMjI3ZDM1Li5hMTY4OTk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMDctMjMgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF1bV0syXSBBZGQgdW5pdCB0ZXN0cyBmb3Ig Y3VzdG9tIHRleHQgZW5jb2Rpbmcgc2V0dGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE5ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgdW5pdCB0ZXN0cyBmb3IgZ2V0IGFuZCBzZXQgY3VzdG9t IHRleHQgZW5jb2RpbmcgbWV0aG9kcy4gQWxzbywgZml4CisgICAgICAgIGEgc3R5bGUgbml0IGZv ciByMTIzMTc3LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwOgor ICAgICAgICAoZXdrX3ZpZXdfc2V0dGluZ19lbmNvZGluZ19jdXN0b21fc2V0KTogRml4IGEgc3R5 bGUgbml0IC0gYWRkIG5ld2xpbmUKKyAgICAgICAgYmVmb3JlIHJldHVybi4KKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHA6CisgICAgICAgIChURVNU X0YpOgorCiAyMDEyLTA3LTIzICBQaWVycmUgUm9zc2kgIDxwaWVycmUucm9zc2lAZ21haWwuY29t PgogCiAgICAgICAgIFtRdF0gRW5hYmxlIHRvdWNoIHNsaWRlciB3aGVuIHRvdWNoIGV2ZW50cyBh cmUgZW5hYmxlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv ZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX3ZpZXcu Y3BwCmluZGV4IDNmODBhYTEuLmFjOThkNjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKQEAgLTk4Niw1ICs5ODYsNiBAQCBFaW5hX0Jvb2wgZXdr X3ZpZXdfc2V0dGluZ19lbmNvZGluZ19jdXN0b21fc2V0KEV2YXNfT2JqZWN0KiBld2tWaWV3LCBj b25zdCBjaGFyKgogICAgIFdLUmV0YWluUHRyPFdLU3RyaW5nUmVmPiB3a0VuY29kaW5nTmFtZSA9 IGVuY29kaW5nID8gYWRvcHRXSyhXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZyhlbmNvZGlu ZykpIDogMDsKICAgICBpZiAoZWluYV9zdHJpbmdzaGFyZV9yZXBsYWNlKCZwcml2LT5jdXN0b21F bmNvZGluZywgZW5jb2RpbmcpKQogICAgICAgICBXS1BhZ2VTZXRDdXN0b21UZXh0RW5jb2RpbmdO YW1lKHRvQVBJKHByaXYtPnBhZ2VDbGllbnQtPnBhZ2UoKSksIHdrRW5jb2RpbmdOYW1lLmdldCgp KTsKKwogICAgIHJldHVybiB0cnVlOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX3ZpZXcuY3BwCmluZGV4IDhlZTEzNGQu LmM4MDczNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rl c3RzL3Rlc3RfZXdrMl92aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2VmbC90ZXN0cy90ZXN0X2V3azJfdmlldy5jcHAKQEAgLTMzLDMgKzMzLDEzIEBAIFRFU1RfRihF V0syVW5pdFRlc3RCYXNlLCBld2tfdmlld191cmlfZ2V0KQogICAgIGxvYWRVcmxTeW5jKGVudmly b25tZW50LT5kZWZhdWx0VGVzdFBhZ2VVcmwoKSk7CiAgICAgRVhQRUNUX1NUUkVRKGV3a192aWV3 X3VyaV9nZXQod2ViVmlldygpKSwgZW52aXJvbm1lbnQtPmRlZmF1bHRUZXN0UGFnZVVybCgpKTsK IH0KKworVEVTVF9GKEVXSzJVbml0VGVzdEJhc2UsIGV3a192aWV3X3NldHRpbmdfZW5jb2Rpbmdf Y3VzdG9tKQoreworICAgIEFTU0VSVF9GQUxTRShld2tfdmlld19zZXR0aW5nX2VuY29kaW5nX2N1 c3RvbV9nZXQod2ViVmlldygpKSk7CisgICAgQVNTRVJUX1RSVUUoZXdrX3ZpZXdfc2V0dGluZ19l bmNvZGluZ19jdXN0b21fc2V0KHdlYlZpZXcoKSwgIlVURi04IikpOworICAgIEFTU0VSVF9TVFJF UShld2tfdmlld19zZXR0aW5nX2VuY29kaW5nX2N1c3RvbV9nZXQod2ViVmlldygpKSwgIlVURi04 Iik7CisgICAgLy8gU2V0IHRoZSBkZWZhdWx0IGNoYXJzZXQuCisgICAgQVNTRVJUX1RSVUUoZXdr X3ZpZXdfc2V0dGluZ19lbmNvZGluZ19jdXN0b21fc2V0KHdlYlZpZXcoKSwgMCkpOworICAgIEFT U0VSVF9GQUxTRShld2tfdmlld19zZXR0aW5nX2VuY29kaW5nX2N1c3RvbV9nZXQod2ViVmlldygp KSk7Cit9Cg==