91964 2012-07-23 00:03:35 -0700 Add "webkitBackgroundRequest" property to XMLHttpRequest 2012-08-06 00:52:50 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 0 xuewen.ok webkit-unassigned abarth ap charles.wei joenotcharles lquinn mifenton ojan staikos tonikitoo webkit.review.bot oldest_to_newest 675480 0 xuewen.ok 2012-07-23 00:03:35 -0700 When the page is doing an interruptable background XHR, such as the Instant fast searching, or when the XHR is from an extension, we may allow the request failing quietly other than having it popping up a dialog such as the authentication dialogs. We may want to indicate the XMLHttpRequest running on the background mode explicitly. 675508 1 153748 xuewen.ok 2012-07-23 00:58:44 -0700 Created attachment 153748 patch Mozilla have added a property "mozBackgroundRequest" Some discussions from mozilla and chromium. https://developer.mozilla.org/en/xmlhttprequest https://bugzilla.mozilla.org/show_bug.cgi?id=383430 http://code.google.com/p/chromium/issues/detail?id=31582 675652 2 153748 joenotcharles 2012-07-23 05:44:03 -0700 Comment on attachment 153748 patch View in context: https://bugs.webkit.org/attachment.cgi?id=153748&action=review > Source/WebCore/ChangeLog:10 > + When set thewebkitBackgournd property to true, the XHR should not popup dialogs, it can fail Typo: should be "the webkitBackground". Also the commit message should always talk about "webkitBackgroundRequest" since that's the full name of the property. > Source/WebCore/ChangeLog:15 > + supported by some platforms which is needed by the new tests. We should still write tests, and just skip them on platforms that don't support setHandlesAuthenticationChallenges > Source/WebCore/ChangeLog:24 > + * platform/network/blackberry/NetworkJob.cpp: I think the BlackBerry-specific part of this should be in a separate patch. 675765 3 ap 2012-07-23 09:24:30 -0700 This is a new feature, and as such needs to be discussed on webkit-dev first. I personally think that we shouldn't implement this feature unless it makes its way to the spec. It's a very specialized handling of a rare edge case - if people want more control over authentication, it should not be through "background request". Besides, it's up to debate whether XHR should ever be allowed to display authentication dialogs anyway. > Mozilla have added a property "mozBackgroundRequest" Note this: "Requires elevated privileges to access." And these requests have different semantics in that they are not associated with a frame. 675767 4 153748 abarth 2012-07-23 09:25:20 -0700 Comment on attachment 153748 patch View in context: https://bugs.webkit.org/attachment.cgi?id=153748&action=review I'm not sure I understand the use case. We should just stop XMLHttpRequest from poping up HTTP auth dialogs all the time. > Source/WebCore/platform/network/ResourceRequestBase.h:194 > + bool m_loadInBackground : 1; You can't add state to ResourceRequestBase that can't be represented in an NSURLRequest. Yes, that's lame, but it's a current design constraint. 683496 5 lquinn 2012-07-31 14:49:54 -0700 (In reply to comment #4) > We should just stop XMLHttpRequest from poping up HTTP auth dialogs all the time. That sounds reasonable to me, but it does go against http://www.w3.org/TR/XMLHttpRequest/, which says "If authentication fails, XMLHttpRequest origin and the request URL are same origin, Authorization is not in the list of author request headers, request username is null, and request password is null, user agents should prompt the end user for their username and password." Current versions of Chrome, Firefox, and Opera all prompt the user on a 401 from XHR. Safari does not. 683501 6 ap 2012-07-31 14:53:17 -0700 Are you testing with a synchronous request? With regular async ones, Safari does prompt too. 683505 7 lquinn 2012-07-31 14:59:26 -0700 (In reply to comment #6) > Are you testing with a synchronous request? With regular async ones, Safari does prompt too. Yes, you're right. I was testing with a synchronous request. With async, Safari does indeed prompt. 687831 8 charles.wei 2012-08-06 00:52:50 -0700 Let's just fail the HTTP authentication for the XHR and other sub-resources instead of prompting the user for credentials, if there's no credentials stored for the resource. 153748 2012-07-23 00:58:44 -0700 2012-07-23 09:25:20 -0700 patch 0001-Add-webkitBackgroundRequest-property-to-XMLHttpReque.patch text/plain 10035 xuewen.ok RnJvbSBlNWI2YmU2MzJmZGQ0MTYyZjg5ZjE2Mjk2NDE1MGYzM2VlYTQ5MTgzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTZWFuIFdhbmcgPFh1ZXdlbi5XYW5nQHRvcmNobW9iaWxlLmNv bS5jbj4KRGF0ZTogTW9uLCAyMyBKdWwgMjAxMiAxNToyMTowMyArMDgwMApTdWJqZWN0OiBbUEFU Q0hdIEFkZCAid2Via2l0QmFja2dyb3VuZFJlcXVlc3QiIHByb3BlcnR5IHRvIFhNTEh0dHBSZXF1 ZXN0CiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE5NjQKClJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKQWRkIHdlYmtpdEJhY2tncm91bmQgcHJvcGVydHkgdG8g WE1MSHR0cFJlcXVlc3QgdG8gYWxsb3cgaGF2aW5nIFhIUiB0byB3b3JrIG9uIGJhY2tncm91bmQg ZXhwbGljaXRseS4KCldoZW4gc2V0IHRoZXdlYmtpdEJhY2tnb3VybmQgcHJvcGVydHkgdG8gdHJ1 ZSwgdGhlIFhIUiBzaG91bGQgbm90IHBvcHVwIGRpYWxvZ3MsIGl0IGNhbiBmYWlsCnF1aWV0bHku IFRoaXMgcGF0Y2ggYWRkIHR3byBzd2l0Y2ggb3B0aW9ucyB0byBYTUxIdHRwUmVxdWVzdCBhbmQg UmVzb3VyY2VSZXF1ZXN0LCBhbmQgZGlzYWJsZSB0aGUKYXV0aGVudGljYXRpb24gZGlhbG9ncyBp ZiB0aGUgb3B0aW9ucyBhcmUgZW5hYmxlZC4KCk5vIG5ldyB0ZXN0cywgYmVjYXVzZSB0aGUgRFJU IGFwaSBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRIYW5kbGVzQXV0aGVudGljYXRpb25DaGFsbGVu Z2VzIGFyZSBub3QKc3VwcG9ydGVkIGJ5IHNvbWUgcGxhdGZvcm1zIHdoaWNoIGlzIG5lZWRlZCBi eSB0aGUgbmV3IHRlc3RzLgoKKiBwbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJhc2Uu aDoKKFJlc291cmNlUmVxdWVzdEJhc2UpOgooV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0QmFzZTo6 bG9hZEluQmFja2dyb3VuZCk6CihXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3RCYXNlOjpzZXRMb2Fk SW5CYWNrZ3JvdW5kKToKKFdlYkNvcmU6OlJlc291cmNlUmVxdWVzdEJhc2U6OlJlc291cmNlUmVx dWVzdEJhc2UpOgogICAgQWRkIG1fbG9hZEluQmFja2dyb3VuZCBhbmQgaXRzIGdldHRlciBhbmQg c2V0dGVyLgoKKiBwbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya0pvYi5jcHA6CihX ZWJDb3JlOjpOZXR3b3JrSm9iOjpzZW5kUmVxdWVzdFdpdGhDcmVkZW50aWFscyk6CiAgICBjaGVj ayB0aGUgbV9sb2FkSW5CYWNrZ3JvdW5kIG9mIFJlc291cmNlUmVxdWVzdCwgZG9uJ3QgcG9wdXAg dGhlIEF1dGhlbnRpY2F0aW9uIGRpYWxvZ3MgaWYgaXQgaXMKICAgIHRydWUuCgoqIHhtbC9YTUxI dHRwUmVxdWVzdC5jcHA6CihXZWJDb3JlOjpYTUxIdHRwUmVxdWVzdDo6WE1MSHR0cFJlcXVlc3Qp OgooV2ViQ29yZTo6WE1MSHR0cFJlcXVlc3Q6OnNldFdlYmtpdEJhY2tncm91bmRSZXF1ZXN0KToK KFdlYkNvcmUpOgooV2ViQ29yZTo6WE1MSHR0cFJlcXVlc3Q6OmNyZWF0ZVJlcXVlc3QpOgoqIHht bC9YTUxIdHRwUmVxdWVzdC5oOgooV2ViQ29yZTo6WE1MSHR0cFJlcXVlc3Q6OndlYmtpdEJhY2tn cm91bmRSZXF1ZXN0KToKKFhNTEh0dHBSZXF1ZXN0KToKKiB4bWwvWE1MSHR0cFJlcXVlc3QuaWRs OgogICAgQWRkIG1fYmFja2dyb3VuZFJlcXVlc3QgYW5kIGl0cyBnZXR0ZXIvc2V0dGVyLCBzZXQg aXQgdG8gZmFsc2UgYnkgZGVmYXVsdC4gUHV0IGl0IHZhbHVlIGludG8KICAgIFJlc291cmNlUmVx dWVzdCB3aGVuIGNyZWF0ZVJlcXVlc3QoKS4KLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cg ICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgNDAgKysrKysrKysrKysrKysrKysrKysKIC4u Li9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXF1ZXN0QmFzZS5oIHwgICAgNyAr KysrCiAuLi4vcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwICAgICB8 ICAgIDMgKy0KIFNvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAgICAgICAgICAg ICAgIHwgICAxMSArKysrKysKIFNvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5oICAg ICAgICAgICAgICAgIHwgICAgMyArKwogU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0 LmlkbCAgICAgICAgICAgICAgfCAgICAzICsrCiA2IGZpbGVzIGNoYW5nZWQsIDY2IGluc2VydGlv bnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjE0ZjYwMC4uNDE3Nzk3YyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwpAQCAtMSwzICsxLDQzIEBACisyMDEyLTA3LTIzICBTZWFuIFdhbmcgIDxYdWV3ZW4u V2FuZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgQWRkICJ3ZWJraXRCYWNrZ3JvdW5k UmVxdWVzdCIgcHJvcGVydHkgdG8gWE1MSHR0cFJlcXVlc3QKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxOTY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHdlYmtpdEJhY2tncm91bmQgcHJvcGVydHkg dG8gWE1MSHR0cFJlcXVlc3QgdG8gYWxsb3cgaGF2aW5nIFhIUiB0byB3b3JrIG9uIGJhY2tncm91 bmQgZXhwbGljaXRseS4KKworICAgICAgICBXaGVuIHNldCB0aGV3ZWJraXRCYWNrZ291cm5kIHBy b3BlcnR5IHRvIHRydWUsIHRoZSBYSFIgc2hvdWxkIG5vdCBwb3B1cCBkaWFsb2dzLCBpdCBjYW4g ZmFpbAorICAgICAgICBxdWlldGx5LiBUaGlzIHBhdGNoIGFkZCB0d28gc3dpdGNoIG9wdGlvbnMg dG8gWE1MSHR0cFJlcXVlc3QgYW5kIFJlc291cmNlUmVxdWVzdCwgYW5kIGRpc2FibGUgdGhlCisg ICAgICAgIGF1dGhlbnRpY2F0aW9uIGRpYWxvZ3MgaWYgdGhlIG9wdGlvbnMgYXJlIGVuYWJsZWQu CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBiZWNhdXNlIHRoZSBEUlQgYXBpIGxheW91dFRlc3RD b250cm9sbGVyLnNldEhhbmRsZXNBdXRoZW50aWNhdGlvbkNoYWxsZW5nZXMgYXJlIG5vdAorICAg ICAgICBzdXBwb3J0ZWQgYnkgc29tZSBwbGF0Zm9ybXMgd2hpY2ggaXMgbmVlZGVkIGJ5IHRoZSBu ZXcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJh c2UuaDoKKyAgICAgICAgKFJlc291cmNlUmVxdWVzdEJhc2UpOgorICAgICAgICAoV2ViQ29yZTo6 UmVzb3VyY2VSZXF1ZXN0QmFzZTo6bG9hZEluQmFja2dyb3VuZCk6CisgICAgICAgIChXZWJDb3Jl OjpSZXNvdXJjZVJlcXVlc3RCYXNlOjpzZXRMb2FkSW5CYWNrZ3JvdW5kKToKKyAgICAgICAgKFdl YkNvcmU6OlJlc291cmNlUmVxdWVzdEJhc2U6OlJlc291cmNlUmVxdWVzdEJhc2UpOgorICAgICAg ICAgICAgQWRkIG1fbG9hZEluQmFja2dyb3VuZCBhbmQgaXRzIGdldHRlciBhbmQgc2V0dGVyLgor CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6TmV0d29ya0pvYjo6c2VuZFJlcXVlc3RXaXRoQ3JlZGVudGlhbHMp OgorICAgICAgICAgICAgY2hlY2sgdGhlIG1fbG9hZEluQmFja2dyb3VuZCBvZiBSZXNvdXJjZVJl cXVlc3QsIGRvbid0IHBvcHVwIHRoZSBBdXRoZW50aWNhdGlvbiBkaWFsb2dzIGlmIGl0IGlzCisg ICAgICAgICAgICB0cnVlLgorCisgICAgICAgICogeG1sL1hNTEh0dHBSZXF1ZXN0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlhNTEh0dHBSZXF1ZXN0OjpYTUxIdHRwUmVxdWVzdCk6CisgICAgICAg IChXZWJDb3JlOjpYTUxIdHRwUmVxdWVzdDo6c2V0V2Via2l0QmFja2dyb3VuZFJlcXVlc3QpOgor ICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpYTUxIdHRwUmVxdWVzdDo6Y3Jl YXRlUmVxdWVzdCk6CisgICAgICAgICogeG1sL1hNTEh0dHBSZXF1ZXN0Lmg6CisgICAgICAgIChX ZWJDb3JlOjpYTUxIdHRwUmVxdWVzdDo6d2Via2l0QmFja2dyb3VuZFJlcXVlc3QpOgorICAgICAg ICAoWE1MSHR0cFJlcXVlc3QpOgorICAgICAgICAqIHhtbC9YTUxIdHRwUmVxdWVzdC5pZGw6Cisg ICAgICAgICAgICBBZGQgbV9iYWNrZ3JvdW5kUmVxdWVzdCBhbmQgaXRzIGdldHRlci9zZXR0ZXIs IHNldCBpdCB0byBmYWxzZSBieSBkZWZhdWx0LiBQdXQgaXQgdmFsdWUgaW50bworICAgICAgICAg ICAgUmVzb3VyY2VSZXF1ZXN0IHdoZW4gY3JlYXRlUmVxdWVzdCgpLgorCiAyMDEyLTA3LTIyICBL ZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbVjhdIENvZGVH ZW5lcmF0b3JWOC5wbSBzaG91bGQgc3VwcG9ydCBzdGF0aWMgYXR0cmlidXRlcwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlcXVlc3RCYXNlLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuaApp bmRleCA4NmRkNjJlLi5iMjQyZTJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuaApAQCAtMTMyLDYgKzEzMiwxMCBAQCBu YW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIGJvb2wgcmVwb3J0UmF3SGVhZGVycygpIGNvbnN0 IHsgcmV0dXJuIG1fcmVwb3J0UmF3SGVhZGVyczsgfQogICAgICAgICB2b2lkIHNldFJlcG9ydFJh d0hlYWRlcnMoYm9vbCByZXBvcnRSYXdIZWFkZXJzKSB7IG1fcmVwb3J0UmF3SGVhZGVycyA9IHJl cG9ydFJhd0hlYWRlcnM7IH0KIAorICAgICAgICAvLyBXaGV0aGVyIHRoZSByZXF1ZXN0IGlzIGJl aW5nIGxvYWRlZCBpbiB0aGUgYmFja2dyb3VuZCBYSFIgd2hlcmUgd2UgZG9uJ3Qgd2FudCB0byBz aG93IGFueSBkaWFsb2dzLgorICAgICAgICBib29sIGxvYWRJbkJhY2tncm91bmQoKSBjb25zdCB7 IHJldHVybiBtX2xvYWRJbkJhY2tncm91bmQ7IH0KKyAgICAgICAgdm9pZCBzZXRMb2FkSW5CYWNr Z3JvdW5kKGJvb2wgbG9hZEluQmFja2dyb3VuZCkgeyBtX2xvYWRJbkJhY2tncm91bmQgPSBsb2Fk SW5CYWNrZ3JvdW5kOyB9CisKICAgICAgICAgc3RhdGljIGRvdWJsZSBkZWZhdWx0VGltZW91dElu dGVydmFsKCk7IC8vIE1heSByZXR1cm4gMCB3aGVuIHVzaW5nIHBsYXRmb3JtIGRlZmF1bHQuCiAg ICAgICAgIHN0YXRpYyB2b2lkIHNldERlZmF1bHRUaW1lb3V0SW50ZXJ2YWwoZG91YmxlKTsKIApA QCAtMTQ1LDYgKzE0OSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgICAgICwgbV9y ZXBvcnRVcGxvYWRQcm9ncmVzcyhmYWxzZSkKICAgICAgICAgICAgICwgbV9yZXBvcnRMb2FkVGlt aW5nKGZhbHNlKQogICAgICAgICAgICAgLCBtX3JlcG9ydFJhd0hlYWRlcnMoZmFsc2UpCisgICAg ICAgICAgICAsIG1fbG9hZEluQmFja2dyb3VuZChmYWxzZSkKICAgICAgICAgICAgICwgbV9wcmlv cml0eShSZXNvdXJjZUxvYWRQcmlvcml0eUxvdykKICAgICAgICAgewogICAgICAgICB9CkBAIC0x NjAsNiArMTY1LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICAgICAgLCBtX3JlcG9y dFVwbG9hZFByb2dyZXNzKGZhbHNlKQogICAgICAgICAgICAgLCBtX3JlcG9ydExvYWRUaW1pbmco ZmFsc2UpCiAgICAgICAgICAgICAsIG1fcmVwb3J0UmF3SGVhZGVycyhmYWxzZSkKKyAgICAgICAg ICAgICwgbV9sb2FkSW5CYWNrZ3JvdW5kKGZhbHNlKQogICAgICAgICAgICAgLCBtX3ByaW9yaXR5 KFJlc291cmNlTG9hZFByaW9yaXR5TG93KQogICAgICAgICB7CiAgICAgICAgIH0KQEAgLTE4NSw2 ICsxOTEsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIGJvb2wgbV9yZXBvcnRVcGxv YWRQcm9ncmVzcyA6IDE7CiAgICAgICAgIGJvb2wgbV9yZXBvcnRMb2FkVGltaW5nIDogMTsKICAg ICAgICAgYm9vbCBtX3JlcG9ydFJhd0hlYWRlcnMgOiAxOworICAgICAgICBib29sIG1fbG9hZElu QmFja2dyb3VuZCA6IDE7CiAgICAgICAgIFJlc291cmNlTG9hZFByaW9yaXR5IG1fcHJpb3JpdHk7 CiAKICAgICBwcml2YXRlOgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCmluZGV4IGUwMWJkYzEuLjNkMGI3OWQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9O ZXR3b3JrSm9iLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNr YmVycnkvTmV0d29ya0pvYi5jcHAKQEAgLTczMCw3ICs3MzAsOCBAQCBib29sIE5ldHdvcmtKb2I6 OnNlbmRSZXF1ZXN0V2l0aENyZWRlbnRpYWxzKFByb3RlY3Rpb25TcGFjZVNlcnZlclR5cGUgdHlw ZSwgUHJvdAogICAgICAgICAgICAgICAgIG1faGFuZGxlLT5nZXRJbnRlcm5hbCgpLT5tX3Bhc3Mg PSAiIjsKICAgICAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAgICAgQ3JlZGVudGlhbCBp bnB1dENyZWRlbnRpYWw7Ci0gICAgICAgICAgICAgICAgaWYgKCFtX2ZyYW1lLT5wYWdlKCktPmNo cm9tZSgpLT5jbGllbnQoKS0+cGxhdGZvcm1QYWdlQ2xpZW50KCktPmF1dGhlbnRpY2F0aW9uQ2hh bGxlbmdlKG5ld1VSTCwgcHJvdGVjdGlvblNwYWNlLCBpbnB1dENyZWRlbnRpYWwpKQorICAgICAg ICAgICAgICAgIGlmIChtX2hhbmRsZS0+Zmlyc3RSZXF1ZXN0KCkubG9hZEluQmFja2dyb3VuZCgp CisgICAgICAgICAgICAgICAgICAgIHx8ICFtX2ZyYW1lLT5wYWdlKCktPmNocm9tZSgpLT5jbGll bnQoKS0+cGxhdGZvcm1QYWdlQ2xpZW50KCktPmF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKG5ld1VS TCwgcHJvdGVjdGlvblNwYWNlLCBpbnB1dENyZWRlbnRpYWwpKQogICAgICAgICAgICAgICAgICAg ICByZXR1cm4gZmFsc2U7CiAgICAgICAgICAgICAgICAgdXNlcm5hbWUgPSBpbnB1dENyZWRlbnRp YWwudXNlcigpOwogICAgICAgICAgICAgICAgIHBhc3N3b3JkID0gaW5wdXRDcmVkZW50aWFsLnBh c3N3b3JkKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3Qu Y3BwIGIvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcAppbmRleCA3NjhhMDE5 Li44MTk1ZTBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3Qu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAKQEAgLTE3NSw2 ICsxNzUsNyBAQCBYTUxIdHRwUmVxdWVzdDo6WE1MSHR0cFJlcXVlc3QoU2NyaXB0RXhlY3V0aW9u Q29udGV4dCogY29udGV4dCwgUGFzc1JlZlB0cjxTZWN1cgogICAgIDogQWN0aXZlRE9NT2JqZWN0 KGNvbnRleHQsIHRoaXMpCiAgICAgLCBtX2FzeW5jKHRydWUpCiAgICAgLCBtX2luY2x1ZGVDcmVk ZW50aWFscyhmYWxzZSkKKyAgICAsIG1fYmFja2dyb3VuZFJlcXVlc3QoZmFsc2UpCiAgICAgLCBt X3N0YXRlKFVOU0VOVCkKICAgICAsIG1fY3JlYXRlZERvY3VtZW50KGZhbHNlKQogICAgICwgbV9l cnJvcihmYWxzZSkKQEAgLTQxOSw2ICs0MjAsMTUgQEAgdm9pZCBYTUxIdHRwUmVxdWVzdDo6c2V0 V2l0aENyZWRlbnRpYWxzKGJvb2wgdmFsdWUsIEV4Y2VwdGlvbkNvZGUmIGVjKQogICAgIG1faW5j bHVkZUNyZWRlbnRpYWxzID0gdmFsdWU7CiB9CiAKK3ZvaWQgWE1MSHR0cFJlcXVlc3Q6OnNldFdl YmtpdEJhY2tncm91bmRSZXF1ZXN0KGJvb2wgdmFsdWUsIEV4Y2VwdGlvbkNvZGUmIGVjKQorewor ICAgIGlmIChtX3N0YXRlID49IEhFQURFUlNfUkVDRUlWRUQpIHsKKyAgICAgICAgZWMgPSBJTlZB TElEX1NUQVRFX0VSUjsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKyAgICBtX2JhY2tncm91bmRS ZXF1ZXN0ID0gdmFsdWU7Cit9CisKIGJvb2wgWE1MSHR0cFJlcXVlc3Q6OmlzQWxsb3dlZEhUVFBN ZXRob2QoY29uc3QgU3RyaW5nJiBtZXRob2QpCiB7CiAgICAgcmV0dXJuICFlcXVhbElnbm9yaW5n Q2FzZShtZXRob2QsICJUUkFDRSIpCkBAIC03MTcsNiArNzI3LDcgQEAgdm9pZCBYTUxIdHRwUmVx dWVzdDo6Y3JlYXRlUmVxdWVzdChFeGNlcHRpb25Db2RlJiBlYykKICNpZiBQTEFURk9STShDSFJP TUlVTSkgfHwgUExBVEZPUk0oQkxBQ0tCRVJSWSkKICAgICByZXF1ZXN0LnNldFRhcmdldFR5cGUo UmVzb3VyY2VSZXF1ZXN0OjpUYXJnZXRJc1hIUik7CiAjZW5kaWYKKyAgICByZXF1ZXN0LnNldExv YWRJbkJhY2tncm91bmQobV9iYWNrZ3JvdW5kUmVxdWVzdCk7CiAKICAgICBpZiAobV9yZXF1ZXN0 RW50aXR5Qm9keSkgewogICAgICAgICBBU1NFUlQobV9tZXRob2QgIT0gIkdFVCIpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmggYi9Tb3VyY2UvV2ViQ29y ZS94bWwvWE1MSHR0cFJlcXVlc3QuaAppbmRleCA2MDY0MjhiLi44YjBjZGRiIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS94bWwvWE1MSHR0cFJlcXVlc3QuaApAQCAtODMsNiArODMsOCBAQCBwdWJsaWM6CiAgICAgU3Rh dGUgcmVhZHlTdGF0ZSgpIGNvbnN0OwogICAgIGJvb2wgd2l0aENyZWRlbnRpYWxzKCkgY29uc3Qg eyByZXR1cm4gbV9pbmNsdWRlQ3JlZGVudGlhbHM7IH0KICAgICB2b2lkIHNldFdpdGhDcmVkZW50 aWFscyhib29sLCBFeGNlcHRpb25Db2RlJik7CisgICAgYm9vbCB3ZWJraXRCYWNrZ3JvdW5kUmVx dWVzdCgpIGNvbnN0IHsgcmV0dXJuIG1fYmFja2dyb3VuZFJlcXVlc3Q7IH0KKyAgICB2b2lkIHNl dFdlYmtpdEJhY2tncm91bmRSZXF1ZXN0KGJvb2wsIEV4Y2VwdGlvbkNvZGUmKTsKICAgICB2b2lk IG9wZW4oY29uc3QgU3RyaW5nJiBtZXRob2QsIGNvbnN0IEtVUkwmLCBFeGNlcHRpb25Db2RlJik7 CiAgICAgdm9pZCBvcGVuKGNvbnN0IFN0cmluZyYgbWV0aG9kLCBjb25zdCBLVVJMJiwgYm9vbCBh c3luYywgRXhjZXB0aW9uQ29kZSYpOwogICAgIHZvaWQgb3Blbihjb25zdCBTdHJpbmcmIG1ldGhv ZCwgY29uc3QgS1VSTCYsIGJvb2wgYXN5bmMsIGNvbnN0IFN0cmluZyYgdXNlciwgRXhjZXB0aW9u Q29kZSYpOwpAQCAtMTg5LDYgKzE5MSw3IEBAIHByaXZhdGU6CiAgICAgU3RyaW5nIG1fbWltZVR5 cGVPdmVycmlkZTsKICAgICBib29sIG1fYXN5bmM7CiAgICAgYm9vbCBtX2luY2x1ZGVDcmVkZW50 aWFsczsKKyAgICBib29sIG1fYmFja2dyb3VuZFJlcXVlc3Q7CiAgICAgUmVmUHRyPEJsb2I+IG1f cmVzcG9uc2VCbG9iOwogCiAgICAgUmVmUHRyPFRocmVhZGFibGVMb2FkZXI+IG1fbG9hZGVyOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmlkbCBiL1NvdXJj ZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5pZGwKaW5kZXggYzk1NTdiMy4uYjhiMTQ4MyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmlkbAorKysgYi9T b3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuaWRsCkBAIC02MSw2ICs2MSw5IEBAIG1v ZHVsZSB4bWwgewogICAgICAgICBhdHRyaWJ1dGUgYm9vbGVhbiB3aXRoQ3JlZGVudGlhbHMKICAg ICAgICAgICAgIHNldHRlciByYWlzZXMoRE9NRXhjZXB0aW9uKTsKIAorICAgICAgICBhdHRyaWJ1 dGUgYm9vbGVhbiB3ZWJraXRCYWNrZ3JvdW5kUmVxdWVzdAorICAgICAgICAgICAgc2V0dGVyIHJh aXNlcyhET01FeGVwdGlvbik7CisKICAgICAgICAgW0N1c3RvbV0gdm9pZCBvcGVuKGluIERPTVN0 cmluZyBtZXRob2QsIGluIERPTVN0cmluZyB1cmwsIGluIFtPcHRpb25hbF0gYm9vbGVhbiBhc3lu YywgaW4gW09wdGlvbmFsXSBET01TdHJpbmcgdXNlciwgaW4gW09wdGlvbmFsXSBET01TdHJpbmcg cGFzc3dvcmQpCiAgICAgICAgICAgICByYWlzZXMoRE9NRXhjZXB0aW9uKTsKIAotLSAKMS43Ljku NQoK