91963 2012-07-22 23:57:44 -0700 Null-pointer crash when parsing border-image 2012-07-23 17:06:46 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dstockwell dstockwell cmarcelo macpherson menard webkit.review.bot oldest_to_newest 675478 0 dstockwell 2012-07-22 23:57:44 -0700 Null-pointer crash when parsing border-image 675479 1 153741 dstockwell 2012-07-22 23:59:19 -0700 Created attachment 153741 Patch 675620 2 153741 menard 2012-07-23 04:42:04 -0700 Comment on attachment 153741 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153741&action=review > LayoutTests/ChangeLog:8 > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). The changelog is wrong here. > LayoutTests/fast/css/border-image-fill-crash.html:7 > + testRunner.dumpAsText(); You should use the new JS template for test, e.g. fast/css/getComputedStyle/getComputedStyle-margin-shorthand.html 676141 3 153891 dstockwell 2012-07-23 16:18:44 -0700 Created attachment 153891 Patch 676145 4 dstockwell 2012-07-23 16:23:35 -0700 (In reply to comment #2) > (From update of attachment 153741 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=153741&action=review > > > LayoutTests/ChangeLog:8 > > + Additional information of the change such as approach, rationale. Please add per-function descriptions below (OOPS!). > > The changelog is wrong here. OOPS! Fixed. > > LayoutTests/fast/css/border-image-fill-crash.html:7 > > + testRunner.dumpAsText(); > > You should use the new JS template for test, e.g. fast/css/getComputedStyle/getComputedStyle-margin-shorthand.html I can see how this might be helpful for a JavaScript based test, but in this case I think it would just make the test harder to read, what do you think? 676198 5 153891 webkit.review.bot 2012-07-23 17:06:42 -0700 Comment on attachment 153891 Patch Clearing flags on attachment: 153891 Committed r123406: <http://trac.webkit.org/changeset/123406> 676199 6 webkit.review.bot 2012-07-23 17:06:46 -0700 All reviewed patches have been landed. Closing bug. 153741 2012-07-22 23:59:19 -0700 2012-07-23 16:18:39 -0700 Patch bug-91963-20120723165911.patch text/plain 3093 dstockwell U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMzA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjE0ZjYwMDIyZGRlOTdi MWJhYTc2Y2JlNTQ5YTFlNTU5ODIzZTFhMi4uNmJjOWY1OWJiOGRmYmE1OTZmYTAwZWExYmY5YjBi MzE0MWEyNzcwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3LTIyICBEb3Vn bGFzIFN0b2Nrd2VsbCAgPGRzdG9ja3dlbGxAZ29vZ2xlLmNvbT4KKworICAgICAgICBOdWxsLXBv aW50ZXIgY3Jhc2ggd2hlbiBwYXJzaW5nIGJvcmRlci1pbWFnZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE5NjMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBmYXN0L2Nzcy9ib3JkZXItaW1hZ2Ut ZmlsbC1jcmFzaC5odG1sCisKKyAgICAgICAgKiBjc3MvQ1NTUGFyc2VyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkNTU1BhcnNlcjo6cGFyc2VCb3JkZXJJbWFnZVJlcGVhdCk6IEhhbmRsZSB0aGUg Y2FzZSB3aGVyZQorICAgICAgICBwYXJzZUJvcmRlckltYWdlUmVwZWF0IGlzIGNhbGxlZCB3aGVu IHRoZSB2YWx1ZSBsaXN0IGlzIGVtcHR5LgorCiAyMDEyLTA3LTIyICBLZW50YXJvIEhhcmEgIDxo YXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbVjhdIENvZGVHZW5lcmF0b3JWOC5wbSBz aG91bGQgc3VwcG9ydCBzdGF0aWMgYXR0cmlidXRlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvY3NzL0NTU1BhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcApp bmRleCA0YmQ5Nzc4YWQ3MzVlNzY0ZGY0YTJlZWI0MzBjZDA0YmFmNjZlNmI5Li41NTllYTlkMWQ5 YmVhNTMwZDkxZjNjZTgzNzY1ZDA5YjQwODkyMDY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNw cApAQCAtNjA2NCw2ICs2MDY0LDggQEAgYm9vbCBDU1NQYXJzZXI6OnBhcnNlQm9yZGVySW1hZ2VS ZXBlYXQoUmVmUHRyPENTU1ZhbHVlPiYgcmVzdWx0KQogICAgIFJlZlB0cjxDU1NQcmltaXRpdmVW YWx1ZT4gZmlyc3RWYWx1ZTsKICAgICBSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+IHNlY29uZFZh bHVlOwogICAgIENTU1BhcnNlclZhbHVlKiB2YWwgPSBtX3ZhbHVlTGlzdC0+Y3VycmVudCgpOwor ICAgIGlmICghdmFsKQorICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgaWYgKGlzQm9yZGVySW1h Z2VSZXBlYXRLZXl3b3JkKHZhbC0+aWQpKQogICAgICAgICBmaXJzdFZhbHVlID0gY3NzVmFsdWVQ b29sKCkuY3JlYXRlSWRlbnRpZmllclZhbHVlKHZhbC0+aWQpOwogICAgIGVsc2UKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBj ZWI2MWQ3M2I2NjAyYTVmMmVhMTFiYTI5YzhjODQ3MzA4MzMxMzIwLi45NGZiY2ZkYmU5MTk0OGI3 YzgyZTYzNjM0MDhkNzEwMTFhNzk4YjMyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDct MjIgIERvdWdsYXMgU3RvY2t3ZWxsICA8ZHN0b2Nrd2VsbEBnb29nbGUuY29tPgorCisgICAgICAg IE51bGwtcG9pbnRlciBjcmFzaCB3aGVuIHBhcnNpbmcgYm9yZGVyLWltYWdlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTk2MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGl0aW9uYWwgaW5mb3JtYXRp b24gb2YgdGhlIGNoYW5nZSBzdWNoIGFzIGFwcHJvYWNoLCByYXRpb25hbGUuIFBsZWFzZSBhZGQg cGVyLWZ1bmN0aW9uIGRlc2NyaXB0aW9ucyBiZWxvdyAoT09QUyEpLgorCisgICAgICAgICogZmFz dC9jc3MvYm9yZGVyLWltYWdlLWZpbGwtY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg ICAgKiBmYXN0L2Nzcy9ib3JkZXItaW1hZ2UtZmlsbC1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAx Mi0wNy0yMiAgTGkgWWluICA8bGkueWluQGludGVsLmNvbT4KIAogICAgICAgICBJbXByb3ZlIEJp cXVhZEZpbHRlck5vZGUgdGVzdCBjYXNlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nz cy9ib3JkZXItaW1hZ2UtZmlsbC1jcmFzaC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0 L2Nzcy9ib3JkZXItaW1hZ2UtZmlsbC1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTcy OTY0ODE5YjRjNGJlN2I4YmM1ZjdhMWFjYzY5YmM2ZjI2YTQyMAotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvY3NzL2JvcmRlci1pbWFnZS1maWxsLWNyYXNoLWV4cGVjdGVkLnR4 dApAQCAtMCwwICsxIEBACitUaGlzIHRlc3QgcGFzc2VzIGlmIGl0IGRvZXMgbm90IENSQVNILgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MvYm9yZGVyLWltYWdlLWZpbGwtY3Jhc2gu aHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2JvcmRlci1pbWFnZS1maWxsLWNyYXNoLmh0bWwK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uZmU0MmRhNDUxYjY2MjE5YmU4M2EyMDc1NTQ3Y2ZkMjU4Njk3YjViOQotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2JvcmRlci1pbWFnZS1maWxsLWNy YXNoLmh0bWwKQEAgLTAsMCArMSw4IEBACis8c3R5bGU+CisqIHsgYm9yZGVyLWltYWdlOiBmaWxs OyB9Cis8L3N0eWxlPgorVGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2VzIG5vdCBDUkFTSC4KKzxz Y3JpcHQ+CitpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0 KCk7Cis8L3NjcmlwdD4K 153891 2012-07-23 16:18:44 -0700 2012-07-23 17:06:42 -0700 Patch bug-91963-20120724091836.patch text/plain 2964 dstockwell U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMzA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjE0ZjYwMDIyZGRlOTdi MWJhYTc2Y2JlNTQ5YTFlNTU5ODIzZTFhMi4uNmJjOWY1OWJiOGRmYmE1OTZmYTAwZWExYmY5YjBi MzE0MWEyNzcwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3LTIyICBEb3Vn bGFzIFN0b2Nrd2VsbCAgPGRzdG9ja3dlbGxAZ29vZ2xlLmNvbT4KKworICAgICAgICBOdWxsLXBv aW50ZXIgY3Jhc2ggd2hlbiBwYXJzaW5nIGJvcmRlci1pbWFnZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE5NjMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBmYXN0L2Nzcy9ib3JkZXItaW1hZ2Ut ZmlsbC1jcmFzaC5odG1sCisKKyAgICAgICAgKiBjc3MvQ1NTUGFyc2VyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkNTU1BhcnNlcjo6cGFyc2VCb3JkZXJJbWFnZVJlcGVhdCk6IEhhbmRsZSB0aGUg Y2FzZSB3aGVyZQorICAgICAgICBwYXJzZUJvcmRlckltYWdlUmVwZWF0IGlzIGNhbGxlZCB3aGVu IHRoZSB2YWx1ZSBsaXN0IGlzIGVtcHR5LgorCiAyMDEyLTA3LTIyICBLZW50YXJvIEhhcmEgIDxo YXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbVjhdIENvZGVHZW5lcmF0b3JWOC5wbSBz aG91bGQgc3VwcG9ydCBzdGF0aWMgYXR0cmlidXRlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvY3NzL0NTU1BhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcApp bmRleCA0YmQ5Nzc4YWQ3MzVlNzY0ZGY0YTJlZWI0MzBjZDA0YmFmNjZlNmI5Li41NTllYTlkMWQ5 YmVhNTMwZDkxZjNjZTgzNzY1ZDA5YjQwODkyMDY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNw cApAQCAtNjA2NCw2ICs2MDY0LDggQEAgYm9vbCBDU1NQYXJzZXI6OnBhcnNlQm9yZGVySW1hZ2VS ZXBlYXQoUmVmUHRyPENTU1ZhbHVlPiYgcmVzdWx0KQogICAgIFJlZlB0cjxDU1NQcmltaXRpdmVW YWx1ZT4gZmlyc3RWYWx1ZTsKICAgICBSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+IHNlY29uZFZh bHVlOwogICAgIENTU1BhcnNlclZhbHVlKiB2YWwgPSBtX3ZhbHVlTGlzdC0+Y3VycmVudCgpOwor ICAgIGlmICghdmFsKQorICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgaWYgKGlzQm9yZGVySW1h Z2VSZXBlYXRLZXl3b3JkKHZhbC0+aWQpKQogICAgICAgICBmaXJzdFZhbHVlID0gY3NzVmFsdWVQ b29sKCkuY3JlYXRlSWRlbnRpZmllclZhbHVlKHZhbC0+aWQpOwogICAgIGVsc2UKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBj ZWI2MWQ3M2I2NjAyYTVmMmVhMTFiYTI5YzhjODQ3MzA4MzMxMzIwLi41NDk4MDlhZGNhZTk0YTY5 NTkxMTVkOGVjMDM0ZmVjZDczZDFjYjhkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDct MjIgIERvdWdsYXMgU3RvY2t3ZWxsICA8ZHN0b2Nrd2VsbEBnb29nbGUuY29tPgorCisgICAgICAg IE51bGwtcG9pbnRlciBjcmFzaCB3aGVuIHBhcnNpbmcgYm9yZGVyLWltYWdlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTk2MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9jc3MvYm9yZGVyLWlt YWdlLWZpbGwtY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9i b3JkZXItaW1hZ2UtZmlsbC1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAxMi0wNy0yMiAgTGkgWWlu ICA8bGkueWluQGludGVsLmNvbT4KIAogICAgICAgICBJbXByb3ZlIEJpcXVhZEZpbHRlck5vZGUg dGVzdCBjYXNlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9ib3JkZXItaW1hZ2Ut ZmlsbC1jcmFzaC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9ib3JkZXItaW1h Z2UtZmlsbC1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTcyOTY0ODE5YjRjNGJlN2I4 YmM1ZjdhMWFjYzY5YmM2ZjI2YTQyMAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zh c3QvY3NzL2JvcmRlci1pbWFnZS1maWxsLWNyYXNoLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBA CitUaGlzIHRlc3QgcGFzc2VzIGlmIGl0IGRvZXMgbm90IENSQVNILgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9jc3MvYm9yZGVyLWltYWdlLWZpbGwtY3Jhc2guaHRtbCBiL0xheW91dFRl c3RzL2Zhc3QvY3NzL2JvcmRlci1pbWFnZS1maWxsLWNyYXNoLmh0bWwKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZmU0 MmRhNDUxYjY2MjE5YmU4M2EyMDc1NTQ3Y2ZkMjU4Njk3YjViOQotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvY3NzL2JvcmRlci1pbWFnZS1maWxsLWNyYXNoLmh0bWwKQEAgLTAs MCArMSw4IEBACis8c3R5bGU+CisqIHsgYm9yZGVyLWltYWdlOiBmaWxsOyB9Cis8L3N0eWxlPgor VGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2VzIG5vdCBDUkFTSC4KKzxzY3JpcHQ+CitpZiAod2lu ZG93LnRlc3RSdW5uZXIpCisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7Cis8L3NjcmlwdD4K