91962 2012-07-22 23:35:53 -0700 Improve AudioChannelSplitter test 2012-08-20 16:04:11 -0700 1 1 1 Unclassified WebKit Web Audio 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 94540 1 li.yin li.yin crogers eric.carlson feature-media-reviews haraken webkit.review.bot oldest_to_newest 675467 0 li.yin 2012-07-22 23:35:53 -0700 Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioChannelSplitter-section The numberOfOutputs parameter determines the number of outputs. Values of up to 32 must be supported. If not specified, then 6 will be used. The test should cover empty parmeter and some values needed to be supported. 675469 1 153738 li.yin 2012-07-22 23:43:37 -0700 Created attachment 153738 Patch 675476 2 153738 haraken 2012-07-22 23:54:22 -0700 Comment on attachment 153738 Patch Looks OK. Shall we add more test cases for "An exception will be thrown for invalid parameter values" in a follow-up patch? (e.g. null, undefined, "123" etc) 675488 3 li.yin 2012-07-23 00:30:08 -0700 (In reply to comment #2) > (From update of attachment 153738 [details]) > Looks OK. Shall we add more test cases for "An exception will be thrown for invalid parameter values" in a follow-up patch? (e.g. null, undefined, "123" etc) Thanks for your review. These invalid parameter should be general for all the test. They should be depended on JS or V8 core. I think other tests have covered them already. I wander if it is necessary to cover these details. 675499 4 153738 webkit.review.bot 2012-07-23 00:53:39 -0700 Comment on attachment 153738 Patch Clearing flags on attachment: 153738 Committed r123309: <http://trac.webkit.org/changeset/123309> 675500 5 webkit.review.bot 2012-07-23 00:53:42 -0700 All reviewed patches have been landed. Closing bug. 153738 2012-07-22 23:43:37 -0700 2012-07-23 00:53:39 -0700 Patch bug-91962-20120724144806.patch text/plain 3886 li.yin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyMjgyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjIzY2NkOTBhNTAzYmZiNjYyNzA3 YzcxZDg5MWI1YjcwMWM5NTc5Zi4uNTdkOGE2N2FjMjZlMjA2MWQ1ZjgzNGVjZmNiYjBjNGU1ZWY1 NGRkOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTIzICBMaSBZaW4gIDxsaS55aW5A aW50ZWwuY29tPgorCisgICAgICAgIEltcHJvdmUgQXVkaW9DaGFubmVsU3BsaXR0ZXIgdGVzdAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE5NjIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTcGVjOiBodHRw czovL2R2Y3MudzMub3JnL2hnL2F1ZGlvL3Jhdy1maWxlL3RpcC93ZWJhdWRpby9zcGVjaWZpY2F0 aW9uLmh0bWwjQXVkaW9DaGFubmVsU3BsaXR0ZXItc2VjdGlvbgorICAgICAgICBUaGUgbnVtYmVy T2ZPdXRwdXRzIHBhcmFtZXRlciBkZXRlcm1pbmVzIHRoZSBudW1iZXIgb2Ygb3V0cHV0cy4KKyAg ICAgICAgVmFsdWVzIG9mIHVwIHRvIDMyIG11c3QgYmUgc3VwcG9ydGVkLiBJZiBub3Qgc3BlY2lm aWVkLCB0aGVuIDYgd2lsbCBiZSB1c2VkLgorCisgICAgICAgICogd2ViYXVkaW8vYXVkaW9jaGFu bmVsc3BsaXR0ZXItZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHdlYmF1ZGlvL2F1ZGlvY2hhbm5l bHNwbGl0dGVyLmh0bWw6CisKIDIwMTItMDctMTAgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29n bGUuY29tPgogCiAgICAgICAgIExpbmUgZGlyZWN0aXZlIHRlc3QgaW4gZmFzdC9jYW52YXMvd2Vi Z2wvZ2xzbC1jb25mb3JtYW5jZS5odG1sIGlzIGluY29ycmVjdApkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvd2ViYXVkaW8vYXVkaW9jaGFubmVsc3BsaXR0ZXItZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvd2ViYXVkaW8vYXVkaW9jaGFubmVsc3BsaXR0ZXItZXhwZWN0ZWQudHh0CmluZGV4IGNj OGY0NjdjOThhNzAyZGMwYjI2NjRlNmE5ZTM1ZGM5M2E3MzBhMjQuLjM4OGFiYTA1NWQ3YmViZTAx YmVlMDA2ZmQyZWUzNmFkYzM4NzljZDIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3dlYmF1ZGlv L2F1ZGlvY2hhbm5lbHNwbGl0dGVyLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy93ZWJh dWRpby9hdWRpb2NoYW5uZWxzcGxpdHRlci1leHBlY3RlZC50eHQKQEAgLTQsNiArNCwxMSBAQCBP biBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xs b3dlZCBieSAiVEVTVCBDT01QTEVURQogCiBQQVNTIEV4Y2VwdGlvbiBiZWVuIHRocm93biBmb3Ig bnVtYmVyT2ZPdXRwdXRzIDw9IDAuCiBQQVNTIEV4Y2VwdGlvbiBiZWVuIHRocm93biBmb3IgbnVt YmVyT2ZPdXRwdXRzID49IDMyLgorUEFTUyBBdWRpb0NoYW5uZWxTcGxpdHRlciBjcmVhdGVkIHN1 Y2Nlc3NmdWxseSB3aXRoIG51bWJlck9mT3V0cHV0cyA9IDMyLgorUEFTUyBBdWRpb0NoYW5uZWxT cGxpdHRlciBoYXMgMzIgb3V0cHV0cyB3aGVuIGl0IGlzIGNyZWF0ZWQgd2l0aCBudW1iZXJPZk91 dHB1dHMgPSAzMi4KK1BBU1MgQXVkaW9DaGFubmVsU3BsaXR0ZXIgaGFzIG9uZSBpbnB1dC4KK1BB U1MgQXVkaW9DaGFubmVsU3BsaXR0ZXIgY3JlYXRlZCBzdWNjZXNzZnVsbHkgd2l0aCBlbXB0eSBw YXJhbWV0ZXIuCitQQVNTIEF1ZGlvQ2hhbm5lbFNwbGl0dGVyIGhhcyA2IG91dHB1dHMgd2hlbiBp dCBpcyBjcmVhdGVkIHdpdGggZW1wdHkgcGFyYW1ldGVyLgogUEFTUyBDb3JyZWN0bHkgZXhjaGFu Z2VkIGxlZnQgYW5kIHJpZ2h0IGNoYW5uZWxzLgogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMg dHJ1ZQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy93ZWJhdWRpby9hdWRpb2NoYW5uZWxzcGxp dHRlci5odG1sIGIvTGF5b3V0VGVzdHMvd2ViYXVkaW8vYXVkaW9jaGFubmVsc3BsaXR0ZXIuaHRt bAppbmRleCBiZTlhZGFjZmFjZTQ0NzUzYWEwN2VmMjAzZTUzNzAwNmM3MDM1NTcwLi5hYjYyYzBi ZWIwZmNmZTc4MWYwNWMzMDZhOTE2ZGEwMzU1ZGY0MzUwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy93ZWJhdWRpby9hdWRpb2NoYW5uZWxzcGxpdHRlci5odG1sCisrKyBiL0xheW91dFRlc3RzL3dl YmF1ZGlvL2F1ZGlvY2hhbm5lbHNwbGl0dGVyLmh0bWwKQEAgLTk3LDYgKzk3LDMzIEBAIGZ1bmN0 aW9uIHJ1blRlc3QoKSB7CiAgICAgICAgIHRlc3RQYXNzZWQoIkV4Y2VwdGlvbiBiZWVuIHRocm93 biBmb3IgbnVtYmVyT2ZPdXRwdXRzID49IDMyLiIpOwogICAgIH0KIAorICAgIHRyeSB7CisgICAg ICAgIHZhciBzcGxpdHRlcm5vZGUgPSBjb250ZXh0LmNyZWF0ZUNoYW5uZWxTcGxpdHRlcigzMik7 CisgICAgICAgIHRlc3RQYXNzZWQoIkF1ZGlvQ2hhbm5lbFNwbGl0dGVyIGNyZWF0ZWQgc3VjY2Vz c2Z1bGx5IHdpdGggbnVtYmVyT2ZPdXRwdXRzID0gMzIuIik7CisgICAgICAgIGlmIChzcGxpdHRl cm5vZGUubnVtYmVyT2ZPdXRwdXRzID09PSAzMikKKyAgICAgICAgICAgIHRlc3RQYXNzZWQoIkF1 ZGlvQ2hhbm5lbFNwbGl0dGVyIGhhcyAzMiBvdXRwdXRzIHdoZW4gaXQgaXMgY3JlYXRlZCB3aXRo IG51bWJlck9mT3V0cHV0cyA9IDMyLiIpOworICAgICAgICBlbHNlCisgICAgICAgICAgICB0ZXN0 RmFpbGVkKCJBdWRpb0NoYW5uZWxTcGxpdHRlciBzaG91bGQgaGF2ZSAzMiBvdXRwdXRzIHdoZW4g aXQgaXMgY3JlYXRlZCB3aXRoIG51bWJlck9mT3V0cHV0cyA9IDMyLiIpOworCisgICAgICAgIGlm IChzcGxpdHRlcm5vZGUubnVtYmVyT2ZJbnB1dHMgPT09IDEpCisgICAgICAgICAgICB0ZXN0UGFz c2VkKCJBdWRpb0NoYW5uZWxTcGxpdHRlciBoYXMgb25lIGlucHV0LiIpOworICAgICAgICBlbHNl CisgICAgICAgICAgICB0ZXN0RmFpbGVkKCJBdWRpb0NoYW5uZWxTcGxpdHRlciBzaG91bGQgaGF2 ZSBvbmUgaW5wdXQuIik7CisgICAgfSBjYXRjaChlKSB7CisgICAgICAgIHRlc3RGYWlsZWQoIkZh aWxlZCB0byBjcmVhdGUgQXVkaW9DaGFubmVsU3BsaXR0ZXIgd2l0aCBudW1iZXJPZklucHV0cyA9 IDMyLiIpOworICAgIH0KKworICAgIHRyeSB7CisgICAgICAgIHZhciBzcGxpdHRlcm5vZGUgPSBj b250ZXh0LmNyZWF0ZUNoYW5uZWxTcGxpdHRlcigpOworICAgICAgICB0ZXN0UGFzc2VkKCJBdWRp b0NoYW5uZWxTcGxpdHRlciBjcmVhdGVkIHN1Y2Nlc3NmdWxseSB3aXRoIGVtcHR5IHBhcmFtZXRl ci4iKTsKKyAgICAgICAgaWYgKHNwbGl0dGVybm9kZS5udW1iZXJPZk91dHB1dHMgPT09IDYpCisg ICAgICAgICAgICB0ZXN0UGFzc2VkKCJBdWRpb0NoYW5uZWxTcGxpdHRlciBoYXMgNiBvdXRwdXRz IHdoZW4gaXQgaXMgY3JlYXRlZCB3aXRoIGVtcHR5IHBhcmFtZXRlci4iKTsKKyAgICAgICAgZWxz ZQorICAgICAgICAgICAgdGVzdEZhaWxlZCgiQXVkaW9DaGFubmVsU3BsaXR0ZXIgc2hvdWxkIGhh dmUgNiBvdXRwdXRzIHdoZW4gaXQgaXMgY3JlYXRlZCB3aXRoIGVtcHR5IHBhcmFtZXRlci4iKTsK KyAgICB9IGNhdGNoKGUpIHsKKyAgICAgICAgdGVzdEZhaWxlZCgiRmFpbGVkIHRvIGNyZWF0ZSBB dWRpb0NoYW5uZWxTcGxpdHRlciB3aXRoIGVtcHR5IHBhcmFtZXRlci4iKTsKKyAgICB9CisKICAg ICAvLyBDcmVhdGUgYSBzdGVyZW8gYnVmZmVyLCB3aXRoIGFsbCArMSB2YWx1ZXMgaW4gbGVmdCBj aGFubmVsLCBhbGwgLTEgaW4gcmlnaHQgY2hhbm5lbC4KICAgICBzb3VyY2VCdWZmZXIgPSBjcmVh dGVTdGVyZW9CdWZmZXJXaXRoRENPZmZzZXQobGVuZ3RoSW5TYW1wbGVGcmFtZXMsIHNhbXBsZVJh dGUsIDEpOwogCg==