91939 2012-07-22 01:38:39 -0700 [CMake] Add option for ENABLE_DFG_JIT 2012-07-23 06:44:38 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All REOPENED P2 Normal --- 91953 1 paroga paroga dbates gyuyoung.kim rakuco rwlbuis ryuan.choi tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 675296 0 paroga 2012-07-22 01:38:39 -0700 [CMake] Add option for ENABLE_DFG_JIT 675297 1 153689 paroga 2012-07-22 01:41:28 -0700 Created attachment 153689 Patch 675319 2 153689 webkit.review.bot 2012-07-22 09:36:43 -0700 Comment on attachment 153689 Patch Clearing flags on attachment: 153689 Committed r123298: <http://trac.webkit.org/changeset/123298> 675320 3 webkit.review.bot 2012-07-22 09:36:48 -0700 All reviewed patches have been landed. Closing bug. 675378 4 webkit.review.bot 2012-07-22 18:03:46 -0700 Re-opened since this is blocked by 91953 675474 5 dbates 2012-07-22 23:53:00 -0700 (In reply to comment #2) > [...] > Committed r123298: <http://trac.webkit.org/changeset/123298> This patch broke the Windows CE Release build: <http://build.webkit.org/builders/WinCE%20Release%20%28Build%29/builds/26012/steps/compile-webkit/logs/stdio> 675475 6 dbates 2012-07-22 23:54:20 -0700 (In reply to comment #5) > (In reply to comment #2) > > [...] > > Committed r123298: <http://trac.webkit.org/changeset/123298> > > This patch broke the Windows CE Release build: > > <http://build.webkit.org/builders/WinCE%20Release%20%28Build%29/builds/26012/steps/compile-webkit/logs/stdio> I committed an attempt to fix the build in <http://trac.webkit.org/changeset/123301> (see remark (*)). This broke the EFL Linux 64-bit Debug build [1] because the CMake defined ENABLE_DFG_JIT prevents us from evaluating the logic for enabling the ENABLE_DFG_JIT in wtf/Platorm.h [2]. From talking with Ryuan Choi on IRC this evening, we thought it was best to rollout this patch <http://trac.webkit.org/changeset/123303> (bug #91953) so that the intricacies between CMake and wtf/Platform.h can be worked out offline. It may also be beneficial to elaborate on the use case for exposing this option in CMake. (*) I chose to disable the DFG JIT (by default) because I was unclear of both the state of JIT support in the Windows CE port (can we enable it in OptionsWinCE.cmake? [3]) and whether consensus was reached among other CMake-based port maintainers to enable the DFG JIT by default. [1] <http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/3131/steps/compile-webkit/logs/stdio> [2] <http://trac.webkit.org/browser/trunk/Source/WTF/wtf/Platform.h?rev=123181#L897> [3] <http://trac.webkit.org/browser/trunk/Source/cmake/OptionsWinCE.cmake?rev=119767#L25> 675481 7 paroga 2012-07-23 00:03:57 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #2) > > > [...] > > > Committed r123298: <http://trac.webkit.org/changeset/123298> > > > > This patch broke the Windows CE Release build: > > > > <http://build.webkit.org/builders/WinCE%20Release%20%28Build%29/builds/26012/steps/compile-webkit/logs/stdio> > > I committed an attempt to fix the build in <http://trac.webkit.org/changeset/123301> (see remark (*)). This broke the EFL Linux 64-bit Debug build [1] because the CMake defined ENABLE_DFG_JIT prevents us from evaluating the logic for enabling the ENABLE_DFG_JIT in wtf/Platorm.h [2]. > > From talking with Ryuan Choi on IRC this evening, we thought it was best to rollout this patch <http://trac.webkit.org/changeset/123303> (bug #91953) so that the intricacies between CMake and wtf/Platform.h can be worked out offline. It may also be beneficial to elaborate on the use case for exposing this option in CMake. > > (*) I chose to disable the DFG JIT (by default) because I was unclear of both the state of JIT support in the Windows CE port (can we enable it in OptionsWinCE.cmake? [3]) and whether consensus was reached among other CMake-based port maintainers to enable the DFG JIT by default. I took the same on/off value as Platform.h declares. It's on for the EFL and Blackberry port all the time AFAICS. The build problem was caused, by the fact that ENABLE_DFG_JIT isn't guided with ENABLE_JIT to. Since we don't have any guideline when a CMake option is ok and when not I'd like to add it again with the corresponding off value for WinCE. (I hate doing so much "feature detection" in Platform.h) 153689 2012-07-22 01:41:28 -0700 2012-07-22 09:36:43 -0700 Patch bug-91939.patch text/plain 1809 paroga ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA4MTM3NTJmLi5kOWE1NDA2 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTItMDctMjIgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgW0NNYWtlXSBBZGQgb3B0aW9uIGZvciBFTkFCTEVfREZHX0pJVAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE5MzkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRG ZWF0dXJlcy5jbWFrZToKKyAgICAgICAgKiBTb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZToKKwog MjAxMi0wNy0yMCAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmVuYW1lIEVOQUJMRV9EQVRBTElTVCB0byBFTkFCTEVfREFUQUxJU1RfRUxFTUVOVApkaWZmIC0t Z2l0IGEvU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlIGIvU291cmNlL2NtYWtlL1dl YktpdEZlYXR1cmVzLmNtYWtlCmluZGV4IDMzNmY5NDUuLmI2NWNmODggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvV2ViS2l0 RmVhdHVyZXMuY21ha2UKQEAgLTM1LDYgKzM1LDcgQEAgTUFDUk8gKFdFQktJVF9PUFRJT05fQkVH SU4pCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0RBVEFfVFJBTlNGRVJfSVRFTVMg IlRvZ2dsZSBIVE1MNSBkYXRhIHRyYW5zZmVyIGl0ZW1zIHN1cHBvcnQiIE9GRikKICAgICBXRUJL SVRfT1BUSU9OX0RFRklORShFTkFCTEVfREVUQUlMUyAiVG9nZ2xlIEhUTUw1IGRldGFpbHMgc3Vw cG9ydCIgT04pCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0RFVklDRV9PUklFTlRB VElPTiAiVG9nZ2xlIERldmljZU9yaWVudGF0aW9uIHN1cHBvcnQiIE9GRikKKyAgICBXRUJLSVRf T1BUSU9OX0RFRklORShFTkFCTEVfREZHX0pJVCAiVG9nZ2xlIGRhdGEgZmxvdyBncmFwaCBKSVQg c3VwcG9ydCIgT04pCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0RJQUxPR19FTEVN RU5UICJUb2dnbGUgRGlhbG9nIEVsZW1lbnQgc3VwcG9ydCIgT0ZGKQogICAgIFdFQktJVF9PUFRJ T05fREVGSU5FKEVOQUJMRV9ESVJFQ1RPUllfVVBMT0FEICJUb2dnbGUgRGlyZWN0b3J5IHVwbG9h ZCBzdXBwb3J0IiBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX0RPV05MT0FE X0FUVFJJQlVURSAiVG9nZ2xlIGRvd25sb2FkIGF0dHJpYnV0ZSBzdXBwb3J0IiBPRkYpCmRpZmYg LS1naXQgYS9Tb3VyY2UvY21ha2Vjb25maWcuaC5jbWFrZSBiL1NvdXJjZS9jbWFrZWNvbmZpZy5o LmNtYWtlCmluZGV4IDZkNzgxYTQuLjQ2YzQyM2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZWNv bmZpZy5oLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZWNvbmZpZy5oLmNtYWtlCkBAIC0yOSw2ICsy OSw3IEBACiAjY21ha2VkZWZpbmUwMSBFTkFCTEVfREFUQV9UUkFOU0ZFUl9JVEVNUwogI2NtYWtl ZGVmaW5lMDEgRU5BQkxFX0RFVEFJTFMKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9ERVZJQ0VfT1JJ RU5UQVRJT04KKyNjbWFrZWRlZmluZTAxIEVOQUJMRV9ERkdfSklUCiAjY21ha2VkZWZpbmUwMSBF TkFCTEVfRElBTE9HX0VMRU1FTlQKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9ET1dOTE9BRF9BVFRS SUJVVEUKICNjbWFrZWRlZmluZTAxIEVOQUJMRV9EUkFHX1NVUFBPUlQK