91938 2012-07-22 01:32:41 -0700 [WINCE] Define NOMINMAX in the build system instead of Platform.h 2012-07-23 03:07:47 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 paroga paroga aroben bfulgham gyuyoung.kim rakuco webkit.review.bot oldest_to_newest 675294 0 paroga 2012-07-22 01:32:41 -0700 [WINCE] Define NOMINMAX in the build system instead of Platform.h 675295 1 153688 paroga 2012-07-22 01:35:57 -0700 Created attachment 153688 Patch 675337 2 153688 rakuco 2012-07-22 12:33:02 -0700 Comment on attachment 153688 Patch LGTM from the build system side. 675501 3 153688 rniwa 2012-07-23 00:53:47 -0700 Comment on attachment 153688 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153688&action=review > ChangeLog:8 > + Define it OptionsWindows.cmake, since NOMINMAX Nit: Define it in*. 675580 4 paroga 2012-07-23 03:05:55 -0700 Committed r123324: <http://trac.webkit.org/changeset/123324> 153688 2012-07-22 01:35:57 -0700 2012-07-23 03:07:47 -0700 Patch bug-91938.patch text/plain 2446 paroga ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA4MTM3NTJmLi4yZjQ1ZTYz IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTItMDctMjIgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgW1dJTkNFXSBEZWZpbmUgTk9NSU5NQVggaW4gdGhlIGJ1aWxkIHN5c3RlbSBpbnN0ZWFk IG9mIFBsYXRmb3JtLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTkxOTM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgRGVmaW5lIGl0IE9wdGlvbnNXaW5kb3dzLmNtYWtlLCBzaW5jZSBOT01JTk1BWAorICAg ICAgICBzaG91bGQgdG8gYmUgZGVmaW5lZCBmb3IgYWxsIHdpbmRvd3MgcG9ydHMuCisKKyAgICAg ICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc1dpbkNFLmNtYWtlOgorICAgICAgICAqIFNvdXJjZS9j bWFrZS9PcHRpb25zV2luZG93cy5jbWFrZToKKwogMjAxMi0wNy0yMCAgS2VudCBUYW11cmEgIDx0 a2VudEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVuYW1lIEVOQUJMRV9EQVRBTElTVCB0byBF TkFCTEVfREFUQUxJU1RfRUxFTUVOVApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi9DaGFuZ2VMb2cg Yi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwppbmRleCBiNjFkNzhjLi43ZjY1YTcwIDEwMDY0NAotLS0g YS9Tb3VyY2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDEyLTA3LTIyICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQu b3JnPgorCisgICAgICAgIFtXSU5DRV0gRGVmaW5lIE5PTUlOTUFYIGluIHRoZSBidWlsZCBzeXN0 ZW0gaW5zdGVhZCBvZiBQbGF0Zm9ybS5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05MTkzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMTItMDctMjAgIEhhbiBTaGVu ICA8c2hlbmhhbkBnb29nbGUuY29tPgogCiAgICAgICAgIFtDaHJvbWl1bV0gQ29tcGlsYXRpb24g ZmFpbHMgdW5kZXIgZ2NjIDQuNwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm0u aCBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKaW5kZXggYTdlMWQ1Mi4uYTI1ODkzNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9Q bGF0Zm9ybS5oCkBAIC01MDIsNyArNTAyLDYgQEAKICNlbmRpZgogCiAjaWYgT1MoV0lOQ0UpICYm ICFQTEFURk9STShRVCkKLSNkZWZpbmUgTk9NSU5NQVggICAgICAgLyogV2luZG93cyBtaW4gYW5k IG1heCBjb25mbGljdCB3aXRoIHN0YW5kYXJkIG1hY3JvcyAqLwogI2RlZmluZSBOT1NITFdBUEkg ICAgICAvKiBzaGx3YXBpLmggbm90IGF2YWlsYWJsZSBvbiBXaW5DZSAqLwogCiAvKiBNU0ROIGRv Y3VtZW50YXRpb24gc2F5cyB0aGVzZSBmdW5jdGlvbnMgYXJlIHByb3ZpZGVkIHdpdGggdXNwY2Uu bGliLiAgQnV0IHdlIGNhbm5vdCBmaW5kIHRoaXMgZmlsZS4gKi8KZGlmZiAtLWdpdCBhL1NvdXJj ZS9jbWFrZS9PcHRpb25zV2luQ0UuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc1dpbkNFLmNt YWtlCmluZGV4IDRmZTc3NWMuLjI3MGYwMDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zV2luQ0UuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNXaW5DRS5jbWFrZQpAQCAt MSw1ICsxLDYgQEAKIElOQ0xVREUoT3B0aW9uc1dpbmRvd3MpCiAKK0FERF9ERUZJTklUSU9OUygt RF9DRV9DUlRfQUxMT1dfV0lOX01JTk1BWCkKIEFERF9ERUZJTklUSU9OUygtRFdURl9VU0VfV0lO Q0VfVU5JQ09ERT0xKQogQUREX0RFRklOSVRJT05TKC1EV1RGX1VTRV9XSU5JTkVUPTEpCiBBRERf REVGSU5JVElPTlMoLURXVEZfQ1BVX0FSTV9UUkFESVRJT05BTCAtRFdJTkNFQkFTSUMpCmRpZmYg LS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc1dpbmRvd3MuY21ha2UgYi9Tb3VyY2UvY21ha2Uv T3B0aW9uc1dpbmRvd3MuY21ha2UKaW5kZXggOWVkN2MyZC4uM2ZkY2Y2OCAxMDA2NDQKLS0tIGEv U291cmNlL2NtYWtlL09wdGlvbnNXaW5kb3dzLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRp b25zV2luZG93cy5jbWFrZQpAQCAtMSw3ICsxLDcgQEAKIEFERF9ERUZJTklUSU9OUygtRFdURl9Q TEFURk9STV9XSU49MSkKIFNFVChXVEZfUExBVEZPUk1fV0lOIDEpCiAKLUFERF9ERUZJTklUSU9O UygtRFVOSUNPREUpCitBRERfREVGSU5JVElPTlMoLUROT01JTk1BWCAtRFVOSUNPREUpCiAKIElO Q0xVREVfRElSRUNUT1JJRVMoJHtKQVZBU0NSSVBUQ09SRV9ESVJ9L29zLXdpbjMyKQogCg==