91936 2012-07-22 01:18:40 -0700 [WIN] Use GetTimeZoneInformation() for getting the timezone name 2012-08-08 00:31:32 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 92282 1 paroga paroga aroben bfulgham webkit.review.bot oldest_to_newest 675290 0 paroga 2012-07-22 01:18:40 -0700 [WIN] Use GetTimeZoneInformation() for getting the timezone name 675291 1 153686 paroga 2012-07-22 01:20:48 -0700 Created attachment 153686 Patch 675531 2 153686 rniwa 2012-07-23 01:24:53 -0700 Comment on attachment 153686 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153686&action=review > Source/JavaScriptCore/runtime/DateConversion.cpp:93 > + DWORD result = GetTimeZoneInformation(&timeZoneInformation); I would have named this variable daylightType instead. > Source/JavaScriptCore/runtime/DateConversion.cpp:94 > + CString timeZoneNameString = String(result == TIME_ZONE_ID_DAYLIGHT ? timeZoneInformation.DaylightName : timeZoneInformation.StandardName).latin1(); It's unfortunate that we have to convert WCHAR to char here. I would use ascii().data() instead possibly allocating String as a local variable. 675532 3 153686 rniwa 2012-07-23 01:30:14 -0700 Comment on attachment 153686 Patch Okay, I withdraw my r+. We need to be more careful here. I thought DaylightName could only be 3-letter abbreviations but this apparently isn't the case. It could be a full long timezone name. 688995 4 156901 paroga 2012-08-07 03:00:29 -0700 Created attachment 156901 Patch 689960 5 156901 rniwa 2012-08-07 23:25:02 -0700 Comment on attachment 156901 Patch This is more like it! 690018 6 156901 webkit.review.bot 2012-08-08 00:31:28 -0700 Comment on attachment 156901 Patch Clearing flags on attachment: 156901 Committed r125004: <http://trac.webkit.org/changeset/125004> 690019 7 webkit.review.bot 2012-08-08 00:31:32 -0700 All reviewed patches have been landed. Closing bug. 153686 2012-07-22 01:20:48 -0700 2012-08-07 03:00:29 -0700 Patch bug-91936.patch text/plain 2121 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDFhNThmZDguLjIwNjFlYjkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTIyICBQYXRyaWNrIEdhbnN0 ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgorCisgICAgICAgIFtXSU5dIFVzZSBHZXRUaW1lWm9u ZUluZm9ybWF0aW9uKCkgZm9yIGdldHRpbmcgdGhlIHRpbWV6b25lIG5hbWUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxOTM2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIE1TIENSVCBpbXBsZW1lbnRh dGlvbiBvZiBzdHJmdGltZSBjYWxscyB0aGUgc2FtZSBmdW5jdGlvbnMgaW4gdGhlIGJhY2tncm91 bmQuCisgICAgICAgIFVzaW5nIHRoZW0gZGlyZWN0bHkgYXZvaWRzIHRoZSBvdmVyaGVhZCBvZiBw YXJzaW5nIHRoZSBmb3JtYXQgc3RyaW5nIGFuZCByZW1vdmVzCisgICAgICAgIHRoZSBkZXBlbmRl bmN5IG9uIHN0cmZ0aW1lKCkgZm9yIFdpbkNFIHdoZXJlIHRoaXMgZnVuY3Rpb24gZG9lcyBub3Qg ZXhpc3QuCisKKyAgICAgICAgKiBydW50aW1lL0RhdGVDb252ZXJzaW9uLmNwcDoKKyAgICAgICAg KEpTQzo6Zm9ybWF0VGltZSk6CisKIDIwMTItMDctMjEgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFy b2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1dJTl0gVXNlIEdldERhdGVGb3JtYXQgYW5kIEdl dFRpbWVGb3JtYXQgaW5zdGVhZCBvZiBzdHJmdGltZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvRGF0ZUNvbnZlcnNpb24uY3BwIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvRGF0ZUNvbnZlcnNpb24uY3BwCmluZGV4IDdiYzBjYmMuLjk2NTM5OTUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0RhdGVDb252ZXJzaW9uLmNw cAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9EYXRlQ29udmVyc2lvbi5jcHAK QEAgLTUxLDYgKzUxLDEwIEBACiAjaW5jbHVkZSA8d3RmL1N0cmluZ0V4dHJhcy5oPgogI2luY2x1 ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KIAorI2lmIE9TKFdJTkRPV1MpCisjaW5jbHVkZSA8d2lu ZG93cy5oPgorI2VuZGlmCisKIHVzaW5nIG5hbWVzcGFjZSBXVEY7CiAKIG5hbWVzcGFjZSBKU0Mg ewpAQCAtODQsOSArODgsMTYgQEAgdm9pZCBmb3JtYXREYXRlVVRDVmFyaWFudChjb25zdCBHcmVn b3JpYW5EYXRlVGltZSAmdCwgRGF0ZUNvbnZlcnNpb25CdWZmZXImIGJ1ZmYKIHZvaWQgZm9ybWF0 VGltZShjb25zdCBHcmVnb3JpYW5EYXRlVGltZSAmdCwgRGF0ZUNvbnZlcnNpb25CdWZmZXImIGJ1 ZmZlcikKIHsKICAgICBpbnQgb2Zmc2V0ID0gYWJzKGdtdG9mZnNldCh0KSk7CisjaWYgT1MoV0lO RE9XUykKKyAgICBUSU1FX1pPTkVfSU5GT1JNQVRJT04gdGltZVpvbmVJbmZvcm1hdGlvbjsKKyAg ICBEV09SRCByZXN1bHQgPSBHZXRUaW1lWm9uZUluZm9ybWF0aW9uKCZ0aW1lWm9uZUluZm9ybWF0 aW9uKTsKKyAgICBDU3RyaW5nIHRpbWVab25lTmFtZVN0cmluZyA9IFN0cmluZyhyZXN1bHQgPT0g VElNRV9aT05FX0lEX0RBWUxJR0hUID8gdGltZVpvbmVJbmZvcm1hdGlvbi5EYXlsaWdodE5hbWUg OiB0aW1lWm9uZUluZm9ybWF0aW9uLlN0YW5kYXJkTmFtZSkubGF0aW4xKCk7CisgICAgY29uc3Qg Y2hhciogdGltZVpvbmVOYW1lID0gdGltZVpvbmVOYW1lU3RyaW5nLmRhdGEoKTsKKyNlbHNlCiAg ICAgY2hhciB0aW1lWm9uZU5hbWVbNzBdOwogICAgIHN0cnVjdCB0bSBndG0gPSB0OwogICAgIHN0 cmZ0aW1lKHRpbWVab25lTmFtZSwgc2l6ZW9mKHRpbWVab25lTmFtZSksICIlWiIsICZndG0pOwor I2VuZGlmCiAKICAgICBpZiAodGltZVpvbmVOYW1lWzBdKSB7CiAgICAgICAgIHNucHJpbnRmKGJ1 ZmZlciwgRGF0ZUNvbnZlcnNpb25CdWZmZXJTaXplLCAiJTAyZDolMDJkOiUwMmQgR01UJWMlMDJk JTAyZCAoJXMpIiwK 156901 2012-08-07 03:00:29 -0700 2012-08-08 00:31:28 -0700 Patch bug-91936b.patch text/plain 2053 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDFhNThmZDguLjIwNjFlYjkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTIyICBQYXRyaWNrIEdhbnN0 ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgorCisgICAgICAgIFtXSU5dIFVzZSBHZXRUaW1lWm9u ZUluZm9ybWF0aW9uKCkgZm9yIGdldHRpbmcgdGhlIHRpbWV6b25lIG5hbWUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxOTM2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIE1TIENSVCBpbXBsZW1lbnRh dGlvbiBvZiBzdHJmdGltZSBjYWxscyB0aGUgc2FtZSBmdW5jdGlvbnMgaW4gdGhlIGJhY2tncm91 bmQuCisgICAgICAgIFVzaW5nIHRoZW0gZGlyZWN0bHkgYXZvaWRzIHRoZSBvdmVyaGVhZCBvZiBw YXJzaW5nIHRoZSBmb3JtYXQgc3RyaW5nIGFuZCByZW1vdmVzCisgICAgICAgIHRoZSBkZXBlbmRl bmN5IG9uIHN0cmZ0aW1lKCkgZm9yIFdpbkNFIHdoZXJlIHRoaXMgZnVuY3Rpb24gZG9lcyBub3Qg ZXhpc3QuCisKKyAgICAgICAgKiBydW50aW1lL0RhdGVDb252ZXJzaW9uLmNwcDoKKyAgICAgICAg KEpTQzo6Zm9ybWF0VGltZSk6CisKIDIwMTItMDctMjEgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFy b2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1dJTl0gVXNlIEdldERhdGVGb3JtYXQgYW5kIEdl dFRpbWVGb3JtYXQgaW5zdGVhZCBvZiBzdHJmdGltZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvRGF0ZUNvbnZlcnNpb24uY3BwIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3J1bnRpbWUvRGF0ZUNvbnZlcnNpb24uY3BwCmluZGV4IDZmMzY1ZDAuLjQ3ODM5ODEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0RhdGVDb252ZXJzaW9uLmNw cAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9EYXRlQ29udmVyc2lvbi5jcHAK QEAgLTMwLDYgKzMwLDEwIEBACiAjaW5jbHVkZSA8d3RmL0RhdGVNYXRoLmg+CiAjaW5jbHVkZSA8 d3RmL3RleHQvU3RyaW5nQnVpbGRlci5oPgogCisjaWYgT1MoV0lORE9XUykKKyNpbmNsdWRlIDx3 aW5kb3dzLmg+CisjZW5kaWYKKwogdXNpbmcgbmFtZXNwYWNlIFdURjsKIAogbmFtZXNwYWNlIEpT QyB7CkBAIC0xMDAsOSArMTA0LDE1IEBAIFVTdHJpbmcgZm9ybWF0RGF0ZVRpbWUoY29uc3QgR3Jl Z29yaWFuRGF0ZVRpbWUmIHQsIERhdGVUaW1lRm9ybWF0IGZvcm1hdCwgYm9vbCBhCiAgICAgICAg ICAgICBhcHBlbmROdW1iZXI8Mj4oYnVpbGRlciwgb2Zmc2V0IC8gNjApOwogICAgICAgICAgICAg YXBwZW5kTnVtYmVyPDI+KGJ1aWxkZXIsIG9mZnNldCAlIDYwKTsKIAorI2lmIE9TKFdJTkRPV1Mp CisgICAgICAgICAgICBUSU1FX1pPTkVfSU5GT1JNQVRJT04gdGltZVpvbmVJbmZvcm1hdGlvbjsK KyAgICAgICAgICAgIEdldFRpbWVab25lSW5mb3JtYXRpb24oJnRpbWVab25lSW5mb3JtYXRpb24p OworICAgICAgICAgICAgY29uc3QgV0NIQVIqIHRpbWVab25lTmFtZSA9IHQuaXNEU1QoKSA/IHRp bWVab25lSW5mb3JtYXRpb24uRGF5bGlnaHROYW1lIDogdGltZVpvbmVJbmZvcm1hdGlvbi5TdGFu ZGFyZE5hbWU7CisjZWxzZQogICAgICAgICAgICAgc3RydWN0IHRtIGd0bSA9IHQ7CiAgICAgICAg ICAgICBjaGFyIHRpbWVab25lTmFtZVs3MF07CiAgICAgICAgICAgICBzdHJmdGltZSh0aW1lWm9u ZU5hbWUsIHNpemVvZih0aW1lWm9uZU5hbWUpLCAiJVoiLCAmZ3RtKTsKKyNlbmRpZgogICAgICAg ICAgICAgaWYgKHRpbWVab25lTmFtZVswXSkgewogICAgICAgICAgICAgICAgIGJ1aWxkZXIuYXBw ZW5kKCIgKCIpOwogICAgICAgICAgICAgICAgIGJ1aWxkZXIuYXBwZW5kKHRpbWVab25lTmFtZSk7 Cg==