91934 2012-07-21 17:34:19 -0700 Missing *explicit* keyword in storage and workers 2012-07-22 18:28:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim haraken webkit.review.bot oldest_to_newest 675277 0 gyuyoung.kim 2012-07-21 17:34:19 -0700 Some constructors missed to use *explicit* keyword. They need to be added *explicit* keyword to contructor which has a parameter in order to avoid implicit type conversion. 675278 1 153680 gyuyoung.kim 2012-07-21 17:36:24 -0700 Created attachment 153680 Patch 675370 2 153680 haraken 2012-07-22 16:49:16 -0700 Comment on attachment 153680 Patch Good refactoring. 675389 3 153680 webkit.review.bot 2012-07-22 18:27:55 -0700 Comment on attachment 153680 Patch Clearing flags on attachment: 153680 Committed r123305: <http://trac.webkit.org/changeset/123305> 675390 4 webkit.review.bot 2012-07-22 18:28:00 -0700 All reviewed patches have been landed. Closing bug. 153680 2012-07-21 17:36:24 -0700 2012-07-22 18:27:55 -0700 Patch bug-91934-20120722093618.patch text/plain 6891 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzE1ODU4ZGI5Zjg3NGU2 NTA2NjRhM2E0MThlOWUxMTM4N2Y1YjIzMy4uZGYwNjdjNGNmOWQ5MzczODY5M2Y1ZWI2NDQ1MTM1 ODU2N2RhMDRmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM1IEBACisyMDEyLTA3LTIxICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgTWlzc2luZyAq ZXhwbGljaXQqIGtleXdvcmQgaW4gc3RvcmFnZSBhbmQgd29ya2Vycy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxOTM0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU29tZSBjb25zdHJ1Y3RvcnMgbWlzc2Vk IHRvIHVzZSAqZXhwbGljaXQqIGtleXdvcmQuIFRoZXkgbmVlZCB0byBiZSBhZGRlZAorICAgICAg ICAqZXhwbGljaXQqIGtleXdvcmQgdG8gY29udHJ1Y3RvciB3aGljaCBoYXMgYSBwYXJhbWV0ZXIg aW4gb3JkZXIgdG8gYXZvaWQKKyAgICAgICAgaW1wbGljaXQgdHlwZSBjb252ZXJzaW9uLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cy4gQ29udmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAg ICAgKiBzdG9yYWdlL1N0b3JhZ2VBcmVhSW1wbC5oOgorICAgICAgICAoU3RvcmFnZUFyZWFJbXBs KToKKyAgICAgICAgKiBzdG9yYWdlL1N0b3JhZ2VNYXAuaDoKKyAgICAgICAgKFN0b3JhZ2VNYXAp OgorICAgICAgICAqIHN0b3JhZ2UvU3RvcmFnZVN5bmNNYW5hZ2VyLmg6CisgICAgICAgIChTdG9y YWdlU3luY01hbmFnZXIpOgorICAgICAgICAqIHN0b3JhZ2UvU3RvcmFnZVRhc2suaDoKKyAgICAg ICAgKFN0b3JhZ2VUYXNrKToKKyAgICAgICAgKiBzdG9yYWdlL1N0b3JhZ2VUcmFja2VyLmg6Cisg ICAgICAgIChTdG9yYWdlVHJhY2tlcik6CisgICAgICAgICogd29ya2Vycy9TaGFyZWRXb3JrZXIu aDoKKyAgICAgICAgKFNoYXJlZFdvcmtlcik6CisgICAgICAgICogd29ya2Vycy9Xb3JrZXIuaDoK KyAgICAgICAgKFdvcmtlcik6CisgICAgICAgICogd29ya2Vycy9Xb3JrZXJMb2NhdGlvbi5oOgor ICAgICAgICAoV2ViQ29yZTo6V29ya2VyTG9jYXRpb246OldvcmtlckxvY2F0aW9uKToKKyAgICAg ICAgKiB3b3JrZXJzL1dvcmtlck1lc3NhZ2luZ1Byb3h5Lmg6CisgICAgICAgIChXb3JrZXJNZXNz YWdpbmdQcm94eSk6CisKIDIwMTItMDctMjEgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdl YmtpdC5vcmc+CiAKICAgICAgICAgQ2xlYW51cCBUZXh0RW5jb2RpbmcgVVNFKFhYWF9VTklDT0RF KSBtYWNyb3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZUFyZWFJ bXBsLmggYi9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2VBcmVhSW1wbC5oCmluZGV4IGJl MDQ1MWM4NTBiYTQyYzcxY2JhZDhhNmQ5YTE5YmEwZDhmMDYwN2IuLjRjOTBlNWJjMDNlZDU0Njc0 ZDRmZTgzNGY4NTdhNjEwYTI4ODViNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N0b3Jh Z2UvU3RvcmFnZUFyZWFJbXBsLmgKKysrIGIvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdl QXJlYUltcGwuaApAQCAtNzAsNyArNzAsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICBw cml2YXRlOgogICAgICAgICBTdG9yYWdlQXJlYUltcGwoU3RvcmFnZVR5cGUsIFBhc3NSZWZQdHI8 U2VjdXJpdHlPcmlnaW4+LCBQYXNzUmVmUHRyPFN0b3JhZ2VTeW5jTWFuYWdlcj4sIHVuc2lnbmVk IHF1b3RhKTsKLSAgICAgICAgU3RvcmFnZUFyZWFJbXBsKFN0b3JhZ2VBcmVhSW1wbCopOworICAg ICAgICBleHBsaWNpdCBTdG9yYWdlQXJlYUltcGwoU3RvcmFnZUFyZWFJbXBsKik7CiAKICAgICAg ICAgdm9pZCBibG9ja1VudGlsSW1wb3J0Q29tcGxldGUoKSBjb25zdDsKICAgICAgICAgdm9pZCBj bG9zZURhdGFiYXNlVGltZXJGaXJlZChUaW1lcjxTdG9yYWdlQXJlYUltcGw+Kik7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2VNYXAuaCBiL1NvdXJjZS9XZWJDb3Jl L3N0b3JhZ2UvU3RvcmFnZU1hcC5oCmluZGV4IDFmYzE3YjA3NzU4OGIxY2E4ODFmODE5ODg3ODBi YTA2OGQyZmE3YTEuLjE0N2RmNjQwMmQ0NzU3NTVjOWI1MzhkNDFlNWRmZjNmNzJjOGNiZDMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZU1hcC5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZU1hcC5oCkBAIC01NCw3ICs1NCw3IEBAIG5hbWVzcGFj ZSBXZWJDb3JlIHsKICAgICAgICAgc3RhdGljIGNvbnN0IHVuc2lnbmVkIG5vUXVvdGEgPSBVSU5U X01BWDsKIAogICAgIHByaXZhdGU6Ci0gICAgICAgIFN0b3JhZ2VNYXAodW5zaWduZWQgcXVvdGEp OworICAgICAgICBleHBsaWNpdCBTdG9yYWdlTWFwKHVuc2lnbmVkIHF1b3RhKTsKICAgICAgICAg UGFzc1JlZlB0cjxTdG9yYWdlTWFwPiBjb3B5KCk7CiAgICAgICAgIHZvaWQgaW52YWxpZGF0ZUl0 ZXJhdG9yKCk7CiAgICAgICAgIHZvaWQgc2V0SXRlcmF0b3JUb0luZGV4KHVuc2lnbmVkKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZVN5bmNNYW5hZ2VyLmggYi9T b3VyY2UvV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2VTeW5jTWFuYWdlci5oCmluZGV4IGUyNzgzMzc4 NzlmMTNhZDJiNzU2MzJjMjc2ZjZiOTAwN2I5YjNlMTEuLmZhNWMxNmRjYzY3ZjEwZWFlNGVmZWM4 NGFjNzE0YmE2N2FmYWQwZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvU3Rv cmFnZVN5bmNNYW5hZ2VyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdlU3lu Y01hbmFnZXIuaApAQCAtNTAsNyArNTAsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAg IHZvaWQgY2xvc2UoKTsKIAogICAgIHByaXZhdGU6Ci0gICAgICAgIFN0b3JhZ2VTeW5jTWFuYWdl cihjb25zdCBTdHJpbmcmIHBhdGgpOworICAgICAgICBleHBsaWNpdCBTdG9yYWdlU3luY01hbmFn ZXIoY29uc3QgU3RyaW5nJiBwYXRoKTsKIAogICAgICAgICBPd25QdHI8U3RvcmFnZVRocmVhZD4g bV90aHJlYWQ7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZVRh c2suaCBiL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZVRhc2suaAppbmRleCA3ZDA1MjNm ZDFjYjM2NDg5YjQwYzlmMjRiODM2N2Y2NDg1M2QwYzdlLi5iMTRlOWZlNWZmZTkyNWVlNWQzMGNl MWZiMTMyN2YyNmNiNWJhNDIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL1N0 b3JhZ2VUYXNrLmgKKysrIGIvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdlVGFzay5oCkBA IC01OCw3ICs1OCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgU3RvcmFnZVRhc2so VHlwZSwgU3RvcmFnZVRocmVhZCopOwogICAgICAgICBTdG9yYWdlVGFzayhUeXBlLCBjb25zdCBT dHJpbmcmIG9yaWdpbklkZW50aWZpZXIpOwogICAgICAgICBTdG9yYWdlVGFzayhUeXBlLCBjb25z dCBTdHJpbmcmIG9yaWdpbklkZW50aWZpZXIsIGNvbnN0IFN0cmluZyYgZGF0YWJhc2VGaWxlbmFt ZSk7Ci0gICAgICAgIFN0b3JhZ2VUYXNrKFR5cGUpOworICAgICAgICBleHBsaWNpdCBTdG9yYWdl VGFzayhUeXBlKTsKIAogICAgICAgICBUeXBlIG1fdHlwZTsKICAgICAgICAgU3RvcmFnZUFyZWFT eW5jKiBtX2FyZWE7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2VU cmFja2VyLmggYi9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2VUcmFja2VyLmgKaW5kZXgg OWVlMjNmNWZmZmMxM2UyYzhiYjY2YWVmZjc1NmU3YmI1NGZhNzdmNS4uZWEzYTM4ZmRlYzA4NDVk MTdlYTUyNDc4ZTNiMGMwNDcyNTNlMGQ2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3Rv cmFnZS9TdG9yYWdlVHJhY2tlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFn ZVRyYWNrZXIuaApAQCAtNzgsNyArNzgsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRTdG9yYWdl RGF0YWJhc2VJZGxlSW50ZXJ2YWwoZG91YmxlIGludGVydmFsKSB7IG1fU3RvcmFnZURhdGFiYXNl SWRsZUludGVydmFsID0gaW50ZXJ2YWw7IH0KIAogcHJpdmF0ZToKLSAgICBTdG9yYWdlVHJhY2tl cihjb25zdCBTdHJpbmcmIHN0b3JhZ2VQYXRoKTsKKyAgICBleHBsaWNpdCBTdG9yYWdlVHJhY2tl cihjb25zdCBTdHJpbmcmIHN0b3JhZ2VQYXRoKTsKICAgICBzdGF0aWMgdm9pZCBzY2hlZHVsZVRh c2sodm9pZCopOwogCiAgICAgdm9pZCBpbnRlcm5hbEluaXRpYWxpemUoKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvU2hhcmVkV29ya2VyLmggYi9Tb3VyY2UvV2ViQ29yZS93 b3JrZXJzL1NoYXJlZFdvcmtlci5oCmluZGV4IDAwMzYyYmEyNTNkOGZiMTI1MDQ4M2YzMDAxYjQw NDA0ZTMzNDNhMjQuLjg0NWFlZDljM2QxNDBhNmM5MGVhNzI5YzI1NzhhYjA3ODdlMzc4MDQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvU2hhcmVkV29ya2VyLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvd29ya2Vycy9TaGFyZWRXb3JrZXIuaApAQCAtNDgsNyArNDgsNyBAQCBuYW1l c3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHZpcnR1YWwgY29uc3QgQXRvbWljU3RyaW5nJiBpbnRl cmZhY2VOYW1lKCkgY29uc3Q7CiAKICAgICBwcml2YXRlOgotICAgICAgICBTaGFyZWRXb3JrZXIo U2NyaXB0RXhlY3V0aW9uQ29udGV4dCopOworICAgICAgICBleHBsaWNpdCBTaGFyZWRXb3JrZXIo U2NyaXB0RXhlY3V0aW9uQ29udGV4dCopOwogCiAgICAgICAgIHZpcnR1YWwgU2hhcmVkV29ya2Vy KiB0b1NoYXJlZFdvcmtlcigpIHsgcmV0dXJuIHRoaXM7IH0KIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvd29ya2Vycy9Xb3JrZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2Vy LmgKaW5kZXggY2VhMWE2NDBlMDg2ZjcyZmVmMTAxYzI5YWY1YjRiYmU4YjI4ZjU1NC4uYzdhMWY4 ZDk5MGJhNGQzZmFlZDU3YjUzNzBlMWUxNTNmYjE0NGY2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvd29ya2Vycy9Xb3JrZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtl ci5oCkBAIC03MCw3ICs3MCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgREVGSU5F X0FUVFJJQlVURV9FVkVOVF9MSVNURU5FUihtZXNzYWdlKTsKIAogICAgIHByaXZhdGU6Ci0gICAg ICAgIFdvcmtlcihTY3JpcHRFeGVjdXRpb25Db250ZXh0Kik7CisgICAgICAgIGV4cGxpY2l0IFdv cmtlcihTY3JpcHRFeGVjdXRpb25Db250ZXh0Kik7CiAKICAgICAgICAgLy8gV29ya2VyU2NyaXB0 TG9hZGVyQ2xpZW50IGNhbGxiYWNrcwogICAgICAgICB2aXJ0dWFsIHZvaWQgZGlkUmVjZWl2ZVJl c3BvbnNlKHVuc2lnbmVkIGxvbmcgaWRlbnRpZmllciwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJMb2NhdGlvbi5oIGIv U291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJMb2NhdGlvbi5oCmluZGV4IDY5MmMwZTNjNTFj NDc0MzA4YWExZDM0ZTMzZWY5MGMwMTg1MzA5MWYuLjRiZDM1OTE4OTJmNjFjOTMzYzU0ZjJkZWNh MWQ5Mzk0NjE1OTBlODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2Vy TG9jYXRpb24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL1dvcmtlckxvY2F0aW9uLmgK QEAgLTYwLDcgKzYwLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBTdHJpbmcgdG9T dHJpbmcoKSBjb25zdCB7IHJldHVybiBocmVmKCk7IH0KIAogICAgIHByaXZhdGU6Ci0gICAgICAg IFdvcmtlckxvY2F0aW9uKGNvbnN0IEtVUkwmIHVybCkgOiBtX3VybCh1cmwpIHsgfQorICAgICAg ICBleHBsaWNpdCBXb3JrZXJMb2NhdGlvbihjb25zdCBLVVJMJiB1cmwpIDogbV91cmwodXJsKSB7 IH0KIAogICAgICAgICBLVVJMIG1fdXJsOwogICAgIH07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS93b3JrZXJzL1dvcmtlck1lc3NhZ2luZ1Byb3h5LmggYi9Tb3VyY2UvV2ViQ29yZS93b3Jr ZXJzL1dvcmtlck1lc3NhZ2luZ1Byb3h5LmgKaW5kZXggYjdjYmU1MjZmNGE2MjU0ODUzYzJiNjgx MWUyOGY2OGEzMWMxOGIxMS4uNzdiY2FiMmI2NjgwNzQwZGNhMTFkMTYwNWFkODYwNGU5OTExODIw MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvd29ya2Vycy9Xb3JrZXJNZXNzYWdpbmdQcm94 eS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvV29ya2VyTWVzc2FnaW5nUHJveHkuaApA QCAtNDksNyArNDksNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgY2xhc3MgV29ya2VyTWVz c2FnaW5nUHJveHkgOiBwdWJsaWMgV29ya2VyQ29udGV4dFByb3h5LCBwdWJsaWMgV29ya2VyT2Jq ZWN0UHJveHksIHB1YmxpYyBXb3JrZXJMb2FkZXJQcm94eSB7CiAgICAgICAgIFdURl9NQUtFX05P TkNPUFlBQkxFKFdvcmtlck1lc3NhZ2luZ1Byb3h5KTsgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7 CiAgICAgcHVibGljOgotICAgICAgICBXb3JrZXJNZXNzYWdpbmdQcm94eShXb3JrZXIqKTsKKyAg ICAgICAgZXhwbGljaXQgV29ya2VyTWVzc2FnaW5nUHJveHkoV29ya2VyKik7CiAKICAgICAgICAg Ly8gSW1wbGVtZW50YXRpb25zIG9mIFdvcmtlckNvbnRleHRQcm94eS4KICAgICAgICAgLy8gKE9u bHkgdXNlIHRoZXNlIG1ldGhvZHMgaW4gdGhlIHdvcmtlciBvYmplY3QgdGhyZWFkLikK