91925 2012-07-21 03:21:34 -0700 [JSC] REGRESSION(r122912): CodeGeneratorJS.pm generates wrong code for static attributes in supplemental IDL files 2012-07-26 12:51:53 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 91764 88919 92413 1 haraken haraken abarth japhet jochen jonlee oliver webkit-bug-importer webkit.review.bot oldest_to_newest 675222 0 haraken 2012-07-21 03:21:34 -0700 r122912 implemented static attributes in CodeGeneratorJS.pm. However, It generates wrong code for static attributes in supplemental IDL files, as you can see in https://bugs.webkit.org/attachment.cgi?id=153666&action=review. We should fix it. I will upload a patch after bug 91764 is fixed. 676467 1 153977 haraken 2012-07-24 00:35:09 -0700 Created attachment 153977 Patch 676526 2 153977 webkit.review.bot 2012-07-24 01:45:19 -0700 Comment on attachment 153977 Patch Clearing flags on attachment: 153977 Committed r123439: <http://trac.webkit.org/changeset/123439> 676527 3 webkit.review.bot 2012-07-24 01:45:23 -0700 All reviewed patches have been landed. Closing bug. 677128 4 webkit-bug-importer 2012-07-24 12:52:57 -0700 <rdar://problem/11947923> 153977 2012-07-24 00:35:09 -0700 2012-07-24 01:45:19 -0700 Patch bug-91925-20120724163500.patch text/plain 4977 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzNDMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjBjNzAyMDM0MTJlOGNj NTJiM2RiYTYxMTkzYTdiOTc3ZmJmMjYxMy4uZjQ5YjYzYjMyYzY0MGFiOTAzNTNlNTEwN2Y4MzNh MzUzYWVhYjc3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDEyLTA3LTI0ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbSlNDXSBSRUdSRVNT SU9OKHIxMjI5MTIpOiBDb2RlR2VuZXJhdG9ySlMucG0gZ2VuZXJhdGVzIHdyb25nIGNvZGUKKyAg ICAgICAgZm9yIHN0YXRpYyBhdHRyaWJ1dGVzIGluIHN1cHBsZW1lbnRhbCBJREwgZmlsZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxOTI1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcjEyMjkxMiBpbXBs ZW1lbnRlZCBzdGF0aWMgYXR0cmlidXRlcyBpbiBDb2RlR2VuZXJhdG9ySlMucG0uCisgICAgICAg IEhvd2V2ZXIsIGl0IGdlbmVyYXRlcyB3cm9uZyBjb2RlIGZvciBzdGF0aWMgYXR0cmlidXRlcyBp biBzdXBwbGVtZW50YWwKKyAgICAgICAgSURMIGZpbGVzLiBUaGlzIHBhdGNoIGZpeGVzIGl0IGFz IHNob3duIGluIEpTVGVzdEludGVyZmFjZS5jcHAuCisgICAgICAgIFRoaXMgZml4IGFsaWducyB3 aXRoIHRoZSBmaXggaW4gQ29kZUdlbmVyYXRvclY4LnBtIChyMTIzMzA4KS4KKworICAgICAgICBU ZXN0OiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3QvVGVzdFN1cHBsZW1lbnRhbC5pZGwKKworICAgICAg ICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtOgorICAgICAgICAoR2VuZXJh dGVJbXBsZW1lbnRhdGlvbik6CisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pT VGVzdEludGVyZmFjZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpqc1Rlc3RJbnRlcmZhY2VDb25z dHJ1Y3RvclN1cHBsZW1lbnRhbFN0YXRpY1JlYWRPbmx5QXR0cik6CisgICAgICAgIChXZWJDb3Jl Ojpqc1Rlc3RJbnRlcmZhY2VDb25zdHJ1Y3RvclN1cHBsZW1lbnRhbFN0YXRpY0F0dHIpOgorICAg ICAgICAoV2ViQ29yZTo6c2V0SlNUZXN0SW50ZXJmYWNlQ29uc3RydWN0b3JTdXBwbGVtZW50YWxT dGF0aWNBdHRyKToKKworMjAxMi0wNy0yNCAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1 bS5vcmc+CisKICAgICAgICAgW0pTQ10gUkVHUkVTU0lPTihyMTIyOTEyKTogQ29kZUdlbmVyYXRv ckpTLnBtIHNob3VsZCBub3QKICAgICAgICAgaW1wbGljaXRseSBhc3N1bWUgU2NyaXB0RXhlY3V0 aW9uQ29udGV4dCBmb3Igc3RhdGljIGF0dHJpYnV0ZXMKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxOTI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbSBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCmluZGV4IGFhYzRhMjk0MDc0ZDM5NDY2 NDJkZjVkOGY1MzViZTUwNzYzNGQ5YmUuLjAzY2M0ZTczMDI5ODMzZGM0NzU0NjdjMGVjMjNiY2Iy ZDRhMTg5NzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckpTLnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29k ZUdlbmVyYXRvckpTLnBtCkBAIC0xODQyLDcgKzE4NDIsNyBAQCBzdWIgR2VuZXJhdGVJbXBsZW1l bnRhdGlvbgogICAgICAgICAgICAgICAgICAgICAgICAgICAgIG15ICRpbXBsZW1lbnRlZEJ5ID0g JGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiSW1wbGVtZW50ZWRC eSJ9OwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICRpbXBsSW5jbHVkZXN7IiR7aW1wbGVt ZW50ZWRCeX0uaCJ9ID0gMTsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAkZnVuY3Rpb25O YW1lID0gIiR7aW1wbGVtZW50ZWRCeX06OiR7ZnVuY3Rpb25OYW1lfSI7Ci0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgdW5zaGlmdChAYXJndW1lbnRzLCAiaW1wbCIpOworICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHVuc2hpZnQoQGFyZ3VtZW50cywgImltcGwiKSBpZiAhJGF0dHJpYnV0 ZS0+aXNTdGF0aWM7CiAgICAgICAgICAgICAgICAgICAgICAgICB9IGVsc2lmICgkYXR0cmlidXRl LT5pc1N0YXRpYykgewogICAgICAgICAgICAgICAgICAgICAgICAgICAgICRmdW5jdGlvbk5hbWUg PSAiJHtpbXBsQ2xhc3NOYW1lfTo6JHtmdW5jdGlvbk5hbWV9IjsKICAgICAgICAgICAgICAgICAg ICAgICAgIH0gZWxzZSB7CkBAIC0yMDcxLDcgKzIwNzEsNyBAQCBzdWIgR2VuZXJhdGVJbXBsZW1l bnRhdGlvbgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYgKCRhdHRyaWJ1 dGUtPnNpZ25hdHVyZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkltcGxlbWVudGVkQnkifSkgewog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG15ICRpbXBsZW1lbnRlZEJ5 ID0gJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiSW1wbGVtZW50 ZWRCeSJ9OwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICRpbXBsSW5j bHVkZXN7IiR7aW1wbGVtZW50ZWRCeX0uaCJ9ID0gMTsKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB1bnNoaWZ0KEBhcmd1bWVudHMsICJpbXBsIik7CisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaGlmdChAYXJndW1lbnRzLCAiaW1wbCIp IGlmICEkYXR0cmlidXRlLT5pc1N0YXRpYzsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAkZnVuY3Rpb25OYW1lID0gIiR7aW1wbGVtZW50ZWRCeX06OiR7ZnVuY3Rpb25O YW1lfSI7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB9IGVsc2lmICgkYXR0 cmlidXRlLT5pc1N0YXRpYykgewogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICRmdW5jdGlvbk5hbWUgPSAiJHtpbXBsQ2xhc3NOYW1lfTo6JHtmdW5jdGlvbk5hbWV9IjsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rl c3RJbnRlcmZhY2UuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pT L0pTVGVzdEludGVyZmFjZS5jcHAKaW5kZXggMzk3YWYwZjJhYWNmNTFhNjY0NTJlNTQ0ODNiM2Fi MzgzMjFjOGZkZS4uMjY4YzkwMzQxYmU0OGEwNGI1ZjQ4MDU4YjNhZGE2NDBhMjJmNzMyNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdElu dGVyZmFjZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pT L0pTVGVzdEludGVyZmFjZS5jcHAKQEAgLTI0NSw3ICsyNDUsNyBAQCBib29sIEpTVGVzdEludGVy ZmFjZTo6Z2V0T3duUHJvcGVydHlEZXNjcmlwdG9yKEpTT2JqZWN0KiBvYmplY3QsIEV4ZWNTdGF0 ZSogZXhlYwogSlNWYWx1ZSBqc1Rlc3RJbnRlcmZhY2VDb25zdHJ1Y3RvclN1cHBsZW1lbnRhbFN0 YXRpY1JlYWRPbmx5QXR0cihFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUsIFByb3BlcnR5TmFtZSkK IHsKICAgICBVTlVTRURfUEFSQU0oZXhlYyk7Ci0gICAgSlNWYWx1ZSByZXN1bHQgPSBqc051bWJl cihUZXN0U3VwcGxlbWVudGFsOjpzdXBwbGVtZW50YWxTdGF0aWNSZWFkT25seUF0dHIoaW1wbCkp OworICAgIEpTVmFsdWUgcmVzdWx0ID0ganNOdW1iZXIoVGVzdFN1cHBsZW1lbnRhbDo6c3VwcGxl bWVudGFsU3RhdGljUmVhZE9ubHlBdHRyKCkpOwogICAgIHJldHVybiByZXN1bHQ7CiB9CiAKQEAg LTI1NSw3ICsyNTUsNyBAQCBKU1ZhbHVlIGpzVGVzdEludGVyZmFjZUNvbnN0cnVjdG9yU3VwcGxl bWVudGFsU3RhdGljUmVhZE9ubHlBdHRyKEV4ZWNTdGF0ZSogZXhlYwogSlNWYWx1ZSBqc1Rlc3RJ bnRlcmZhY2VDb25zdHJ1Y3RvclN1cHBsZW1lbnRhbFN0YXRpY0F0dHIoRXhlY1N0YXRlKiBleGVj LCBKU1ZhbHVlLCBQcm9wZXJ0eU5hbWUpCiB7CiAgICAgVU5VU0VEX1BBUkFNKGV4ZWMpOwotICAg IEpTVmFsdWUgcmVzdWx0ID0ganNTdHJpbmcoZXhlYywgVGVzdFN1cHBsZW1lbnRhbDo6c3VwcGxl bWVudGFsU3RhdGljQXR0cihpbXBsKSk7CisgICAgSlNWYWx1ZSByZXN1bHQgPSBqc1N0cmluZyhl eGVjLCBUZXN0U3VwcGxlbWVudGFsOjpzdXBwbGVtZW50YWxTdGF0aWNBdHRyKCkpOwogICAgIHJl dHVybiByZXN1bHQ7CiB9CiAKQEAgLTMyNSw3ICszMjUsNyBAQCB2b2lkIEpTVGVzdEludGVyZmFj ZTo6cHV0KEpTQ2VsbCogY2VsbCwgRXhlY1N0YXRlKiBleGVjLCBQcm9wZXJ0eU5hbWUgcHJvcGVy dHlOYQogdm9pZCBzZXRKU1Rlc3RJbnRlcmZhY2VDb25zdHJ1Y3RvclN1cHBsZW1lbnRhbFN0YXRp Y0F0dHIoRXhlY1N0YXRlKiBleGVjLCBKU09iamVjdCosIEpTVmFsdWUgdmFsdWUpCiB7CiAgICAg VU5VU0VEX1BBUkFNKGV4ZWMpOwotICAgIFRlc3RTdXBwbGVtZW50YWw6OnNldFN1cHBsZW1lbnRh bFN0YXRpY0F0dHIoaW1wbCwgdXN0cmluZ1RvU3RyaW5nKHZhbHVlLmlzRW1wdHkoKSA/IFVTdHJp bmcoKSA6IHZhbHVlLnRvU3RyaW5nKGV4ZWMpLT52YWx1ZShleGVjKSkpOworICAgIFRlc3RTdXBw bGVtZW50YWw6OnNldFN1cHBsZW1lbnRhbFN0YXRpY0F0dHIodXN0cmluZ1RvU3RyaW5nKHZhbHVl LmlzRW1wdHkoKSA/IFVTdHJpbmcoKSA6IHZhbHVlLnRvU3RyaW5nKGV4ZWMpLT52YWx1ZShleGVj KSkpOwogfQogCiAjZW5kaWYK