91921 2012-07-21 02:15:20 -0700 [WIN] Remove ICU dependencies from UniscribeController 2012-07-23 03:07:24 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 paroga paroga aroben bfulgham oldest_to_newest 675211 0 paroga 2012-07-21 02:15:20 -0700 [WIN] Remove ICU dependencies from UniscribeController 675212 1 153662 paroga 2012-07-21 02:18:59 -0700 Created attachment 153662 Patch 675518 2 153662 rniwa 2012-07-23 01:09:26 -0700 Comment on attachment 153662 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153662&action=review > Source/WebCore/platform/graphics/win/UniscribeController.cpp:151 > + bool forceSmallCaps = isSmallCaps && (category(*curr) & (Mark_NonSpacing | Mark_Enclosing | Mark_SpacingCombining)); It's probably better to use c here instead of *curr. 675519 3 paroga 2012-07-23 01:10:48 -0700 From http://icu-project.org/apiref/icu4c/uchar_8h.html #define U_GC_M_MASK (U_GC_MN_MASK|U_GC_ME_MASK|U_GC_MC_MASK) #define U_GC_MN_MASK U_MASK(U_NON_SPACING_MARK) #define U_GC_ME_MASK U_MASK(U_ENCLOSING_MARK) #define U_GC_MC_MASK U_MASK(U_COMBINING_SPACING_MARK) 675579 4 paroga 2012-07-23 02:59:11 -0700 Committed r123323: <http://trac.webkit.org/changeset/123323> 153662 2012-07-21 02:18:59 -0700 2012-07-23 03:07:24 -0700 Patch bug-91921.patch text/plain 2561 paroga ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkYTM3OWIwLi45MDM3MGE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTItMDctMjEgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgW1dJTl0gUmVtb3ZlIElDVSBkZXBlbmRlbmNpZXMgZnJvbSBVbmlzY3JpYmVDb250 cm9sbGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 MTkyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJl cGxhY2UgSUNVIHNwZWNpZmljIGZ1bmN0aW9ucyBhbmQgbWFjcm9zIHdpdGggdGhlIGNvcnJlc3Bv bmRpbmcgY29kZSBmcm9tIFdURjo6VW5pY29kZS4KKyAgICAgICAgVGhpcyBhbGxvd3MgdXMgdG8g dXNlIFVuaXNjcmliZUNvbnRyb2xsZXIgd2l0aCBhbiBvdGhlciBVbmljb2RlIGltcGxlbWVudGF0 aW9uIHRvby4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3dpbi9VbmlzY3JpYmVDb250 cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlVuaXNjcmliZUNvbnRyb2xsZXI6OmFkdmFu Y2UpOgorCiAyMDEyLTA3LTIwICBIYW4gU2hlbiAgPHNoZW5oYW5AZ29vZ2xlLmNvbT4KIAogICAg ICAgICBbQ2hyb21pdW1dIENvbXBpbGF0aW9uIGZhaWxzIHVuZGVyIGdjYyA0LjcKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9VbmlzY3JpYmVDb250cm9s bGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9VbmlzY3JpYmVD b250cm9sbGVyLmNwcAppbmRleCA2MGY4ZDEyLi43M2U4NTcyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vVW5pc2NyaWJlQ29udHJvbGxlci5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL1VuaXNjcmliZUNvbnRyb2xs ZXIuY3BwCkBAIC0zMSw2ICszMSw4IEBACiAjaW5jbHVkZSAiVGV4dFJ1bi5oIgogI2luY2x1ZGUg PHd0Zi9NYXRoRXh0cmFzLmg+CiAKK3VzaW5nIG5hbWVzcGFjZSBXVEY7Cit1c2luZyBuYW1lc3Bh Y2UgVW5pY29kZTsKIHVzaW5nIG5hbWVzcGFjZSBzdGQ7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsK QEAgLTEzMSw3ICsxMzMsNyBAQCB2b2lkIFVuaXNjcmliZUNvbnRyb2xsZXI6OmFkdmFuY2UodW5z aWduZWQgb2Zmc2V0LCBHbHlwaEJ1ZmZlciogZ2x5cGhCdWZmZXIpCiAgICAgVUNoYXIgbmV3QyA9 IDA7CiAKICAgICBib29sIGlzU21hbGxDYXBzOwotICAgIGJvb2wgbmV4dElzU21hbGxDYXBzID0g bV9mb250LmlzU21hbGxDYXBzKCkgJiYgIShVX0dFVF9HQ19NQVNLKCpjdXJyKSAmIFVfR0NfTV9N QVNLKSAmJiAobmV3QyA9IHVfdG91cHBlcigqY3VycikpICE9ICpjdXJyOworICAgIGJvb2wgbmV4 dElzU21hbGxDYXBzID0gbV9mb250LmlzU21hbGxDYXBzKCkgJiYgIShjYXRlZ29yeSgqY3Vycikg JiAoTWFya19Ob25TcGFjaW5nIHwgTWFya19FbmNsb3NpbmcgfCBNYXJrX1NwYWNpbmdDb21iaW5p bmcpKSAmJiAobmV3QyA9IHRvVXBwZXIoKmN1cnIpKSAhPSAqY3VycjsKIAogICAgIGlmIChuZXh0 SXNTbWFsbENhcHMpCiAgICAgICAgIHNtYWxsQ2Fwc0J1ZmZlcltjdXJyIC0gY3BdID0gbmV3QzsK QEAgLTE0NiwxMCArMTQ4LDEwIEBAIHZvaWQgVW5pc2NyaWJlQ29udHJvbGxlcjo6YWR2YW5jZSh1 bnNpZ25lZCBvZmZzZXQsIEdseXBoQnVmZmVyKiBnbHlwaEJ1ZmZlcikKICAgICAgICAgaW50IGlu ZGV4ID0gY3VyciAtIGNwOwogICAgICAgICBVQ2hhciBjID0gKmN1cnI7CiAKLSAgICAgICAgYm9v bCBmb3JjZVNtYWxsQ2FwcyA9IGlzU21hbGxDYXBzICYmIChVX0dFVF9HQ19NQVNLKGMpICYgVV9H Q19NX01BU0spOworICAgICAgICBib29sIGZvcmNlU21hbGxDYXBzID0gaXNTbWFsbENhcHMgJiYg KGNhdGVnb3J5KCpjdXJyKSAmIChNYXJrX05vblNwYWNpbmcgfCBNYXJrX0VuY2xvc2luZyB8IE1h cmtfU3BhY2luZ0NvbWJpbmluZykpOwogICAgICAgICBuZXh0Rm9udERhdGEgPSBtX2ZvbnQuZ2x5 cGhEYXRhRm9yQ2hhcmFjdGVyKCpjdXJyLCBmYWxzZSwgZm9yY2VTbWFsbENhcHMgPyBTbWFsbENh cHNWYXJpYW50IDogQXV0b1ZhcmlhbnQpLmZvbnREYXRhOwogICAgICAgICBpZiAobV9mb250Lmlz U21hbGxDYXBzKCkpIHsKLSAgICAgICAgICAgIG5leHRJc1NtYWxsQ2FwcyA9IGZvcmNlU21hbGxD YXBzIHx8IChuZXdDID0gdV90b3VwcGVyKGMpKSAhPSBjOworICAgICAgICAgICAgbmV4dElzU21h bGxDYXBzID0gZm9yY2VTbWFsbENhcHMgfHwgKG5ld0MgPSB0b1VwcGVyKGMpKSAhPSBjOwogICAg ICAgICAgICAgaWYgKG5leHRJc1NtYWxsQ2FwcykKICAgICAgICAgICAgICAgICBzbWFsbENhcHNC dWZmZXJbaW5kZXhdID0gZm9yY2VTbWFsbENhcHMgPyBjIDogbmV3QzsKICAgICAgICAgfQo=