91914 2012-07-20 18:16:56 -0700 [EFL] Remove unused headers from ewk_security_origin 2012-07-20 20:58:47 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All Unspecified RESOLVED FIXED P2 Normal --- 0 kihong.kwon webkit-unassigned gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 675128 0 kihong.kwon 2012-07-20 18:16:56 -0700 There are some unused header in the ewk_security_origin.h/cpp We need to remove them. 675140 1 153638 kihong.kwon 2012-07-20 18:55:20 -0700 Created attachment 153638 Patch 675145 2 153638 gyuyoung.kim 2012-07-20 19:02:37 -0700 Comment on attachment 153638 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153638&action=review I don't think we can land any patchess without review except for gardening and urgent build break, crash problems > Source/WebKit/efl/ChangeLog:6 > + Unreviewed EFL gardening. This patch is not gardening. 675146 3 153640 kihong.kwon 2012-07-20 19:07:04 -0700 Created attachment 153640 Patch 675147 4 153640 gyuyoung.kim 2012-07-20 19:08:52 -0700 Comment on attachment 153640 Patch LGTM 675148 5 153640 gyuyoung.kim 2012-07-20 19:11:17 -0700 Comment on attachment 153640 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153640&action=review > Source/WebKit/efl/ewk/ewk_security_origin.h:36 > +#include <Eina.h> It looks we don't need to move to .h file. 675149 6 153640 gyuyoung.kim 2012-07-20 19:20:25 -0700 Comment on attachment 153640 Patch Eina_List is being used by ewk_security_origin.h. It looks Eina.h files has included by include chain so far. So, there was a little misunderstanding. LGTM now. 675158 7 153640 noam 2012-07-20 20:02:06 -0700 Comment on attachment 153640 Patch rs=me 675163 8 153640 webkit.review.bot 2012-07-20 20:58:42 -0700 Comment on attachment 153640 Patch Clearing flags on attachment: 153640 Committed r123287: <http://trac.webkit.org/changeset/123287> 675164 9 webkit.review.bot 2012-07-20 20:58:47 -0700 All reviewed patches have been landed. Closing bug. 153638 2012-07-20 18:55:20 -0700 2012-07-20 19:06:56 -0700 Patch bug-91914-20120721105515.patch text/plain 1941 kihong.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggM2U3YjU0Nzkz ZTk5MjZkYWQxODg5ODNlMzRlZDM2NjM0NjU3MDVkYi4uY2E2OTI5NTJlZDJjYTA5ZTdkZjJlMmI5 ODQ0ODlhMzRjYzY3MTFlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEy LTA3LTIwICBLaWhvbmcgS3dvbiAgPGtpaG9uZy5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAg IFtFRkxdIFJlbW92ZSB1bnVzZWQgaGVhZGVycyBmcm9tIGV3a19zZWN1cml0eV9vcmlnaW4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxOTE0CisKKyAg ICAgICAgVW5yZXZpZXdlZCBFRkwgZ2FyZGVuaW5nLgorCisgICAgICAgIFRoZXJlIGFyZSBzb21l IHVudXNlZCBoZWFkZXIgaW4gdGhlIGV3a19zZWN1cml0eV9vcmlnaW4uaC9jcHAKKyAgICAgICAg V2UgbmVlZCB0byByZW1vdmUgdGhlbS4KKworICAgICAgICAqIGV3ay9ld2tfc2VjdXJpdHlfb3Jp Z2luLmNwcDoKKyAgICAgICAgKiBld2svZXdrX3NlY3VyaXR5X29yaWdpbi5oOgorCiAyMDEyLTA3 LTIwICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRlbC5jb20+CiAKICAg ICAgICAgW0VGTF0gUHJveHkgY29uZmlndXJhdGlvbiBzaG91bGQgaG9ub3IgdGhlIG5vX3Byb3h5 IGVudmlyb25tZW50IHZhcmlhYmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2sv ZXdrX3NlY3VyaXR5X29yaWdpbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NlY3Vy aXR5X29yaWdpbi5jcHAKaW5kZXggZDdlMzA0YzFhYzQ5NzM3MTYxZDFjNjAyOGE5ZmNiNDQwMTc0 MDJmZC4uMWI2ODg0ZThjMTk3ZmU4NjhlYmZiZTA3NjBmNDY2NzhjYzcwNDUzYyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZWN1cml0eV9vcmlnaW4uY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2VjdXJpdHlfb3JpZ2luLmNwcApAQCAtMjQsMTEgKzI0 LDkgQEAKICNpbmNsdWRlICJBcHBsaWNhdGlvbkNhY2hlU3RvcmFnZS5oIgogI2luY2x1ZGUgIkRh dGFiYXNlVHJhY2tlci5oIgogI2luY2x1ZGUgIlNlY3VyaXR5T3JpZ2luLmgiCi0jaW5jbHVkZSAi ZXdrX3ByaXZhdGUuaCIKICNpbmNsdWRlICJld2tfc2VjdXJpdHlfb3JpZ2luX3ByaXZhdGUuaCIK ICNpbmNsdWRlICJld2tfd2ViX2RhdGFiYXNlLmgiCiAjaW5jbHVkZSAiZXdrX3dlYl9kYXRhYmFz ZV9wcml2YXRlLmgiCi0jaW5jbHVkZSA8RWluYS5oPgogI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4K ICNpbmNsdWRlIDx3dGYvVW51c2VkUGFyYW0uaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5n Lmg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NlY3VyaXR5X29yaWdp bi5oIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZWN1cml0eV9vcmlnaW4uaAppbmRleCA2 ZTA0YzkyMWJiZmNhYzM1NDc1MGFmYmZmMTk5MWFjMTI3YmJmNjIyLi45OTk2OTcyZDcxYjU2M2Fi NDJhYjY0NmEwNDlhYTkyN2JjOTBlZWZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9l d2svZXdrX3NlY3VyaXR5X29yaWdpbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tf c2VjdXJpdHlfb3JpZ2luLmgKQEAgLTMzLDcgKzMzLDcgQEAKICNpZm5kZWYgZXdrX3NlY3VyaXR5 X29yaWdpbl9oCiAjZGVmaW5lIGV3a19zZWN1cml0eV9vcmlnaW5faAogCi0jaW5jbHVkZSA8RXZh cy5oPgorI2luY2x1ZGUgPEVpbmEuaD4KIAogI2lmZGVmIF9fY3BsdXNwbHVzCiBleHRlcm4gIkMi IHsK 153640 2012-07-20 19:07:04 -0700 2012-07-20 20:58:42 -0700 Patch bug-91914-20120721110659.patch text/plain 1943 kihong.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMjgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggM2U3YjU0Nzkz ZTk5MjZkYWQxODg5ODNlMzRlZDM2NjM0NjU3MDVkYi4uMTk3ZmY3ZTcxZjE3ZmM2NWU5MjhiZjk2 OThlY2I5N2FiMDY2OTFkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEy LTA3LTIwICBLaWhvbmcgS3dvbiAgPGtpaG9uZy5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAg IFtFRkxdIFJlbW92ZSB1bnVzZWQgaGVhZGVycyBmcm9tIGV3a19zZWN1cml0eV9vcmlnaW4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxOTE0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgYXJlIHNv bWUgdW51c2VkIGhlYWRlciBpbiB0aGUgZXdrX3NlY3VyaXR5X29yaWdpbi5oL2NwcAorICAgICAg ICBXZSBuZWVkIHRvIHJlbW92ZSB0aGVtLgorCisgICAgICAgICogZXdrL2V3a19zZWN1cml0eV9v cmlnaW4uY3BwOgorICAgICAgICAqIGV3ay9ld2tfc2VjdXJpdHlfb3JpZ2luLmg6CisKIDIwMTIt MDctMjAgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAog ICAgICAgICBbRUZMXSBQcm94eSBjb25maWd1cmF0aW9uIHNob3VsZCBob25vciB0aGUgbm9fcHJv eHkgZW52aXJvbm1lbnQgdmFyaWFibGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3 ay9ld2tfc2VjdXJpdHlfb3JpZ2luLmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2Vj dXJpdHlfb3JpZ2luLmNwcAppbmRleCBkN2UzMDRjMWFjNDk3MzcxNjFkMWM2MDI4YTlmY2I0NDAx NzQwMmZkLi4xYjY4ODRlOGMxOTdmZTg2OGViZmJlMDc2MGY0NjY3OGNjNzA0NTNjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NlY3VyaXR5X29yaWdpbi5jcHAKKysrIGIv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a19zZWN1cml0eV9vcmlnaW4uY3BwCkBAIC0yNCwxMSAr MjQsOSBAQAogI2luY2x1ZGUgIkFwcGxpY2F0aW9uQ2FjaGVTdG9yYWdlLmgiCiAjaW5jbHVkZSAi RGF0YWJhc2VUcmFja2VyLmgiCiAjaW5jbHVkZSAiU2VjdXJpdHlPcmlnaW4uaCIKLSNpbmNsdWRl ICJld2tfcHJpdmF0ZS5oIgogI2luY2x1ZGUgImV3a19zZWN1cml0eV9vcmlnaW5fcHJpdmF0ZS5o IgogI2luY2x1ZGUgImV3a193ZWJfZGF0YWJhc2UuaCIKICNpbmNsdWRlICJld2tfd2ViX2RhdGFi YXNlX3ByaXZhdGUuaCIKLSNpbmNsdWRlIDxFaW5hLmg+CiAjaW5jbHVkZSA8d3RmL1JlZlB0ci5o PgogI2luY2x1ZGUgPHd0Zi9VbnVzZWRQYXJhbS5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJp bmcuaD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfc2VjdXJpdHlfb3Jp Z2luLmggYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3NlY3VyaXR5X29yaWdpbi5oCmluZGV4 IDZlMDRjOTIxYmJmY2FjMzU0NzUwYWZiZmYxOTkxYWMxMjdiYmY2MjIuLjk5OTY5NzJkNzFiNTYz YWI0MmFiNjQ2YTA0OWFhOTI3YmM5MGVlZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfc2VjdXJpdHlfb3JpZ2luLmgKKysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a19zZWN1cml0eV9vcmlnaW4uaApAQCAtMzMsNyArMzMsNyBAQAogI2lmbmRlZiBld2tfc2VjdXJp dHlfb3JpZ2luX2gKICNkZWZpbmUgZXdrX3NlY3VyaXR5X29yaWdpbl9oCiAKLSNpbmNsdWRlIDxF dmFzLmg+CisjaW5jbHVkZSA8RWluYS5oPgogCiAjaWZkZWYgX19jcGx1c3BsdXMKIGV4dGVybiAi QyIgewo=