91913 2012-07-20 17:53:07 -0700 If select element is off screen horizontally, menu is either inappropriately resized or positioned offscreen 2012-07-23 17:48:27 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 roger_fong roger_fong thorton webkit.review.bot oldest_to_newest 675119 0 roger_fong 2012-07-20 17:53:07 -0700 If the select element is positioned off the edge of the screen to the left, the menu is resized. It should not be resized, just shifted to remain on the screen. If the select element is positioned off the edge of the screen to the right, the menu goes off screen instead of being shifted over to appear on screen. 675120 1 roger_fong 2012-07-20 17:54:40 -0700 Radar: <rdar://problem/7611229> 675930 2 153847 roger_fong 2012-07-23 13:03:10 -0700 Created attachment 153847 Patch to fix Windows menu list positioning code. 675935 3 153847 thorton 2012-07-23 13:11:41 -0700 Comment on attachment 153847 Patch to fix Windows menu list positioning code. View in context: https://bugs.webkit.org/attachment.cgi?id=153847&action=review > ManualTests/win/select-menu-off-screen.html:8 > +<select id = "left-select-over" style="margin-left:-50px;"> You have extra space around the = > ManualTests/win/select-menu-off-screen.html:12 > + <option value="volvo">Volvo</option> > + <option value="saab">Saab</option> > + <option value="mercedes">Mercedes</option> > + <option value="audi">Audi</option> I wonder if we should use something more neutral than car manufacturers :) > ManualTests/win/select-menu-off-screen.html:14 > +<select id = "right-select-over" style="float:right; margin-right:-50px;"> You have extra space around the = > Source/WebCore/platform/win/PopupMenuWin.cpp:-382 > - if (popupRect.x() < screen.x()) { > - popupRect.setWidth(popupRect.width() - (screen.x() - popupRect.x())); What happens now if the popup is super wide? 675936 4 thorton 2012-07-23 13:12:16 -0700 You've got that executable flag set again. I wonder if there's something you can do in your svn config to stop that from happening. 675944 5 153851 roger_fong 2012-07-23 13:23:35 -0700 Created attachment 153851 Remove executable property from test file 675948 6 webkit.review.bot 2012-07-23 13:26:38 -0700 Attachment 153851 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'ManualTests/win/select-menu-..." exit_code: 1 ManualTests/win/select-menu-off-screen.html:1: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] Suppressing further [whitespace/carriage_return] reports for this file. Total errors found: 21 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 675974 7 roger_fong 2012-07-23 13:53:09 -0700 If the width is too large it just flows off screen according to whichever case it first hits. I guess however that I may as well adjust the width. It should probably also always show the beginning of the menu entries. 676095 8 153879 roger_fong 2012-07-23 15:40:56 -0700 Created attachment 153879 Correction to make sure that if width is larger than screen width, left side of menus will always appear. Changed test file to use more generic menu items. 676243 9 153879 webkit.review.bot 2012-07-23 17:48:24 -0700 Comment on attachment 153879 Correction to make sure that if width is larger than screen width, left side of menus will always appear. Changed test file to use more generic menu items. Clearing flags on attachment: 153879 Committed r123411: <http://trac.webkit.org/changeset/123411> 676244 10 webkit.review.bot 2012-07-23 17:48:27 -0700 All reviewed patches have been landed. Closing bug. 153847 2012-07-23 13:03:10 -0700 2012-07-23 13:23:35 -0700 Patch to fix Windows menu list positioning code. 91913_patch.txt text/plain 4442 roger_fong SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEyMzM2 MykKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3 LTIzICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgSWYgc2Vs ZWN0IGVsZW1lbnQgaW4gV2luZG93cyBpcyBvZmYgc2NyZWVuIGhvcml6b250YWxseSwgCisgICAg ICAgIG1lbnUgaXMgZWl0aGVyIGluYXBwcm9wcmlhdGVseSByZXNpemVkIG9yIHBvc2l0aW9uZWQg b2Zmc2NyZWVuLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTE5MTMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc2MTEyMjk+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgbWFudWFsIHRlc3QgdG8g dmVyaWZ5IHRoYXQgcG9wdXAgbWVudXMgcmVuZGVyIGluIHRoZSBjb3JyZWN0IHBsYWNlLgorICAg ICAgICAKKyAgICAgICAgKiBNYW51YWxUZXN0cy93aW4vc2VsZWN0LW1lbnUtb2ZmLXNjcmVlbi5o dG1sOiBBZGRlZC4KKwogMjAxMi0wNy0yMyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFw cGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgc3RpY2t5IHBvc2l0aW9uaW5nCkluZGV4OiBN YW51YWxUZXN0cy93aW4vc2VsZWN0LW1lbnUtb2ZmLXNjcmVlbi5odG1sCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IE1hbnVhbFRlc3RzL3dpbi9zZWxlY3QtbWVudS1vZmYtc2NyZWVuLmh0bWwJKHJldmlzaW9uIDAp CisrKyBNYW51YWxUZXN0cy93aW4vc2VsZWN0LW1lbnUtb2ZmLXNjcmVlbi5odG1sCSh3b3JraW5n IGNvcHkpCkBAIC0wLDAgKzEsMjIgQEAKKzxodG1sPg0KKzxib2R5Pg0KKzxvbD4NCis8bGk+TWF4 aW1pemUgd2luZG93LjwvbGk+DQorPGxpPkNsaWNrIG9uIGxlZnQgbWVudSBhbmQgbWFrZSBzdXJl IHdob2xlIG1lbnUgKHlvdSBzaG91bGQgc2VlIGFsbCBvZiAnTWVyY2VkZXMnKSBhcHBlYXJzIG9u IHNjcmVlbiBhZ2FpbnN0IHRoZSBsZWZ0IGVkZ2Ugb2YgdGhlIHNjcmVlbi48L2xpPg0KKzxsaT5D bGljayBvbiByaWdodCBtZW51YW5kIG1ha2Ugc3VyZSB3aG9sZSBtZW51ICh5b3Ugc2hvdWxkIHNl ZSBhbGwgb2YgJ01lcmNlZGVzJykgYXBwZWFycyBvbiBzY3JlZW4gYWdhaW5zdCB0aGUgcmlnaHQg ZWRnZSBvZiB0aGUgc2NyZWVuLjwvbGk+DQorPC9vbD4NCis8c2VsZWN0IGlkID0gImxlZnQtc2Vs ZWN0LW92ZXIiIHN0eWxlPSJtYXJnaW4tbGVmdDotNTBweDsiPg0KKyAgPG9wdGlvbiB2YWx1ZT0i dm9sdm8iPlZvbHZvPC9vcHRpb24+DQorICA8b3B0aW9uIHZhbHVlPSJzYWFiIj5TYWFiPC9vcHRp b24+DQorICA8b3B0aW9uIHZhbHVlPSJtZXJjZWRlcyI+TWVyY2VkZXM8L29wdGlvbj4NCisgIDxv cHRpb24gdmFsdWU9ImF1ZGkiPkF1ZGk8L29wdGlvbj4NCis8L3NlbGVjdD4NCis8c2VsZWN0IGlk ID0gInJpZ2h0LXNlbGVjdC1vdmVyIiBzdHlsZT0iZmxvYXQ6cmlnaHQ7IG1hcmdpbi1yaWdodDot NTBweDsiPg0KKyAgPG9wdGlvbiB2YWx1ZT0idm9sdm8iPlZvbHZvPC9vcHRpb24+DQorICA8b3B0 aW9uIHZhbHVlPSJzYWFiIj5TYWFiPC9vcHRpb24+DQorICA8b3B0aW9uIHZhbHVlPSJtZXJjZWRl cyI+TWVyY2VkZXM8L29wdGlvbj4NCisgIDxvcHRpb24gdmFsdWU9ImF1ZGkiPkF1ZGk8L29wdGlv bj4NCis8L3NlbGVjdD4NCis8L2JvZHk+DQorPGh0bWw+DQorDQpJbmRleDogTWFudWFsVGVzdHMv d2luL3NlbGVjdC1tZW51LW9mZi1zY3JlZW4uaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBNYW51YWxUZXN0 cy93aW4vc2VsZWN0LW1lbnUtb2ZmLXNjcmVlbi5odG1sCShyZXZpc2lvbiAwKQorKysgTWFudWFs VGVzdHMvd2luL3NlbGVjdC1tZW51LW9mZi1zY3JlZW4uaHRtbAkod29ya2luZyBjb3B5KQoKUHJv cGVydHkgY2hhbmdlcyBvbjogTWFudWFsVGVzdHMvd2luL3NlbGVjdC1tZW51LW9mZi1zY3JlZW4u aHRtbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkFkZGVkOiBzdm46ZXhlY3V0YWJsZQojIyAtMCwwICsxICMjCisqClwg Tm8gbmV3bGluZSBhdCBlbmQgb2YgcHJvcGVydHkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEy MzM2MykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI1IEBACisyMDEyLTA3LTIzICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+ CisKKyAgICAgICAgT24gV2luZG93cywgaWYgc2VsZWN0IGVsZW1lbnQgaXMgb2ZmIHNjcmVlbiBo b3Jpem9udGFsbHksIAorICAgICAgICBtZW51IGlzIGVpdGhlciBpbmFwcHJvcHJpYXRlbHkgcmVz aXplZCBvciBwb3NpdGlvbmVkIG9mZnNjcmVlbi4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTkxOTEzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NjEx MjI5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElm IHRoZSBzZWxlY3QgZWxlbWVudCBpcyBwb3NpdGlvbmVkIG9mZiB0aGUgZWRnZSBvZiB0aGUgc2Ny ZWVuIHRvIHRoZSBsZWZ0LCAKKyAgICAgICAgdGhlIG1lbnUgaXMgcmVzaXplZC4gSXQgc2hvdWxk IG5vdCBiZSByZXNpemVkLCBqdXN0IHNoaWZ0ZWQgdG8gcmVtYWluIG9uIHRoZSBzY3JlZW4uCisg ICAgICAgIElmIHRoZSBzZWxlY3QgZWxlbWVudCBpcyBwb3NpdGlvbmVkIG9mZiB0aGUgZWRnZSBv ZiB0aGUgc2NyZWVuIHRvIHRoZSByaWdodCwgCisgICAgICAgIHRoZSBtZW51IGdvZXMgb2ZmIHNj cmVlbiBpbnN0ZWFkIG9mIGJlaW5nIHNoaWZ0ZWQgb3ZlciB0byBhcHBlYXIgb24gc2NyZWVuLgor ICAgICAgICBUaGlzIHByb2JsZW0gb25seSBvY2N1cnMgb24gV2luZG93cy4KKyAgICAgICAgCisg ICAgICAgIFRlc3Q6IE1hbnVhbFRlc3RzL3dpbi9zZWxlY3QtbWVudS1vZmYtc2NyZWVuLmh0bWwK KworICAgICAgICAqIHBsYXRmb3JtL3dpbi9Qb3B1cE1lbnVXaW4uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UG9wdXBNZW51V2luOjpjYWxjdWxhdGVQb3NpdGlvbkFuZFNpemUpOgorICAgICAgICBN b2RpZmllZCBmaW5hbCBob3Jpem9udGFsIHBvc2l0aW9uIGNhbGN1bGF0aW9uIGNvZGUgdG8gcG9z aXRpb24KKyAgICAgICAgcG9wdXAgbWVudSBvbiBzY3JlZW4gaWYgaXQgd291bGQgb3RoZXJ3aXNl IGdvIG9mZi4KKyAgICAgICAgCiAyMDEyLTA3LTIzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJr aXQub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjEyMzI4MSk6IGNoaWxkTm9kZXMgc29tZXRp bWVzIHJldHVybnMgd3Jvbmcgbm9kZXMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dp bi9Qb3B1cE1lbnVXaW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L3dpbi9Qb3B1cE1lbnVXaW4uY3BwCShyZXZpc2lvbiAxMjMyNjcpCisrKyBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS93aW4vUG9wdXBNZW51V2luLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzc4LDEw ICszNzgsMTEgQEAgdm9pZCBQb3B1cE1lbnVXaW46OmNhbGN1bGF0ZVBvc2l0aW9uQW5kUwogICAg IH0KIAogICAgIC8vIENoZWNrIHRoYXQgd2UgZG9uJ3QgZ28gb2ZmIHRoZSBzY3JlZW4gaG9yaXpv bnRhbGx5Ci0gICAgaWYgKHBvcHVwUmVjdC54KCkgPCBzY3JlZW4ueCgpKSB7Ci0gICAgICAgIHBv cHVwUmVjdC5zZXRXaWR0aChwb3B1cFJlY3Qud2lkdGgoKSAtIChzY3JlZW4ueCgpIC0gcG9wdXBS ZWN0LngoKSkpOworICAgIGlmIChwb3B1cFJlY3QueCgpIDwgc2NyZWVuLngoKSkKICAgICAgICAg cG9wdXBSZWN0LnNldFgoc2NyZWVuLngoKSk7Ci0gICAgfQorICAgIGVsc2UgaWYgKHBvcHVwUmVj dC54KCkgKyBwb3B1cFJlY3Qud2lkdGgoKSA+IHNjcmVlbi53aWR0aCgpKQorICAgICAgICBwb3B1 cFJlY3Quc2V0WChzY3JlZW4ueCgpICsgc2NyZWVuLndpZHRoKCkgLSBwb3B1cFJlY3Qud2lkdGgo KSk7CisKICAgICBtX3dpbmRvd1JlY3QgPSBwb3B1cFJlY3Q7CiAgICAgcmV0dXJuOwogfQo= 153851 2012-07-23 13:23:35 -0700 2012-07-23 15:40:56 -0700 Remove executable property from test file 91913_patch.txt text/plain 3991 roger_fong SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEyMzM2 OCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3 LTIzICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgSWYgc2Vs ZWN0IGVsZW1lbnQgaW4gV2luZG93cyBpcyBvZmYgc2NyZWVuIGhvcml6b250YWxseSwgCisgICAg ICAgIG1lbnUgaXMgZWl0aGVyIGluYXBwcm9wcmlhdGVseSByZXNpemVkIG9yIHBvc2l0aW9uZWQg b2Zmc2NyZWVuLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTE5MTMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc2MTEyMjk+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgbWFudWFsIHRlc3QgdG8g dmVyaWZ5IHRoYXQgcG9wdXAgbWVudXMgcmVuZGVyIGluIHRoZSBjb3JyZWN0IHBsYWNlLgorICAg ICAgICAKKyAgICAgICAgKiBNYW51YWxUZXN0cy93aW4vc2VsZWN0LW1lbnUtb2ZmLXNjcmVlbi5o dG1sOiBBZGRlZC4KKwogMjAxMi0wNy0yMyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFw cGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgc3RpY2t5IHBvc2l0aW9uaW5nCkluZGV4OiBN YW51YWxUZXN0cy93aW4vc2VsZWN0LW1lbnUtb2ZmLXNjcmVlbi5odG1sCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IE1hbnVhbFRlc3RzL3dpbi9zZWxlY3QtbWVudS1vZmYtc2NyZWVuLmh0bWwJKHJldmlzaW9uIDAp CisrKyBNYW51YWxUZXN0cy93aW4vc2VsZWN0LW1lbnUtb2ZmLXNjcmVlbi5odG1sCSh3b3JraW5n IGNvcHkpCkBAIC0wLDAgKzEsMjEgQEAKKzxodG1sPg0KKzxib2R5Pg0KKzxvbD4NCis8bGk+TWF4 aW1pemUgd2luZG93LjwvbGk+DQorPGxpPkNsaWNrIG9uIGxlZnQgbWVudSBhbmQgbWFrZSBzdXJl IHdob2xlIG1lbnUgKHlvdSBzaG91bGQgc2VlIGFsbCBvZiAnTWVyY2VkZXMnKSBhcHBlYXJzIG9u IHNjcmVlbiBhZ2FpbnN0IHRoZSBsZWZ0IGVkZ2Ugb2YgdGhlIHNjcmVlbi48L2xpPg0KKzxsaT5D bGljayBvbiByaWdodCBtZW51YW5kIG1ha2Ugc3VyZSB3aG9sZSBtZW51ICh5b3Ugc2hvdWxkIHNl ZSBhbGwgb2YgJ01lcmNlZGVzJykgYXBwZWFycyBvbiBzY3JlZW4gYWdhaW5zdCB0aGUgcmlnaHQg ZWRnZSBvZiB0aGUgc2NyZWVuLjwvbGk+DQorPC9vbD4NCis8c2VsZWN0IGlkID0gImxlZnQtc2Vs ZWN0LW92ZXIiIHN0eWxlPSJtYXJnaW4tbGVmdDotNTBweDsiPg0KKyAgPG9wdGlvbiB2YWx1ZT0i dm9sdm8iPlZvbHZvPC9vcHRpb24+DQorICA8b3B0aW9uIHZhbHVlPSJzYWFiIj5TYWFiPC9vcHRp b24+DQorICA8b3B0aW9uIHZhbHVlPSJtZXJjZWRlcyI+TWVyY2VkZXM8L29wdGlvbj4NCisgIDxv cHRpb24gdmFsdWU9ImF1ZGkiPkF1ZGk8L29wdGlvbj4NCis8L3NlbGVjdD4NCis8c2VsZWN0IGlk ID0gInJpZ2h0LXNlbGVjdC1vdmVyIiBzdHlsZT0iZmxvYXQ6cmlnaHQ7IG1hcmdpbi1yaWdodDot NTBweDsiPg0KKyAgPG9wdGlvbiB2YWx1ZT0idm9sdm8iPlZvbHZvPC9vcHRpb24+DQorICA8b3B0 aW9uIHZhbHVlPSJzYWFiIj5TYWFiPC9vcHRpb24+DQorICA8b3B0aW9uIHZhbHVlPSJtZXJjZWRl cyI+TWVyY2VkZXM8L29wdGlvbj4NCisgIDxvcHRpb24gdmFsdWU9ImF1ZGkiPkF1ZGk8L29wdGlv bj4NCis8L3NlbGVjdD4NCis8L2JvZHk+DQorPGh0bWw+DQpJbmRleDogU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNp b24gMTIzMzY4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjUgQEAKKzIwMTItMDctMjMgIFJvZ2VyIEZvbmcgIDxyb2dlcl9mb25nQGFwcGxl LmNvbT4KKworICAgICAgICBPbiBXaW5kb3dzLCBpZiBzZWxlY3QgZWxlbWVudCBpcyBvZmYgc2Ny ZWVuIGhvcml6b250YWxseSwgCisgICAgICAgIG1lbnUgaXMgZWl0aGVyIGluYXBwcm9wcmlhdGVs eSByZXNpemVkIG9yIHBvc2l0aW9uZWQgb2Zmc2NyZWVuLgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE5MTMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt Lzc2MTEyMjk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgSWYgdGhlIHNlbGVjdCBlbGVtZW50IGlzIHBvc2l0aW9uZWQgb2ZmIHRoZSBlZGdlIG9mIHRo ZSBzY3JlZW4gdG8gdGhlIGxlZnQsIAorICAgICAgICB0aGUgbWVudSBpcyByZXNpemVkLiBJdCBz aG91bGQgbm90IGJlIHJlc2l6ZWQsIGp1c3Qgc2hpZnRlZCB0byByZW1haW4gb24gdGhlIHNjcmVl bi4KKyAgICAgICAgSWYgdGhlIHNlbGVjdCBlbGVtZW50IGlzIHBvc2l0aW9uZWQgb2ZmIHRoZSBl ZGdlIG9mIHRoZSBzY3JlZW4gdG8gdGhlIHJpZ2h0LCAKKyAgICAgICAgdGhlIG1lbnUgZ29lcyBv ZmYgc2NyZWVuIGluc3RlYWQgb2YgYmVpbmcgc2hpZnRlZCBvdmVyIHRvIGFwcGVhciBvbiBzY3Jl ZW4uCisgICAgICAgIFRoaXMgcHJvYmxlbSBvbmx5IG9jY3VycyBvbiBXaW5kb3dzLgorICAgICAg ICAKKyAgICAgICAgVGVzdDogTWFudWFsVGVzdHMvd2luL3NlbGVjdC1tZW51LW9mZi1zY3JlZW4u aHRtbAorCisgICAgICAgICogcGxhdGZvcm0vd2luL1BvcHVwTWVudVdpbi5jcHA6CisgICAgICAg IChXZWJDb3JlOjpQb3B1cE1lbnVXaW46OmNhbGN1bGF0ZVBvc2l0aW9uQW5kU2l6ZSk6CisgICAg ICAgIE1vZGlmaWVkIGZpbmFsIGhvcml6b250YWwgcG9zaXRpb24gY2FsY3VsYXRpb24gY29kZSB0 byBwb3NpdGlvbgorICAgICAgICBwb3B1cCBtZW51IG9uIHNjcmVlbiBpZiBpdCB3b3VsZCBvdGhl cndpc2UgZ28gb2ZmLgorICAgICAgICAKIDIwMTItMDctMjMgIFJ5b3N1a2UgTml3YSAgPHJuaXdh QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTIzMjgxKTogY2hpbGROb2RlcyBz b21ldGltZXMgcmV0dXJucyB3cm9uZyBub2RlcwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vd2luL1BvcHVwTWVudVdpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vd2luL1BvcHVwTWVudVdpbi5jcHAJKHJldmlzaW9uIDEyMzM2OCkKKysrIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3dpbi9Qb3B1cE1lbnVXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0z NzgsMTAgKzM3OCwxMSBAQCB2b2lkIFBvcHVwTWVudVdpbjo6Y2FsY3VsYXRlUG9zaXRpb25BbmRT CiAgICAgfQogCiAgICAgLy8gQ2hlY2sgdGhhdCB3ZSBkb24ndCBnbyBvZmYgdGhlIHNjcmVlbiBo b3Jpem9udGFsbHkKLSAgICBpZiAocG9wdXBSZWN0LngoKSA8IHNjcmVlbi54KCkpIHsKLSAgICAg ICAgcG9wdXBSZWN0LnNldFdpZHRoKHBvcHVwUmVjdC53aWR0aCgpIC0gKHNjcmVlbi54KCkgLSBw b3B1cFJlY3QueCgpKSk7CisgICAgaWYgKHBvcHVwUmVjdC54KCkgPCBzY3JlZW4ueCgpKQogICAg ICAgICBwb3B1cFJlY3Quc2V0WChzY3JlZW4ueCgpKTsKLSAgICB9CisgICAgZWxzZSBpZiAocG9w dXBSZWN0LngoKSArIHBvcHVwUmVjdC53aWR0aCgpID4gc2NyZWVuLndpZHRoKCkpCisgICAgICAg IHBvcHVwUmVjdC5zZXRYKHNjcmVlbi54KCkgKyBzY3JlZW4ud2lkdGgoKSAtIHBvcHVwUmVjdC53 aWR0aCgpKTsKKwogICAgIG1fd2luZG93UmVjdCA9IHBvcHVwUmVjdDsKICAgICByZXR1cm47CiB9 Cg== 153879 2012-07-23 15:40:56 -0700 2012-07-23 17:48:24 -0700 Correction to make sure that if width is larger than screen width, left side of menus will always appear. Changed test file to use more generic menu items. 91913_patch.txt text/plain 4065 roger_fong SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEyMzM2 OCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA3 LTIzICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgSWYgc2Vs ZWN0IGVsZW1lbnQgaW4gV2luZG93cyBpcyBvZmYgc2NyZWVuIGhvcml6b250YWxseSwgCisgICAg ICAgIG1lbnUgaXMgZWl0aGVyIGluYXBwcm9wcmlhdGVseSByZXNpemVkIG9yIHBvc2l0aW9uZWQg b2Zmc2NyZWVuLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9OTE5MTMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc2MTEyMjk+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgbWFudWFsIHRlc3QgdG8g dmVyaWZ5IHRoYXQgcG9wdXAgbWVudXMgcmVuZGVyIGluIHRoZSBjb3JyZWN0IHBsYWNlLgorICAg ICAgICAKKyAgICAgICAgKiBNYW51YWxUZXN0cy93aW4vc2VsZWN0LW1lbnUtb2ZmLXNjcmVlbi5o dG1sOiBBZGRlZC4KKwogMjAxMi0wNy0yMyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFw cGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgc3RpY2t5IHBvc2l0aW9uaW5nCkluZGV4OiBN YW51YWxUZXN0cy93aW4vc2VsZWN0LW1lbnUtb2ZmLXNjcmVlbi5odG1sCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IE1hbnVhbFRlc3RzL3dpbi9zZWxlY3QtbWVudS1vZmYtc2NyZWVuLmh0bWwJKHJldmlzaW9uIDAp CisrKyBNYW51YWxUZXN0cy93aW4vc2VsZWN0LW1lbnUtb2ZmLXNjcmVlbi5odG1sCSh3b3JraW5n IGNvcHkpCkBAIC0wLDAgKzEsMjIgQEAKKzxodG1sPgorPGJvZHk+CisgICAgPG9sPgorICAgIDxs aT5NYXhpbWl6ZSB3aW5kb3cuPC9saT4KKyAgICA8bGk+Q2xpY2sgb24gbGVmdCBtZW51IGFuZCBt YWtlIHN1cmUgd2hvbGUgbWVudSAoYWxsIG9mIHRoZSBlbnRyaWVzIHNob3VsZCBiZSBjb21wbGV0 ZWx5IHZpc2libGUpIGFwcGVhcnMgb24gc2NyZWVuIGFnYWluc3QgdGhlIGxlZnQgZWRnZSBvZiB0 aGUgc2NyZWVuLjwvbGk+CisgICAgPGxpPkNsaWNrIG9uIHJpZ2h0IG1lbnVhbmQgbWFrZSBzdXJl IHdob2xlIG1lbnUgKGFsbCBvZiB0aGUgZW50cmllcyBzaG91bGQgYmUgY29tcGxldGVseSB2aXNp YmxlKSBhcHBlYXJzIG9uIHNjcmVlbiBhZ2FpbnN0IHRoZSByaWdodCBlZGdlIG9mIHRoZSBzY3Jl ZW4uPC9saT4KKyAgICA8L29sPgorICAgIDxzZWxlY3QgaWQ9ImxlZnQtc2VsZWN0LW92ZXIiIHN0 eWxlPSJtYXJnaW4tbGVmdDotNTBweDsiPgorICAgICAgPG9wdGlvbiB2YWx1ZT0iZmlyc3QiPkZp cnN0PC9vcHRpb24+CisgICAgICA8b3B0aW9uIHZhbHVlPSJzZWNvbmQiPlNlY29uZDwvb3B0aW9u PgorICAgICAgPG9wdGlvbiB2YWx1ZT0idGhpcmQiPlRoaXJkPC9vcHRpb24+CisgICAgICA8b3B0 aW9uIHZhbHVlPSJmb3VydGgiPkZvdXJ0aDwvb3B0aW9uPgorICAgIDwvc2VsZWN0PgorICAgIDxz ZWxlY3QgaWQ9InJpZ2h0LXNlbGVjdC1vdmVyIiBzdHlsZT0iZmxvYXQ6cmlnaHQ7IG1hcmdpbi1y aWdodDotNTBweDsiPgorICAgICAgPG9wdGlvbiB2YWx1ZT0iZmlyc3QiPkZpcnN0PC9vcHRpb24+ CisgICAgICA8b3B0aW9uIHZhbHVlPSJzZWNvbmQiPlNlY29uZDwvb3B0aW9uPgorICAgICAgPG9w dGlvbiB2YWx1ZT0idGhpcmQiPlRoaXJkPC9vcHRpb24+CisgICAgICA8b3B0aW9uIHZhbHVlPSJm b3VydGgiPkZvdXJ0aDwvb3B0aW9uPgorICAgIDwvc2VsZWN0PgorPC9ib2R5PgorPGh0bWw+CisK SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMzM2OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA3LTIzICBSb2dlciBG b25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+CisKKyAgICAgICAgT24gV2luZG93cywgaWYgc2Vs ZWN0IGVsZW1lbnQgaXMgb2ZmIHNjcmVlbiBob3Jpem9udGFsbHksIAorICAgICAgICBtZW51IGlz IGVpdGhlciBpbmFwcHJvcHJpYXRlbHkgcmVzaXplZCBvciBwb3NpdGlvbmVkIG9mZnNjcmVlbi4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxOTEzCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NjExMjI5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIHRoZSBzZWxlY3QgZWxlbWVudCBpcyBwb3NpdGlv bmVkIG9mZiB0aGUgZWRnZSBvZiB0aGUgc2NyZWVuIHRvIHRoZSBsZWZ0LCAKKyAgICAgICAgdGhl IG1lbnUgaXMgcmVzaXplZC4gSXQgc2hvdWxkIG5vdCBiZSByZXNpemVkLCBqdXN0IHNoaWZ0ZWQg dG8gcmVtYWluIG9uIHRoZSBzY3JlZW4uCisgICAgICAgIElmIHRoZSBzZWxlY3QgZWxlbWVudCBp cyBwb3NpdGlvbmVkIG9mZiB0aGUgZWRnZSBvZiB0aGUgc2NyZWVuIHRvIHRoZSByaWdodCwgCisg ICAgICAgIHRoZSBtZW51IGdvZXMgb2ZmIHNjcmVlbiBpbnN0ZWFkIG9mIGJlaW5nIHNoaWZ0ZWQg b3ZlciB0byBhcHBlYXIgb24gc2NyZWVuLgorICAgICAgICBUaGlzIHByb2JsZW0gb25seSBvY2N1 cnMgb24gV2luZG93cy4KKyAgICAgICAgCisgICAgICAgIFRlc3Q6IE1hbnVhbFRlc3RzL3dpbi9z ZWxlY3QtbWVudS1vZmYtc2NyZWVuLmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL3dpbi9Qb3B1 cE1lbnVXaW4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6UG9wdXBNZW51V2luOjpjYWxjdWxhdGVQ b3NpdGlvbkFuZFNpemUpOgorICAgICAgICBNb2RpZmllZCBmaW5hbCBob3Jpem9udGFsIHBvc2l0 aW9uIGNhbGN1bGF0aW9uIGNvZGUgdG8gcG9zaXRpb24KKyAgICAgICAgcG9wdXAgbWVudSBvbiBz Y3JlZW4gaWYgaXQgd291bGQgb3RoZXJ3aXNlIGdvIG9mZi4KKyAgICAgICAgCiAyMDEyLTA3LTIz ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04o cjEyMzI4MSk6IGNoaWxkTm9kZXMgc29tZXRpbWVzIHJldHVybnMgd3Jvbmcgbm9kZXMKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9Qb3B1cE1lbnVXaW4uY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3dpbi9Qb3B1cE1lbnVXaW4uY3BwCShyZXZpc2lv biAxMjMzNjgpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS93aW4vUG9wdXBNZW51V2luLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMzc4LDEwICszNzgsMTEgQEAgdm9pZCBQb3B1cE1lbnVXaW46 OmNhbGN1bGF0ZVBvc2l0aW9uQW5kUwogICAgIH0KIAogICAgIC8vIENoZWNrIHRoYXQgd2UgZG9u J3QgZ28gb2ZmIHRoZSBzY3JlZW4gaG9yaXpvbnRhbGx5Ci0gICAgaWYgKHBvcHVwUmVjdC54KCkg PCBzY3JlZW4ueCgpKSB7Ci0gICAgICAgIHBvcHVwUmVjdC5zZXRXaWR0aChwb3B1cFJlY3Qud2lk dGgoKSAtIChzY3JlZW4ueCgpIC0gcG9wdXBSZWN0LngoKSkpOworICAgIGlmIChwb3B1cFJlY3Qu eCgpICsgcG9wdXBSZWN0LndpZHRoKCkgPiBzY3JlZW4ud2lkdGgoKSkKKyAgICAgICAgcG9wdXBS ZWN0LnNldFgoc2NyZWVuLngoKSArIHNjcmVlbi53aWR0aCgpIC0gcG9wdXBSZWN0LndpZHRoKCkp OworICAgIGlmIChwb3B1cFJlY3QueCgpIDwgc2NyZWVuLngoKSkKICAgICAgICAgcG9wdXBSZWN0 LnNldFgoc2NyZWVuLngoKSk7Ci0gICAgfQorCiAgICAgbV93aW5kb3dSZWN0ID0gcG9wdXBSZWN0 OwogICAgIHJldHVybjsKIH0K