91888 2012-07-20 11:58:27 -0700 [Qt] WebViewLoadFavIcon::test_favIconLoad() fails 2012-08-10 09:30:42 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 70236 1 rafael.lobo rafael.lobo cmarcelo menard ossy webkit.review.bot zoltan oldest_to_newest 674812 0 rafael.lobo 2012-07-20 11:58:27 -0700 [Qt] WebViewLoadFavIcon::test_favIconLoad() fails 674813 1 153554 rafael.lobo 2012-07-20 11:59:58 -0700 Created attachment 153554 Patch 674832 2 153554 cmarcelo 2012-07-20 12:21:08 -0700 Comment on attachment 153554 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153554&action=review Looks good to me. But I have a question :-) > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml:40 > verify(webView.waitForLoadSucceeded()) > + spy.wait() Do we even need to webView.waitForLoadSucceeded here? > Source/WebKit2/UIProcess/API/qt/tests/qmltests/WebView/tst_favIconLoad.qml:51 > verify(webView.waitForLoadSucceeded()) > + spy.wait() And here. 682427 3 155374 rafael.lobo 2012-07-30 15:03:24 -0700 Created attachment 155374 Patch 682431 4 rafael.lobo 2012-07-30 15:05:07 -0700 Makes sense. Unfortunately the bug is no longer showing up on my machine because it's now faster and it seems it's neither showing up on buildbot. But for me it's clear that there's a problem there, so I'm all for upstreaming this patch. :-) 692608 5 155374 webkit.review.bot 2012-08-10 09:30:39 -0700 Comment on attachment 155374 Patch Clearing flags on attachment: 155374 Committed r125291: <http://trac.webkit.org/changeset/125291> 692609 6 webkit.review.bot 2012-08-10 09:30:42 -0700 All reviewed patches have been landed. Closing bug. 153554 2012-07-20 11:59:58 -0700 2012-07-30 15:03:19 -0700 Patch bug-91888-20120720155954.patch text/plain 1952 rafael.lobo U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODY0YTk3YjYzZTU0Mzc4 NDBiZGMyMjZhMzc2MTRiZjZmZDVhNTgxNy4uY2Q4MjQ5YTcxNDc0ZjFjMzBmNTBlMTE4Y2ZkMTdk MGIyZjI4MjFhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA3LTIwICBSYWZh ZWwgQnJhbmRhbyAgPHJhZmFlbC5sb2JvQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW1F0XSBX ZWJWaWV3TG9hZEZhdkljb246OnRlc3RfZmF2SWNvbkxvYWQoKSBmYWlscworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE4ODgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvdGVz dHMvcW1sdGVzdHMvV2ViVmlldy90c3RfZmF2SWNvbkxvYWQucW1sOgorICAgICAgICBXZSBzaG91 bGQgd2FpdCBmb3IgaWNvbkNoYW5nZWQgc2lnbmFsIGluc3RlYWQgb2YgbG9hZEZpbmlzaGVkLAor ICAgICAgICB0aGVyZSB3YXMgbm8gZ3VhcmFudHRlIHRoYXQgYXQgdGhhdCBwb2ludCB3ZSB3b3Vs ZCBnZXQgaXQgYWxyZWFkeS4KKwogMjAxMi0wNy0yMCAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlz dG9waGUuZHVtZXpAaW50ZWwuY29tPgogCiAgICAgICAgIFtFRkxdIFByb3h5IGNvbmZpZ3VyYXRp b24gc2hvdWxkIGhvbm9yIHRoZSBub19wcm94eSBlbnZpcm9ubWVudCB2YXJpYWJsZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9XZWJW aWV3L3RzdF9mYXZJY29uTG9hZC5xbWwgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X2Zhdkljb25Mb2FkLnFtbAppbmRleCBmNmVkNGIy NjEwMDAwOGE4ZDJiOWU1ZDk1NTliN2U4MjA2NDM2ODM4Li43NjA0ZWQ0ZWI5YzFmZTdkMDU2ZThj MDkwZTI2OTFlYzc1YmVlYmVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0X2Zhdkljb25Mb2FkLnFtbAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3Rlc3RzL3FtbHRlc3RzL1dlYlZpZXcvdHN0 X2Zhdkljb25Mb2FkLnFtbApAQCAtMzcsNiArMzcsNyBAQCBUZXN0V2ViVmlldyB7CiAgICAgICAg ICAgICB2YXIgdXJsID0gUXQucmVzb2x2ZWRVcmwoIi4uL2NvbW1vbi9mYXZpY29uLmh0bWwiKQog ICAgICAgICAgICAgd2ViVmlldy51cmwgPSB1cmwKICAgICAgICAgICAgIHZlcmlmeSh3ZWJWaWV3 LndhaXRGb3JMb2FkU3VjY2VlZGVkKCkpCisgICAgICAgICAgICBzcHkud2FpdCgpCiAgICAgICAg ICAgICBjb21wYXJlKHNweS5jb3VudCwgMSkKICAgICAgICAgICAgIGNvbXBhcmUoZmF2aWNvbi53 aWR0aCwgNDgpCiAgICAgICAgICAgICBjb21wYXJlKGZhdmljb24uaGVpZ2h0LCA0OCkKQEAgLTQ3 LDYgKzQ4LDcgQEAgVGVzdFdlYlZpZXcgewogICAgICAgICAgICAgdmFyIHVybCA9IFF0LnJlc29s dmVkVXJsKCIuLi9jb21tb24vZmF2aWNvbjIuaHRtbD9mYXZpY29uPWxvYWQgc2hvdWxkIHdvcmsg d2l0aCN3aGl0ZXNwYWNlISIpCiAgICAgICAgICAgICB3ZWJWaWV3LnVybCA9IHVybAogICAgICAg ICAgICAgdmVyaWZ5KHdlYlZpZXcud2FpdEZvckxvYWRTdWNjZWVkZWQoKSkKKyAgICAgICAgICAg IHNweS53YWl0KCkKICAgICAgICAgICAgIGNvbXBhcmUoc3B5LmNvdW50LCAxKQogICAgICAgICAg ICAgY29tcGFyZShmYXZpY29uLndpZHRoLCAxNikKICAgICAgICAgICAgIGNvbXBhcmUoZmF2aWNv bi5oZWlnaHQsIDE2KQo= 155374 2012-07-30 15:03:24 -0700 2012-08-10 09:30:38 -0700 Patch bug-91888-20120730190458.patch text/plain 1990 rafael.lobo U3VidmVyc2lvbiBSZXZpc2lvbjogMTI0MDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMGZlN2Y3ZmQ2MjdhN2I4 MDViNDI5OWQ0NDUwY2ZlYTY1NGMwMzFiZS4uNWNjZTFiMGM0MmZmNWY1MmQxMDQxNTFhNjgzMmU1 MmIxOGJjOWQ4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA3LTMwICBSYWZh ZWwgQnJhbmRhbyAgPHJhZmFlbC5sb2JvQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgW1F0XSBX ZWJWaWV3TG9hZEZhdkljb246OnRlc3RfZmF2SWNvbkxvYWQoKSBmYWlscworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE4ODgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvdGVz dHMvcW1sdGVzdHMvV2ViVmlldy90c3RfZmF2SWNvbkxvYWQucW1sOgorICAgICAgICBXZSBzaG91 bGQgd2FpdCBmb3IgaWNvbkNoYW5nZWQgc2lnbmFsIGluc3RlYWQgb2YgbG9hZEZpbmlzaGVkLAor ICAgICAgICB0aGVyZSB3YXMgbm8gZ3VhcmFudGVlIHRoYXQgYXQgdGhhdCBwb2ludCB3ZSB3b3Vs ZCBnZXQgaXQgYWxyZWFkeS4KKwogMjAxMi0wNy0zMCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2 aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjEy Mzk2NiBhbmQgcjEyMzk2Ny4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9B UEkvcXQvdGVzdHMvcW1sdGVzdHMvV2ViVmlldy90c3RfZmF2SWNvbkxvYWQucW1sIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3L3RzdF9mYXZJ Y29uTG9hZC5xbWwKaW5kZXggZjZlZDRiMjYxMDAwMDhhOGQyYjllNWQ5NTU5YjdlODIwNjQzNjgz OC4uNmYwODU4Njk2N2ZmNzA5ZGRlNGM0MTQ2Y2M3OTU3ZWE4N2Q2Y2NmOCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3L3Rz dF9mYXZJY29uTG9hZC5xbWwKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC90 ZXN0cy9xbWx0ZXN0cy9XZWJWaWV3L3RzdF9mYXZJY29uTG9hZC5xbWwKQEAgLTM2LDcgKzM2LDcg QEAgVGVzdFdlYlZpZXcgewogICAgICAgICAgICAgY29tcGFyZShzcHkuY291bnQsIDApCiAgICAg ICAgICAgICB2YXIgdXJsID0gUXQucmVzb2x2ZWRVcmwoIi4uL2NvbW1vbi9mYXZpY29uLmh0bWwi KQogICAgICAgICAgICAgd2ViVmlldy51cmwgPSB1cmwKLSAgICAgICAgICAgIHZlcmlmeSh3ZWJW aWV3LndhaXRGb3JMb2FkU3VjY2VlZGVkKCkpCisgICAgICAgICAgICBzcHkud2FpdCgpCiAgICAg ICAgICAgICBjb21wYXJlKHNweS5jb3VudCwgMSkKICAgICAgICAgICAgIGNvbXBhcmUoZmF2aWNv bi53aWR0aCwgNDgpCiAgICAgICAgICAgICBjb21wYXJlKGZhdmljb24uaGVpZ2h0LCA0OCkKQEAg LTQ2LDcgKzQ2LDcgQEAgVGVzdFdlYlZpZXcgewogICAgICAgICAgICAgY29tcGFyZShzcHkuY291 bnQsIDApCiAgICAgICAgICAgICB2YXIgdXJsID0gUXQucmVzb2x2ZWRVcmwoIi4uL2NvbW1vbi9m YXZpY29uMi5odG1sP2Zhdmljb249bG9hZCBzaG91bGQgd29yayB3aXRoI3doaXRlc3BhY2UhIikK ICAgICAgICAgICAgIHdlYlZpZXcudXJsID0gdXJsCi0gICAgICAgICAgICB2ZXJpZnkod2ViVmll dy53YWl0Rm9yTG9hZFN1Y2NlZWRlZCgpKQorICAgICAgICAgICAgc3B5LndhaXQoKQogICAgICAg ICAgICAgY29tcGFyZShzcHkuY291bnQsIDEpCiAgICAgICAgICAgICBjb21wYXJlKGZhdmljb24u d2lkdGgsIDE2KQogICAgICAgICAgICAgY29tcGFyZShmYXZpY29uLmhlaWdodCwgMTYpCg==