91857 2012-07-20 07:00:59 -0700 [chromium] MediaStream API: Clean up the MockWebKitPlatformSupport object at shutdown 2012-07-23 09:15:50 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 tommyw tommyw abarth dglazkov fishd jamesr tkent tkent+wkapi webkit.review.bot oldest_to_newest 674528 0 tommyw 2012-07-20 07:00:59 -0700 It caused valgrind issues. 674532 1 153497 tommyw 2012-07-20 07:03:26 -0700 Created attachment 153497 Patch 674546 2 153501 tommyw 2012-07-20 07:20:42 -0700 Created attachment 153501 Patch 674548 3 webkit.review.bot 2012-07-20 07:22:21 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 674619 4 153501 abarth 2012-07-20 09:07:55 -0700 Comment on attachment 153501 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153501&action=review > Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:85 > + OwnPtr<MockWebKitPlatformSupport> mockPlatform; mockPlatform -> m_mockPlatform > Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:38 > -Platform* MockWebKitPlatformSupport::create() > +MockWebKitPlatformSupport* MockWebKitPlatformSupport::create() Should this return a PassOwnPtr? > Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h:39 > + ~MockWebKitPlatformSupport() { } Please move this declaration out of line. 675512 5 153750 tommyw 2012-07-23 01:05:13 -0700 Created attachment 153750 Patch 675513 6 153501 tommyw 2012-07-23 01:06:19 -0700 Comment on attachment 153501 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153501&action=review >> Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:85 >> + OwnPtr<MockWebKitPlatformSupport> mockPlatform; > > mockPlatform -> m_mockPlatform Done. >> Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:38 >> +MockWebKitPlatformSupport* MockWebKitPlatformSupport::create() > > Should this return a PassOwnPtr? Yes, done. >> Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h:39 >> + ~MockWebKitPlatformSupport() { } > > Please move this declaration out of line. Done. 675746 7 153750 abarth 2012-07-23 09:02:13 -0700 Comment on attachment 153750 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153750&action=review > Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:40 > - return new MockWebKitPlatformSupport(); > + return WTF::adoptPtr(new MockWebKitPlatformSupport()); I think the WTF:: here is optional. 675758 8 153750 webkit.review.bot 2012-07-23 09:15:45 -0700 Comment on attachment 153750 Patch Clearing flags on attachment: 153750 Committed r123345: <http://trac.webkit.org/changeset/123345> 675759 9 webkit.review.bot 2012-07-23 09:15:50 -0700 All reviewed patches have been landed. Closing bug. 153497 2012-07-20 07:03:26 -0700 2012-07-20 07:20:37 -0700 Patch bug-91857-20120720160321.patch text/plain 3495 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMTkzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDM4ZTEzZjg2MWI4ZDkwNDIzYmNiOTdiMmZmYjAwNTA5 M2NjNjFhNi4uMTU1ZmUyYzBjYmVjOTQ4MzBmYmQ1Mzg5YWMwZDQzYzZkYzg2ODBiYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDEyLTA3LTIwICBUb21teSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgor CisgICAgICAgIFtjaHJvbWl1bV0gTWVkaWFTdHJlYW0gQVBJOiBDbGVhbiB1cCB0aGUgTW9ja1dl YktpdFBsYXRmb3JtU3VwcG9ydCBvYmplY3QgYXQgc2h1dGRvd24KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxODU3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFkZSBhIGZldyBjaGFuZ2VzIHNvIHRoYXQg dGhlIGRlc3RydWN0b3IgY291bGQgYmUgY2FsbGVkIGF0IHNodXRkb3duLgorCisgICAgICAgICog RHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAgICAoV2Vi S2l0U3VwcG9ydFRlc3RFbnZpcm9ubWVudDo6V2ViS2l0U3VwcG9ydFRlc3RFbnZpcm9ubWVudCk6 CisgICAgICAgIChXZWJLaXRTdXBwb3J0VGVzdEVudmlyb25tZW50KToKKyAgICAgICAgKiBEdW1w UmVuZGVyVHJlZS9jaHJvbWl1bS9Nb2NrV2ViS2l0UGxhdGZvcm1TdXBwb3J0LmNwcDoKKyAgICAg ICAgKE1vY2tXZWJLaXRQbGF0Zm9ybVN1cHBvcnQ6OmNyZWF0ZSk6CisgICAgICAgICogRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vTW9ja1dlYktpdFBsYXRmb3JtU3VwcG9ydC5oOgorICAgICAgICAo TW9ja1dlYktpdFBsYXRmb3JtU3VwcG9ydCk6CisgICAgICAgIChNb2NrV2ViS2l0UGxhdGZvcm1T dXBwb3J0Ojp+TW9ja1dlYktpdFBsYXRmb3JtU3VwcG9ydCk6CisKIDIwMTItMDctMjAgIEd5dXlv dW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbV1RSXSBBZGQg KmV4cGxpY2l0KiBrZXl3b3JkIHRvIGNvbnN0cnVjdG9yIHdoaWNoIGhhcyBhIHBhcmFtZXRlcgpk aWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRHVtcFJlbmRlclRyZWUu Y3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRHVtcFJlbmRlclRyZWUuY3BwCmlu ZGV4IGU1ODlkZjJiZjQ2ZmJjYTgzNzMyNWYwMDIzNzI1ZDVhYjlkZWIzNTcuLmYyNWVjMzgxNTUz NWY3MDJhZjczZmJmYmI5MDAwNGY4NDU5ODcwZWYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL2Nocm9taXVtL0R1bXBSZW5kZXJUcmVlLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVy VHJlZS9jaHJvbWl1bS9EdW1wUmVuZGVyVHJlZS5jcHAKQEAgLTM2LDYgKzM2LDcgQEAKICNpbmNs dWRlICJ3ZWJraXQvc3VwcG9ydC93ZWJraXRfc3VwcG9ydC5oIgogI2luY2x1ZGUgPHY4L2luY2x1 ZGUvdjgtdGVzdGluZy5oPgogI2luY2x1ZGUgPHY4L2luY2x1ZGUvdjguaD4KKyNpbmNsdWRlIDx3 dGYvT3duUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1ZlY3Rvci5oPgogCiB1c2luZyBuYW1lc3BhY2Ug c3RkOwpAQCAtNzMsMTIgKzc0LDE1IEBAIGNsYXNzIFdlYktpdFN1cHBvcnRUZXN0RW52aXJvbm1l bnQgewogcHVibGljOgogICAgIFdlYktpdFN1cHBvcnRUZXN0RW52aXJvbm1lbnQoKQogICAgIHsK LSAgICAgICAgd2Via2l0X3N1cHBvcnQ6OlNldFVwVGVzdEVudmlyb25tZW50KE1vY2tXZWJLaXRQ bGF0Zm9ybVN1cHBvcnQ6OmNyZWF0ZSgpKTsKKyAgICAgICAgbW9ja1BsYXRmb3JtID0gYWRvcHRQ dHIoTW9ja1dlYktpdFBsYXRmb3JtU3VwcG9ydDo6Y3JlYXRlKCkpOworICAgICAgICB3ZWJraXRf c3VwcG9ydDo6U2V0VXBUZXN0RW52aXJvbm1lbnQobW9ja1BsYXRmb3JtLmdldCgpKTsKICAgICB9 CiAgICAgfldlYktpdFN1cHBvcnRUZXN0RW52aXJvbm1lbnQoKQogICAgIHsKICAgICAgICAgd2Vi a2l0X3N1cHBvcnQ6OlRlYXJEb3duVGVzdEVudmlyb25tZW50KCk7CiAgICAgfQorcHJpdmF0ZToK KyAgICBPd25QdHI8TW9ja1dlYktpdFBsYXRmb3JtU3VwcG9ydD4gbW9ja1BsYXRmb3JtOwogfTsK IAogc3RhdGljIHZvaWQgcnVuVGVzdChUZXN0U2hlbGwmIHNoZWxsLCBUZXN0UGFyYW1zJiBwYXJh bXMsIGNvbnN0IHN0cmluZyYgdGVzdE5hbWUpCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVy VHJlZS9jaHJvbWl1bS9Nb2NrV2ViS2l0UGxhdGZvcm1TdXBwb3J0LmNwcCBiL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL2Nocm9taXVtL01vY2tXZWJLaXRQbGF0Zm9ybVN1cHBvcnQuY3BwCmluZGV4IGQ0 ODdiODhhYTEyOTFiMWUwNDIzNzJkYjBhMjgzODc2ZThmNGI3NjIuLjYwZTdiZDMzNzFkMmQ5Mzg3 MjY2ZjY1ZDIzZmU1OTJlOGEyY2Y1MTQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVl L2Nocm9taXVtL01vY2tXZWJLaXRQbGF0Zm9ybVN1cHBvcnQuY3BwCisrKyBiL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL2Nocm9taXVtL01vY2tXZWJLaXRQbGF0Zm9ybVN1cHBvcnQuY3BwCkBAIC0zNSw3 ICszNSw3IEBACiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiAKLVBsYXRmb3JtKiBNb2NrV2Vi S2l0UGxhdGZvcm1TdXBwb3J0OjpjcmVhdGUoKQorTW9ja1dlYktpdFBsYXRmb3JtU3VwcG9ydCog TW9ja1dlYktpdFBsYXRmb3JtU3VwcG9ydDo6Y3JlYXRlKCkKIHsKICAgICByZXR1cm4gbmV3IE1v Y2tXZWJLaXRQbGF0Zm9ybVN1cHBvcnQoKTsKIH0KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL2Nocm9taXVtL01vY2tXZWJLaXRQbGF0Zm9ybVN1cHBvcnQuaCBiL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL2Nocm9taXVtL01vY2tXZWJLaXRQbGF0Zm9ybVN1cHBvcnQuaAppbmRleCBjNWRh YTZmMGY1OTA3MWZhYzUyMjJlNjFjYzk4NjM5YTg4MDNjMTE2Li4zMzA4NmYwYTYzNGU5OGU2ZTli MTQ4OWU1ODcwODU2MzQ4NWE4YWM0IDEwMDY0NAotLS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9j aHJvbWl1bS9Nb2NrV2ViS2l0UGxhdGZvcm1TdXBwb3J0LmgKKysrIGIvVG9vbHMvRHVtcFJlbmRl clRyZWUvY2hyb21pdW0vTW9ja1dlYktpdFBsYXRmb3JtU3VwcG9ydC5oCkBAIC0zNSw3ICszNSw4 IEBACiAKIGNsYXNzIE1vY2tXZWJLaXRQbGF0Zm9ybVN1cHBvcnQgOiBwdWJsaWMgV2ViS2l0OjpQ bGF0Zm9ybSB7CiBwdWJsaWM6Ci0gICAgc3RhdGljIFdlYktpdDo6UGxhdGZvcm0qIGNyZWF0ZSgp OworICAgIHN0YXRpYyBNb2NrV2ViS2l0UGxhdGZvcm1TdXBwb3J0KiBjcmVhdGUoKTsKKyAgICB+ TW9ja1dlYktpdFBsYXRmb3JtU3VwcG9ydCgpIHsgfQogCiAgICAgdmlydHVhbCB2b2lkIGNyeXB0 b2dyYXBoaWNhbGx5UmFuZG9tVmFsdWVzKHVuc2lnbmVkIGNoYXIqIGJ1ZmZlciwgc2l6ZV90IGxl bmd0aCkgT1ZFUlJJREU7CiAK 153501 2012-07-20 07:20:42 -0700 2012-07-23 01:06:19 -0700 Patch bug-91857-20120720162038.patch text/plain 4776 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA3NmMxNzEzM2YzOGQ4 MDE0ZWY5MGMzOTZhNzI0NWU0NzhhOTNmMTNhLi41ZjQ1MmJjOGVkNmYwMGEzNDYxODNhOWNhODE0 OGQ2M2UwNTlkNjUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wNy0yMCAg VG9tbXkgV2lkZW5mbHljaHQgIDx0b21teXdAZ29vZ2xlLmNvbT4KKworICAgICAgICBbY2hyb21p dW1dIE1lZGlhU3RyZWFtIEFQSTogQ2xlYW4gdXAgdGhlIE1vY2tXZWJLaXRQbGF0Zm9ybVN1cHBv cnQgb2JqZWN0IGF0IHNodXRkb3duCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05MTg1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE1hZGUgUGxhdGZvcm1zIGRlc3RydWN0b3IgdmlydHVhbC4KKworICAgICAg ICAqIGNocm9taXVtL3B1YmxpYy9QbGF0Zm9ybS5oOgorICAgICAgICAoV2ViS2l0OjpQbGF0Zm9y bTo6flBsYXRmb3JtKToKKwogMjAxMi0wNy0xOCAgQW50b2luZSBMYWJvdXIgIDxwaW1hbkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBJbnRyb2R1Y2UgQ0NSZXNvdXJjZVByb3Zp ZGVyLCByZXBsYWNpbmcgVGV4dHVyZUFsbG9jYXRvciBhbmQgaGlkaW5nIHRleHR1cmVzIGZyb20g Y2xpZW50cyB0byBhbGxvdyB0cmFuc3BvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9QbGF0Zm9ybS9j aHJvbWl1bS9wdWJsaWMvUGxhdGZvcm0uaCBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJs aWMvUGxhdGZvcm0uaAppbmRleCBiMGIwZTZlZDI0NmQxZGEyZGE3NjM5NzJmNjFmNjg4MTI3YWJm MzE3Li42NGRmM2JhODk1Y2ZkYjRhOWZkMzE5MWRjYmI2MTZlOTkzMTI5ZWRkIDEwMDY0NAotLS0g YS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1BsYXRmb3JtLmgKKysrIGIvU291cmNl L1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9QbGF0Zm9ybS5oCkBAIC00MjQsNyArNDI0LDcgQEAg cHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBkaWRTdG9wV29ya2VyUnVuTG9vcChjb25zdCBXZWJX b3JrZXJSdW5Mb29wJikgeyB9CiAKIHByb3RlY3RlZDoKLSAgICB+UGxhdGZvcm0oKSB7IH0KKyAg ICB2aXJ0dWFsIH5QbGF0Zm9ybSgpIHsgfQogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRp ZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDM4ZTEz Zjg2MWI4ZDkwNDIzYmNiOTdiMmZmYjAwNTA5M2NjNjFhNi4uMTU1ZmUyYzBjYmVjOTQ4MzBmYmQ1 Mzg5YWMwZDQzYzZkYzg2ODBiYSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rv b2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA3LTIwICBUb21teSBXaWRlbmZs eWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV0gTWVkaWFTdHJl YW0gQVBJOiBDbGVhbiB1cCB0aGUgTW9ja1dlYktpdFBsYXRmb3JtU3VwcG9ydCBvYmplY3QgYXQg c2h1dGRvd24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTkxODU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg TWFkZSBhIGZldyBjaGFuZ2VzIHNvIHRoYXQgdGhlIGRlc3RydWN0b3IgY291bGQgYmUgY2FsbGVk IGF0IHNodXRkb3duLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRHVtcFJl bmRlclRyZWUuY3BwOgorICAgICAgICAoV2ViS2l0U3VwcG9ydFRlc3RFbnZpcm9ubWVudDo6V2Vi S2l0U3VwcG9ydFRlc3RFbnZpcm9ubWVudCk6CisgICAgICAgIChXZWJLaXRTdXBwb3J0VGVzdEVu dmlyb25tZW50KToKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9Nb2NrV2ViS2l0 UGxhdGZvcm1TdXBwb3J0LmNwcDoKKyAgICAgICAgKE1vY2tXZWJLaXRQbGF0Zm9ybVN1cHBvcnQ6 OmNyZWF0ZSk6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTW9ja1dlYktpdFBs YXRmb3JtU3VwcG9ydC5oOgorICAgICAgICAoTW9ja1dlYktpdFBsYXRmb3JtU3VwcG9ydCk6Cisg ICAgICAgIChNb2NrV2ViS2l0UGxhdGZvcm1TdXBwb3J0Ojp+TW9ja1dlYktpdFBsYXRmb3JtU3Vw cG9ydCk6CisKIDIwMTItMDctMjAgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5n LmNvbT4KIAogICAgICAgICBbV1RSXSBBZGQgKmV4cGxpY2l0KiBrZXl3b3JkIHRvIGNvbnN0cnVj dG9yIHdoaWNoIGhhcyBhIHBhcmFtZXRlcgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRy ZWUvY2hyb21pdW0vRHVtcFJlbmRlclRyZWUuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hy b21pdW0vRHVtcFJlbmRlclRyZWUuY3BwCmluZGV4IGU1ODlkZjJiZjQ2ZmJjYTgzNzMyNWYwMDIz NzI1ZDVhYjlkZWIzNTcuLmYyNWVjMzgxNTUzNWY3MDJhZjczZmJmYmI5MDAwNGY4NDU5ODcwZWYg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0R1bXBSZW5kZXJUcmVl LmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9EdW1wUmVuZGVyVHJlZS5j cHAKQEAgLTM2LDYgKzM2LDcgQEAKICNpbmNsdWRlICJ3ZWJraXQvc3VwcG9ydC93ZWJraXRfc3Vw cG9ydC5oIgogI2luY2x1ZGUgPHY4L2luY2x1ZGUvdjgtdGVzdGluZy5oPgogI2luY2x1ZGUgPHY4 L2luY2x1ZGUvdjguaD4KKyNpbmNsdWRlIDx3dGYvT3duUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1Zl Y3Rvci5oPgogCiB1c2luZyBuYW1lc3BhY2Ugc3RkOwpAQCAtNzMsMTIgKzc0LDE1IEBAIGNsYXNz IFdlYktpdFN1cHBvcnRUZXN0RW52aXJvbm1lbnQgewogcHVibGljOgogICAgIFdlYktpdFN1cHBv cnRUZXN0RW52aXJvbm1lbnQoKQogICAgIHsKLSAgICAgICAgd2Via2l0X3N1cHBvcnQ6OlNldFVw VGVzdEVudmlyb25tZW50KE1vY2tXZWJLaXRQbGF0Zm9ybVN1cHBvcnQ6OmNyZWF0ZSgpKTsKKyAg ICAgICAgbW9ja1BsYXRmb3JtID0gYWRvcHRQdHIoTW9ja1dlYktpdFBsYXRmb3JtU3VwcG9ydDo6 Y3JlYXRlKCkpOworICAgICAgICB3ZWJraXRfc3VwcG9ydDo6U2V0VXBUZXN0RW52aXJvbm1lbnQo bW9ja1BsYXRmb3JtLmdldCgpKTsKICAgICB9CiAgICAgfldlYktpdFN1cHBvcnRUZXN0RW52aXJv bm1lbnQoKQogICAgIHsKICAgICAgICAgd2Via2l0X3N1cHBvcnQ6OlRlYXJEb3duVGVzdEVudmly b25tZW50KCk7CiAgICAgfQorcHJpdmF0ZToKKyAgICBPd25QdHI8TW9ja1dlYktpdFBsYXRmb3Jt U3VwcG9ydD4gbW9ja1BsYXRmb3JtOwogfTsKIAogc3RhdGljIHZvaWQgcnVuVGVzdChUZXN0U2hl bGwmIHNoZWxsLCBUZXN0UGFyYW1zJiBwYXJhbXMsIGNvbnN0IHN0cmluZyYgdGVzdE5hbWUpCmRp ZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9Nb2NrV2ViS2l0UGxhdGZv cm1TdXBwb3J0LmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL01vY2tXZWJLaXRQ bGF0Zm9ybVN1cHBvcnQuY3BwCmluZGV4IGQ0ODdiODhhYTEyOTFiMWUwNDIzNzJkYjBhMjgzODc2 ZThmNGI3NjIuLjYwZTdiZDMzNzFkMmQ5Mzg3MjY2ZjY1ZDIzZmU1OTJlOGEyY2Y1MTQgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL01vY2tXZWJLaXRQbGF0Zm9ybVN1 cHBvcnQuY3BwCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL01vY2tXZWJLaXRQ bGF0Zm9ybVN1cHBvcnQuY3BwCkBAIC0zNSw3ICszNSw3IEBACiAKIHVzaW5nIG5hbWVzcGFjZSBX ZWJLaXQ7CiAKLVBsYXRmb3JtKiBNb2NrV2ViS2l0UGxhdGZvcm1TdXBwb3J0OjpjcmVhdGUoKQor TW9ja1dlYktpdFBsYXRmb3JtU3VwcG9ydCogTW9ja1dlYktpdFBsYXRmb3JtU3VwcG9ydDo6Y3Jl YXRlKCkKIHsKICAgICByZXR1cm4gbmV3IE1vY2tXZWJLaXRQbGF0Zm9ybVN1cHBvcnQoKTsKIH0K ZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL01vY2tXZWJLaXRQbGF0 Zm9ybVN1cHBvcnQuaCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL01vY2tXZWJLaXRQ bGF0Zm9ybVN1cHBvcnQuaAppbmRleCBjNWRhYTZmMGY1OTA3MWZhYzUyMjJlNjFjYzk4NjM5YTg4 MDNjMTE2Li4zMzA4NmYwYTYzNGU5OGU2ZTliMTQ4OWU1ODcwODU2MzQ4NWE4YWM0IDEwMDY0NAot LS0gYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9Nb2NrV2ViS2l0UGxhdGZvcm1TdXBw b3J0LmgKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTW9ja1dlYktpdFBsYXRm b3JtU3VwcG9ydC5oCkBAIC0zNSw3ICszNSw4IEBACiAKIGNsYXNzIE1vY2tXZWJLaXRQbGF0Zm9y bVN1cHBvcnQgOiBwdWJsaWMgV2ViS2l0OjpQbGF0Zm9ybSB7CiBwdWJsaWM6Ci0gICAgc3RhdGlj IFdlYktpdDo6UGxhdGZvcm0qIGNyZWF0ZSgpOworICAgIHN0YXRpYyBNb2NrV2ViS2l0UGxhdGZv cm1TdXBwb3J0KiBjcmVhdGUoKTsKKyAgICB+TW9ja1dlYktpdFBsYXRmb3JtU3VwcG9ydCgpIHsg fQogCiAgICAgdmlydHVhbCB2b2lkIGNyeXB0b2dyYXBoaWNhbGx5UmFuZG9tVmFsdWVzKHVuc2ln bmVkIGNoYXIqIGJ1ZmZlciwgc2l6ZV90IGxlbmd0aCkgT1ZFUlJJREU7CiAK 153750 2012-07-23 01:05:13 -0700 2012-07-23 09:15:45 -0700 Patch bug-91857-20120723100505.patch text/plain 5188 tommyw U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCA3NmMxNzEzM2YzOGQ4 MDE0ZWY5MGMzOTZhNzI0NWU0NzhhOTNmMTNhLi41ZjQ1MmJjOGVkNmYwMGEzNDYxODNhOWNhODE0 OGQ2M2UwNTlkNjUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wNy0yMCAg VG9tbXkgV2lkZW5mbHljaHQgIDx0b21teXdAZ29vZ2xlLmNvbT4KKworICAgICAgICBbY2hyb21p dW1dIE1lZGlhU3RyZWFtIEFQSTogQ2xlYW4gdXAgdGhlIE1vY2tXZWJLaXRQbGF0Zm9ybVN1cHBv cnQgb2JqZWN0IGF0IHNodXRkb3duCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05MTg1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE1hZGUgUGxhdGZvcm1zIGRlc3RydWN0b3IgdmlydHVhbC4KKworICAgICAg ICAqIGNocm9taXVtL3B1YmxpYy9QbGF0Zm9ybS5oOgorICAgICAgICAoV2ViS2l0OjpQbGF0Zm9y bTo6flBsYXRmb3JtKToKKwogMjAxMi0wNy0xOCAgQW50b2luZSBMYWJvdXIgIDxwaW1hbkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBJbnRyb2R1Y2UgQ0NSZXNvdXJjZVByb3Zp ZGVyLCByZXBsYWNpbmcgVGV4dHVyZUFsbG9jYXRvciBhbmQgaGlkaW5nIHRleHR1cmVzIGZyb20g Y2xpZW50cyB0byBhbGxvdyB0cmFuc3BvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9QbGF0Zm9ybS9j aHJvbWl1bS9wdWJsaWMvUGxhdGZvcm0uaCBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9wdWJs aWMvUGxhdGZvcm0uaAppbmRleCBiMGIwZTZlZDI0NmQxZGEyZGE3NjM5NzJmNjFmNjg4MTI3YWJm MzE3Li42NGRmM2JhODk1Y2ZkYjRhOWZkMzE5MWRjYmI2MTZlOTkzMTI5ZWRkIDEwMDY0NAotLS0g YS9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vcHVibGljL1BsYXRmb3JtLmgKKysrIGIvU291cmNl L1BsYXRmb3JtL2Nocm9taXVtL3B1YmxpYy9QbGF0Zm9ybS5oCkBAIC00MjQsNyArNDI0LDcgQEAg cHVibGljOgogICAgIHZpcnR1YWwgdm9pZCBkaWRTdG9wV29ya2VyUnVuTG9vcChjb25zdCBXZWJX b3JrZXJSdW5Mb29wJikgeyB9CiAKIHByb3RlY3RlZDoKLSAgICB+UGxhdGZvcm0oKSB7IH0KKyAg ICB2aXJ0dWFsIH5QbGF0Zm9ybSgpIHsgfQogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRp ZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDM4ZTEz Zjg2MWI4ZDkwNDIzYmNiOTdiMmZmYjAwNTA5M2NjNjFhNi4uMTU1ZmUyYzBjYmVjOTQ4MzBmYmQ1 Mzg5YWMwZDQzYzZkYzg2ODBiYSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rv b2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA3LTIwICBUb21teSBXaWRlbmZs eWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgorCisgICAgICAgIFtjaHJvbWl1bV0gTWVkaWFTdHJl YW0gQVBJOiBDbGVhbiB1cCB0aGUgTW9ja1dlYktpdFBsYXRmb3JtU3VwcG9ydCBvYmplY3QgYXQg c2h1dGRvd24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTkxODU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg TWFkZSBhIGZldyBjaGFuZ2VzIHNvIHRoYXQgdGhlIGRlc3RydWN0b3IgY291bGQgYmUgY2FsbGVk IGF0IHNodXRkb3duLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vRHVtcFJl bmRlclRyZWUuY3BwOgorICAgICAgICAoV2ViS2l0U3VwcG9ydFRlc3RFbnZpcm9ubWVudDo6V2Vi S2l0U3VwcG9ydFRlc3RFbnZpcm9ubWVudCk6CisgICAgICAgIChXZWJLaXRTdXBwb3J0VGVzdEVu dmlyb25tZW50KToKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9Nb2NrV2ViS2l0 UGxhdGZvcm1TdXBwb3J0LmNwcDoKKyAgICAgICAgKE1vY2tXZWJLaXRQbGF0Zm9ybVN1cHBvcnQ6 OmNyZWF0ZSk6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTW9ja1dlYktpdFBs YXRmb3JtU3VwcG9ydC5oOgorICAgICAgICAoTW9ja1dlYktpdFBsYXRmb3JtU3VwcG9ydCk6Cisg ICAgICAgIChNb2NrV2ViS2l0UGxhdGZvcm1TdXBwb3J0Ojp+TW9ja1dlYktpdFBsYXRmb3JtU3Vw cG9ydCk6CisKIDIwMTItMDctMjAgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5n LmNvbT4KIAogICAgICAgICBbV1RSXSBBZGQgKmV4cGxpY2l0KiBrZXl3b3JkIHRvIGNvbnN0cnVj dG9yIHdoaWNoIGhhcyBhIHBhcmFtZXRlcgpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRy ZWUvY2hyb21pdW0vRHVtcFJlbmRlclRyZWUuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hy b21pdW0vRHVtcFJlbmRlclRyZWUuY3BwCmluZGV4IGU1ODlkZjJiZjQ2ZmJjYTgzNzMyNWYwMDIz NzI1ZDVhYjlkZWIzNTcuLjYxNTVmNDQxZjVkOGJiM2M0NGU1MTc5MDgwZGNiMTc0NDVlODk4NzQg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0R1bXBSZW5kZXJUcmVl LmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9EdW1wUmVuZGVyVHJlZS5j cHAKQEAgLTM2LDYgKzM2LDcgQEAKICNpbmNsdWRlICJ3ZWJraXQvc3VwcG9ydC93ZWJraXRfc3Vw cG9ydC5oIgogI2luY2x1ZGUgPHY4L2luY2x1ZGUvdjgtdGVzdGluZy5oPgogI2luY2x1ZGUgPHY4 L2luY2x1ZGUvdjguaD4KKyNpbmNsdWRlIDx3dGYvT3duUHRyLmg+CiAjaW5jbHVkZSA8d3RmL1Zl Y3Rvci5oPgogCiB1c2luZyBuYW1lc3BhY2Ugc3RkOwpAQCAtNzMsMTIgKzc0LDE1IEBAIGNsYXNz IFdlYktpdFN1cHBvcnRUZXN0RW52aXJvbm1lbnQgewogcHVibGljOgogICAgIFdlYktpdFN1cHBv cnRUZXN0RW52aXJvbm1lbnQoKQogICAgIHsKLSAgICAgICAgd2Via2l0X3N1cHBvcnQ6OlNldFVw VGVzdEVudmlyb25tZW50KE1vY2tXZWJLaXRQbGF0Zm9ybVN1cHBvcnQ6OmNyZWF0ZSgpKTsKKyAg ICAgICAgbV9tb2NrUGxhdGZvcm0gPSBNb2NrV2ViS2l0UGxhdGZvcm1TdXBwb3J0OjpjcmVhdGUo KTsKKyAgICAgICAgd2Via2l0X3N1cHBvcnQ6OlNldFVwVGVzdEVudmlyb25tZW50KG1fbW9ja1Bs YXRmb3JtLmdldCgpKTsKICAgICB9CiAgICAgfldlYktpdFN1cHBvcnRUZXN0RW52aXJvbm1lbnQo KQogICAgIHsKICAgICAgICAgd2Via2l0X3N1cHBvcnQ6OlRlYXJEb3duVGVzdEVudmlyb25tZW50 KCk7CiAgICAgfQorcHJpdmF0ZToKKyAgICBPd25QdHI8TW9ja1dlYktpdFBsYXRmb3JtU3VwcG9y dD4gbV9tb2NrUGxhdGZvcm07CiB9OwogCiBzdGF0aWMgdm9pZCBydW5UZXN0KFRlc3RTaGVsbCYg c2hlbGwsIFRlc3RQYXJhbXMmIHBhcmFtcywgY29uc3Qgc3RyaW5nJiB0ZXN0TmFtZSkKZGlmZiAt LWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL01vY2tXZWJLaXRQbGF0Zm9ybVN1 cHBvcnQuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTW9ja1dlYktpdFBsYXRm b3JtU3VwcG9ydC5jcHAKaW5kZXggZDQ4N2I4OGFhMTI5MWIxZTA0MjM3MmRiMGEyODM4NzZlOGY0 Yjc2Mi4uMjNiNWFhN2RiMTc4NWNhMTNhMmNjZjFkMzMzYTc0NGRkOTc1NmE5YiAxMDA2NDQKLS0t IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTW9ja1dlYktpdFBsYXRmb3JtU3VwcG9y dC5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTW9ja1dlYktpdFBsYXRm b3JtU3VwcG9ydC5jcHAKQEAgLTM1LDE1ICszNSwxOSBAQAogCiB1c2luZyBuYW1lc3BhY2UgV2Vi S2l0OwogCi1QbGF0Zm9ybSogTW9ja1dlYktpdFBsYXRmb3JtU3VwcG9ydDo6Y3JlYXRlKCkKK1Bh c3NPd25QdHI8TW9ja1dlYktpdFBsYXRmb3JtU3VwcG9ydD4gTW9ja1dlYktpdFBsYXRmb3JtU3Vw cG9ydDo6Y3JlYXRlKCkKIHsKLSAgICByZXR1cm4gbmV3IE1vY2tXZWJLaXRQbGF0Zm9ybVN1cHBv cnQoKTsKKyAgICByZXR1cm4gV1RGOjphZG9wdFB0cihuZXcgTW9ja1dlYktpdFBsYXRmb3JtU3Vw cG9ydCgpKTsKIH0KIAogTW9ja1dlYktpdFBsYXRmb3JtU3VwcG9ydDo6TW9ja1dlYktpdFBsYXRm b3JtU3VwcG9ydCgpCiB7CiB9CiAKK01vY2tXZWJLaXRQbGF0Zm9ybVN1cHBvcnQ6On5Nb2NrV2Vi S2l0UGxhdGZvcm1TdXBwb3J0KCkKK3sKK30KKwogdm9pZCBNb2NrV2ViS2l0UGxhdGZvcm1TdXBw b3J0OjpjcnlwdG9ncmFwaGljYWxseVJhbmRvbVZhbHVlcyh1bnNpZ25lZCBjaGFyKiwgc2l6ZV90 KQogewogICAgIENSQVNIKCk7CmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJv bWl1bS9Nb2NrV2ViS2l0UGxhdGZvcm1TdXBwb3J0LmggYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9j aHJvbWl1bS9Nb2NrV2ViS2l0UGxhdGZvcm1TdXBwb3J0LmgKaW5kZXggYzVkYWE2ZjBmNTkwNzFm YWM1MjIyZTYxY2M5ODYzOWE4ODAzYzExNi4uNWU4OTc3ZDU1ZTFlNjM1OWE0NGUwMDNhNjNmMGU4 MjMzNmI2MmE1ZCAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vTW9j a1dlYktpdFBsYXRmb3JtU3VwcG9ydC5oCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9t aXVtL01vY2tXZWJLaXRQbGF0Zm9ybVN1cHBvcnQuaApAQCAtMzIsMTAgKzMyLDEyIEBACiAjZGVm aW5lIE1vY2tXZWJLaXRQbGF0Zm9ybVN1cHBvcnRfaAogCiAjaW5jbHVkZSA8cHVibGljL1BsYXRm b3JtLmg+CisjaW5jbHVkZSA8d3RmL1Bhc3NPd25QdHIuaD4KIAogY2xhc3MgTW9ja1dlYktpdFBs YXRmb3JtU3VwcG9ydCA6IHB1YmxpYyBXZWJLaXQ6OlBsYXRmb3JtIHsKIHB1YmxpYzoKLSAgICBz dGF0aWMgV2ViS2l0OjpQbGF0Zm9ybSogY3JlYXRlKCk7CisgICAgc3RhdGljIFBhc3NPd25QdHI8 TW9ja1dlYktpdFBsYXRmb3JtU3VwcG9ydD4gY3JlYXRlKCk7CisgICAgfk1vY2tXZWJLaXRQbGF0 Zm9ybVN1cHBvcnQoKTsKIAogICAgIHZpcnR1YWwgdm9pZCBjcnlwdG9ncmFwaGljYWxseVJhbmRv bVZhbHVlcyh1bnNpZ25lZCBjaGFyKiBidWZmZXIsIHNpemVfdCBsZW5ndGgpIE9WRVJSSURFOwog Cg==