91847 2012-07-20 03:00:01 -0700 [chromium] Don't include WebCore headers in TestInterfaces so it's safe to include from outside of WebCore 2012-07-20 11:13:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jochen jochen abarth tkent webkit.review.bot oldest_to_newest 674401 0 jochen 2012-07-20 03:00:01 -0700 [chromium] Don't include WebCore headers in TestInterfaces so it's safe to include from outside of WebCore 674404 1 153462 jochen 2012-07-20 03:07:02 -0700 Created attachment 153462 Patch 674599 2 153462 abarth 2012-07-20 08:38:54 -0700 Comment on attachment 153462 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153462&action=review > Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.h:48 > + class Internal; > + Internal* m_internal; Isn't there an OwnPtr-like class we can use from the WebKit API? WebPrivatePtr or something? 674738 3 jochen 2012-07-20 10:59:25 -0700 (In reply to comment #2) > (From update of attachment 153462 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=153462&action=review > > > Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.h:48 > > + class Internal; > > + Internal* m_internal; > > Isn't there an OwnPtr-like class we can use from the WebKit API? WebPrivatePtr or something? Yes, but it would require defining WEBKIT_IMPLEMENTATION in TestInterfaces.cpp, and in contrast to OwnPtr, it doesn't destroy it's pointee automatically on destruction I esp. don't like defining WEBKIT_IMPLEMENTATION, wdyt? 674744 4 abarth 2012-07-20 11:02:38 -0700 We don't want to define WEBKIT_IMPLEMENTATION since this library isn't part of webkit.dll. Lets try your approach for now. We might need to revise the approach in the future. 674764 5 153462 webkit.review.bot 2012-07-20 11:13:33 -0700 Comment on attachment 153462 Patch Clearing flags on attachment: 153462 Committed r123240: <http://trac.webkit.org/changeset/123240> 674765 6 webkit.review.bot 2012-07-20 11:13:37 -0700 All reviewed patches have been landed. Closing bug. 153462 2012-07-20 03:07:02 -0700 2012-07-20 11:13:32 -0700 Patch bug-91847-20120720120657.patch text/plain 3684 jochen U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMTkyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDM4ZTEzZjg2MWI4ZDkwNDIzYmNiOTdiMmZmYjAwNTA5 M2NjNjFhNi4uOWY2YWRmZjhkNzI2ZGJlZmNiNjYzZmNhZWQ5MWQzM2Q4NWM4YTA3MyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2 IEBACisyMDEyLTA3LTIwICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgor CisgICAgICAgIFtjaHJvbWl1bV0gRG9uJ3QgaW5jbHVkZSBXZWJDb3JlIGhlYWRlcnMgaW4gVGVz dEludGVyZmFjZXMgc28gaXQncyBzYWZlIHRvIGluY2x1ZGUgZnJvbSBvdXRzaWRlIG9mIFdlYkNv cmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxODQ3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBh bGxvd3MgZm9yIGluY2x1ZGluZyB0aGUgVGVzdEludGVmYWNlcy5oIGZyb20gY29udGVudCBzaGVs bAorICAgICAgICB3aXRob3V0IGludHJvZHVjaW5nIGEgZGVwZW5kZW5jeSB0byBXZWJDb3JlL3d0 ZgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFJ1bm5lci9UZXN0SW50 ZXJmYWNlcy5jcHA6CisgICAgICAgIChUZXN0SW50ZXJmYWNlczo6SW50ZXJuYWwpOgorICAgICAg ICAoVGVzdEludGVyZmFjZXM6OkludGVybmFsOjpJbnRlcm5hbCk6CisgICAgICAgIChUZXN0SW50 ZXJmYWNlczo6SW50ZXJuYWw6On5JbnRlcm5hbCk6CisgICAgICAgIChUZXN0SW50ZXJmYWNlczo6 SW50ZXJuYWw6OmJpbmRUbyk6CisgICAgICAgIChUZXN0SW50ZXJmYWNlczo6SW50ZXJuYWw6OnJl c2V0QWxsKToKKyAgICAgICAgKFRlc3RJbnRlcmZhY2VzOjpUZXN0SW50ZXJmYWNlcyk6CisgICAg ICAgIChUZXN0SW50ZXJmYWNlczo6flRlc3RJbnRlcmZhY2VzKToKKyAgICAgICAgKFRlc3RJbnRl cmZhY2VzOjpiaW5kVG8pOgorICAgICAgICAoVGVzdEludGVyZmFjZXM6OnJlc2V0QWxsKToKKyAg ICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL1Rlc3RJbnRlcmZhY2Vz Lmg6CisgICAgICAgIChUZXN0SW50ZXJmYWNlcyk6CisKIDIwMTItMDctMjAgIEd5dXlvdW5nIEtp bSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbV1RSXSBBZGQgKmV4cGxp Y2l0KiBrZXl3b3JkIHRvIGNvbnN0cnVjdG9yIHdoaWNoIGhhcyBhIHBhcmFtZXRlcgpkaWZmIC0t Z2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFJ1bm5lci9UZXN0SW50ZXJm YWNlcy5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL1Rlc3RJ bnRlcmZhY2VzLmNwcAppbmRleCA1Y2ZiMmMyZjgxYTgzNGE4YmQ5ZmU5N2MxY2QyM2RlYjcwNmYx NDM3Li5jMGQ1MzJhMDdmMjcyOTE1ZmJiZjgzMGJhN2Q5N2NmY2JmYjczNDI2IDEwMDY0NAotLS0g YS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL1Rlc3RJbnRlcmZhY2Vz LmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL1Rlc3RJ bnRlcmZhY2VzLmNwcApAQCAtMzQsMjQgKzM0LDU4IEBACiAjaW5jbHVkZSAiR2FtZXBhZENvbnRy b2xsZXIuaCIKICNpbmNsdWRlICJwbGF0Zm9ybS9XZWJTdHJpbmcuaCIKIAorI2luY2x1ZGUgPHd0 Zi9Pd25QdHIuaD4KKwogdXNpbmcgV2ViS2l0OjpXZWJGcmFtZTsKIHVzaW5nIFdlYktpdDo6V2Vi U3RyaW5nOwogCi1UZXN0SW50ZXJmYWNlczo6VGVzdEludGVyZmFjZXMoKQorY2xhc3MgVGVzdElu dGVyZmFjZXM6OkludGVybmFsIHsKK3B1YmxpYzoKKyAgICBJbnRlcm5hbCgpOworICAgIH5JbnRl cm5hbCgpOworCisgICAgdm9pZCBiaW5kVG8oV2ViRnJhbWUqKTsKKyAgICB2b2lkIHJlc2V0QWxs KCk7CisKK3ByaXZhdGU6CisgICAgT3duUHRyPEdhbWVwYWRDb250cm9sbGVyPiBtX2dhbWVwYWRD b250cm9sbGVyOworfTsKKworVGVzdEludGVyZmFjZXM6OkludGVybmFsOjpJbnRlcm5hbCgpCiB7 CiAgICAgbV9nYW1lcGFkQ29udHJvbGxlciA9IGFkb3B0UHRyKG5ldyBHYW1lcGFkQ29udHJvbGxl cigpKTsKIH0KIAorVGVzdEludGVyZmFjZXM6OkludGVybmFsOjp+SW50ZXJuYWwoKQoreworfQor Cit2b2lkIFRlc3RJbnRlcmZhY2VzOjpJbnRlcm5hbDo6YmluZFRvKFdlYkZyYW1lKiBmcmFtZSkK K3sKKyAgICBtX2dhbWVwYWRDb250cm9sbGVyLT5iaW5kVG9KYXZhc2NyaXB0KGZyYW1lLCBXZWJT dHJpbmc6OmZyb21VVEY4KCJnYW1lcGFkQ29udHJvbGxlciIpKTsKK30KKwordm9pZCBUZXN0SW50 ZXJmYWNlczo6SW50ZXJuYWw6OnJlc2V0QWxsKCkKK3sKKyAgICBtX2dhbWVwYWRDb250cm9sbGVy LT5yZXNldCgpOworfQorCitUZXN0SW50ZXJmYWNlczo6VGVzdEludGVyZmFjZXMoKQorICAgIDog bV9pbnRlcm5hbChuZXcgVGVzdEludGVyZmFjZXM6OkludGVybmFsKCkpCit7Cit9CisKIFRlc3RJ bnRlcmZhY2VzOjp+VGVzdEludGVyZmFjZXMoKQogeworICAgIGRlbGV0ZSBtX2ludGVybmFsOwog fQogCiB2b2lkIFRlc3RJbnRlcmZhY2VzOjpiaW5kVG8oV2ViRnJhbWUqIGZyYW1lKQogewotICAg IG1fZ2FtZXBhZENvbnRyb2xsZXItPmJpbmRUb0phdmFzY3JpcHQoZnJhbWUsIFdlYlN0cmluZzo6 ZnJvbVVURjgoImdhbWVwYWRDb250cm9sbGVyIikpOworICAgIG1faW50ZXJuYWwtPmJpbmRUbyhm cmFtZSk7CiB9CiAKIHZvaWQgVGVzdEludGVyZmFjZXM6OnJlc2V0QWxsKCkKIHsKLSAgICBtX2dh bWVwYWRDb250cm9sbGVyLT5yZXNldCgpOworICAgIG1faW50ZXJuYWwtPnJlc2V0QWxsKCk7CiB9 CmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL1Rl c3RJbnRlcmZhY2VzLmggYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVy L1Rlc3RJbnRlcmZhY2VzLmgKaW5kZXggZTI0MDRhZDZkZDg2ZGE3NWY5ZGRlMzRhMjc3NzBjMThh YzFjZDZmYy4uMTZlZDVhNjllOWNiYTRmM2Y0ZWE2ZDE3NmM0NWZhNzE3MmQ1NDBkOCAxMDA2NDQK LS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFJ1bm5lci9UZXN0SW50ZXJm YWNlcy5oCisrKyBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RSdW5uZXIvVGVz dEludGVyZmFjZXMuaApAQCAtMzEsMTQgKzMxLDEwIEBACiAjaWZuZGVmIFRlc3RJbnRlcmZhY2Vz X2gKICNkZWZpbmUgVGVzdEludGVyZmFjZXNfaAogCi0jaW5jbHVkZSA8d3RmL093blB0ci5oPgot CiBuYW1lc3BhY2UgV2ViS2l0IHsKIGNsYXNzIFdlYkZyYW1lOwogfQogCi1jbGFzcyBHYW1lcGFk Q29udHJvbGxlcjsKLQogY2xhc3MgVGVzdEludGVyZmFjZXMgewogcHVibGljOgogICAgIFRlc3RJ bnRlcmZhY2VzKCk7CkBAIC00OCw3ICs0NCw4IEBAIHB1YmxpYzoKICAgICB2b2lkIHJlc2V0QWxs KCk7CiAKIHByaXZhdGU6Ci0gICAgT3duUHRyPEdhbWVwYWRDb250cm9sbGVyPiBtX2dhbWVwYWRD b250cm9sbGVyOworICAgIGNsYXNzIEludGVybmFsOworICAgIEludGVybmFsKiBtX2ludGVybmFs OwogfTsKIAogI2VuZGlmIC8vIFRlc3RJbnRlcmZhY2VzX2gK