91827 2012-07-20 00:31:52 -0700 REGRESSION(r122873): 15% regression on Dromaeo/dom-attr 2012-07-20 14:34:34 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa andersca darin kling koivisto ojan oldest_to_newest 674268 0 rniwa 2012-07-20 00:31:52 -0700 http://code.google.com/p/chromium/issues/detail?id=137964 http://build.chromium.org/f/chromium/perf/mac-release-10.6-webkit-latest/dromaeo_domcore/report.html?history=150&rev=-1&graph=dom_attr_setAttribute Apparently gcc isn't that smart. 674272 1 153437 rniwa 2012-07-20 00:35:57 -0700 Created attachment 153437 Fixed 674773 2 rniwa 2012-07-20 11:19:21 -0700 Thanks for the review :) 674790 3 rniwa 2012-07-20 11:28:30 -0700 Committed r123243: <http://trac.webkit.org/changeset/123243> 674979 4 rniwa 2012-07-20 14:34:34 -0700 It worked!! http://build.chromium.org/f/chromium/perf/mac-release-10.6-webkit-latest/dromaeo_domcore/report.html?history=150&rev=-1&graph=dom_attr_setAttribute 153437 2012-07-20 00:35:57 -0700 2012-07-20 11:18:30 -0700 Fixed bug-91827-20120720003553.patch text/plain 4621 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMzE4NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA3LTIwICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjEyMjg3Myk6 IDE1JSByZWdyZXNzaW9uIG9uIERyb21hZW8vZG9tLWF0dHIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxODI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTW92ZSBzaG91bGRJbnZhbGlkYXRlTm9kZUxpc3RD YWNoZXMgZnJvbSBEb2N1bWVudC5jcHAgdG8gTm9kZS5jcHAgc2luY2UgaXQncyBvbmx5IGNhbGxl ZAorICAgICAgICBpbiBOb2RlOjppbnZhbGlkYXRlTm9kZUxpc3RDYWNoZXNJbkFuY2VzdG9ycy4g QWxzbyBmb3JjZSBpdCB0byBiZSBhbHdheXMgaW5saW5lLgorCisgICAgICAgIFRlc3Q6IFBlcmZv cm1hbmNlVGVzdHMvRHJvbWFlby9kb20tYXR0ci5odG1sLgorCisgICAgICAgICogZG9tL0RvY3Vt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIGRvbS9Ob2RlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OnNob3VsZEludmFsaWRhdGVOb2RlTGlzdENhY2hlc0ZvckF0dHIpOiBF eHRyYWN0ZWQgZnJvbSBzaG91bGRJbnZhbGlkYXRlTm9kZUxpc3RDYWNoZXMKKyAgICAgICAgdG8g dW5yb2xsIHRoZSBsb29wIGluIHNob3VsZEludmFsaWRhdGVOb2RlTGlzdENhY2hlcy4gQXBwYXJl bnRseSBnY2Mgd2Fzbid0IGRvaW5nIHRoZSByaWdodCB0aGluZy4KKyAgICAgICAgKFdlYkNvcmU6 OkRvY3VtZW50OjpzaG91bGRJbnZhbGlkYXRlTm9kZUxpc3RDYWNoZXMpOgorICAgICAgICAoV2Vi Q29yZTo6RG9jdW1lbnQ6OmludmFsaWRhdGVOb2RlTGlzdENhY2hlcyk6CisgICAgICAgIChXZWJD b3JlOjpOb2RlOjppbnZhbGlkYXRlTm9kZUxpc3RDYWNoZXNJbkFuY2VzdG9ycyk6CisKIDIwMTIt MDctMTkgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgogCiAgICAg ICAgIFtRdF0gQ29tcGlsZSBXZWJDb3JlIHdpdGhvdXQgUXRXaWRnZXRzCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAJKHJldmlzaW9uIDEyMzE1OCkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9E b2N1bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM4OTksMzEgKzM4OTksNiBAQCB2b2lkIERv Y3VtZW50Ojp1bnJlZ2lzdGVyTm9kZUxpc3RDYWNoZShECiAgICAgfQogfQogCi1ib29sIERvY3Vt ZW50OjpzaG91bGRJbnZhbGlkYXRlTm9kZUxpc3RDYWNoZXMoY29uc3QgUXVhbGlmaWVkTmFtZSog YXR0ck5hbWUpIGNvbnN0Ci17Ci0gICAgaWYgKGF0dHJOYW1lKSB7Ci0gICAgICAgIGZvciAoaW50 IHR5cGUgPSBEb05vdEludmFsaWRhdGVPbkF0dHJpYnV0ZUNoYW5nZXMgKyAxOyB0eXBlIDwgbnVt Tm9kZUxpc3RJbnZhbGlkYXRpb25UeXBlczsgdHlwZSsrKSB7Ci0gICAgICAgICAgICBpZiAobV9u b2RlTGlzdENvdW50c1t0eXBlXSAmJiBEeW5hbWljTm9kZUxpc3RDYWNoZUJhc2U6OnNob3VsZElu dmFsaWRhdGVUeXBlT25BdHRyaWJ1dGVDaGFuZ2Uoc3RhdGljX2Nhc3Q8Tm9kZUxpc3RJbnZhbGlk YXRpb25UeXBlPih0eXBlKSwgKmF0dHJOYW1lKSkKLSAgICAgICAgICAgICAgICByZXR1cm4gdHJ1 ZTsKLSAgICAgICAgfQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgfQotCi0gICAgZm9yIChp bnQgdHlwZSA9IDA7IHR5cGUgPCBudW1Ob2RlTGlzdEludmFsaWRhdGlvblR5cGVzOyB0eXBlKysp IHsKLSAgICAgICAgaWYgKG1fbm9kZUxpc3RDb3VudHNbdHlwZV0pCi0gICAgICAgICAgICByZXR1 cm4gdHJ1ZTsKLSAgICB9Ci0KLSAgICByZXR1cm4gZmFsc2U7Ci19Ci0KLXZvaWQgRG9jdW1lbnQ6 OmludmFsaWRhdGVOb2RlTGlzdENhY2hlcyhjb25zdCBRdWFsaWZpZWROYW1lKiBhdHRyTmFtZSkK LXsKLSAgICBIYXNoU2V0PER5bmFtaWNOb2RlTGlzdENhY2hlQmFzZSo+OjppdGVyYXRvciBlbmQg PSBtX2xpc3RzSW52YWxpZGF0ZWRBdERvY3VtZW50LmVuZCgpOwotICAgIGZvciAoSGFzaFNldDxE eW5hbWljTm9kZUxpc3RDYWNoZUJhc2UqPjo6aXRlcmF0b3IgaXQgPSBtX2xpc3RzSW52YWxpZGF0 ZWRBdERvY3VtZW50LmJlZ2luKCk7IGl0ICE9IGVuZDsgKytpdCkKLSAgICAgICAgKCppdCktPmlu dmFsaWRhdGVDYWNoZShhdHRyTmFtZSk7Ci19Ci0KIHZvaWQgRG9jdW1lbnQ6OmF0dGFjaE5vZGVJ dGVyYXRvcihOb2RlSXRlcmF0b3IqIG5pKQogewogICAgIG1fbm9kZUl0ZXJhdG9ycy5hZGQobmkp OwpJbmRleDogU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAkocmV2aXNpb24gMTIzMTU4KQorKysgU291cmNlL1dlYkNv cmUvZG9tL05vZGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05NjIsNiArOTYyLDQwIEBAIHVuc2ln bmVkIE5vZGU6Om5vZGVJbmRleCgpIGNvbnN0CiAgICAgcmV0dXJuIGNvdW50OwogfQogCit0ZW1w bGF0ZTx1bnNpZ25lZCB0eXBlPgorYm9vbCBzaG91bGRJbnZhbGlkYXRlTm9kZUxpc3RDYWNoZXNG b3JBdHRyKGNvbnN0IHVuc2lnbmVkIG5vZGVMaXN0Q291bnRzW10sIGNvbnN0IFF1YWxpZmllZE5h bWUmIGF0dHJOYW1lKQoreworICAgIGlmIChub2RlTGlzdENvdW50c1t0eXBlXSAmJiBEeW5hbWlj Tm9kZUxpc3RDYWNoZUJhc2U6OnNob3VsZEludmFsaWRhdGVUeXBlT25BdHRyaWJ1dGVDaGFuZ2Uo c3RhdGljX2Nhc3Q8Tm9kZUxpc3RJbnZhbGlkYXRpb25UeXBlPih0eXBlKSwgYXR0ck5hbWUpKQor ICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICByZXR1cm4gc2hvdWxkSW52YWxpZGF0ZU5vZGVMaXN0 Q2FjaGVzRm9yQXR0cjx0eXBlICsgMT4obm9kZUxpc3RDb3VudHMsIGF0dHJOYW1lKTsKK30KKwor dGVtcGxhdGU8PgorYm9vbCBzaG91bGRJbnZhbGlkYXRlTm9kZUxpc3RDYWNoZXNGb3JBdHRyPG51 bU5vZGVMaXN0SW52YWxpZGF0aW9uVHlwZXM+KGNvbnN0IHVuc2lnbmVkW10sIGNvbnN0IFF1YWxp ZmllZE5hbWUmKQoreworICAgIHJldHVybiBmYWxzZTsKK30KKworYm9vbCBEb2N1bWVudDo6c2hv dWxkSW52YWxpZGF0ZU5vZGVMaXN0Q2FjaGVzKGNvbnN0IFF1YWxpZmllZE5hbWUqIGF0dHJOYW1l KSBjb25zdAoreworICAgIGlmIChhdHRyTmFtZSkKKyAgICAgICAgcmV0dXJuIHNob3VsZEludmFs aWRhdGVOb2RlTGlzdENhY2hlc0ZvckF0dHI8RG9Ob3RJbnZhbGlkYXRlT25BdHRyaWJ1dGVDaGFu Z2VzICsgMT4obV9ub2RlTGlzdENvdW50cywgKmF0dHJOYW1lKTsKKworICAgIGZvciAoaW50IHR5 cGUgPSAwOyB0eXBlIDwgbnVtTm9kZUxpc3RJbnZhbGlkYXRpb25UeXBlczsgdHlwZSsrKSB7Cisg ICAgICAgIGlmIChtX25vZGVMaXN0Q291bnRzW3R5cGVdKQorICAgICAgICAgICAgcmV0dXJuIHRy dWU7CisgICAgfQorCisgICAgcmV0dXJuIGZhbHNlOworfQorCit2b2lkIERvY3VtZW50OjppbnZh bGlkYXRlTm9kZUxpc3RDYWNoZXMoY29uc3QgUXVhbGlmaWVkTmFtZSogYXR0ck5hbWUpCit7Cisg ICAgSGFzaFNldDxEeW5hbWljTm9kZUxpc3RDYWNoZUJhc2UqPjo6aXRlcmF0b3IgZW5kID0gbV9s aXN0c0ludmFsaWRhdGVkQXREb2N1bWVudC5lbmQoKTsKKyAgICBmb3IgKEhhc2hTZXQ8RHluYW1p Y05vZGVMaXN0Q2FjaGVCYXNlKj46Oml0ZXJhdG9yIGl0ID0gbV9saXN0c0ludmFsaWRhdGVkQXRE b2N1bWVudC5iZWdpbigpOyBpdCAhPSBlbmQ7ICsraXQpCisgICAgICAgICgqaXQpLT5pbnZhbGlk YXRlQ2FjaGUoYXR0ck5hbWUpOworfQorCiB2b2lkIE5vZGU6OmludmFsaWRhdGVOb2RlTGlzdENh Y2hlc0luQW5jZXN0b3JzKGNvbnN0IFF1YWxpZmllZE5hbWUqIGF0dHJOYW1lLCBFbGVtZW50KiBh dHRyaWJ1dGVPd25lckVsZW1lbnQpCiB7CiAgICAgaWYgKGhhc1JhcmVEYXRhKCkgJiYgKCFhdHRy TmFtZSB8fCBpc0F0dHJpYnV0ZU5vZGUoKSkpCkBAIC05NzEsNyArMTAwNSw3IEBAIHZvaWQgTm9k ZTo6aW52YWxpZGF0ZU5vZGVMaXN0Q2FjaGVzSW5BbmMKICAgICBpZiAoYXR0ck5hbWUgJiYgIWF0 dHJpYnV0ZU93bmVyRWxlbWVudCkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYgKCFkb2N1bWVu dCgpLT5zaG91bGRJbnZhbGlkYXRlTm9kZUxpc3RDYWNoZXMoKSkKKyAgICBpZiAoIWRvY3VtZW50 KCktPnNob3VsZEludmFsaWRhdGVOb2RlTGlzdENhY2hlcyhhdHRyTmFtZSkpCiAgICAgICAgIHJl dHVybjsKIAogICAgIGRvY3VtZW50KCktPmludmFsaWRhdGVOb2RlTGlzdENhY2hlcyhhdHRyTmFt ZSk7Cg==