91796 2012-07-19 16:47:23 -0700 Fast path of storage resize should be removed from property storage reallocation, since it is only useful for arrays 2012-07-21 14:53:10 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 91788 1 fpizlo fpizlo barraclough ggaren mhahnenberg oliver oldest_to_newest 674061 0 fpizlo 2012-07-19 16:47:23 -0700 Patch forthcoming. 674068 1 153377 fpizlo 2012-07-19 16:50:19 -0700 Created attachment 153377 the patch 674085 2 153377 ggaren 2012-07-19 17:01:17 -0700 Comment on attachment 153377 the patch r=me 675272 3 fpizlo 2012-07-21 14:53:10 -0700 Landed in http://trac.webkit.org/changeset/123164 153377 2012-07-19 16:50:19 -0700 2012-07-19 17:01:17 -0700 the patch removehack_patch_1.diff text/plain 7175 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTIzMTYzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDEyLTA3LTE5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RmFzdCBwYXRoIG9mIHN0b3JhZ2UgcmVzaXplIHNob3VsZCBiZSByZW1vdmVkIGZyb20gcHJvcGVy dHkgc3RvcmFnZSByZWFsbG9jYXRpb24sIHNpbmNlIGl0IGlzIG9ubHkgdXNlZnVsIGZvciBhcnJh eXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNzk2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBkZmcv REZHUmVwYXRjaC5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6ZW1pdFB1dFRyYW5zaXRpb25TdHVi KToKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuY3BwOgorICAgICAgICAoSlNDOjpE Rkc6OlNwZWN1bGF0aXZlSklUOjpjb21waWxlUmVhbGxvY2F0ZVByb3BlcnR5U3RvcmFnZSk6Cisg ICAgICAgICogcnVudGltZS9KU09iamVjdC5jcHA6CisgICAgICAgIChKU0M6OkpTT2JqZWN0Ojpn cm93T3V0T2ZMaW5lU3RvcmFnZSk6CisKIDIwMTItMDctMTkgIE1hcmsgTGFtICA8bWFyay5sYW1A YXBwbGUuY29tPgogCiAgICAgICAgIEJ1ZyBmaXhlcyBhbmQgZW5oYW5jZW1lbnRzIGZvciBPZmZs aW5lQVNNIGFubm90YXRpb24gc3lzdGVtLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdSZXBhdGNoLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR1JlcGF0Y2guY3BwCShyZXZpc2lvbiAxMjMxNTYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvZGZnL0RGR1JlcGF0Y2guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MjksMjEgKzgyOSw4IEBA IHN0YXRpYyB2b2lkIGVtaXRQdXRUcmFuc2l0aW9uU3R1YigKICAgICAgICAgICAgIHNpemVfdCBv bGRTaXplID0gb2xkU3RydWN0dXJlLT5vdXRPZkxpbmVDYXBhY2l0eSgpICogc2l6ZW9mKEpTVmFs dWUpOwogICAgICAgICAgICAgQVNTRVJUKG5ld1NpemUgPiBvbGRTaXplKTsKICAgICAgICAgICAg IAotICAgICAgICAgICAgLy8gT3B0aW1pc3RpY2FsbHkgYXNzdW1lIHRoYXQgdGhlIG9sZCBzdG9y YWdlIHdhcyB0aGUgdmVyeSBsYXN0IHRoaW5nCi0gICAgICAgICAgICAvLyBhbGxvY2F0ZWQuCiAg ICAgICAgICAgICBzdHViSml0LmxvYWRQdHIoTWFjcm9Bc3NlbWJsZXI6OkFkZHJlc3MoYmFzZUdQ UiwgSlNPYmplY3Q6Om9mZnNldE9mT3V0T2ZMaW5lU3RvcmFnZSgpKSwgc2NyYXRjaEdQUjMpOwot ICAgICAgICAgICAgc3R1YkppdC5sb2FkUHRyKCZjb3BpZWRBbGxvY2F0b3ItPm1fY3VycmVudFBh eWxvYWRFbmQsIHNjcmF0Y2hHUFIyKTsKICAgICAgICAgICAgIHN0dWJKaXQubG9hZFB0cigmY29w aWVkQWxsb2NhdG9yLT5tX2N1cnJlbnRSZW1haW5pbmcsIHNjcmF0Y2hHUFIxKTsKLSAgICAgICAg ICAgIHN0dWJKaXQuc3ViUHRyKHNjcmF0Y2hHUFIxLCBzY3JhdGNoR1BSMik7Ci0gICAgICAgICAg ICBzdHViSml0LnN1YlB0cihNYWNyb0Fzc2VtYmxlcjo6VHJ1c3RlZEltbTMyKG9sZFNpemUpLCBz Y3JhdGNoR1BSMik7Ci0gICAgICAgICAgICBNYWNyb0Fzc2VtYmxlcjo6SnVtcCBuZWVkRnVsbFJl YWxsb2MgPQotICAgICAgICAgICAgICAgIHN0dWJKaXQuYnJhbmNoUHRyKE1hY3JvQXNzZW1ibGVy OjpOb3RFcXVhbCwgc2NyYXRjaEdQUjIsIHNjcmF0Y2hHUFIzKTsKLSAgICAgICAgICAgIHNsb3dQ YXRoLmFwcGVuZChzdHViSml0LmJyYW5jaFN1YlB0cihNYWNyb0Fzc2VtYmxlcjo6U2lnbmVkLCBN YWNyb0Fzc2VtYmxlcjo6VHJ1c3RlZEltbTMyKG5ld1NpemUgLSBvbGRTaXplKSwgc2NyYXRjaEdQ UjEpKTsKLSAgICAgICAgICAgIHN0dWJKaXQuc3RvcmVQdHIoc2NyYXRjaEdQUjEsICZjb3BpZWRB bGxvY2F0b3ItPm1fY3VycmVudFJlbWFpbmluZyk7Ci0gICAgICAgICAgICBzdHViSml0Lm1vdmUo c2NyYXRjaEdQUjIsIHNjcmF0Y2hHUFIxKTsKLSAgICAgICAgICAgIE1hY3JvQXNzZW1ibGVyOjpK dW1wIGRvbmVSZWFsbG9jID0gc3R1YkppdC5qdW1wKCk7Ci0gICAgICAgICAgICAKLSAgICAgICAg ICAgIG5lZWRGdWxsUmVhbGxvYy5saW5rKCZzdHViSml0KTsKICAgICAgICAgICAgIHNsb3dQYXRo LmFwcGVuZChzdHViSml0LmJyYW5jaFN1YlB0cihNYWNyb0Fzc2VtYmxlcjo6U2lnbmVkLCBNYWNy b0Fzc2VtYmxlcjo6VHJ1c3RlZEltbTMyKG5ld1NpemUpLCBzY3JhdGNoR1BSMSkpOwogICAgICAg ICAgICAgc3R1YkppdC5zdG9yZVB0cihzY3JhdGNoR1BSMSwgJmNvcGllZEFsbG9jYXRvci0+bV9j dXJyZW50UmVtYWluaW5nKTsKICAgICAgICAgICAgIHN0dWJKaXQubmVnUHRyKHNjcmF0Y2hHUFIx KTsKQEAgLTg1NCw4ICs4NDEsNiBAQCBzdGF0aWMgdm9pZCBlbWl0UHV0VHJhbnNpdGlvblN0dWIo CiAgICAgICAgICAgICAgICAgc3R1YkppdC5sb2FkUHRyKE1hY3JvQXNzZW1ibGVyOjpBZGRyZXNz KHNjcmF0Y2hHUFIzLCBvZmZzZXQpLCBzY3JhdGNoR1BSMik7CiAgICAgICAgICAgICAgICAgc3R1 YkppdC5zdG9yZVB0cihzY3JhdGNoR1BSMiwgTWFjcm9Bc3NlbWJsZXI6OkFkZHJlc3Moc2NyYXRj aEdQUjEsIG9mZnNldCkpOwogICAgICAgICAgICAgfQotICAgICAgICAgICAgCi0gICAgICAgICAg ICBkb25lUmVhbGxvYy5saW5rKCZzdHViSml0KTsKICAgICAgICAgfQogICAgICAgICAKICAgICAg ICAgc3R1YkppdC5zdG9yZVB0cihzY3JhdGNoR1BSMSwgTWFjcm9Bc3NlbWJsZXI6OkFkZHJlc3Mo YmFzZUdQUiwgSlNPYmplY3Q6Om9mZnNldE9mT3V0T2ZMaW5lU3RvcmFnZSgpKSk7CkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1bGF0aXZlSklULmNwcAkocmV2 aXNpb24gMTIzMTU2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2 ZUpJVC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMxNzcsMjYgKzMxNzcsMTUgQEAgdm9pZCBTcGVj dWxhdGl2ZUpJVDo6Y29tcGlsZVJlYWxsb2NhdGVQcgogICAgIEdQUlJlZyBzY3JhdGNoR1BSMSA9 IHNjcmF0Y2gxLmdwcigpOwogICAgIEdQUlJlZyBzY3JhdGNoR1BSMiA9IHNjcmF0Y2gyLmdwcigp OwogICAgICAgICAKLSAgICBKSVRDb21waWxlcjo6SnVtcExpc3Qgc2xvd1BhdGg7CisgICAgSklU Q29tcGlsZXI6Okp1bXAgc2xvd1BhdGg7CiAgICAgICAgIAogICAgIHNpemVfdCBvbGRTaXplID0g bm9kZS5zdHJ1Y3R1cmVUcmFuc2l0aW9uRGF0YSgpLnByZXZpb3VzU3RydWN0dXJlLT5vdXRPZkxp bmVDYXBhY2l0eSgpICogc2l6ZW9mKEpTVmFsdWUpOwogICAgIHNpemVfdCBuZXdTaXplID0gb2xk U2l6ZSAqIG91dE9mTGluZUdyb3d0aEZhY3RvcjsKICAgICBBU1NFUlQobmV3U2l6ZSA9PSBub2Rl LnN0cnVjdHVyZVRyYW5zaXRpb25EYXRhKCkubmV3U3RydWN0dXJlLT5vdXRPZkxpbmVDYXBhY2l0 eSgpICogc2l6ZW9mKEpTVmFsdWUpKTsKICAgICBDb3BpZWRBbGxvY2F0b3IqIGNvcGllZEFsbG9j YXRvciA9ICZtX2ppdC5nbG9iYWxEYXRhKCktPmhlYXAuc3RvcmFnZUFsbG9jYXRvcigpOwogICAg ICAgICAKLSAgICBtX2ppdC5sb2FkUHRyKCZjb3BpZWRBbGxvY2F0b3ItPm1fY3VycmVudFBheWxv YWRFbmQsIHNjcmF0Y2hHUFIxKTsKICAgICBtX2ppdC5sb2FkUHRyKCZjb3BpZWRBbGxvY2F0b3It Pm1fY3VycmVudFJlbWFpbmluZywgc2NyYXRjaEdQUjIpOwotICAgIG1faml0LnN1YlB0cihzY3Jh dGNoR1BSMiwgc2NyYXRjaEdQUjEpOwotICAgIG1faml0LnN1YlB0cihKSVRDb21waWxlcjo6VHJ1 c3RlZEltbTMyKG9sZFNpemUpLCBzY3JhdGNoR1BSMSk7Ci0gICAgSklUQ29tcGlsZXI6Okp1bXAg bmVlZEZ1bGxSZWFsbG9jID0gbV9qaXQuYnJhbmNoUHRyKEpJVENvbXBpbGVyOjpOb3RFcXVhbCwg c2NyYXRjaEdQUjEsIG9sZFN0b3JhZ2VHUFIpOwotICAgIAotICAgIHNsb3dQYXRoLmFwcGVuZCht X2ppdC5icmFuY2hTdWJQdHIoSklUQ29tcGlsZXI6OlNpZ25lZCwgSklUQ29tcGlsZXI6OlRydXN0 ZWRJbW0zMihuZXdTaXplIC0gb2xkU2l6ZSksIHNjcmF0Y2hHUFIyKSk7Ci0gICAgbV9qaXQuc3Rv cmVQdHIoc2NyYXRjaEdQUjIsICZjb3BpZWRBbGxvY2F0b3ItPm1fY3VycmVudFJlbWFpbmluZyk7 Ci0gICAgbV9qaXQubW92ZShvbGRTdG9yYWdlR1BSLCBzY3JhdGNoR1BSMik7Ci0gICAgSklUQ29t cGlsZXI6Okp1bXAgZG9uZVJlYWxsb2MgPSBtX2ppdC5qdW1wKCk7Ci0gICAgICAgIAotICAgIG5l ZWRGdWxsUmVhbGxvYy5saW5rKCZtX2ppdCk7Ci0gICAgc2xvd1BhdGguYXBwZW5kKG1faml0LmJy YW5jaFN1YlB0cihKSVRDb21waWxlcjo6U2lnbmVkLCBKSVRDb21waWxlcjo6VHJ1c3RlZEltbTMy KG5ld1NpemUpLCBzY3JhdGNoR1BSMikpOworICAgIHNsb3dQYXRoID0gbV9qaXQuYnJhbmNoU3Vi UHRyKEpJVENvbXBpbGVyOjpTaWduZWQsIEpJVENvbXBpbGVyOjpUcnVzdGVkSW1tMzIobmV3U2l6 ZSksIHNjcmF0Y2hHUFIyKTsKICAgICBtX2ppdC5zdG9yZVB0cihzY3JhdGNoR1BSMiwgJmNvcGll ZEFsbG9jYXRvci0+bV9jdXJyZW50UmVtYWluaW5nKTsKICAgICBtX2ppdC5uZWdQdHIoc2NyYXRj aEdQUjIpOwogICAgIG1faml0LmFkZFB0cihKSVRDb21waWxlcjo6QWJzb2x1dGVBZGRyZXNzKCZj b3BpZWRBbGxvY2F0b3ItPm1fY3VycmVudFBheWxvYWRFbmQpLCBzY3JhdGNoR1BSMik7CkBAIC0z MjEwLDkgKzMxOTksNyBAQCB2b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxlUmVhbGxvY2F0ZVBy CiAgICAgICAgIG1faml0LnN0b3JlUHRyKHNjcmF0Y2hHUFIxLCBKSVRDb21waWxlcjo6QWRkcmVz cyhzY3JhdGNoR1BSMiwgb2Zmc2V0KSk7CiAgICAgfQogICAgIG1faml0LnN0b3JlUHRyKHNjcmF0 Y2hHUFIyLCBKSVRDb21waWxlcjo6QWRkcmVzcyhiYXNlR1BSLCBKU09iamVjdDo6b2Zmc2V0T2ZP dXRPZkxpbmVTdG9yYWdlKCkpKTsKLSAgICAgICAgCi0gICAgZG9uZVJlYWxsb2MubGluaygmbV9q aXQpOwotICAgICAgICAKKyAgICAKICAgICBzdG9yYWdlUmVzdWx0KHNjcmF0Y2hHUFIyLCBtX2Nv bXBpbGVJbmRleCk7CiB9CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT T2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9K U09iamVjdC5jcHAJKHJldmlzaW9uIDEyMzE1NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTT2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTk5LDE5ICs1OTksMTMgQEAg UHJvcGVydHlTdG9yYWdlIEpTT2JqZWN0Ojpncm93T3V0T2ZMaW5lUwogICAgIFByb3BlcnR5U3Rv cmFnZSBvbGRQcm9wZXJ0eVN0b3JhZ2UgPSBtX291dE9mTGluZVN0b3JhZ2UuZ2V0KCk7CiAgICAg UHJvcGVydHlTdG9yYWdlIG5ld1Byb3BlcnR5U3RvcmFnZSA9IDA7CiAKLSAgICBpZiAoIW9sZFBy b3BlcnR5U3RvcmFnZSkgewotICAgICAgICAvLyBXZSBoYXZlIHRoaXMgZXh0cmEgdGVtcCBoZXJl IHRvIHNsYWtlIEdDQydzIHRoaXJzdCBmb3IgdGhlIGJsb29kIG9mIHRob3NlIHdobyBkZXJlZmVy ZW5jZSB0eXBlLXB1bm5lZCBwb2ludGVycy4KLSAgICAgICAgdm9pZCogdGVtcCA9IG5ld1Byb3Bl cnR5U3RvcmFnZTsKLSAgICAgICAgaWYgKCFnbG9iYWxEYXRhLmhlYXAudHJ5QWxsb2NhdGVTdG9y YWdlKHNpemVvZihXcml0ZUJhcnJpZXJCYXNlPFVua25vd24+KSAqIG5ld1NpemUsICZ0ZW1wKSkK LSAgICAgICAgICAgIENSQVNIKCk7Ci0gICAgICAgIG5ld1Byb3BlcnR5U3RvcmFnZSA9IHN0YXRp Y19jYXN0PFByb3BlcnR5U3RvcmFnZT4odGVtcCk7Ci0gICAgfSBlbHNlIHsKLSAgICAgICAgLy8g V2UgaGF2ZSB0aGlzIGV4dHJhIHRlbXAgaGVyZSB0byBzbGFrZSBHQ0MncyB0aGlyc3QgZm9yIHRo ZSBibG9vZCBvZiB0aG9zZSB3aG8gZGVyZWZlcmVuY2UgdHlwZS1wdW5uZWQgcG9pbnRlcnMuCi0g ICAgICAgIHZvaWQqIHRlbXAgPSBvbGRQcm9wZXJ0eVN0b3JhZ2U7Ci0gICAgICAgIGlmICghZ2xv YmFsRGF0YS5oZWFwLnRyeVJlYWxsb2NhdGVTdG9yYWdlKCZ0ZW1wLCBzaXplb2YoV3JpdGVCYXJy aWVyQmFzZTxVbmtub3duPikgKiBvbGRTaXplLCBzaXplb2YoV3JpdGVCYXJyaWVyQmFzZTxVbmtu b3duPikgKiBuZXdTaXplKSkKLSAgICAgICAgICAgIENSQVNIKCk7Ci0gICAgICAgIG5ld1Byb3Bl cnR5U3RvcmFnZSA9IHN0YXRpY19jYXN0PFByb3BlcnR5U3RvcmFnZT4odGVtcCk7Ci0gICAgfQor ICAgIC8vIFdlIGhhdmUgdGhpcyBleHRyYSB0ZW1wIGhlcmUgdG8gc2xha2UgR0NDJ3MgdGhpcnN0 IGZvciB0aGUgYmxvb2Qgb2YgdGhvc2Ugd2hvIGRlcmVmZXJlbmNlIHR5cGUtcHVubmVkIHBvaW50 ZXJzLgorICAgIHZvaWQqIHRlbXAgPSBuZXdQcm9wZXJ0eVN0b3JhZ2U7CisgICAgaWYgKCFnbG9i YWxEYXRhLmhlYXAudHJ5QWxsb2NhdGVTdG9yYWdlKHNpemVvZihXcml0ZUJhcnJpZXJCYXNlPFVu a25vd24+KSAqIG5ld1NpemUsICZ0ZW1wKSkKKyAgICAgICAgQ1JBU0goKTsKKyAgICBuZXdQcm9w ZXJ0eVN0b3JhZ2UgPSBzdGF0aWNfY2FzdDxQcm9wZXJ0eVN0b3JhZ2U+KHRlbXApOworICAgIAor ICAgIG1lbWNweShuZXdQcm9wZXJ0eVN0b3JhZ2UsIG9sZFByb3BlcnR5U3RvcmFnZSwgc2l6ZW9m KFdyaXRlQmFycmllckJhc2U8VW5rbm93bj4pICogb2xkU2l6ZSk7CiAKICAgICBBU1NFUlQobmV3 UHJvcGVydHlTdG9yYWdlKTsKICAgICByZXR1cm4gbmV3UHJvcGVydHlTdG9yYWdlOwo=