91780 2012-07-19 13:07:36 -0700 In flipped blocks writing modes, no flipping occurs when mapping RenderText’s local coordinates to absolute 2012-07-19 13:46:21 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mitz webkit-unassigned eric webkit.review.bot oldest_to_newest 673841 0 mitz 2012-07-19 13:07:36 -0700 In flipped blocks writing modes, RenderText::absoluteQuadsForRange returns incorrect results because the local coordinates don’t get flipped when mapped to absolute. 673842 1 mitz 2012-07-19 13:08:56 -0700 <rdar://problem/11915433> 673856 2 153332 mitz 2012-07-19 13:22:09 -0700 Created attachment 153332 Made RenderObject::mapLocalToContainer pass through the applyContainerFlip value if it doesn’t apply the flip itself 673883 3 mitz 2012-07-19 13:46:21 -0700 Fixed in <http://trac.webkit.org/r123146>. 153332 2012-07-19 13:22:09 -0700 2012-07-19 13:33:42 -0700 Made RenderObject::mapLocalToContainer pass through the applyContainerFlip value if it doesn’t apply the flip itself 91780_r1.diff text/plain 7249 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyMzE0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA3LTE5ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgSW4gZmxpcHBlZCBibG9ja3Mgd3Jp dGluZyBtb2Rlcywgbm8gZmxpcHBpbmcgb2NjdXJzIHdoZW4gbWFwcGluZyBSZW5kZXJUZXh04oCZ cyBsb2NhbCBjb29yZGluYXRlcyB0byBhYnNvbHV0ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE3ODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBmYXN0L3dyaXRpbmctbW9kZS9mbGlwcGVkLWJs b2Nrcy10ZXh0LW1hcC1sb2NhbC10by1jb250YWluZXIuaHRtbAorCisgICAgICAgIFdoZW4gUmVu ZGVyT2JqZWN0OjptYXBMb2NhbFRvQ29udGFpbmVyKCkgd2FzIGNhbGxlZCBvbiBhIFJlbmRlclRl eHQgd2l0aCBBcHBseUNvbnRhaW5lckZsaXAsCisgICAgICAgIGl0IHdvdWxkIG5vdCBmbGlwIChp ZiB0aGUgY29udGFpbmVyIHdhcyBub3QgYSBib3gpIGJ1dCBpdCB3b3VsZCBhbHdheXMgcGFzcwor ICAgICAgICBEb05vdEFwcGx5Q29udGFpbmVyRmxpcCB3aGVuIHJlY3VycmluZyB0byB0aGUgcGFy ZW50LiBUaGlzIG1lYW50IHRoYXQgbm8gb25lIGFwcGxpZWQgdGhlIGZsaXAuCisKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVySW5saW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlcklu bGluZTo6bWFwTG9jYWxUb0NvbnRhaW5lcik6IE1hZGUgdGhlIHNldHRpbmcgb2YgYXBwbHlDb250 YWluZXJGbGlwIHRvCisgICAgICAgIGZhbHNlIHVuY29uZGl0aW9uYWwgb24gdGhlIGNvbnRhaW5l ciBhY3R1YWxseSBiZWluZyBmbGlwcGVkLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJPYmpl Y3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyT2JqZWN0OjptYXBMb2NhbFRvQ29udGFp bmVyKTogUmF0aGVyIHRoYW4gYWx3YXlzIHBhc3NpbmcKKyAgICAgICAgRG9Ob3RBcHBseUNvbnRh aW5lckZsaXAgd2hlbiByZWN1cnJpbmcgdG8gdGhlIHBhcmVudCwgY2hhbmdlZCB0aGlzIGZ1bmN0 aW9uIHRvIHBhc3MgdGhyb3VnaAorICAgICAgICB0aGUgdmFsdWUgb2YgYXBwbHlDb250YWluZXJG bGlwIGl0IHdhcyBjYWxsZWQgd2l0aCwgdW5sZXNzIGl0IGFwcGxpZWQgdGhlIGZsaXAgaXRzZWxm LgorCiAyMDEyLTA3LTE5ICBNYXggRmVpbCAgPG1mZWlsQHJpbS5jb20+CiAKICAgICAgICAgW0Js YWNrQmVycnldIE9ubHkgbWFpbnRhaW4gdGhlIGhvbGUgcHVuY2ggcmVjdCB3aGlsZSBodG1sNSB2 aWRlbyBpcyBiZWluZyByZW5kZXJlcmVkCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVySW5saW5lLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVySW5saW5lLmNwcAkocmV2aXNpb24gMTIzMTE2KQorKysgU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlcklubGluZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExMzUsOSArMTEzNSwx MSBAQCB2b2lkIFJlbmRlcklubGluZTo6bWFwTG9jYWxUb0NvbnRhaW5lcihSCiAgICAgaWYgKCFv KQogICAgICAgICByZXR1cm47CiAKLSAgICBpZiAoYXBwbHlDb250YWluZXJGbGlwICYmIG8tPmlz Qm94KCkgJiYgby0+c3R5bGUoKS0+aXNGbGlwcGVkQmxvY2tzV3JpdGluZ01vZGUoKSkgewotICAg ICAgICBJbnRQb2ludCBjZW50ZXJQb2ludCA9IHJvdW5kZWRJbnRQb2ludCh0cmFuc2Zvcm1TdGF0 ZS5tYXBwZWRQb2ludCgpKTsKLSAgICAgICAgdHJhbnNmb3JtU3RhdGUubW92ZSh0b1JlbmRlckJv eChvKS0+ZmxpcEZvcldyaXRpbmdNb2RlSW5jbHVkaW5nQ29sdW1ucyhjZW50ZXJQb2ludCkgLSBj ZW50ZXJQb2ludCk7CisgICAgaWYgKGFwcGx5Q29udGFpbmVyRmxpcCAmJiBvLT5pc0JveCgpKSB7 CisgICAgICAgIGlmIChvLT5zdHlsZSgpLT5pc0ZsaXBwZWRCbG9ja3NXcml0aW5nTW9kZSgpKSB7 CisgICAgICAgICAgICBJbnRQb2ludCBjZW50ZXJQb2ludCA9IHJvdW5kZWRJbnRQb2ludCh0cmFu c2Zvcm1TdGF0ZS5tYXBwZWRQb2ludCgpKTsKKyAgICAgICAgICAgIHRyYW5zZm9ybVN0YXRlLm1v dmUodG9SZW5kZXJCb3gobyktPmZsaXBGb3JXcml0aW5nTW9kZUluY2x1ZGluZ0NvbHVtbnMoY2Vu dGVyUG9pbnQpIC0gY2VudGVyUG9pbnQpOworICAgICAgICB9CiAgICAgICAgIGFwcGx5Q29udGFp bmVyRmxpcCA9IERvTm90QXBwbHlDb250YWluZXJGbGlwOwogICAgIH0KIApJbmRleDogU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAJKHJldmlzaW9uIDEyMzExNikKKysr IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0xOTkzLDcgKzE5OTMsNyBAQCBGbG9hdFBvaW50IFJlbmRlck9iamVjdDo6YWJzb2x1dGVU b0xvY2FsCiAgICAgcmV0dXJuIHRyYW5zZm9ybVN0YXRlLmxhc3RQbGFuYXJQb2ludCgpOwogfQog Ci12b2lkIFJlbmRlck9iamVjdDo6bWFwTG9jYWxUb0NvbnRhaW5lcihSZW5kZXJCb3hNb2RlbE9i amVjdCogcmVwYWludENvbnRhaW5lciwgYm9vbCBmaXhlZCwgYm9vbCB1c2VUcmFuc2Zvcm1zLCBU cmFuc2Zvcm1TdGF0ZSYgdHJhbnNmb3JtU3RhdGUsIEFwcGx5Q29udGFpbmVyRmxpcE9yTm90LCBi b29sKiB3YXNGaXhlZCkgY29uc3QKK3ZvaWQgUmVuZGVyT2JqZWN0OjptYXBMb2NhbFRvQ29udGFp bmVyKFJlbmRlckJveE1vZGVsT2JqZWN0KiByZXBhaW50Q29udGFpbmVyLCBib29sIGZpeGVkLCBi b29sIHVzZVRyYW5zZm9ybXMsIFRyYW5zZm9ybVN0YXRlJiB0cmFuc2Zvcm1TdGF0ZSwgQXBwbHlD b250YWluZXJGbGlwT3JOb3QgYXBwbHlDb250YWluZXJGbGlwLCBib29sKiB3YXNGaXhlZCkgY29u c3QKIHsKICAgICBpZiAocmVwYWludENvbnRhaW5lciA9PSB0aGlzKQogICAgICAgICByZXR1cm47 CkBAIC0yMDA0LDggKzIwMDQsMTEgQEAgdm9pZCBSZW5kZXJPYmplY3Q6Om1hcExvY2FsVG9Db250 YWluZXIoUgogCiAgICAgLy8gRklYTUU6IHRoaXMgc2hvdWxkIGNhbGwgb2Zmc2V0RnJvbUNvbnRh aW5lciB0byBzaGFyZSBjb2RlLCBidXQgSSdtIG5vdCBzdXJlIGl0J3MgZXZlciBjYWxsZWQuCiAg ICAgTGF5b3V0UG9pbnQgY2VudGVyUG9pbnQgPSByb3VuZGVkTGF5b3V0UG9pbnQodHJhbnNmb3Jt U3RhdGUubWFwcGVkUG9pbnQoKSk7Ci0gICAgaWYgKG8tPmlzQm94KCkgJiYgby0+c3R5bGUoKS0+ aXNGbGlwcGVkQmxvY2tzV3JpdGluZ01vZGUoKSkKLSAgICAgICAgdHJhbnNmb3JtU3RhdGUubW92 ZSh0b1JlbmRlckJveChvKS0+ZmxpcEZvcldyaXRpbmdNb2RlSW5jbHVkaW5nQ29sdW1ucyhyb3Vu ZGVkTGF5b3V0UG9pbnQodHJhbnNmb3JtU3RhdGUubWFwcGVkUG9pbnQoKSkpIC0gY2VudGVyUG9p bnQpOworICAgIGlmIChhcHBseUNvbnRhaW5lckZsaXAgJiYgby0+aXNCb3goKSkgeworICAgICAg ICBpZiAoby0+c3R5bGUoKS0+aXNGbGlwcGVkQmxvY2tzV3JpdGluZ01vZGUoKSkKKyAgICAgICAg ICAgIHRyYW5zZm9ybVN0YXRlLm1vdmUodG9SZW5kZXJCb3gobyktPmZsaXBGb3JXcml0aW5nTW9k ZUluY2x1ZGluZ0NvbHVtbnMocm91bmRlZExheW91dFBvaW50KHRyYW5zZm9ybVN0YXRlLm1hcHBl ZFBvaW50KCkpKSAtIGNlbnRlclBvaW50KTsKKyAgICAgICAgYXBwbHlDb250YWluZXJGbGlwID0g RG9Ob3RBcHBseUNvbnRhaW5lckZsaXA7CisgICAgfQogCiAgICAgTGF5b3V0U2l6ZSBjb2x1bW5P ZmZzZXQ7CiAgICAgby0+YWRqdXN0Rm9yQ29sdW1ucyhjb2x1bW5PZmZzZXQsIHJvdW5kZWRMYXlv dXRQb2ludCh0cmFuc2Zvcm1TdGF0ZS5tYXBwZWRQb2ludCgpKSk7CkBAIC0yMDE1LDcgKzIwMTgs NyBAQCB2b2lkIFJlbmRlck9iamVjdDo6bWFwTG9jYWxUb0NvbnRhaW5lcihSCiAgICAgaWYgKG8t Pmhhc092ZXJmbG93Q2xpcCgpKQogICAgICAgICB0cmFuc2Zvcm1TdGF0ZS5tb3ZlKC10b1JlbmRl ckJveChvKS0+c2Nyb2xsZWRDb250ZW50T2Zmc2V0KCkpOwogCi0gICAgby0+bWFwTG9jYWxUb0Nv bnRhaW5lcihyZXBhaW50Q29udGFpbmVyLCBmaXhlZCwgdXNlVHJhbnNmb3JtcywgdHJhbnNmb3Jt U3RhdGUsIERvTm90QXBwbHlDb250YWluZXJGbGlwLCB3YXNGaXhlZCk7CisgICAgby0+bWFwTG9j YWxUb0NvbnRhaW5lcihyZXBhaW50Q29udGFpbmVyLCBmaXhlZCwgdXNlVHJhbnNmb3JtcywgdHJh bnNmb3JtU3RhdGUsIGFwcGx5Q29udGFpbmVyRmxpcCwgd2FzRml4ZWQpOwogfQogCiBjb25zdCBS ZW5kZXJPYmplY3QqIFJlbmRlck9iamVjdDo6cHVzaE1hcHBpbmdUb0NvbnRhaW5lcihjb25zdCBS ZW5kZXJCb3hNb2RlbE9iamVjdCogYW5jZXN0b3JUb1N0b3BBdCwgUmVuZGVyR2VvbWV0cnlNYXAm IGdlb21ldHJ5TWFwKSBjb25zdApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTIzMTQyKQorKysgTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDct MTkgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KKworICAgICAgICBJbiBmbGlwcGVk IGJsb2NrcyB3cml0aW5nIG1vZGVzLCBubyBmbGlwcGluZyBvY2N1cnMgd2hlbiBtYXBwaW5nIFJl bmRlclRleHTigJlzIGxvY2FsIGNvb3JkaW5hdGVzIHRvIGFic29sdXRlCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTc4MAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC93cml0aW5nLW1vZGUvZmxp cHBlZC1ibG9ja3MtdGV4dC1tYXAtbG9jYWwtdG8tY29udGFpbmVyLWV4cGVjdGVkLnR4dDogQWRk ZWQuCisgICAgICAgICogZmFzdC93cml0aW5nLW1vZGUvZmxpcHBlZC1ibG9ja3MtdGV4dC1tYXAt bG9jYWwtdG8tY29udGFpbmVyLmh0bWw6IEFkZGVkLgorCiAyMDEyLTA3LTE5ICBaYW4gRG9iZXJz ZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBHVEsgZ2Fy ZGVuaW5nLCBtYXJraW5nIHRocmVlIHN2Zy9XM0MtU1ZHLTEuMSB0ZXN0cyBhcyBmbGFreS4KSW5k ZXg6IExheW91dFRlc3RzL2Zhc3Qvd3JpdGluZy1tb2RlL2ZsaXBwZWQtYmxvY2tzLXRleHQtbWFw LWxvY2FsLXRvLWNvbnRhaW5lci1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvZmFzdC93cml0aW5nLW1vZGUvZmxpcHBlZC1ibG9ja3MtdGV4dC1tYXAtbG9jYWwtdG8tY29u dGFpbmVyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3Qvd3Jp dGluZy1tb2RlL2ZsaXBwZWQtYmxvY2tzLXRleHQtbWFwLWxvY2FsLXRvLWNvbnRhaW5lci1leHBl Y3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMiBAQAorTG9yZW0gaXBzdW0gZG9sb3Ig c2l0IGFtZXQgY29uc2VjdGV0dXIgYWRpcGlzY2luZyBlbGl0LgorUEFTUwpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC93cml0aW5nLW1vZGUvZmxpcHBlZC1ibG9ja3MtdGV4dC1tYXAtbG9jYWwtdG8t Y29udGFpbmVyLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC93cml0aW5nLW1v ZGUvZmxpcHBlZC1ibG9ja3MtdGV4dC1tYXAtbG9jYWwtdG8tY29udGFpbmVyLmh0bWwJKHJldmlz aW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L3dyaXRpbmctbW9kZS9mbGlwcGVkLWJsb2Nrcy10 ZXh0LW1hcC1sb2NhbC10by1jb250YWluZXIuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwy NCBAQAorPG1ldGEgbmFtZT12aWV3cG9ydCBjb250ZW50PSJ3aWR0aD1kZXZpY2Utd2lkdGgiPgor PGRpdiBzdHlsZT0iYm9yZGVyOiBzb2xpZDsgLXdlYmtpdC13cml0aW5nLW1vZGU6IGhvcml6b250 YWwtYnQ7IC13ZWJraXQtbG9naWNhbC13aWR0aDogMjAwcHg7IC13ZWJraXQtbG9naWNhbC1oZWln aHQ6IDQwMHB4OworICAgIGZvbnQtc2l6ZTogMzZweDsgbGluZS1oZWlnaHQ6IDI7CisiPgorICAg IExvcmVtIGlwc3VtIGRvbG9yIDxzcGFuIGlkPSJ0YXJnZXQiPnNpdDwvc3Bhbj4gYW1ldCBjb25z ZWN0ZXR1ciBhZGlwaXNjaW5nIGVsaXQuCis8L2Rpdj4KKzxwIGlkPSJyZXN1bHQiPgorICAgIEZB SUw6IFRlc3QgZGlkIG5vdCBydW4uCis8L3A+Cis8c2NyaXB0PgorICAgIGlmICh3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFz VGV4dCgpOworICAgIH0KKyAgICB2YXIgdGFyZ2V0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo InRhcmdldCIpOworICAgIHZhciByYW5nZSA9IGRvY3VtZW50LmNyZWF0ZVJhbmdlKCk7CisgICAg cmFuZ2Uuc2VsZWN0Tm9kZSh0YXJnZXQuZmlyc3RDaGlsZCk7CisgICAgdmFyIHRleHRUb3AgPSBy YW5nZS5nZXRDbGllbnRSZWN0cygpWzBdLnRvcDsKKyAgICByYW5nZS5zZWxlY3ROb2RlKHRhcmdl dCk7CisgICAgdmFyIHNwYW5Ub3AgPSByYW5nZS5nZXRDbGllbnRSZWN0cygpWzBdLnRvcDsKKyAg ICBpZiAoc3BhblRvcCA9PT0gdGV4dFRvcCkKKyAgICAgICAgcmVzdWx0LmlubmVyVGV4dCA9ICJQ QVNTIjsKKyAgICBlbHNlCisgICAgICAgIHJlc3VsdC5pbm5lclRleHQgID0gIkZBSUw6IFRleHQg dG9wIHdhcyAiICsgdGV4dFRvcCArICIgYnV0IGV4cGVjdGVkICIgKyBzcGFuVG9wICsgIi4iOwor PC9zY3JpcHQ+Cg==