91777 2012-07-19 12:49:36 -0700 Make style bot handle underscores in names more reasonably 2012-07-19 13:07:03 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver abarth dpranke levin ojan webkit.review.bot oldest_to_newest 673816 0 oliver 2012-07-19 12:49:36 -0700 Make style bot handle underscores in names more reasonably 673825 1 153326 oliver 2012-07-19 12:52:51 -0700 Created attachment 153326 Patch 673840 2 oliver 2012-07-19 13:07:03 -0700 Committed r123141: <http://trac.webkit.org/changeset/123141> 153326 2012-07-19 12:52:51 -0700 2012-07-19 13:04:11 -0700 Patch bug-91777-20120719125251.patch text/plain 5957 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMTMwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDgwMTkwNjBkYjBmNTRiNGQyZTQyNWU3NGRiZDRmZDEx N2RkN2U0Yy4uNjNmNzQyNWQ1ZWU3NGI5NjdlZTZjZDU1OTJmOWRlZmFhNDhkYjA5NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDEyLTA3LTE5ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisKKyAgICAg ICAgTWFrZSBzdHlsZSBib3QgaGFuZGxlIHVuZGVyc2NvcmVzIGluIG5hbWVzIG1vcmUgcmVhc29u YWJseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE3 NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlz IHBhdGNoIGFkZHMgYSBuYW1pbmcvcmVhZGFiaWxpdHkvdW5kZXJzY29yZXMgY2F0ZWdvcnkgZm9y IHN0eWxlIGVycm9ycy4KKyAgICAgICAgVGhhdCBhbGxvd3MgdXMgdG8gdXNlIHVuZGVyc2NvcmVz IGluIHRob3NlIHBvcnRpb25zIG9mIEpTQyAoYW5kIHBvdGVudGlhbGx5CisgICAgICAgIGd0az8p IHdpdGhvdXQgdHVybmluZyBvZmYgYWxsIG5hbWluZyBjaGVja3MgZm9yIHRoZSBlZmZlY3RlZCBk aXJlY3Rvcmllcy4KKyAgICAgICAgV2UgYWxzbyBmaWx0ZXIgb3V0IHRoZSBERkdfT1BFUkFUSU9O IHdhcm5pbmcsIGFuZCBhIGZldyBvdGhlciBtaW5vciBjaGFuZ2VzCisgICAgICAgIHRvIG1ha2Ug dGhlIHN0eWxlIGJvdCBsZXNzIG5vaXN5IHdoZW4gcnVubmluZyBvdmVyIEpTQyBhdCBsZWFzdC4K KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weToKKyAgICAgICAg KiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAgKGNoZWNr X2lkZW50aWZpZXJfbmFtZV9pbl9kZWNsYXJhdGlvbik6CisgICAgICAgIChDcHBDaGVja2VyKToK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5w eToKKyAgICAgICAgKFdlYktpdFN0eWxlVGVzdC50ZXN0X25hbWVzKToKKwogMjAxMi0wNy0xOSAg Sm9zaHVhIEJlbGwgIDxqc2JlbGxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJvbGwgb3V0IHIx MjE2MTAgYW5kIHIxMjI0ODcgd2hpY2ggbWF5IGhhdmUgYmVlbiBjYXVzaW5nIGZsYWt5IGNyYXNo ZXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weSBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlci5weQppbmRleCA4Y2Q4NzQ1YmZi ZWZjZmQ1YjBmYWI5ZjU5ODFjMTNkY2Y1NzQ0MjBiLi40MmFiNzE1ODliMDE4YzMzN2IxNDk2ZjIz NjliMGRiM2FiNmI0NmQ3IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxl L2NoZWNrZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2VyLnB5 CkBAIC0xNzgsOCArMTc4LDkgQEAgX1BBVEhfUlVMRVNfU1BFQ0lGSUVSID0gWwogICAgICBbIi1i dWlsZC9oZWFkZXJfZ3VhcmQiXSksCiAgICAgKFsjIGFzc2VtYmxlciBoYXMgbG90cyBvZiBvcGNv ZGVzIHRoYXQgdXNlIHVuZGVyc2NvcmVzLCBzbwogICAgICAgIyB3ZSBkb24ndCBjaGVjayBmb3Ig dW5kZXJzY29yZXMgaW4gdGhhdCBkaXJlY3RvcnkuCi0gICAgICAiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9hc3NlbWJsZXIvIl0sCi0gICAgIFsiLXJlYWRhYmlsaXR5L25hbWluZyJdKSwKKyAgICAg ICJTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyLyIsCisgICAgICAiU291cmNlL0phdmFT Y3JpcHRDb3JlL2ppdC9KSVQiXSwKKyAgICAgWyItcmVhZGFiaWxpdHkvbmFtaW5nL3VuZGVyc2Nv cmVzIl0pLAogICAgIChbIyBKSVRTdHVicyBoYXMgYW4gdXN1YWwgc3ludGF4IHdoaWNoIGNhdXNl cyBmYWxzZSBhbGFybXMgZm9yIGEgZmV3IGNoZWNrcy4KICAgICAgICJKYXZhU2NyaXB0Q29yZS9q aXQvSklUU3R1YnMuY3BwIl0sCiAgICAgIFsiLXJlYWRhYmlsaXR5L3BhcmFtZXRlcl9uYW1lIiwK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5 IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkKaW5kZXggYmEx MTUzMDg3YTQzZTFhMjQwNDM5YzgwNmZmZTk1ZjI2OWM1NjNlNy4uNzhjZDg4MjUwMzBiOTE2OTM4 NzMxZWE3ZDUwODRmMmUzYTcxNmNkMiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHAucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHls ZS9jaGVja2Vycy9jcHAucHkKQEAgLTMxMzcsMTEgKzMxMzcsMTMgQEAgZGVmIGNoZWNrX2lkZW50 aWZpZXJfbmFtZV9pbl9kZWNsYXJhdGlvbihmaWxlbmFtZSwgbGluZV9udW1iZXIsIGxpbmUsIGZp bGVfc3RhdGUKICAgICAgICAgICAgICAgICBhbmQgbm90IG1vZGlmaWVkX2lkZW50aWZpZXIuc3Rh cnRzd2l0aCgnRWluYV8nKQogICAgICAgICAgICAgICAgIGFuZCBub3QgbW9kaWZpZWRfaWRlbnRp Zmllci5zdGFydHN3aXRoKCdFdmFzXycpCiAgICAgICAgICAgICAgICAgYW5kIG5vdCBtb2RpZmll ZF9pZGVudGlmaWVyLnN0YXJ0c3dpdGgoJ0V3a18nKQorICAgICAgICAgICAgICAgIGFuZCBub3Qg bW9kaWZpZWRfaWRlbnRpZmllci5zdGFydHN3aXRoKCdjdGlfJykKICAgICAgICAgICAgICAgICBh bmQgbm90IG1vZGlmaWVkX2lkZW50aWZpZXIuZmluZCgnOjpxdF8nKSA+PSAwCiAgICAgICAgICAg ICAgICAgYW5kIG5vdCBtb2RpZmllZF9pZGVudGlmaWVyLmZpbmQoJzo6X3FfJykgPj0gMAogICAg ICAgICAgICAgICAgIGFuZCBub3QgbW9kaWZpZWRfaWRlbnRpZmllciA9PSAiY29uc3RfaXRlcmF0 b3IiCi0gICAgICAgICAgICAgICAgYW5kIG5vdCBtb2RpZmllZF9pZGVudGlmaWVyID09ICJ2bV90 aHJvdyIpOgotICAgICAgICAgICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAncmVhZGFiaWxpdHkv bmFtaW5nJywgNCwgaWRlbnRpZmllciArICIgaXMgaW5jb3JyZWN0bHkgbmFtZWQuIERvbid0IHVz ZSB1bmRlcnNjb3JlcyBpbiB5b3VyIGlkZW50aWZpZXIgbmFtZXMuIikKKyAgICAgICAgICAgICAg ICBhbmQgbm90IG1vZGlmaWVkX2lkZW50aWZpZXIgPT0gInZtX3Rocm93IgorICAgICAgICAgICAg ICAgIGFuZCBub3QgbW9kaWZpZWRfaWRlbnRpZmllciA9PSAiREZHX09QRVJBVElPTiIpOgorICAg ICAgICAgICAgICAgIGVycm9yKGxpbmVfbnVtYmVyLCAncmVhZGFiaWxpdHkvbmFtaW5nL3VuZGVy c2NvcmVzJywgNCwgaWRlbnRpZmllciArICIgaXMgaW5jb3JyZWN0bHkgbmFtZWQuIERvbid0IHVz ZSB1bmRlcnNjb3JlcyBpbiB5b3VyIGlkZW50aWZpZXIgbmFtZXMuIikKIAogICAgICAgICAjIENo ZWNrIGZvciB2YXJpYWJsZXMgbmFtZWQgJ2wnLCB0aGVzZSBhcmUgdG9vIGVhc3kgdG8gY29uZnVz ZSB3aXRoICcxJyBpbiBzb21lIGZvbnRzCiAgICAgICAgIGlmIG1vZGlmaWVkX2lkZW50aWZpZXIg PT0gJ2wnOgpAQCAtMzU2NCw2ICszNTY2LDcgQEAgY2xhc3MgQ3BwQ2hlY2tlcihvYmplY3QpOgog ICAgICAgICAncmVhZGFiaWxpdHkvbXVsdGlsaW5lX3N0cmluZycsCiAgICAgICAgICdyZWFkYWJp bGl0eS9wYXJhbWV0ZXJfbmFtZScsCiAgICAgICAgICdyZWFkYWJpbGl0eS9uYW1pbmcnLAorICAg ICAgICAncmVhZGFiaWxpdHkvbmFtaW5nL3VuZGVyc2NvcmVzJywKICAgICAgICAgJ3JlYWRhYmls aXR5L251bGwnLAogICAgICAgICAncmVhZGFiaWxpdHkvcGFzc19wdHInLAogICAgICAgICAncmVh ZGFiaWxpdHkvc3RyZWFtcycsCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5 bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5CmluZGV4IDE2NzVjNzAxMDg0MGIwYTJkZmIxM2I5 ZjRjNzdiM2U2M2EwZmQxMjAuLjMzOTg5N2ZlODVjOTA3NzQ1MjgxM2QwNDcxZjhkMWZmOGIxOTZj OTkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3Bw X3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMv Y3BwX3VuaXR0ZXN0LnB5CkBAIC00NDI1LDcgKzQ0MjUsNyBAQCBjbGFzcyBXZWJLaXRTdHlsZVRl c3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAgICAgICAnZm9vLmNwcCcpCiAKICAgICBkZWYg dGVzdF9uYW1lcyhzZWxmKToKLSAgICAgICAgbmFtZV91bmRlcnNjb3JlX2Vycm9yX21lc3NhZ2Ug PSAiIGlzIGluY29ycmVjdGx5IG5hbWVkLiBEb24ndCB1c2UgdW5kZXJzY29yZXMgaW4geW91ciBp ZGVudGlmaWVyIG5hbWVzLiAgW3JlYWRhYmlsaXR5L25hbWluZ10gWzRdIgorICAgICAgICBuYW1l X3VuZGVyc2NvcmVfZXJyb3JfbWVzc2FnZSA9ICIgaXMgaW5jb3JyZWN0bHkgbmFtZWQuIERvbid0 IHVzZSB1bmRlcnNjb3JlcyBpbiB5b3VyIGlkZW50aWZpZXIgbmFtZXMuICBbcmVhZGFiaWxpdHkv bmFtaW5nL3VuZGVyc2NvcmVzXSBbNF0iCiAgICAgICAgIG5hbWVfdG9vc2hvcnRfZXJyb3JfbWVz c2FnZSA9ICIgaXMgaW5jb3JyZWN0bHkgbmFtZWQuIERvbid0IHVzZSB0aGUgc2luZ2xlIGxldHRl ciAnbCcgYXMgYW4gaWRlbnRpZmllciBuYW1lLiAgW3JlYWRhYmlsaXR5L25hbWluZ10gWzRdIgog CiAgICAgICAgICMgQmFzaWMgY2FzZXMgZnJvbSBXZWJLaXQgc3R5bGUgZ3VpZGUuCkBAIC00NTY5 LDExICs0NTY5LDExIEBAIGNsYXNzIFdlYktpdFN0eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToK ICAgICAgICAgIyBUZXN0IHRoYXQgdGhpcyBkb2Vzbid0IGFsc28gYXBwbHkgdG8gZmlsZXMgbm90 IGluIGEgJ2d0aycgZGlyZWN0b3J5LgogICAgICAgICBzZWxmLmFzc2VydF9saW50KCd2b2lkIHdl YmtpdF93ZWJfdmlld19sb2FkKGludCB2YXIxLCBpbnQgdmFyMiknLAogICAgICAgICAgICAgJ3dl YmtpdF93ZWJfdmlld19sb2FkIGlzIGluY29ycmVjdGx5IG5hbWVkLiBEb25cJ3QgdXNlIHVuZGVy c2NvcmVzIGluIHlvdXIgaWRlbnRpZmllciBuYW1lcy4nCi0gICAgICAgICAgICAnICBbcmVhZGFi aWxpdHkvbmFtaW5nXSBbNF0nLCAnU291cmNlL1dlYmtpdC93ZWJraXQvZm9vLmNwcCcpCisgICAg ICAgICAgICAnICBbcmVhZGFiaWxpdHkvbmFtaW5nL3VuZGVyc2NvcmVzXSBbNF0nLCAnU291cmNl L1dlYmtpdC93ZWJraXQvZm9vLmNwcCcpCiAgICAgICAgICMgVGVzdCB0aGF0IHRoaXMgZG9lc24n dCBhbHNvIGFwcGx5IHRvIG5hbWVzIHRoYXQgZG9uJ3Qgc3RhcnQgd2l0aCAnd2Via2l0XycuCiAg ICAgICAgIHNlbGYuYXNzZXJ0X2xpbnRfb25lX29mX21hbnlfZXJyb3JzX3JlKCd2b2lkIG90aGVy a2l0X3dlYl92aWV3X2xvYWQoaW50IHZhcjEsIGludCB2YXIyKScsCiAgICAgICAgICAgICAnb3Ro ZXJraXRfd2ViX3ZpZXdfbG9hZCBpcyBpbmNvcnJlY3RseSBuYW1lZC4gRG9uXCd0IHVzZSB1bmRl cnNjb3JlcyBpbiB5b3VyIGlkZW50aWZpZXIgbmFtZXMuJwotICAgICAgICAgICAgJyAgW3JlYWRh YmlsaXR5L25hbWluZ10gWzRdJywgJ1NvdXJjZS9XZWJraXQvd2Via2l0L2Zvby5jcHAnKQorICAg ICAgICAgICAgJyAgW3JlYWRhYmlsaXR5L25hbWluZy91bmRlcnNjb3Jlc10gWzRdJywgJ1NvdXJj ZS9XZWJraXQvd2Via2l0L2Zvby5jcHAnKQogCiAgICAgICAgICMgVGhlcmUgaXMgYW4gZXhjZXB0 aW9uIGZvciBzb21lIHVuaXQgdGVzdHMgdGhhdCBiZWdpbiB3aXRoICJ0c3RfIi4KICAgICAgICAg c2VsZi5hc3NlcnRfbGludCgndm9pZCB0c3RfUVdlYkZyYW1lOjphcnJheU9iamVjdEVudW1lcmFi bGUoaW50IHZhcjEsIGludCB2YXIyKScsICcnKQo=