91760 2012-07-19 10:52:06 -0700 [CSS Exclusions] - Code cleanup: make shape parsing use isComma() instead of manual checks 2012-07-19 12:32:44 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://dev.w3.org/csswg/css3-exclusions/#shape-inside-property P3 Trivial --- 1 bjonesbe bjonesbe cmarcelo macpherson menard webkit.review.bot oldest_to_newest 673670 0 bjonesbe 2012-07-19 10:52:06 -0700 The CSSParser::parseExclusionShapePolygon method uses an isComma() function to detect a comma when parsing the argument list. The other shape parsing methods are not using this function. To reduce code duplication and make the code easier to read, those methods (CSSParser::parseExclusionShapeEllipse, CSSParser::parseExclusionShapeCircle, CSSParser::parseExclusionShapeRectangle) should use the isComma() function. 673751 1 153318 bjonesbe 2012-07-19 11:56:40 -0700 Created attachment 153318 Bug fix Change the aforementioned methods to use isComma. 673776 2 153318 eric 2012-07-19 12:20:10 -0700 Comment on attachment 153318 Bug fix OK. 673787 3 153318 webkit.review.bot 2012-07-19 12:32:40 -0700 Comment on attachment 153318 Bug fix Clearing flags on attachment: 153318 Committed r123135: <http://trac.webkit.org/changeset/123135> 673788 4 webkit.review.bot 2012-07-19 12:32:44 -0700 All reviewed patches have been landed. Closing bug. 153318 2012-07-19 11:56:40 -0700 2012-07-19 12:32:40 -0700 Bug fix 91760.patch text/plain 2212 bjonesbe ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1NDYxZWJlLi4xZmQ4ZDhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTItMDctMTkgIEJlbSBKb25lcy1CZXkgIDxiam9uZXNiZUBhZG9iZS5jb20+CisKKyAg ICAgICAgW0NTUyBFeGNsdXNpb25zXSAtIENvZGUgY2xlYW51cDogbWFrZSBzaGFwZSBwYXJzaW5n IHVzZSBpc0NvbW1hKCkgaW5zdGVhZCBvZiBtYW51YWwgY2hlY2tzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTc2MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBjb2RlIGR1cGxpY2F0aW9uIGJ5 IG1ha2luZyB0aGUgcmVjdGFuZ2xlLCBjaXJjbGUsIGFuZCBlbGxpcHNlCisgICAgICAgIG1ldGhv ZHMgdXNlIGlzQ29tbWEoKSB0byBkZXRlY3QgYSBjb21tYS4KKworICAgICAgICBObyBuZXcgdGVz dHMgbmVlZGVkOiBubyBuZXcgZnVuY3Rpb25hbGl0eSBhZGRlZC4KKworICAgICAgICAqIGNzcy9D U1NQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpwYXJzZUV4Y2x1c2lv blNoYXBlUmVjdGFuZ2xlKToKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6cGFyc2VFeGNs dXNpb25TaGFwZUNpcmNsZSk6CisgICAgICAgIChXZWJDb3JlOjpDU1NQYXJzZXI6OnBhcnNlRXhj bHVzaW9uU2hhcGVFbGxpcHNlKToKKwogMjAxMi0wNy0xNCAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0 QHdlYmtpdC5vcmc+CiAKICAgICAgICAgQ1NTIDIuMSBmYWlsdXJlOiB0ZXh0LWluZGVudC1pbnRy aW5zaWMtMDAzIGZhaWxzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2Vy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCmluZGV4IDY0MGFmMDIuLjRi ZDk3NzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCkBAIC00NDkyLDcgKzQ0OTIsNyBAQCBQ YXNzUmVmUHRyPENTU1dyYXBTaGFwZT4gQ1NTUGFyc2VyOjpwYXJzZUV4Y2x1c2lvblNoYXBlUmVj dGFuZ2xlKENTU1BhcnNlclZhbHVlTAogICAgICAgICB9CiAgICAgICAgIGFyZ3VtZW50ID0gYXJn cy0+bmV4dCgpOwogICAgICAgICBpZiAoYXJndW1lbnQpIHsKLSAgICAgICAgICAgIGlmIChhcmd1 bWVudC0+dW5pdCAhPSBDU1NQYXJzZXJWYWx1ZTo6T3BlcmF0b3IgfHwgYXJndW1lbnQtPmlWYWx1 ZSAhPSAnLCcpCisgICAgICAgICAgICBpZiAoIWlzQ29tbWEoYXJndW1lbnQpKQogICAgICAgICAg ICAgICAgIHJldHVybiAwOwogCiAgICAgICAgICAgICBhcmd1bWVudCA9IGFyZ3MtPm5leHQoKTsK QEAgLTQ1MzcsNyArNDUzNyw3IEBAIFBhc3NSZWZQdHI8Q1NTV3JhcFNoYXBlPiBDU1NQYXJzZXI6 OnBhcnNlRXhjbHVzaW9uU2hhcGVDaXJjbGUoQ1NTUGFyc2VyVmFsdWVMaXN0CiAKICAgICAgICAg YXJndW1lbnQgPSBhcmdzLT5uZXh0KCk7CiAgICAgICAgIGlmIChhcmd1bWVudCkgewotICAgICAg ICAgICAgaWYgKGFyZ3VtZW50LT51bml0ICE9IENTU1BhcnNlclZhbHVlOjpPcGVyYXRvciB8fCBh cmd1bWVudC0+aVZhbHVlICE9ICcsJykKKyAgICAgICAgICAgIGlmICghaXNDb21tYShhcmd1bWVu dCkpCiAgICAgICAgICAgICAgICAgcmV0dXJuIDA7CiAgICAgICAgICAgICBhcmd1bWVudCA9IGFy Z3MtPm5leHQoKTsKICAgICAgICAgfQpAQCAtNDU4Myw3ICs0NTgzLDcgQEAgUGFzc1JlZlB0cjxD U1NXcmFwU2hhcGU+IENTU1BhcnNlcjo6cGFyc2VFeGNsdXNpb25TaGFwZUVsbGlwc2UoQ1NTUGFy c2VyVmFsdWVMaXMKIAogICAgICAgICBhcmd1bWVudCA9IGFyZ3MtPm5leHQoKTsKICAgICAgICAg aWYgKGFyZ3VtZW50KSB7Ci0gICAgICAgICAgICBpZiAoYXJndW1lbnQtPnVuaXQgIT0gQ1NTUGFy c2VyVmFsdWU6Ok9wZXJhdG9yIHx8IGFyZ3VtZW50LT5pVmFsdWUgIT0gJywnKQorICAgICAgICAg ICAgaWYgKCFpc0NvbW1hKGFyZ3VtZW50KSkKICAgICAgICAgICAgICAgICByZXR1cm4gMDsKICAg ICAgICAgICAgIGFyZ3VtZW50ID0gYXJncy0+bmV4dCgpOwogICAgICAgICB9Cg==