91758 2012-07-19 10:40:16 -0700 CodeGeneratorInspector.py is unnecessarily chatty 2012-07-20 10:56:32 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 adamk adamk prybin thakis vsevik webkit.review.bot yurys oldest_to_newest 673652 0 adamk 2012-07-19 10:40:16 -0700 CodeGeneratorInspector.py is unnecessarily chatty 673655 1 153300 adamk 2012-07-19 10:42:46 -0700 Created attachment 153300 Patch 673882 2 prybin 2012-07-19 13:43:59 -0700 The reason behind this message was to compensate over-simplified build rule. The generator has 7 output files and those files are written conditionally. Before writing output, generator tries to open destination file and does nothing, if the file already has correct content. This enables correct incremental build when generator is involved. Since generator may or may not actually write its output even on build bot, the message to system.out is added. I meant those messages to help track possible errors on the build bots (i.e. I see them meaningful). On the other hand I'm fine with deleting them if it's the right thing to do. 673908 3 adamk 2012-07-19 14:29:22 -0700 (In reply to comment #2) > I meant those messages to help track possible errors on the build bots (i.e. I see them meaningful). > On the other hand I'm fine with deleting them if it's the right thing to do. Do you see these messages as a short-term thing to make sure the code generator works (I see a previous version of this change was rolled out)? If so, I'm fine with leaving them for a bit (say, a week or two) and then removing them. If you think they should always be emitted on the bots, then we'd want a different solution. 673913 4 prybin 2012-07-19 14:35:55 -0700 (In reply to comment #3) > (In reply to comment #2) > > I meant those messages to help track possible errors on the build bots (i.e. I see them meaningful). > > On the other hand I'm fine with deleting them if it's the right thing to do. > > Do you see these messages as a short-term thing to make sure the code generator works (I see a previous version of this change was rolled out)? If so, I'm fine with leaving them for a bit (say, a week or two) and then removing them. If you think they should always be emitted on the bots, then we'd want a different solution. I meant them to be permanent, cause I thought that 1 line per file is fair and is what build normally does, and 7 more doesn't change a lot. Again, I'm fine with removing them. I believe that that change proved to be okay, so the excessive output could be removed at any moment. 673915 5 adamk 2012-07-19 14:39:10 -0700 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > I meant those messages to help track possible errors on the build bots (i.e. I see them meaningful). > > > On the other hand I'm fine with deleting them if it's the right thing to do. > > > > Do you see these messages as a short-term thing to make sure the code generator works (I see a previous version of this change was rolled out)? If so, I'm fine with leaving them for a bit (say, a week or two) and then removing them. If you think they should always be emitted on the bots, then we'd want a different solution. > > I meant them to be permanent, cause I thought that 1 line per file is fair and is what build normally does, and 7 more doesn't change a lot. As I note in the ChangeLog, it's probably only noticeable when building with ninja, but there it's quite noisy (since ninja puts all build output besides errors on a single line). 674034 6 prybin 2012-07-19 16:23:47 -0700 LGTM 674663 7 thakis 2012-07-20 10:01:09 -0700 Thanks! 674725 8 153300 webkit.review.bot 2012-07-20 10:56:29 -0700 Comment on attachment 153300 Patch Clearing flags on attachment: 153300 Committed r123233: <http://trac.webkit.org/changeset/123233> 674726 9 webkit.review.bot 2012-07-20 10:56:32 -0700 All reviewed patches have been landed. Closing bug. 153300 2012-07-19 10:42:46 -0700 2012-07-20 10:56:29 -0700 Patch bug-91758-20120719104245.patch text/plain 1727 adamk U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2JhYTIwNzY3NjczNzRm NGI0MjU5MWU4NDMzMDlkZjM5NDBiOTc1NC4uNDM5ZDY5ODYyMjgwMDA4MWMzYjU0ZDA5OTk5M2Q1 NWNkOTk3ZGQ3NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA3LTE5ICBBZGFt IEtsZWluICA8YWRhbWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENvZGVHZW5lcmF0b3JJbnNw ZWN0b3IucHkgaXMgdW5uZWNlc3NhcmlseSBjaGF0dHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNzU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNvZGUgYWRlZCBpbiByMTIzMDkxIGluY2x1ZGVk IGEgInByaW50IiBzdGF0ZW1lbnQgZm9yIGVhY2ggd3JpdHRlbgorICAgICAgICBmaWxlLiBUaGlz IG1ha2VzIGZvciBub2lzeSBidWlsZCBvdXRwdXQsIGVzcGVjaWFsbHkgbm90aWNlYWJsZSBpbiB0 aGUKKyAgICAgICAgQ2hyb21pdW0gbmluamEgYnVpbGQgKHdoZXJlIGJ1aWxkIG91dHB1dCB0YWtl cyB1cCBhIHNpbmdsZSBsaW5lIG9mIHRoZQorICAgICAgICBjb25zb2xlKS4KKworICAgICAgICBJ ZiB0aGlzIHByaW50IHN0YXRlbWVudCBpcyBnZW5lcmFsbHkgdXNlZnVsLCBpdCBzaG91bGQgYmUK KyAgICAgICAgaGlkZGVuIGJlaGluZCBhIC0tdmVyYm9zZSBjb21tYW5kbGluZSBvcHRpb24sIGFz IHdlIGRvIGZvciB0aGUgYmluZGluZworICAgICAgICBnZW5lcmF0b3JzLgorCisgICAgICAgICog aW5zcGVjdG9yL0NvZGVHZW5lcmF0b3JJbnNwZWN0b3IucHk6CisgICAgICAgIChTbWFydE91dHB1 dC5jbG9zZSk6IFJlbW92ZSBwcmludCBzdGF0ZW1lbnQuCisKIDIwMTItMDctMTkgIFNjb3R0IEdy YWhhbSAgPHNjb3R0bWdAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVzZSBuYXRpdmUgKG5vbi1j eWd3aW4pIGJpbmFyaWVzIGZvciBwZXJsLCBncGVyZiwgYW5kIGJpc29uIGluIENocm9taXVtCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29kZUdlbmVyYXRvckluc3BlY3Rv ci5weSBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9Db2RlR2VuZXJhdG9ySW5zcGVjdG9yLnB5 CmluZGV4IGMyODEyYjYyMTFmMzc4OWQ5NmRjYWQyOWVjYTIyZTc0OGI0YjQxMTAuLmVjMzgxMmIx NmZiNzI4ZmUxN2YwZWExMjY3NmQ4MmQ4Y2IxOWM5ZWIgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9Db2RlR2VuZXJhdG9ySW5zcGVjdG9yLnB5CisrKyBiL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9Db2RlR2VuZXJhdG9ySW5zcGVjdG9yLnB5CkBAIC0yOTc1LDcgKzI5NzUs NiBAQCBjbGFzcyBTbWFydE91dHB1dDoKICAgICAgICAgICAgIHBhc3MKIAogICAgICAgICBpZiB0 ZXh0X2NoYW5nZWQ6Ci0gICAgICAgICAgICBwcmludCAiICAgIHdyaXRpbmcgIiArIHNlbGYuZmls ZV9uYW1lXwogICAgICAgICAgICAgb3V0X2ZpbGUgPSBvcGVuKHNlbGYuZmlsZV9uYW1lXywgInci KQogICAgICAgICAgICAgb3V0X2ZpbGUud3JpdGUoc2VsZi5vdXRwdXRfKQogICAgICAgICAgICAg b3V0X2ZpbGUuY2xvc2UoKQo=