91752 2012-07-19 09:16:20 -0700 [chromium][Mac] Switch the MACOSX_DEPLOYMENT_TARGET to 10.6 2019-05-02 16:22:42 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified OS X 10.6 RESOLVED FIXED http://code.google.com/p/chromium/issues/detail?id=137676 P2 Normal --- 1 rsesek rsesek eric mark mcrobertg7 playmobil rniwa tony webkit.review.bot oldest_to_newest 673567 0 rsesek 2012-07-19 09:16:20 -0700 Downstream Chromium has just changed its build SDK from 10.5 to 10.6, which required no changes. However changing the deployment target from 10.5 to 10.6 generates some -Wdeprecated-declaration warnings that are converted to errors. This bug will track fixing those. 673598 1 153282 rsesek 2012-07-19 09:51:28 -0700 Created attachment 153282 ATSUI,v1 673617 2 153287 rsesek 2012-07-19 10:08:31 -0700 Created attachment 153287 ColorSpaceWarnings,v1 673618 3 rsesek 2012-07-19 10:10:12 -0700 Jeremy: Please review ATSUI,v1 patch to disable ATSUI support on Chromium WebKit. This should not be needed now that downstream does not support 10.5. Mark: Please review ColorSpaceWarnings,v1 to disable #pragmas for a deprecated symbol for which there is no replacement. 673972 4 153282 eric 2012-07-19 15:23:23 -0700 Comment on attachment 153282 ATSUI,v1 Great! Won't we need to update our pixel results? 673973 5 eric 2012-07-19 15:23:40 -0700 You should probably CC the current gardener. 673975 6 153287 eric 2012-07-19 15:24:41 -0700 Comment on attachment 153287 ColorSpaceWarnings,v1 What does the Mac port do? Why don't they run into this? 674025 7 rsesek 2012-07-19 16:15:10 -0700 (In reply to comment #6) > (From update of attachment 153287 [details]) > What does the Mac port do? Why don't they run into this? As far as I could find, they don't have an equivalent to WebKit::WebScreenInfo.isMonochrome implemented on Mac. 674030 8 rsesek 2012-07-19 16:20:00 -0700 (In reply to comment #4) > (From update of attachment 153282 [details]) > Great! Won't we need to update our pixel results? I don't *think* so because only 10.5 should have been using the ATSUI path, and we shouldn't have any testers on 10.5 anymore. I think 10.6 and above would all be using CoreText for font layout. I tried running locally, but I'm on 10.8 now so it's hard to tell if any of the pixel tests are wrong because they changed the subpixel rendering in this version. 674047 9 153282 webkit.review.bot 2012-07-19 16:32:16 -0700 Comment on attachment 153282 ATSUI,v1 Clearing flags on attachment: 153282 Committed r123161: <http://trac.webkit.org/changeset/123161> 674065 10 153287 eric 2012-07-19 16:49:10 -0700 Comment on attachment 153287 ColorSpaceWarnings,v1 It seems CGGetColorSpaceModel is your replacement: https://developer.apple.com/library/mac/#documentation/graphicsimaging/reference/CGColorSpace/Reference/reference.html At least that's what a quick search lead me to. 674066 11 eric 2012-07-19 16:49:41 -0700 CGColorSpaceGetModel, rather. 674146 12 eric 2012-07-19 21:34:58 -0700 You'll have to upload again, your attachment was lost during the window with the failed migration. 674593 13 153509 rsesek 2012-07-20 08:29:53 -0700 Created attachment 153509 ColorSpaceWarnings,v2 674926 14 153509 eric 2012-07-20 13:48:27 -0700 Comment on attachment 153509 ColorSpaceWarnings,v2 Do we need to wrap this all in some sort of exception safely? since this is obj-c in c++? I know we do similar things in WebKit Mac. 674931 15 rsesek 2012-07-20 13:51:04 -0700 No, this doesn't throw ObjC exceptions, which also are different than C++ exceptions. 674943 16 153509 webkit.review.bot 2012-07-20 14:01:46 -0700 Comment on attachment 153509 ColorSpaceWarnings,v2 Clearing flags on attachment: 153509 Committed r123256: <http://trac.webkit.org/changeset/123256> 674944 17 webkit.review.bot 2012-07-20 14:01:50 -0700 All reviewed patches have been landed. Closing bug. 675302 18 playmobil 2012-07-22 04:18:53 -0700 Robert: Thanks for looking into this!! Do you want to file another bug for the ATSUI removal or reopen this one? Are there any other ports that still use ATSUI? (Looks like there aren't, but we probably want to check with Mitz). If not then it'd probably be good to just get rid of all the code and the flag entirely. 677836 19 playmobil 2012-07-25 02:33:39 -0700 For future reference, mitz obsolted ATSUI in r123181 . 153282 2012-07-19 09:51:28 -0700 2012-07-19 16:32:16 -0700 ATSUI,v1 bug-91752-20120719125127.patch text/plain 1096 rsesek U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMDA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDA3NzU2MmFiZjI3NmVhNGQxYjI3OWM4 MWI1OTliNWQ5YzZjMTM2OWQuLjNiNjliN2VjMDc2MjU1Y2M3ZDNmZDY1NGIyMGQyNTIwZmVlYjFj NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDctMTkgIFJvYmVydCBTZXNlayAgPHJzZXNl a0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXVtNYWNdIFN3aXRjaCB0aGUgTUFD T1NYX0RFUExPWU1FTlRfVEFSR0VUIHRvIDEwLjYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNzUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgV2hlbiBidWlsZGluZyBDSFJPTUlVTSAmJiBEQVJXSU4sIGRv IG5vdCBlbmFibGUgQVRTVUkgc3VwcG9ydC4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgor CiAyMDEyLTA3LTE4ICBSb2IgQnVpcyAgPHJidWlzQHJpbS5jb20+CiAKICAgICAgICAgQWxpZ25t ZW50IGNyYXNoIGluIE1JTUVTbmlmZmVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0 Zm9ybS5oIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAppbmRleCBjMTdmM2UxYmMxZTFlYjdm YzkyZTY2YzVmNGYzZDdiNjQ4YWI1ZWU4Li43NzgwYTI4OTBjODBlNmUzNjdjODgyMTU4NDEyMmFl YWQ0ZTUwMjVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCisrKyBiL1Nv dXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKQEAgLTQ2Niw3ICs0NjYsNyBAQAogI2lmIFBMQVRGT1JN KENIUk9NSVVNKQogI2lmIE9TKERBUldJTikKICNkZWZpbmUgV1RGX1VTRV9TS0lBIDEKLSNkZWZp bmUgV1RGX1VTRV9BVFNVSSAxCisjZGVmaW5lIFdURl9VU0VfQVRTVUkgMAogI2RlZmluZSBXVEZf VVNFX0NPUkVfVEVYVCAxCiAjZGVmaW5lIFdURl9VU0VfSUNDSlBFRyAxCiAjZGVmaW5lIFdURl9V U0VfUUNNU0xJQiAxCg== 153287 2012-07-19 10:08:31 -0700 2012-07-20 08:30:18 -0700 ColorSpaceWarnings,v1 bug-91752-20120719130830.patch text/plain 2136 rsesek U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMDA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGRmYjc2ZDk0NzdjYmNlMDkxYWZiM2RjYzQ5NzI4YmEyMjcyMzk3OTYuLjBmMTdhZWI5YmRmZDc5 ZTM2MmM0YjljNGFhNWFiOTMyZWMzNWU0MzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDctMTkgIFJvYmVydCBTZXNlayAgPHJzZXNla0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXVtNYWNdIFN3aXRjaCB0aGUgTUFDT1NYX0RFUExP WU1FTlRfVEFSR0VUIHRvIDEwLjYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTkxNzUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV3JhcCByZWZlcmVuY2VzIHRvIE5Te0NhbGlicmF0ZWQsRGV2aWNlfUJsYWNr Q29sb3JTcGFjZSBpbiAjcHJhZ21hIHRvCisgICAgICAgIGRpc2FibGUgV2RlcHJlY2F0ZWQtZGVj bGFyYXRpb25zIHdhcm5pbmdzLgorCisgICAgICAgICogc3JjL21hYy9XZWJTY3JlZW5JbmZvRmFj dG9yeS5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViU2NyZWVuSW5mb0ZhY3Rvcnk6OnNjcmVlbklu Zm8pOgorCiAyMDEyLTA3LTE4ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgW2Nocm9taXVtXSBVbnJldmlld2VkLCBtb3JlIGNvbXBpbGUgZml4ZXMgb24gQ2hyb21p dW0gV2luLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvbWFjL1dlYlNj cmVlbkluZm9GYWN0b3J5Lm1tIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvbWFjL1dlYlNj cmVlbkluZm9GYWN0b3J5Lm1tCmluZGV4IDg4YzNiNzJlNTNhMDk3ZWM4MjI0MTlmMTc0YjkzZWJi NTVmMDg5NjMuLjI4MGVhNDMyNWExOTYxMGJkZTA0YmUyYjc4ZWRkMTE4OGQ4NTAxN2QgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL21hYy9XZWJTY3JlZW5JbmZvRmFjdG9y eS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9tYWMvV2ViU2NyZWVuSW5mb0Zh Y3RvcnkubW0KQEAgLTEwMywxMCArMTAzLDE0IEBAIFdlYlNjcmVlbkluZm8gV2ViU2NyZWVuSW5m b0ZhY3Rvcnk6OnNjcmVlbkluZm8oTlNWaWV3KiB2aWV3KQogICAgICAgICBOU0JpdHNQZXJQaXhl bEZyb21EZXB0aChbW05TU2NyZWVuIGRlZXBlc3RTY3JlZW5dIGRlcHRoXSk7CiAgICAgcmVzdWx0 cy5kZXB0aFBlckNvbXBvbmVudCA9CiAgICAgICAgIE5TQml0c1BlclNhbXBsZUZyb21EZXB0aChb W05TU2NyZWVuIGRlZXBlc3RTY3JlZW5dIGRlcHRoXSk7CisvLyBBcHBsZSBoYXMgZGVwcmVjYXRl ZCB0aGUgQmxhY2tDb2xvclNwYWNlIGJ1dCBkaWQgbm90IHByb3ZpZGUgYSByZXBsYWNlbWVudC4K KyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwdXNoCisjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMg aWdub3JlZCAiLVdkZXByZWNhdGVkLWRlY2xhcmF0aW9ucyIKICAgICByZXN1bHRzLmlzTW9ub2No cm9tZSA9IGNvbG9yU3BhY2UgPT0gTlNDYWxpYnJhdGVkV2hpdGVDb2xvclNwYWNlCiAgICAgICAg ICAgICAgICAgICAgICAgICB8fCBjb2xvclNwYWNlID09IE5TQ2FsaWJyYXRlZEJsYWNrQ29sb3JT cGFjZQogICAgICAgICAgICAgICAgICAgICAgICAgfHwgY29sb3JTcGFjZSA9PSBOU0RldmljZVdo aXRlQ29sb3JTcGFjZQogICAgICAgICAgICAgICAgICAgICAgICAgfHwgY29sb3JTcGFjZSA9PSBO U0RldmljZUJsYWNrQ29sb3JTcGFjZTsKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwb3AKICAg ICByZXN1bHRzLnJlY3QgPSBjb252ZXJ0UmVjdChbc2NyZWVuRm9yV2luZG93KFt2aWV3IHdpbmRv d10pIGZyYW1lXSwgW3ZpZXcgd2luZG93XSk7CiAgICAgcmVzdWx0cy5hdmFpbGFibGVSZWN0ID0K ICAgICAgICAgY29udmVydFJlY3QoW3NjcmVlbkZvcldpbmRvdyhbdmlldyB3aW5kb3ddKSB2aXNp YmxlRnJhbWVdLCBbdmlldyB3aW5kb3ddKTsK 153509 2012-07-20 08:29:53 -0700 2012-07-20 14:01:45 -0700 ColorSpaceWarnings,v2 bug-91752-20120720112949.patch text/plain 2636 rsesek U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDVmZDZjNmJiYjc5NThmOGU3N2ExYWFmYjQxNjY1MWE5NzNiMzA0MGIuLmY5MzM0ZGE2NDBkOGI5 MjM2MGIwZGJhYzA3NmNjYTQ2MWY2NzUxMjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDctMTkgIFJvYmVydCBTZXNlayAgPHJzZXNla0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXVtNYWNdIFN3aXRjaCB0aGUgTUFDT1NYX0RFUExP WU1FTlRfVEFSR0VUIHRvIDEwLjYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTkxNzUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVXNlIDEwLjYgTlNTY3JlZW4vTlNDb2xvclNwYWNlIEFQSXMgdG8gZGV0ZXJt aW5lIGlmIHRoZSBzY3JlZW4gaXMKKyAgICAgICAgbW9ub2Nocm9tZSByYXRoZXIgdGhhbiBjb21w YXJpbmcgYWdhaW5zdCBkZXByZWNhdGVkIGNvbG9yc3BhY2UgbmFtZXMuCisKKyAgICAgICAgKiBz cmMvbWFjL1dlYlNjcmVlbkluZm9GYWN0b3J5Lm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJTY3Jl ZW5JbmZvRmFjdG9yeTo6c2NyZWVuSW5mbyk6CisKIDIwMTItMDctMTkgIEFkYW0gQmFydGggIDxh YmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBbQ2hyb21pdW1dIFdlYlZpZXcgaXMgbWlzc2lu ZyBpc1NlbGVjdGlvbkVkaXRhYmxlIGFuZCBiYWNrZ3JvdW5kQ29sb3Igd2hpY2ggYXJlIHVzZWQg YnkgY2hyb21pdW0tYW5kcm9pZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvbWFjL1dlYlNjcmVlbkluZm9GYWN0b3J5Lm1tIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvbWFjL1dlYlNjcmVlbkluZm9GYWN0b3J5Lm1tCmluZGV4IDg4YzNiNzJlNTNhMDk3ZWM4MjI0 MTlmMTc0YjkzZWJiNTVmMDg5NjMuLmYyNDZiY2YyYzczMjJhMTkxZmJkNTIwMmQxYWQ5ODNhNzFh YmJhMzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL21hYy9XZWJTY3Jl ZW5JbmZvRmFjdG9yeS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9tYWMvV2Vi U2NyZWVuSW5mb0ZhY3RvcnkubW0KQEAgLTkxLDcgKzkxLDcgQEAgc3RhdGljIGZsb2F0IGRldmlj ZVNjYWxlRmFjdG9yKE5TVmlldyogdmlldykKIAogV2ViU2NyZWVuSW5mbyBXZWJTY3JlZW5JbmZv RmFjdG9yeTo6c2NyZWVuSW5mbyhOU1ZpZXcqIHZpZXcpCiB7Ci0gICAgTlNTdHJpbmcgKmNvbG9y U3BhY2UgPSBOU0NvbG9yU3BhY2VGcm9tRGVwdGgoW1tOU1NjcmVlbiBkZWVwZXN0U2NyZWVuXSBk ZXB0aF0pOworICAgIE5TU2NyZWVuKiBzY3JlZW4gPSBbTlNTY3JlZW4gZGVlcGVzdFNjcmVlbl07 CiAKICAgICBXZWJTY3JlZW5JbmZvIHJlc3VsdHM7CiAKQEAgLTk5LDE0ICs5OSwxMCBAQCBXZWJT Y3JlZW5JbmZvIFdlYlNjcmVlbkluZm9GYWN0b3J5OjpzY3JlZW5JbmZvKE5TVmlldyogdmlldykK ICAgICByZXN1bHRzLmhvcml6b250YWxEUEkgPSBkZXZpY2VEUEk7CiAgICAgcmVzdWx0cy52ZXJ0 aWNhbERQSSA9IGRldmljZURQSTsKIAotICAgIHJlc3VsdHMuZGVwdGggPQotICAgICAgICBOU0Jp dHNQZXJQaXhlbEZyb21EZXB0aChbW05TU2NyZWVuIGRlZXBlc3RTY3JlZW5dIGRlcHRoXSk7Ci0g ICAgcmVzdWx0cy5kZXB0aFBlckNvbXBvbmVudCA9Ci0gICAgICAgIE5TQml0c1BlclNhbXBsZUZy b21EZXB0aChbW05TU2NyZWVuIGRlZXBlc3RTY3JlZW5dIGRlcHRoXSk7Ci0gICAgcmVzdWx0cy5p c01vbm9jaHJvbWUgPSBjb2xvclNwYWNlID09IE5TQ2FsaWJyYXRlZFdoaXRlQ29sb3JTcGFjZQot ICAgICAgICAgICAgICAgICAgICAgICAgfHwgY29sb3JTcGFjZSA9PSBOU0NhbGlicmF0ZWRCbGFj a0NvbG9yU3BhY2UKLSAgICAgICAgICAgICAgICAgICAgICAgIHx8IGNvbG9yU3BhY2UgPT0gTlNE ZXZpY2VXaGl0ZUNvbG9yU3BhY2UKLSAgICAgICAgICAgICAgICAgICAgICAgIHx8IGNvbG9yU3Bh Y2UgPT0gTlNEZXZpY2VCbGFja0NvbG9yU3BhY2U7CisgICAgcmVzdWx0cy5kZXB0aCA9IE5TQml0 c1BlclBpeGVsRnJvbURlcHRoKFtzY3JlZW4gZGVwdGhdKTsKKyAgICByZXN1bHRzLmRlcHRoUGVy Q29tcG9uZW50ID0gTlNCaXRzUGVyU2FtcGxlRnJvbURlcHRoKFtzY3JlZW4gZGVwdGhdKTsKKyAg ICByZXN1bHRzLmlzTW9ub2Nocm9tZSA9CisgICAgICAgIFtbc2NyZWVuIGNvbG9yU3BhY2VdIGNv bG9yU3BhY2VNb2RlbF0gPT0gTlNHcmF5Q29sb3JTcGFjZU1vZGVsOwogICAgIHJlc3VsdHMucmVj dCA9IGNvbnZlcnRSZWN0KFtzY3JlZW5Gb3JXaW5kb3coW3ZpZXcgd2luZG93XSkgZnJhbWVdLCBb dmlldyB3aW5kb3ddKTsKICAgICByZXN1bHRzLmF2YWlsYWJsZVJlY3QgPQogICAgICAgICBjb252 ZXJ0UmVjdChbc2NyZWVuRm9yV2luZG93KFt2aWV3IHdpbmRvd10pIHZpc2libGVGcmFtZV0sIFt2 aWV3IHdpbmRvd10pOwo=