91745 2012-07-19 08:05:25 -0700 [WTR] Add *explicit* keyword to constructor which has a parameter 2012-07-20 00:48:39 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gyuyoung.kim gyuyoung.kim webkit.review.bot oldest_to_newest 673518 0 gyuyoung.kim 2012-07-19 08:05:25 -0700 Add *explicit* keyword to contructor which has a parameter in order to avoid implicit type conversion. 673519 1 153266 gyuyoung.kim 2012-07-19 08:07:35 -0700 Created attachment 153266 Patch 673528 2 153266 cdumez 2012-07-19 08:27:47 -0700 Comment on attachment 153266 Patch LGTM. 674286 3 153266 webkit.review.bot 2012-07-20 00:48:35 -0700 Comment on attachment 153266 Patch Clearing flags on attachment: 153266 Committed r123189: <http://trac.webkit.org/changeset/123189> 674287 4 webkit.review.bot 2012-07-20 00:48:39 -0700 All reviewed patches have been landed. Closing bug. 153266 2012-07-19 08:07:35 -0700 2012-07-20 00:48:34 -0700 Patch bug-91745-20120720000704.patch text/plain 2016 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyOTYzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDgxMTZiZTQxZDFjYTRmZmVlMTNjNDkzNmVmZjgyMDhh NTdhMTVkYS4uYzVhNzhjOWEwMDY1OWU5ZDc3N2ZjM2Y5MjZhNGIxNDA2NmViNDc5ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDEyLTA3LTE5ICBHeXV5b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+ CisKKyAgICAgICAgW1dUUl0gQWRkICpleHBsaWNpdCoga2V5d29yZCB0byBjb25zdHJ1Y3RvciB3 aGljaCBoYXMgYSBwYXJhbWV0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTkxNzQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkICpleHBsaWNpdCoga2V5d29yZCB0byBjb250cnVjdG9yIHdoaWNoIGhh cyBhIHBhcmFtZXRlciBpbiBvcmRlciB0byBhdm9pZCBpbXBsaWNpdCB0eXBlIGNvbnZlcnNpb24u CisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0V2ZW50U2VuZGVyUHJveHkuaDoKKyAgICAg ICAgKEV2ZW50U2VuZGVyUHJveHkpOgorICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIvVGVzdElu dm9jYXRpb24uaDoKKyAgICAgICAgKFRlc3RJbnZvY2F0aW9uKToKKwogMjAxMi0wNy0xOCAgVGhp YWdvIE1hcmNvcyBQLiBTYW50b3MgIDx0aGlhZ28uc2FudG9zQGludGVsLmNvbT4KIAogICAgICAg ICBbQ01ha2VdW0VGTF0gQnVpbGRpbmcganNjIGNhdXNlcyByZWNvbmZpZ3VyYXRpb24KZGlmZiAt LWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvRXZlbnRTZW5kZXJQcm94eS5oIGIvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9FdmVudFNlbmRlclByb3h5LmgKaW5kZXggODE2ODUxMzE5MGY2OTRh ZjQ1YWUwZjdiNDZjZDQ5ZjA3ZjdmMjkzNS4uNTgzMzc2ODA5NjY0NDViOTkyZjRhNTg3ZTUyNGE5 ZmJmMTg3YjhkOCAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9FdmVudFNlbmRl clByb3h5LmgKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9FdmVudFNlbmRlclByb3h5LmgK QEAgLTQ1LDcgKzQ1LDcgQEAgc3RydWN0IFdUUkV2ZW50UXVldWVJdGVtOwogCiBjbGFzcyBFdmVu dFNlbmRlclByb3h5IHsKIHB1YmxpYzoKLSAgICBFdmVudFNlbmRlclByb3h5KFRlc3RDb250cm9s bGVyKik7CisgICAgZXhwbGljaXQgRXZlbnRTZW5kZXJQcm94eShUZXN0Q29udHJvbGxlciopOwog CiAgICAgdm9pZCBtb3VzZURvd24odW5zaWduZWQgYnV0dG9uLCBXS0V2ZW50TW9kaWZpZXJzKTsK ICAgICB2b2lkIG1vdXNlVXAodW5zaWduZWQgYnV0dG9uLCBXS0V2ZW50TW9kaWZpZXJzKTsKZGlm ZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvVGVzdEludm9jYXRpb24uaCBiL1Rvb2xz L1dlYktpdFRlc3RSdW5uZXIvVGVzdEludm9jYXRpb24uaAppbmRleCA5MTY1MjA1ZTMxZWFjMzc0 MWIxNmY2Yzg3ZmRiYTA1NDk2MGQwZDlkLi4xMWUxMzViNTUzYjhmNWEwMGFkNTFlNzgxYzYzMTI1 NDUyNzk0MjNiIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RJbnZvY2F0 aW9uLmgKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9UZXN0SW52b2NhdGlvbi5oCkBAIC0z NSw3ICszNSw3IEBAIG5hbWVzcGFjZSBXVFIgewogY2xhc3MgVGVzdEludm9jYXRpb24gewogICAg IFdURl9NQUtFX05PTkNPUFlBQkxFKFRlc3RJbnZvY2F0aW9uKTsKIHB1YmxpYzoKLSAgICBUZXN0 SW52b2NhdGlvbihjb25zdCBzdGQ6OnN0cmluZyYgcGF0aE9yVVJMKTsKKyAgICBleHBsaWNpdCBU ZXN0SW52b2NhdGlvbihjb25zdCBzdGQ6OnN0cmluZyYgcGF0aE9yVVJMKTsKICAgICB+VGVzdElu dm9jYXRpb24oKTsKIAogICAgIHZvaWQgc2V0SXNQaXhlbFRlc3QoY29uc3Qgc3RkOjpzdHJpbmcm IGV4cGVjdGVkUGl4ZWxIYXNoKTsK