91733 2012-07-19 04:38:52 -0700 Destroy CSS decoded data more eagerly once they become dead caches. 2012-07-25 22:10:40 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 92332 0 dongseong.hwang webkit-unassigned ggaren japhet jochen koivisto sam skyul webkit.review.bot oldest_to_newest 673386 0 dongseong.hwang 2012-07-19 04:38:52 -0700 There are three CachedResources with decoded data: CachedImage, CachedScript and CachedCSSStyleSheet. In the cases of CachedImage and CachedScript, we eagerly destroy the decoded data using Timer in CacehdResource::allClientsRemoved(). We must apply the same policy here in CachedCSSStyleSheet because priority inversion can occur. For example, we can't destroy the decoded data of CachedImages when they are referenced by CachedCSSStyleSheet as background, mask or border images. 673388 1 153228 dongseong.hwang 2012-07-19 04:40:59 -0700 Created attachment 153228 Patch 673389 2 dongseong.hwang 2012-07-19 04:45:12 -0700 Bug 22394 made CacheScript destroy script decoded data eagerly. Bug 22214 made the policy of CachedCSSStyleSheet::allClientsRemoved() and the policy continues to this day. 673698 3 153228 ggaren 2012-07-19 11:08:21 -0700 Comment on attachment 153228 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153228&action=review > Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp:172 > + makePurgeable(true); Where is the makePurgeable(false) call to balance this? That's a good thing to comment on in your ChangeLog. 675396 4 dongseong.hwang 2012-07-22 19:05:13 -0700 (In reply to comment #3) > (From update of attachment 153228 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=153228&action=review > > > Source/WebCore/loader/cache/CachedCSSStyleSheet.cpp:172 > > + makePurgeable(true); > > Where is the makePurgeable(false) call to balance this? That's a good thing to comment on in your ChangeLog. Thank you for your review. makePurgeable(false) is called by MemoryCache::resourceForURL() and DocumentLoader::subresource() like CachedImage and CachedScript. CachedImage and CachedScript call only makePurgeable(true) instead of makePurgeable(false), too. IMHO, "makePurgeable(false) call" may be not related to this patch because the previous CachedCSSStyleSheet did not call makePurgeable(false) and CachedCSSStyleSheet of this patch does also. 675826 5 153228 ggaren 2012-07-23 11:00:32 -0700 Comment on attachment 153228 Patch In future, I'd like to see more code sharing for destroying decoded data on a timer. 676015 6 153228 skyul 2012-07-23 14:38:21 -0700 Comment on attachment 153228 Patch Clearing flags on attachment: 153228 Committed r123385: <http://trac.webkit.org/changeset/123385> 676016 7 skyul 2012-07-23 14:38:26 -0700 All reviewed patches have been landed. Closing bug. 676146 8 dongseong.hwang 2012-07-23 16:23:36 -0700 (In reply to comment #5) > (From update of attachment 153228 [details]) > In future, I'd like to see more code sharing for destroying decoded data on a timer. Thank you for your review. I think so. :) 153228 2012-07-19 04:40:59 -0700 2012-07-23 14:38:20 -0700 Patch bug-91733-20120719204057.patch text/plain 5005 dongseong.hwang U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMDU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjdjNTkwZTlmZGNlNWUz YzkxNTkyY2U4YjZhZWNhOGRjNDU1OTM1Zi4uN2MyZThiN2M1NzIxODVhN2U2ZjhkYjg3ZDE1OWE5 NjliZGY1NWI4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEyLTA3LTE5ICBIdWFu ZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIERlc3Ryb3kg Q1NTIGRlY29kZWQgZGF0YSBtb3JlIGVhZ2VybHkgb25jZSB0aGV5IGJlY29tZSBkZWFkIGNhY2hl cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNzMz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW50ZXJu YWwgcmV2aWV3IGJ5IEt3YW5nIFl1bCBTZW8uCisKKyAgICAgICAgVGhlcmUgYXJlIHRocmVlIENh Y2hlZFJlc291cmNlcyB3aXRoIGRlY29kZWQgZGF0YTogQ2FjaGVkSW1hZ2UsIENhY2hlZFNjcmlw dAorICAgICAgICBhbmQgQ2FjaGVkQ1NTU3R5bGVTaGVldC4gSW4gdGhlIGNhc2VzIG9mIENhY2hl ZEltYWdlIGFuZCBDYWNoZWRTY3JpcHQsIHdlCisgICAgICAgIGVhZ2VybHkgZGVzdHJveSB0aGUg ZGVjb2RlZCBkYXRhIHVzaW5nIFRpbWVyIGluIENhY2VoZFJlc291cmNlOjphbGxDbGllbnRzUmVt b3ZlZCgpLgorICAgICAgICBXZSBtdXN0IGFwcGx5IHRoZSBzYW1lIHBvbGljeSBoZXJlIGluIENh Y2hlZENTU1N0eWxlU2hlZXQgYmVjYXVzZSBwcmlvcml0eQorICAgICAgICBpbnZlcnNpb24gY2Fu IG9jY3VyLiBGb3IgZXhhbXBsZSwgd2UgY2FuJ3QgZGVzdHJveSB0aGUgZGVjb2RlZCBkYXRhIG9m IENhY2hlZEltYWdlcworICAgICAgICB3aGVuIHRoZXkgYXJlIHJlZmVyZW5jZWQgYnkgQ2FjaGVk Q1NTU3R5bGVTaGVldCBhcyBiYWNrZ3JvdW5kLCBtYXNrIG9yIGJvcmRlcgorICAgICAgICBpbWFn ZXMuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIC0gbm8gbmV3IHRlc3RhYmxlIGZ1bmN0aW9uYWxp dHkuCisKKyAgICAgICAgKiBsb2FkZXIvY2FjaGUvQ2FjaGVkQ1NTU3R5bGVTaGVldC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpDYWNoZWRDU1NTdHlsZVNoZWV0OjpDYWNoZWRDU1NTdHlsZVNoZWV0 KToKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZENTU1N0eWxlU2hlZXQ6OmRpZEFkZENsaWVudCk6 CisgICAgICAgIChXZWJDb3JlOjpDYWNoZWRDU1NTdHlsZVNoZWV0OjphbGxDbGllbnRzUmVtb3Zl ZCk6CisgICAgICAgIChXZWJDb3JlOjpDYWNoZWRDU1NTdHlsZVNoZWV0OjpkZXN0cm95RGVjb2Rl ZERhdGEpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpDYWNoZWRDU1NT dHlsZVNoZWV0OjpkZWNvZGVkRGF0YURlbGV0aW9uVGltZXJGaXJlZCk6CisgICAgICAgICogbG9h ZGVyL2NhY2hlL0NhY2hlZENTU1N0eWxlU2hlZXQuaDoKKyAgICAgICAgKENhY2hlZENTU1N0eWxl U2hlZXQpOgorCiAyMDEyLTA3LTE3ICBIdWFuZyBEb25nc3VuZyAgPGx1eHRlbGxhQGNvbXBhbnkx MDAubmV0PgogCiAgICAgICAgIE1ha2UgQ1NTIGJveCBtb2RlbCBiYWNrZ3JvdW5kLCBib3JkZXIg YW5kIG1hc2sgYmUgZGVjb2RlZCBieSBwYXJhbGxlbCBpbWFnZSBkZWNvZGVycy4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRDU1NTdHlsZVNoZWV0LmNwcCBi L1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRDU1NTdHlsZVNoZWV0LmNwcAppbmRl eCAyZGJlNzVlNTQ4Njc1YTc0NGJjMGZhMTQyOTBjMGVkZTNkZTY4NTcxLi42MTczMmIxMTUyODk4 NWMxOTcxMWE3NDBiZDY3MWFiZWZlNTdiZTM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvY2FjaGUvQ2FjaGVkQ1NTU3R5bGVTaGVldC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv bG9hZGVyL2NhY2hlL0NhY2hlZENTU1N0eWxlU2hlZXQuY3BwCkBAIC00Myw2ICs0Myw3IEBAIG5h bWVzcGFjZSBXZWJDb3JlIHsKIENhY2hlZENTU1N0eWxlU2hlZXQ6OkNhY2hlZENTU1N0eWxlU2hl ZXQoY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiByZXNvdXJjZVJlcXVlc3QsIGNvbnN0IFN0cmluZyYg Y2hhcnNldCkKICAgICA6IENhY2hlZFJlc291cmNlKHJlc291cmNlUmVxdWVzdCwgQ1NTU3R5bGVT aGVldCkKICAgICAsIG1fZGVjb2RlcihUZXh0UmVzb3VyY2VEZWNvZGVyOjpjcmVhdGUoInRleHQv Y3NzIiwgY2hhcnNldCkpCisgICAgLCBtX2RlY29kZWREYXRhRGVsZXRpb25UaW1lcih0aGlzLCAm Q2FjaGVkQ1NTU3R5bGVTaGVldDo6ZGVjb2RlZERhdGFEZWxldGlvblRpbWVyRmlyZWQpCiB7CiAg ICAgLy8gUHJlZmVyIHRleHQvY3NzIGJ1dCBhY2NlcHQgYW55IHR5cGUgKGRlbGwuY29tIHNlcnZl cyBhIHN0eWxlc2hlZXQKICAgICAvLyBhcyB0ZXh0L2h0bWw7IHNlZSA8aHR0cDovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTE0NTE+KS4KQEAgLTU4LDE0ICs1OSwxNyBAQCBDYWNo ZWRDU1NTdHlsZVNoZWV0Ojp+Q2FjaGVkQ1NTU3R5bGVTaGVldCgpCiB2b2lkIENhY2hlZENTU1N0 eWxlU2hlZXQ6OmRpZEFkZENsaWVudChDYWNoZWRSZXNvdXJjZUNsaWVudCogYykKIHsKICAgICBB U1NFUlQoYy0+cmVzb3VyY2VDbGllbnRUeXBlKCkgPT0gQ2FjaGVkU3R5bGVTaGVldENsaWVudDo6 ZXhwZWN0ZWRUeXBlKCkpOworICAgIGlmIChtX2RlY29kZWREYXRhRGVsZXRpb25UaW1lci5pc0Fj dGl2ZSgpKQorICAgICAgICBtX2RlY29kZWREYXRhRGVsZXRpb25UaW1lci5zdG9wKCk7CisKICAg ICBpZiAoIWlzTG9hZGluZygpKQogICAgICAgICBzdGF0aWNfY2FzdDxDYWNoZWRTdHlsZVNoZWV0 Q2xpZW50Kj4oYyktPnNldENTU1N0eWxlU2hlZXQobV9yZXNvdXJjZVJlcXVlc3QudXJsKCksIG1f cmVzcG9uc2UudXJsKCksIG1fZGVjb2Rlci0+ZW5jb2RpbmcoKS5uYW1lKCksIHRoaXMpOwogfQog CiB2b2lkIENhY2hlZENTU1N0eWxlU2hlZXQ6OmFsbENsaWVudHNSZW1vdmVkKCkKIHsKLSAgICBp ZiAoIU1lbW9yeUNhY2hlOjpzaG91bGRNYWtlUmVzb3VyY2VQdXJnZWFibGVPbkV2aWN0aW9uKCkg JiYgaXNTYWZlVG9NYWtlUHVyZ2VhYmxlKCkpCi0gICAgICAgIG1ha2VQdXJnZWFibGUodHJ1ZSk7 CisgICAgaWYgKGRvdWJsZSBpbnRlcnZhbCA9IG1lbW9yeUNhY2hlKCktPmRlYWREZWNvZGVkRGF0 YURlbGV0aW9uSW50ZXJ2YWwoKSkKKyAgICAgICAgbV9kZWNvZGVkRGF0YURlbGV0aW9uVGltZXIu c3RhcnRPbmVTaG90KGludGVydmFsKTsKIH0KIAogdm9pZCBDYWNoZWRDU1NTdHlsZVNoZWV0Ojpz ZXRFbmNvZGluZyhjb25zdCBTdHJpbmcmIGNocykKQEAgLTE2Myw2ICsxNjcsMTQgQEAgdm9pZCBD YWNoZWRDU1NTdHlsZVNoZWV0OjpkZXN0cm95RGVjb2RlZERhdGEoKQogICAgIG1fcGFyc2VkU3R5 bGVTaGVldENhY2hlLmNsZWFyKCk7CiAKICAgICBzZXREZWNvZGVkU2l6ZSgwKTsKKworICAgIGlm ICghTWVtb3J5Q2FjaGU6OnNob3VsZE1ha2VSZXNvdXJjZVB1cmdlYWJsZU9uRXZpY3Rpb24oKSAm JiBpc1NhZmVUb01ha2VQdXJnZWFibGUoKSkKKyAgICAgICAgbWFrZVB1cmdlYWJsZSh0cnVlKTsK K30KKwordm9pZCBDYWNoZWRDU1NTdHlsZVNoZWV0OjpkZWNvZGVkRGF0YURlbGV0aW9uVGltZXJG aXJlZChUaW1lcjxDYWNoZWRDU1NTdHlsZVNoZWV0PiopCit7CisgICAgZGVzdHJveURlY29kZWRE YXRhKCk7CiB9CiAKIFBhc3NSZWZQdHI8U3R5bGVTaGVldENvbnRlbnRzPiBDYWNoZWRDU1NTdHls ZVNoZWV0OjpyZXN0b3JlUGFyc2VkU3R5bGVTaGVldChjb25zdCBDU1NQYXJzZXJDb250ZXh0JiBj b250ZXh0KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZENT U1N0eWxlU2hlZXQuaCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRDU1NTdHls ZVNoZWV0LmgKaW5kZXggYjcwZjI2NWRkMjc2MTExZTIzYWUyYWU1MTU5MGE4YWY0NTkzMjhkOC4u OWY1MWYzMGFhYTBiODdjNGFkNWJjNjdhM2JmOWE2YTA3ZWUyMDUxNCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZENTU1N0eWxlU2hlZXQuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkQ1NTU3R5bGVTaGVldC5oCkBAIC0yNyw2ICsy Nyw3IEBACiAjZGVmaW5lIENhY2hlZENTU1N0eWxlU2hlZXRfaAogCiAjaW5jbHVkZSAiQ2FjaGVk UmVzb3VyY2UuaCIKKyNpbmNsdWRlICJUaW1lci5oIgogI2luY2x1ZGUgPHd0Zi9WZWN0b3IuaD4K IAogbmFtZXNwYWNlIFdlYkNvcmUgewpAQCAtNjEsMTIgKzYyLDE0IEBAIG5hbWVzcGFjZSBXZWJD b3JlIHsKICAgICAgICAgdm9pZCBzYXZlUGFyc2VkU3R5bGVTaGVldChQYXNzUmVmUHRyPFN0eWxl U2hlZXRDb250ZW50cz4pOwogICAgIAogICAgIHByaXZhdGU6CisgICAgICAgIHZvaWQgZGVjb2Rl ZERhdGFEZWxldGlvblRpbWVyRmlyZWQoVGltZXI8Q2FjaGVkQ1NTU3R5bGVTaGVldD4qKTsKICAg ICAgICAgYm9vbCBjYW5Vc2VTaGVldChib29sIGVuZm9yY2VNSU1FVHlwZSwgYm9vbCogaGFzVmFs aWRNSU1FVHlwZSkgY29uc3Q7CiAgICAgICAgIHZpcnR1YWwgUHVyZ2VQcmlvcml0eSBwdXJnZVBy aW9yaXR5KCkgY29uc3QgeyByZXR1cm4gUHVyZ2VMYXN0OyB9CiAKICAgICBwcm90ZWN0ZWQ6CiAg ICAgICAgIFJlZlB0cjxUZXh0UmVzb3VyY2VEZWNvZGVyPiBtX2RlY29kZXI7CiAgICAgICAgIFN0 cmluZyBtX2RlY29kZWRTaGVldFRleHQ7CisgICAgICAgIFRpbWVyPENhY2hlZENTU1N0eWxlU2hl ZXQ+IG1fZGVjb2RlZERhdGFEZWxldGlvblRpbWVyOwogCiAgICAgICAgIFJlZlB0cjxTdHlsZVNo ZWV0Q29udGVudHM+IG1fcGFyc2VkU3R5bGVTaGVldENhY2hlOwogICAgIH07Cg==