91732 2012-07-19 04:35:05 -0700 Web Inspector: Drop "Loading..." message from FileContentView 2012-08-14 02:04:50 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 68203 0 tzik tzik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 673383 0 tzik 2012-07-19 04:35:05 -0700 It seems better to show empty view while loading file. 673384 1 153227 tzik 2012-07-19 04:36:17 -0700 Created attachment 153227 Patch 674392 2 153227 vsevik 2012-07-20 02:53:51 -0700 Comment on attachment 153227 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153227&action=review > Source/WebCore/inspector/front-end/FileContentView.js:50 > + this._innerView = new WebInspector.EmptyView(WebInspector.UIString("")); this._innerView = new WebInspector.EmptyView(""); 694506 3 158213 tzik 2012-08-13 22:19:03 -0700 Created attachment 158213 Patch 694512 4 153227 tzik 2012-08-13 22:26:58 -0700 Comment on attachment 153227 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153227&action=review >> Source/WebCore/inspector/front-end/FileContentView.js:50 >> + this._innerView = new WebInspector.EmptyView(WebInspector.UIString("")); > > this._innerView = new WebInspector.EmptyView(""); Done I forgot to handle this... 694694 5 158213 webkit.review.bot 2012-08-14 02:04:45 -0700 Comment on attachment 158213 Patch Clearing flags on attachment: 158213 Committed r125527: <http://trac.webkit.org/changeset/125527> 694695 6 webkit.review.bot 2012-08-14 02:04:50 -0700 All reviewed patches have been landed. Closing bug. 153227 2012-07-19 04:36:17 -0700 2012-08-13 22:26:58 -0700 Patch bug-91732-20120719203616.patch text/plain 1566 tzik U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjU3NWY2YWRiMDFlYjFk ODBkOTE0N2JiZDY1MTJmYTVjYzZlNDIyZC4uYzlmMjdlY2Q2MDJhMDg2OTg5ZjgyN2IxNzJkMmY5 ZjAyODI0NTQ5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA3LTE5ICBUYWlq dSBUc3Vpa2kgIDx0emlrQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBE cm9wICJMb2FkaW5nLi4uIiBtZXNzYWdlIGZyb20gRmlsZUNvbnRlbnRWaWV3CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTczMgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVu ZC9GaWxlQ29udGVudFZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRmlsZUNvbnRlbnRW aWV3LnByb3RvdHlwZS53YXNTaG93bik6CisKIDIwMTItMDctMTggIEhpcm9ub3JpIEJvbm8gIDxo Ym9ub0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTW92ZSBjb250ZW50cyByaWdodCB3aGVuIGEg dmVydGljYWwgc2Nyb2xsYmFyIGlzIHNob3duIGF0IHRoZSBsZWZ0IHNpZGUgb2YgYW4gUlRMIGVs ZW1lbnQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0Zp bGVDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRmls ZUNvbnRlbnRWaWV3LmpzCmluZGV4IDk4Y2YyNjYxYTU5M2I3MjdjNzFiZmRkZDI3MzQwMzFkMDk4 MzM0OGIuLjgxZGVmYWQxMzczMTU4YmVjY2JjZTQ5MDExOGI5Nzc3MGQ0MjkzMjggMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRmlsZUNvbnRlbnRWaWV3Lmpz CisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRmlsZUNvbnRlbnRWaWV3 LmpzCkBAIC00Nyw3ICs0Nyw3IEBAIFdlYkluc3BlY3Rvci5GaWxlQ29udGVudFZpZXcucHJvdG90 eXBlID0gewogICAgIHsKICAgICAgICAgaWYgKCF0aGlzLl9pbm5lclZpZXcpIHsKICAgICAgICAg ICAgIGlmICh0aGlzLl9maWxlLmlzVGV4dEZpbGUpCi0gICAgICAgICAgICAgICAgdGhpcy5faW5u ZXJWaWV3ID0gbmV3IFdlYkluc3BlY3Rvci5FbXB0eVZpZXcoV2ViSW5zcGVjdG9yLlVJU3RyaW5n KCJMb2FkaW5nLi4uIikpOworICAgICAgICAgICAgICAgIHRoaXMuX2lubmVyVmlldyA9IG5ldyBX ZWJJbnNwZWN0b3IuRW1wdHlWaWV3KFdlYkluc3BlY3Rvci5VSVN0cmluZygiIikpOwogICAgICAg ICAgICAgZWxzZQogICAgICAgICAgICAgICAgIHRoaXMuX2lubmVyVmlldyA9IG5ldyBXZWJJbnNw ZWN0b3IuRW1wdHlWaWV3KFdlYkluc3BlY3Rvci5VSVN0cmluZygiQmluYXJ5IEZpbGUiKSk7CiAg ICAgICAgICAgICB0aGlzLnJlZnJlc2goKTsK 158213 2012-08-13 22:19:03 -0700 2012-08-14 02:04:44 -0700 Patch bug-91732-20120814141831.patch text/plain 1493 tzik U3VidmVyc2lvbiBSZXZpc2lvbjogMTI1NDg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzhiMzUyMzQ3MDZiOWE5 NDRiZmRkN2Q0MzI0MTg4ZDNiZTJiNjMyNS4uNjU5NjA1NGI2Njg3NzBlMzNmMGVmNjQ4NTA2ODZi OGEwZDYwYjc5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA3LTE5ICBUYWlq dSBUc3Vpa2kgIDx0emlrQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBE cm9wICJMb2FkaW5nLi4uIiBtZXNzYWdlIGZyb20gRmlsZUNvbnRlbnRWaWV3CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTczMgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVu ZC9GaWxlQ29udGVudFZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRmlsZUNvbnRlbnRW aWV3LnByb3RvdHlwZS53YXNTaG93bik6CisKIDIwMTItMDgtMTMgIEtlbnRhcm8gSGFyYSAgPGhh cmFrZW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtWOF0gUmVtb3ZlIFtUcmVhdFJldHVybmVk TnVsbEFzPUZhbHNlXQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9GaWxlQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL0ZpbGVDb250ZW50Vmlldy5qcwppbmRleCA5OGNmMjY2MWE1OTNiNzI3YzcxYmZkZGQyNzM0 MDMxZDA5ODMzNDhiLi5jMDc0MTI4ZWUxZTk4MmUwMjA4MzIzNzhkZmU2MjdlZjVlNzQzYTU3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0ZpbGVDb250ZW50 Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0ZpbGVDb250 ZW50Vmlldy5qcwpAQCAtNDcsNyArNDcsNyBAQCBXZWJJbnNwZWN0b3IuRmlsZUNvbnRlbnRWaWV3 LnByb3RvdHlwZSA9IHsKICAgICB7CiAgICAgICAgIGlmICghdGhpcy5faW5uZXJWaWV3KSB7CiAg ICAgICAgICAgICBpZiAodGhpcy5fZmlsZS5pc1RleHRGaWxlKQotICAgICAgICAgICAgICAgIHRo aXMuX2lubmVyVmlldyA9IG5ldyBXZWJJbnNwZWN0b3IuRW1wdHlWaWV3KFdlYkluc3BlY3Rvci5V SVN0cmluZygiTG9hZGluZy4uLiIpKTsKKyAgICAgICAgICAgICAgICB0aGlzLl9pbm5lclZpZXcg PSBuZXcgV2ViSW5zcGVjdG9yLkVtcHR5VmlldygiIik7CiAgICAgICAgICAgICBlbHNlCiAgICAg ICAgICAgICAgICAgdGhpcy5faW5uZXJWaWV3ID0gbmV3IFdlYkluc3BlY3Rvci5FbXB0eVZpZXco V2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJCaW5hcnkgRmlsZSIpKTsKICAgICAgICAgICAgIHRoaXMu cmVmcmVzaCgpOwo=