91721 2012-07-19 00:40:54 -0700 [EFL][WK2] Use "load,finished" signal in EWK2UnitTestBase::loadUrlSync() instead of "load,progress" 2012-07-20 03:17:26 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez gyuyoung.kim kenneth tmpsantos tonikitoo webkit.review.bot oldest_to_newest 673256 0 cdumez 2012-07-19 00:40:54 -0700 The purpose of EWK2UnitTestBase::loadUrlSync() is to load a URL in the view and wait synchronously for the load to finish. The current implementation uses the "load,progress" signal to detect when the load is finished, which is inefficient because it gets emitted several times. It is better to wait for the "load,finished" signal which gets emitted only once when the load is complete. 673258 1 153197 cdumez 2012-07-19 00:43:09 -0700 Created attachment 153197 Patch 673304 2 153197 tmpsantos 2012-07-19 01:44:02 -0700 Comment on attachment 153197 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153197&action=review Good to know that we finally have "load,finished" for EFL WebKit2. :) > Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:-34 > - UNUSED_PARAM(webView); It's unclear to me the policy regarding unused parameters at the EFL port. Some reviewers asked me for UNUSED_PARAM a couple of times,. If the policy is not to use, you should also remove <wtf/UnusedParam.h> and, if the policy is to use, you should add for webView and eventInfo. > Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:-87 > - while (m_loadProgress != 1) > - ecore_main_loop_iterate(); I think we still need to use ecore_main_loop_iterate() with some exit condition (maybe s/m_loadProgress/m_loadDone). The reason is we might call the loadUrlSync from inside a callback. If you do that, you will nest two ecore_main_loop_begin() (that first one will probably starve, but the EFL docs doesn't say anything about it). > Source/WebKit2/UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:-31 > - void setLoadProgress(float progress) { m_loadProgress = progress; } You might need a setLoadDone() for the reasons I mentioned at the comment about ecore_main_loop_iterate(). 674290 3 153197 cdumez 2012-07-20 00:54:32 -0700 Comment on attachment 153197 Patch Will reupload a patch taking Thiago's feedback into consideration soon. Clearing flags until then. 674304 4 153442 cdumez 2012-07-20 01:15:48 -0700 Created attachment 153442 Patch 674323 5 153442 tmpsantos 2012-07-20 01:38:55 -0700 Comment on attachment 153442 Patch LGTM. Thanks. 674408 6 153442 webkit.review.bot 2012-07-20 03:17:20 -0700 Comment on attachment 153442 Patch Clearing flags on attachment: 153442 Committed r123199: <http://trac.webkit.org/changeset/123199> 674409 7 webkit.review.bot 2012-07-20 03:17:26 -0700 All reviewed patches have been landed. Closing bug. 153197 2012-07-19 00:43:09 -0700 2012-07-20 01:15:48 -0700 Patch 91721_utest_load_sync.patch text/plain 3764 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiYzMyNjk2Li5kOGYyMzcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTItMDctMTkgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIFVzZSAibG9hZCxmaW5pc2hlZCIgc2lnbmFsIGlu IEVXSzJVbml0VGVzdEJhc2U6OmxvYWRVcmxTeW5jKCkgaW5zdGVhZCBvZiAibG9hZCxwcm9ncmVz cyIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNzIx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHB1 cnBvc2Ugb2YgRVdLMlVuaXRUZXN0QmFzZTo6bG9hZFVybFN5bmMoKSBpcyB0byBsb2FkCisgICAg ICAgIGEgVVJMIGluIHRoZSB2aWV3IGFuZCB3YWl0IHN5bmNocm9ub3VzbHkgZm9yIHRoZSBsb2Fk IHRvIGZpbmlzaC4KKyAgICAgICAgVGhlIGN1cnJlbnQgaW1wbGVtZW50YXRpb24gdXNlcyB0aGUg ImxvYWQscHJvZ3Jlc3MiIHNpZ25hbCB0bworICAgICAgICBkZXRlY3Qgd2hlbiB0aGUgbG9hZCBp cyBmaW5pc2hlZCwgd2hpY2ggaXMgaW5lZmZpY2llbnQgYmVjYXVzZQorICAgICAgICBpdCBnZXRz IGVtaXR0ZWQgc2V2ZXJhbCB0aW1lcy4KKworICAgICAgICBJdCBpcyBiZXR0ZXIgdG8gd2FpdCBm b3IgdGhlICJsb2FkLGZpbmlzaGVkIiBzaWduYWwgd2hpY2ggZ2V0cworICAgICAgICBlbWl0dGVk IG9ubHkgb25jZSB3aGVuIHRoZSBsb2FkIGlzIGNvbXBsZXRlLgorCisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0syVW5pdFRlc3RCYXNlLmNwcDoKKyAg ICAgICAgKEVXSzJVbml0VGVzdDo6b25Mb2FkRmluaXNoZWQpOgorICAgICAgICAoRVdLMlVuaXRU ZXN0OjpFV0syVW5pdFRlc3RCYXNlOjpFV0syVW5pdFRlc3RCYXNlKToKKyAgICAgICAgKEVXSzJV bml0VGVzdDo6RVdLMlVuaXRUZXN0QmFzZTo6bG9hZFVybFN5bmMpOgorICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdLMlVuaXRUZXN0QmFzZS5oOgorICAg ICAgICAoRVdLMlVuaXRUZXN0QmFzZSk6CisKIDIwMTItMDctMTggIENocmlzdG9waGUgRHVtZXog IDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJdIEVGTCBz aG91bGQgdXNlIERvd25sb2FkU291cCBpbnN0ZWFkIG9mIGRlZmluaW5nIERvd25sb2FkRWZsCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy9Vbml0VGVz dFV0aWxzL0VXSzJVbml0VGVzdEJhc2UuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0syVW5pdFRlc3RCYXNlLmNwcAppbmRleCBkODEw MTA2Li4wMjBhMmNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2Vm bC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VXSzJVbml0VGVzdEJhc2UuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdLMlVuaXRUZXN0 QmFzZS5jcHAKQEAgLTI5LDE5ICsyOSwxMyBAQCBleHRlcm4gRVdLMlVuaXRUZXN0OjpFV0syVW5p dFRlc3RFbnZpcm9ubWVudCogZW52aXJvbm1lbnQ7CiAKIG5hbWVzcGFjZSBFV0syVW5pdFRlc3Qg ewogCi1zdGF0aWMgdm9pZCBvbkxvYWRQcm9ncmVzcyh2b2lkKiB1c2VyRGF0YSwgRXZhc19PYmpl Y3QqIHdlYlZpZXcsIHZvaWQqIGV2ZW50SW5mbykKK3N0YXRpYyB2b2lkIG9uTG9hZEZpbmlzaGVk KHZvaWQqIHVzZXJEYXRhLCBFdmFzX09iamVjdCogd2ViVmlldywgdm9pZCogZXZlbnRJbmZvKQog ewotICAgIFVOVVNFRF9QQVJBTSh3ZWJWaWV3KTsKLQotICAgIEVXSzJVbml0VGVzdEJhc2UqIHRl c3QgPSBzdGF0aWNfY2FzdDxFV0syVW5pdFRlc3RCYXNlKj4odXNlckRhdGEpOwotICAgIGRvdWJs ZSBwcm9ncmVzcyA9ICpzdGF0aWNfY2FzdDxkb3VibGUqPihldmVudEluZm8pOwotCi0gICAgdGVz dC0+c2V0TG9hZFByb2dyZXNzKHByb2dyZXNzKTsKKyAgICBlY29yZV9tYWluX2xvb3BfcXVpdCgp OwogfQogCiBFV0syVW5pdFRlc3RCYXNlOjpFV0syVW5pdFRlc3RCYXNlKCkKLSAgICA6IG1fbG9h ZFByb2dyZXNzKDApCi0gICAgLCBtX2Vjb3JlRXZhcygwKQorICAgIDogbV9lY29yZUV2YXMoMCkK ICAgICAsIG1fd2ViVmlldygwKQogewogfQpAQCAtNzgsMTUgKzcyLDEwIEBAIHZvaWQgRVdLMlVu aXRUZXN0QmFzZTo6VGVhckRvd24oKQogCiB2b2lkIEVXSzJVbml0VGVzdEJhc2U6OmxvYWRVcmxT eW5jKGNvbnN0IGNoYXIqIHVybCkKIHsKLSAgICBtX2xvYWRQcm9ncmVzcyA9IDA7Ci0KLSAgICBl dmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQobV93ZWJWaWV3LCAibG9hZCxwcm9ncmVzcyIs IG9uTG9hZFByb2dyZXNzLCB0aGlzKTsKKyAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19h ZGQobV93ZWJWaWV3LCAibG9hZCxmaW5pc2hlZCIsIG9uTG9hZEZpbmlzaGVkLCB0aGlzKTsKICAg ICBld2tfdmlld191cmlfc2V0KG1fd2ViVmlldywgdXJsKTsKLQotICAgIHdoaWxlIChtX2xvYWRQ cm9ncmVzcyAhPSAxKQotICAgICAgICBlY29yZV9tYWluX2xvb3BfaXRlcmF0ZSgpOwotCi0gICAg ZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfZGVsKG1fd2ViVmlldywgImxvYWQscHJvZ3Jlc3Mi LCBvbkxvYWRQcm9ncmVzcyk7CisgICAgZWNvcmVfbWFpbl9sb29wX2JlZ2luKCk7CisgICAgZXZh c19vYmplY3Rfc21hcnRfY2FsbGJhY2tfZGVsKG1fd2ViVmlldywgImxvYWQsZmluaXNoZWQiLCBv bkxvYWRGaW5pc2hlZCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIEVXSzJVbml0VGVzdApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RVdGls cy9FV0syVW5pdFRlc3RCYXNlLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90 ZXN0cy9Vbml0VGVzdFV0aWxzL0VXSzJVbml0VGVzdEJhc2UuaAppbmRleCA3OTQ2ODgxLi44ZmEx YjUwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMv VW5pdFRlc3RVdGlscy9FV0syVW5pdFRlc3RCYXNlLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0syVW5pdFRlc3RCYXNlLmgKQEAg LTI4LDcgKzI4LDYgQEAgbmFtZXNwYWNlIEVXSzJVbml0VGVzdCB7CiAKIGNsYXNzIEVXSzJVbml0 VGVzdEJhc2UgOiBwdWJsaWMgOjp0ZXN0aW5nOjpUZXN0IHsKIHB1YmxpYzoKLSAgICB2b2lkIHNl dExvYWRQcm9ncmVzcyhmbG9hdCBwcm9ncmVzcykgeyBtX2xvYWRQcm9ncmVzcyA9IHByb2dyZXNz OyB9CiAgICAgRXZhc19PYmplY3QqIHdlYlZpZXcoKSB7IHJldHVybiBtX3dlYlZpZXc7IH0KIAog cHJvdGVjdGVkOgpAQCAtNDIsOCArNDEsNiBAQCBwcm90ZWN0ZWQ6CiBwcml2YXRlOgogICAgIEV2 YXNfT2JqZWN0KiBtX3dlYlZpZXc7CiAgICAgRWNvcmVfRXZhcyogbV9lY29yZUV2YXM7Ci0KLSAg ICBmbG9hdCBtX2xvYWRQcm9ncmVzczsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIEVXSzJVbml0VGVz dAo= 153442 2012-07-20 01:15:48 -0700 2012-07-20 03:17:20 -0700 Patch 91721_load_sync.patch text/plain 3875 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA0OTdhMzk0Li43NzBiODA3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTItMDctMjAgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIFVzZSAibG9hZCxmaW5pc2hlZCIgc2lnbmFsIGlu IEVXSzJVbml0VGVzdEJhc2U6OmxvYWRVcmxTeW5jKCkgaW5zdGVhZCBvZiAibG9hZCxwcm9ncmVz cyIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNzIx CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHB1 cnBvc2Ugb2YgRVdLMlVuaXRUZXN0QmFzZTo6bG9hZFVybFN5bmMoKSBpcyB0byBsb2FkCisgICAg ICAgIGEgVVJMIGluIHRoZSB2aWV3IGFuZCB3YWl0IHN5bmNocm9ub3VzbHkgZm9yIHRoZSBsb2Fk IHRvIGZpbmlzaC4KKyAgICAgICAgVGhlIGN1cnJlbnQgaW1wbGVtZW50YXRpb24gdXNlcyB0aGUg ImxvYWQscHJvZ3Jlc3MiIHNpZ25hbCB0bworICAgICAgICBkZXRlY3Qgd2hlbiB0aGUgbG9hZCBp cyBmaW5pc2hlZCwgd2hpY2ggaXMgaW5lZmZpY2llbnQgYmVjYXVzZQorICAgICAgICBpdCBnZXRz IGVtaXR0ZWQgc2V2ZXJhbCB0aW1lcy4KKworICAgICAgICBJdCBpcyBiZXR0ZXIgdG8gd2FpdCBm b3IgdGhlICJsb2FkLGZpbmlzaGVkIiBzaWduYWwgd2hpY2ggZ2V0cworICAgICAgICBlbWl0dGVk IG9ubHkgb25jZSB3aGVuIHRoZSBsb2FkIGlzIGNvbXBsZXRlLgorCisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0syVW5pdFRlc3RCYXNlLmNwcDoKKyAg ICAgICAgKEVXSzJVbml0VGVzdDo6b25Mb2FkRmluaXNoZWQpOgorICAgICAgICAoRVdLMlVuaXRU ZXN0OjpFV0syVW5pdFRlc3RCYXNlOjpFV0syVW5pdFRlc3RCYXNlKToKKyAgICAgICAgKEVXSzJV bml0VGVzdDo6RVdLMlVuaXRUZXN0QmFzZTo6bG9hZFVybFN5bmMpOgorICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvZWZsL3Rlc3RzL1VuaXRUZXN0VXRpbHMvRVdLMlVuaXRUZXN0QmFzZS5oOgorICAg ICAgICAoRVdLMlVuaXRUZXN0QmFzZSk6CisKIDIwMTItMDctMTkgIE1PUklUQSBIYWppbWUgIDxt b3JyaXRhQGdvb2dsZS5jb20+CiAKICAgICAgICAgW1JlZmFjdG9yaW5nXSBSZXBsYWNlIE5vZGUn cyBEb2N1bWVudCBwb2ludGVyIHdpdGggYSBUcmVlU2NvcGUgcG9pbnRlcgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0sy VW5pdFRlc3RCYXNlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3Rz L1VuaXRUZXN0VXRpbHMvRVdLMlVuaXRUZXN0QmFzZS5jcHAKaW5kZXggZDgxMDEwNi4uMDUxNjhl MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5p dFRlc3RVdGlscy9FV0syVW5pdFRlc3RCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2VmbC90ZXN0cy9Vbml0VGVzdFV0aWxzL0VXSzJVbml0VGVzdEJhc2UuY3BwCkBA IC0yOSwxOSArMjksMTcgQEAgZXh0ZXJuIEVXSzJVbml0VGVzdDo6RVdLMlVuaXRUZXN0RW52aXJv bm1lbnQqIGVudmlyb25tZW50OwogCiBuYW1lc3BhY2UgRVdLMlVuaXRUZXN0IHsKIAotc3RhdGlj IHZvaWQgb25Mb2FkUHJvZ3Jlc3Modm9pZCogdXNlckRhdGEsIEV2YXNfT2JqZWN0KiB3ZWJWaWV3 LCB2b2lkKiBldmVudEluZm8pCitzdGF0aWMgdm9pZCBvbkxvYWRGaW5pc2hlZCh2b2lkKiB1c2Vy RGF0YSwgRXZhc19PYmplY3QqIHdlYlZpZXcsIHZvaWQqIGV2ZW50SW5mbykKIHsKICAgICBVTlVT RURfUEFSQU0od2ViVmlldyk7CisgICAgVU5VU0VEX1BBUkFNKGV2ZW50SW5mbyk7CiAKLSAgICBF V0syVW5pdFRlc3RCYXNlKiB0ZXN0ID0gc3RhdGljX2Nhc3Q8RVdLMlVuaXRUZXN0QmFzZSo+KHVz ZXJEYXRhKTsKLSAgICBkb3VibGUgcHJvZ3Jlc3MgPSAqc3RhdGljX2Nhc3Q8ZG91YmxlKj4oZXZl bnRJbmZvKTsKLQotICAgIHRlc3QtPnNldExvYWRQcm9ncmVzcyhwcm9ncmVzcyk7CisgICAgYm9v bCogbG9hZEZpbmlzaGVkID0gc3RhdGljX2Nhc3Q8Ym9vbCo+KHVzZXJEYXRhKTsKKyAgICAqbG9h ZEZpbmlzaGVkID0gdHJ1ZTsKIH0KIAogRVdLMlVuaXRUZXN0QmFzZTo6RVdLMlVuaXRUZXN0QmFz ZSgpCi0gICAgOiBtX2xvYWRQcm9ncmVzcygwKQotICAgICwgbV9lY29yZUV2YXMoMCkKKyAgICA6 IG1fZWNvcmVFdmFzKDApCiAgICAgLCBtX3dlYlZpZXcoMCkKIHsKIH0KQEAgLTc4LDE1ICs3Niwx NSBAQCB2b2lkIEVXSzJVbml0VGVzdEJhc2U6OlRlYXJEb3duKCkKIAogdm9pZCBFV0syVW5pdFRl c3RCYXNlOjpsb2FkVXJsU3luYyhjb25zdCBjaGFyKiB1cmwpCiB7Ci0gICAgbV9sb2FkUHJvZ3Jl c3MgPSAwOworICAgIGJvb2wgbG9hZEZpbmlzaGVkID0gZmFsc2U7CiAKLSAgICBldmFzX29iamVj dF9zbWFydF9jYWxsYmFja19hZGQobV93ZWJWaWV3LCAibG9hZCxwcm9ncmVzcyIsIG9uTG9hZFBy b2dyZXNzLCB0aGlzKTsKKyAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19hZGQobV93ZWJW aWV3LCAibG9hZCxmaW5pc2hlZCIsIG9uTG9hZEZpbmlzaGVkLCAmbG9hZEZpbmlzaGVkKTsKICAg ICBld2tfdmlld191cmlfc2V0KG1fd2ViVmlldywgdXJsKTsKIAotICAgIHdoaWxlIChtX2xvYWRQ cm9ncmVzcyAhPSAxKQorICAgIHdoaWxlICghbG9hZEZpbmlzaGVkKQogICAgICAgICBlY29yZV9t YWluX2xvb3BfaXRlcmF0ZSgpOwogCi0gICAgZXZhc19vYmplY3Rfc21hcnRfY2FsbGJhY2tfZGVs KG1fd2ViVmlldywgImxvYWQscHJvZ3Jlc3MiLCBvbkxvYWRQcm9ncmVzcyk7CisgICAgZXZhc19v YmplY3Rfc21hcnRfY2FsbGJhY2tfZGVsKG1fd2ViVmlldywgImxvYWQsZmluaXNoZWQiLCBvbkxv YWRGaW5pc2hlZCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIEVXSzJVbml0VGVzdApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9F V0syVW5pdFRlc3RCYXNlLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0 cy9Vbml0VGVzdFV0aWxzL0VXSzJVbml0VGVzdEJhc2UuaAppbmRleCA3OTQ2ODgxLi44ZmExYjUw MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvVW5p dFRlc3RVdGlscy9FV0syVW5pdFRlc3RCYXNlLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvdGVzdHMvVW5pdFRlc3RVdGlscy9FV0syVW5pdFRlc3RCYXNlLmgKQEAgLTI4 LDcgKzI4LDYgQEAgbmFtZXNwYWNlIEVXSzJVbml0VGVzdCB7CiAKIGNsYXNzIEVXSzJVbml0VGVz dEJhc2UgOiBwdWJsaWMgOjp0ZXN0aW5nOjpUZXN0IHsKIHB1YmxpYzoKLSAgICB2b2lkIHNldExv YWRQcm9ncmVzcyhmbG9hdCBwcm9ncmVzcykgeyBtX2xvYWRQcm9ncmVzcyA9IHByb2dyZXNzOyB9 CiAgICAgRXZhc19PYmplY3QqIHdlYlZpZXcoKSB7IHJldHVybiBtX3dlYlZpZXc7IH0KIAogcHJv dGVjdGVkOgpAQCAtNDIsOCArNDEsNiBAQCBwcm90ZWN0ZWQ6CiBwcml2YXRlOgogICAgIEV2YXNf T2JqZWN0KiBtX3dlYlZpZXc7CiAgICAgRWNvcmVfRXZhcyogbV9lY29yZUV2YXM7Ci0KLSAgICBm bG9hdCBtX2xvYWRQcm9ncmVzczsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIEVXSzJVbml0VGVzdAo=