91715 2012-07-18 23:19:21 -0700 CodeGeneratorV8.pm : @enabledAtRuntime is not used in GenerateHeader. 2012-07-19 00:30:04 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 dw.im webkit-unassigned abarth haraken japhet jochen webkit.review.bot oldest_to_newest 673198 0 dw.im 2012-07-18 23:19:21 -0700 @enabledAtRuntime is not used in GenerateHeader. We can remove it from CodeGeneratorV8.pm. I'll upload a patch soon. 673201 1 153185 dw.im 2012-07-18 23:32:09 -0700 Created attachment 153185 Patch 673211 2 153185 haraken 2012-07-18 23:40:13 -0700 Comment on attachment 153185 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153185&action=review Looks good except for the copyright. > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:10 > +# Copyright (C) 2012 Samsung Electronics Normally WebKit doesn't add copyright for a simple change like this. 673219 3 dw.im 2012-07-18 23:48:42 -0700 (In reply to comment #2) > (From update of attachment 153185 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=153185&action=review > > Looks good except for the copyright. > > > Source/WebCore/bindings/scripts/CodeGeneratorV8.pm:10 > > +# Copyright (C) 2012 Samsung Electronics > > Normally WebKit doesn't add copyright for a simple change like this. Oh. ok. no problem. ;) I usually implement a feature on port, so I put the copyright as a habit. If you want, I can re-upload the patch without the line. 673221 4 153190 dw.im 2012-07-18 23:50:36 -0700 Created attachment 153190 Patch 673225 5 153190 haraken 2012-07-18 23:53:25 -0700 Comment on attachment 153190 Patch OK. Please set "r?", then I can change it to "r+". 673226 6 haraken 2012-07-18 23:54:13 -0700 Also you can set "cq?" if you want to commit it, then I can change it to "cq+". 673229 7 dw.im 2012-07-19 00:02:08 -0700 (In reply to comment #6) > Also you can set "cq?" if you want to commit it, then I can change it to "cq+". I did! Actually, I was waiting the result of chromium ews. ;) 673230 8 haraken 2012-07-19 00:05:06 -0700 (In reply to comment #7) > Actually, I was waiting the result of chromium ews. ;) Basically you can set "r?" if you want to get feedback (without waiting the bot results). Also I can set "cq+" without waiting the bot results, since the commit queue will run the same tests before landing. 673248 9 153190 webkit.review.bot 2012-07-19 00:29:59 -0700 Comment on attachment 153190 Patch Clearing flags on attachment: 153190 Committed r123077: <http://trac.webkit.org/changeset/123077> 673249 10 webkit.review.bot 2012-07-19 00:30:04 -0700 All reviewed patches have been landed. Closing bug. 153185 2012-07-18 23:32:09 -0700 2012-07-18 23:50:36 -0700 Patch patch_91715_0719.patch text/plain 2308 dw.im ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkOTAyMTIwLi4zNGZhNWRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDctMTggIERvbmd3b28gSW0gIDxkdy5pbUBzYW1zdW5nLmNvbT4KKworICAgICAg ICBDb2RlR2VuZXJhdG9yVjgucG0gOiBAZW5hYmxlZEF0UnVudGltZSBpcyBub3QgdXNlZCBpbiBH ZW5lcmF0ZUhlYWRlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTkxNzE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQGVuYWJsZWRBdFJ1bnRpbWUgaXMgbm90IHVzZWQgaW4gR2VuZXJhdGVIZWFkZXIuCisg ICAgICAgIFdlIGNhbiByZW1vdmUgaXQgZnJvbSBHZW5lcmF0ZUhlYWRlci4KKworICAgICAgICBO byBuZXcgdGVzdHMgYXMgdGhpcyBoYXMgbm8gZnVuY3Rpb25hbCBjaGFuZ2VzLgorCisgICAgICAg ICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06IFJlbW92ZSBAZW5hYmxlZEF0 UnVudGltZSBmcm9tIEdlbmVyYXRlSGVhZGVyLgorICAgICAgICAoR2VuZXJhdGVIZWFkZXIpOgor CiAyMDEyLTA3LTE3ICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBzaG93IGxvYWRlcnMgbWVtb3J5IGNvbnN1bXB0aW9uIG9u IHRoZSBtZW1vcnkgY2hhcnQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvclY4LnBtCmluZGV4IDE0N2MzZDkuLmI3MjA5YWQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC03 LDYgKzcsNyBAQAogIyBDb3B5cmlnaHQgKEMpIDIwMDkgQ2FtZXJvbiBNY0Nvcm1hY2sgPGNhbUBt Y2MuaWQuYXU+CiAjIENvcHlyaWdodCAoQykgUmVzZWFyY2ggSW4gTW90aW9uIExpbWl0ZWQgMjAx MC4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMgQ29weXJpZ2h0IChDKSAyMDEwIE5va2lhIENvcnBv cmF0aW9uIGFuZC9vciBpdHMgc3Vic2lkaWFyeSgtaWVzKQorIyBDb3B5cmlnaHQgKEMpIDIwMTIg U2Ftc3VuZyBFbGVjdHJvbmljcwogIwogIyBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsg eW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCiAjIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVy bXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljCkBAIC00MDksNyArNDEwLDYgQEAg RU5ECiBFTkQKICAgICB9CiAKLSAgICBteSBAZW5hYmxlZEF0UnVudGltZTsKICAgICBteSBAZW5h YmxlZFBlckNvbnRleHQ7CiAgICAgZm9yZWFjaCBteSAkZnVuY3Rpb24gKEB7JGRhdGFOb2RlLT5m dW5jdGlvbnN9KSB7CiAgICAgICAgIG15ICRuYW1lID0gJGZ1bmN0aW9uLT5zaWduYXR1cmUtPm5h bWU7CkBAIC00MjMsMTAgKzQyMyw2IEBAIEVORAogRU5ECiAgICAgICAgICAgICBwdXNoKEBoZWFk ZXJDb250ZW50LCAiI2VuZGlmIC8vICR7Y29uZGl0aW9uYWxTdHJpbmd9XG4iKSBpZiAkY29uZGl0 aW9uYWxTdHJpbmc7CiAgICAgICAgIH0KLQotICAgICAgICBpZiAoJGF0dHJFeHQtPnsiVjhFbmFi bGVkQXRSdW50aW1lIn0pIHsKLSAgICAgICAgICAgIHB1c2goQGVuYWJsZWRBdFJ1bnRpbWUsICRm dW5jdGlvbik7Ci0gICAgICAgIH0KICAgICB9CiAKICAgICBpZiAoSXNDb25zdHJ1Y3RhYmxlKCRk YXRhTm9kZSkpIHsKQEAgLTQ1NywxMCArNDUzLDYgQEAgRU5ECiBFTkQKICAgICAgICAgICAgIHB1 c2goQGhlYWRlckNvbnRlbnQsICIjZW5kaWYgLy8gJHtjb25kaXRpb25hbFN0cmluZ31cbiIpIGlm ICRjb25kaXRpb25hbFN0cmluZzsKICAgICAgICAgfQotICAgICAgICBpZiAoJGF0dHJFeHQtPnsi VjhFbmFibGVkQXRSdW50aW1lIn0pIHsKLSAgICAgICAgICAgIHB1c2goQGVuYWJsZWRBdFJ1bnRp bWUsICRhdHRyaWJ1dGUpOwotICAgICAgICB9Ci0KICAgICAgICAgaWYgKCRhdHRyRXh0LT57IlY4 RW5hYmxlZFBlckNvbnRleHQifSkgewogICAgICAgICAgICAgcHVzaChAZW5hYmxlZFBlckNvbnRl eHQsICRhdHRyaWJ1dGUpOwogICAgICAgICB9Cg== 153190 2012-07-18 23:50:36 -0700 2012-07-19 00:29:59 -0700 Patch patch_91715_0719_01.patch text/plain 1924 dw.im ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkOTAyMTIwLi4zNGZhNWRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDctMTggIERvbmd3b28gSW0gIDxkdy5pbUBzYW1zdW5nLmNvbT4KKworICAgICAg ICBDb2RlR2VuZXJhdG9yVjgucG0gOiBAZW5hYmxlZEF0UnVudGltZSBpcyBub3QgdXNlZCBpbiBH ZW5lcmF0ZUhlYWRlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTkxNzE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQGVuYWJsZWRBdFJ1bnRpbWUgaXMgbm90IHVzZWQgaW4gR2VuZXJhdGVIZWFkZXIuCisg ICAgICAgIFdlIGNhbiByZW1vdmUgaXQgZnJvbSBHZW5lcmF0ZUhlYWRlci4KKworICAgICAgICBO byBuZXcgdGVzdHMgYXMgdGhpcyBoYXMgbm8gZnVuY3Rpb25hbCBjaGFuZ2VzLgorCisgICAgICAg ICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06IFJlbW92ZSBAZW5hYmxlZEF0 UnVudGltZSBmcm9tIEdlbmVyYXRlSGVhZGVyLgorICAgICAgICAoR2VuZXJhdGVIZWFkZXIpOgor CiAyMDEyLTA3LTE3ICBJbHlhIFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBXZWIgSW5zcGVjdG9yOiBzaG93IGxvYWRlcnMgbWVtb3J5IGNvbnN1bXB0aW9uIG9u IHRoZSBtZW1vcnkgY2hhcnQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbSBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Njcmlw dHMvQ29kZUdlbmVyYXRvclY4LnBtCmluZGV4IDE0N2MzZDkuLmMwNjMwNjYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC00 MDksNyArNDA5LDYgQEAgRU5ECiBFTkQKICAgICB9CiAKLSAgICBteSBAZW5hYmxlZEF0UnVudGlt ZTsKICAgICBteSBAZW5hYmxlZFBlckNvbnRleHQ7CiAgICAgZm9yZWFjaCBteSAkZnVuY3Rpb24g KEB7JGRhdGFOb2RlLT5mdW5jdGlvbnN9KSB7CiAgICAgICAgIG15ICRuYW1lID0gJGZ1bmN0aW9u LT5zaWduYXR1cmUtPm5hbWU7CkBAIC00MjMsMTAgKzQyMiw2IEBAIEVORAogRU5ECiAgICAgICAg ICAgICBwdXNoKEBoZWFkZXJDb250ZW50LCAiI2VuZGlmIC8vICR7Y29uZGl0aW9uYWxTdHJpbmd9 XG4iKSBpZiAkY29uZGl0aW9uYWxTdHJpbmc7CiAgICAgICAgIH0KLQotICAgICAgICBpZiAoJGF0 dHJFeHQtPnsiVjhFbmFibGVkQXRSdW50aW1lIn0pIHsKLSAgICAgICAgICAgIHB1c2goQGVuYWJs ZWRBdFJ1bnRpbWUsICRmdW5jdGlvbik7Ci0gICAgICAgIH0KICAgICB9CiAKICAgICBpZiAoSXND b25zdHJ1Y3RhYmxlKCRkYXRhTm9kZSkpIHsKQEAgLTQ1NywxMCArNDUyLDYgQEAgRU5ECiBFTkQK ICAgICAgICAgICAgIHB1c2goQGhlYWRlckNvbnRlbnQsICIjZW5kaWYgLy8gJHtjb25kaXRpb25h bFN0cmluZ31cbiIpIGlmICRjb25kaXRpb25hbFN0cmluZzsKICAgICAgICAgfQotICAgICAgICBp ZiAoJGF0dHJFeHQtPnsiVjhFbmFibGVkQXRSdW50aW1lIn0pIHsKLSAgICAgICAgICAgIHB1c2go QGVuYWJsZWRBdFJ1bnRpbWUsICRhdHRyaWJ1dGUpOwotICAgICAgICB9Ci0KICAgICAgICAgaWYg KCRhdHRyRXh0LT57IlY4RW5hYmxlZFBlckNvbnRleHQifSkgewogICAgICAgICAgICAgcHVzaChA ZW5hYmxlZFBlckNvbnRleHQsICRhdHRyaWJ1dGUpOwogICAgICAgICB9Cg==