91711 2012-07-18 22:24:56 -0700 [EFL] Enable interactive form validation 2012-07-19 00:11:28 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All Unspecified RESOLVED FIXED P2 Normal --- 0 kihong.kwon webkit-unassigned gyuyoung.kim gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 673172 0 kihong.kwon 2012-07-18 22:24:56 -0700 Enable interactive form validation in the WebCore::Settings. It is already enabled at gtk, blackberry, chromium and mac ports, and EFL also already enables it in the DRT. This makes we can validate data at form elements. In addition, if we disable this in the DRT, we have 14 regressions about form validation. -------------------------------------------------------------------------------- Unexpected flakiness: text diff mismatch (1) fast/forms/interactive-validation-attach-assertion.html = TEXT TIMEOUT PASS Unexpected flakiness: tests timed out (1) fast/forms/validation-message-clone.html = TEXT TIMEOUT PASS Regressions: Unexpected text diff mismatch : (12) fast/forms/interactive-validation-assertion-by-validate-twice.html = TEXT fast/forms/interactive-validation-crash-by-style-override.html = TEXT fast/forms/interactive-validation-prevented.html = TEXT fast/forms/interactive-validation-select-crash.html = TEXT fast/forms/validation-message-appearance.html = TEXT fast/forms/validation-message-in-relative-body.html = TEXT fast/forms/validation-message-on-checkbox.html = TEXT fast/forms/validation-message-on-listbox.html = TEXT fast/forms/validation-message-on-menulist.html = TEXT fast/forms/validation-message-on-radio.html = TEXT fast/forms/validation-message-on-range.html = TEXT fast/forms/validation-message-on-textarea.html = TEXT 673176 1 153179 kihong.kwon 2012-07-18 22:30:29 -0700 Created attachment 153179 Patch 673180 2 153179 gyuyoung.kim 2012-07-18 22:36:16 -0700 Comment on attachment 153179 Patch Looks fine. BTW, can we adjust this setting int EFL WK2 as well ? 673181 3 kihong.kwon 2012-07-18 22:38:42 -0700 (In reply to comment #2) > (From update of attachment 153179 [details]) > Looks fine. BTW, can we adjust this setting int EFL WK2 as well ? OK, I will do that. Thanks. 673200 4 gyuyoung.kim 2012-07-18 23:26:14 -0700 Oops, I forgot an initial patch for page setting of WK2 EFL is being reviewed on Bug 91206. So, I think this patch can be landed first. Please file a new bug after landing Bug 91206. 673233 5 153179 webkit.review.bot 2012-07-19 00:11:20 -0700 Comment on attachment 153179 Patch Clearing flags on attachment: 153179 Committed r123075: <http://trac.webkit.org/changeset/123075> 673234 6 webkit.review.bot 2012-07-19 00:11:28 -0700 All reviewed patches have been landed. Closing bug. 153179 2012-07-18 22:30:29 -0700 2012-07-19 00:11:20 -0700 Patch bug-91711-20120719143028.patch text/plain 1485 kihong.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNzkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKaW5kZXggODU4YzMyZjE4 NzMxMGRmNjFkYmM3ZjZhMzcwZmIzNjU0ZjdjY2I1MS4uMzcwOWNmOTY2NTRjODBlMTdjYjJlMjQ0 OGRjN2Q2NjY2ZWNlZmNhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEy LTA3LTE4ICBLaWhvbmcgS3dvbiAgPGtpaG9uZy5rd29uQHNhbXN1bmcuY29tPgorCisgICAgICAg IFtFRkxdIEVuYWJsZSBpbnRlcmFjdGl2ZSBmb3JtIHZhbGlkYXRpb24KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNzExCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRW5hYmxlIGludGVyYWN0aXZlIGZvcm0g dmFsaWRhdGlvbiBvbiB0aGUgRWZsLgorICAgICAgICBUaGlzIG1ha2VzIHdlIGNhbiB2YWxpZGF0 ZSBkYXRhIGF0IGZvcm0gZWxlbWVudHMuCisgICAgICAgIEluIGFkZGl0aW9uLCBpdCBpcyBhbHJl YWR5IGVuYWJsZWQgaW4gdGhlIERSVC4KKworICAgICAgICAqIGV3ay9ld2tfdmlldy5jcHA6Cisg ICAgICAgIChfZXdrX3ZpZXdfcHJpdl9uZXcpOgorCiAyMDEyLTA3LTE2ICBLaWhvbmcgS3dvbiAg PGtpaG9uZy5rd29uQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFJlbW92ZSBzZXRDb250cm9sbGVy IGZyb20gQmF0dGVyeUNsaWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKaW5kZXggOWIy NTVlODFlM2IzYzM1NmQyYzViNGE3M2ZiODBlMmI5NDNlZGVlYy4uNTAzN2FlZmE4YzA1Yzc5MzRi NzYzYjQ5YWNkMjdhZWM3NTJiOWY1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdr L2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBA IC03ODksNiArNzg5LDcgQEAgc3RhdGljIEV3a19WaWV3X1ByaXZhdGVfRGF0YSogX2V3a192aWV3 X3ByaXZfbmV3KEV3a19WaWV3X1NtYXJ0X0RhdGEqIHNtYXJ0RGF0YSkKICNpZiBFTkFCTEUoRlVM TFNDUkVFTl9BUEkpCiAgICAgcHJpdi0+cGFnZVNldHRpbmdzLT5zZXRGdWxsU2NyZWVuRW5hYmxl ZCh0cnVlKTsKICNlbmRpZgorICAgIHByaXYtPnBhZ2VTZXR0aW5ncy0+c2V0SW50ZXJhY3RpdmVG b3JtVmFsaWRhdGlvbkVuYWJsZWQodHJ1ZSk7CiAKICAgICB1cmwgPSBwcml2LT5wYWdlU2V0dGlu Z3MtPnVzZXJTdHlsZVNoZWV0TG9jYXRpb24oKTsKICAgICBwcml2LT5zZXR0aW5ncy51c2VyU3R5 bGVzaGVldCA9IGVpbmFfc3RyaW5nc2hhcmVfYWRkKHVybC5zdHJpbmcoKS51dGY4KCkuZGF0YSgp KTsK