91708 2012-07-18 20:58:33 -0700 Enable CSS variables compile time flag in Chrome. 2012-07-22 16:53:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson dglazkov macpherson peter simon.fraser webkit.review.bot oldest_to_newest 673123 0 macpherson 2012-07-18 20:58:33 -0700 Enable CSS variables compile time flag in Chrome. 673126 1 153171 macpherson 2012-07-18 21:02:38 -0700 Created attachment 153171 Patch 673331 2 peter 2012-07-19 02:24:58 -0700 The current implementation is not according to recent specification changes anymore. Wouldn't it be better to update the implementation prior to exposing it to authors (even behind a flag)? 673552 3 dglazkov 2012-07-19 09:03:34 -0700 (In reply to comment #2) > The current implementation is not according to recent specification changes anymore. Wouldn't it be better to update the implementation prior to exposing it to authors (even behind a flag)? As long as it's behind the runtime flag and Luke is actively working on it, I don't see a problem here. I would much rather start compiling this and avoid code rot. 673571 4 peter 2012-07-19 09:17:30 -0700 (In reply to comment #3) > As long as it's behind the runtime flag and Luke is actively working on it, I don't see a problem here. I would much rather start compiling this and avoid code rot. Agreed. If the syntax updates will be made in the short term, can we postpone advertising the feature in chrome://flags/ until that? 674015 5 macpherson 2012-07-19 16:05:48 -0700 You might be referring to the editor's draft. http://dev.w3.org/csswg/css-variables/ Right now I'm tracking the CSSWG working draft syntax. http://www.w3.org/TR/css-variables/ There is another WG meeting coming up in about 4 weeks, so hopefully we'll talk about it then and some of the editor's draft ideas will be propagated to the working draft. 674036 6 macpherson 2012-07-19 16:25:59 -0700 Also, I don't think it will actually appear under chrome://flags/ without me doing some additional work in chrome. 674138 7 153171 webkit.review.bot 2012-07-19 21:29:55 -0700 Comment on attachment 153171 Patch Clearing flags on attachment: 153171 Committed r123176: <http://trac.webkit.org/changeset/123176> 674139 8 webkit.review.bot 2012-07-19 21:29:58 -0700 All reviewed patches have been landed. Closing bug. 675321 9 simon.fraser 2012-07-22 09:55:13 -0700 Why was this just enabled in Chrome, and not in Mac builds? Most of the time we try to keep the features in sync. 675371 10 macpherson 2012-07-22 16:53:50 -0700 I'm more than happy to flip it on if that's what you guys want. Note that this just flipped the compile flag, not the runtime flag, so there is no visible change to web pages yet, but it will help us get it stable and ready to turn on by default. 153171 2012-07-18 21:02:38 -0700 2012-07-19 21:29:54 -0700 Patch bug-91708-20120719140236.patch text/plain 1537 macpherson U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDJmOTE4NTBhM2FiYzM5OTg2ZWNkNjNhNjU0Y2UyOGNiZDhkNTFkNGEuLjViMjE1NzQ4ZTk5NzJl MDVlMmRmZmZiYjk2MGUxZGQwODk4Zjg5NWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDctMTggIEx1a2UgTWFjcGhlcnNvbiAgIDxtYWNwaGVyc29u QGNocm9taXVtLm9yZz4KKworICAgICAgICBFbmFibGUgQ1NTIHZhcmlhYmxlcyBjb21waWxlIHRp bWUgZmxhZyBpbiBDaHJvbWUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05MTcwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZsaXBzIHRoZSBFTkFCTEVfQ1NTX1ZBUklBQkxFUyBjb21waWxlIGZsYWcgb24g Zm9yIENocm9tZS4gVGhlcmUgaXMgYWxzbyBhIHJ1bi10aW1lIGZsYWcgdGhhdCBpcyBvZmYgYnkg ZGVmYXVsdCwKKyAgICAgICAgc28gdGhpcyBzaG91bGQgbm90IGhhdmUgYSB1c2VyIHZpc2libGUg ZWZmZWN0IG90aGVyIHRoYW4gbWFraW5nIHRoZSB2YXJpYWJsZXMgcnVudGltZSBmbGFnIHZpc2li bGUgYXQgY2hyb21lOi8vZmxhZ3MvCisKKyAgICAgICAgKiBmZWF0dXJlcy5neXBpOgorCiAyMDEy LTA3LTE4ICBBbnRvaW5lIExhYm91ciAgPHBpbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBb Y2hyb21pdW1dIEludHJvZHVjZSBDQ1Jlc291cmNlUHJvdmlkZXIsIHJlcGxhY2luZyBUZXh0dXJl QWxsb2NhdG9yIGFuZCBoaWRpbmcgdGV4dHVyZXMgZnJvbSBjbGllbnRzIHRvIGFsbG93IHRyYW5z cG9ydApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9mZWF0dXJlcy5neXBpCmluZGV4IGNhYzA0Mjc3MTE0M2E0 ZmFhMjkwZDQxN2FjN2Q2Nzg3ZTRiODAxYzQuLjY0M2I4ZTkxNTgxN2Q5ODc2NWNiMjAxMWQ5ZDE4 N2Q5NzMwNjI0ZTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMu Z3lwaQorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkKQEAgLTQ2LDcg KzQ2LDcgQEAKICAgICAgICdFTkFCTEVfQ1NTX0lNQUdFX1JFU09MVVRJT049MCcsCiAgICAgICAn RU5BQkxFX0NTU19SRUdJT05TPTEnLAogICAgICAgJ0VOQUJMRV9DU1NfU0hBREVSUz0xJywKLSAg ICAgICdFTkFCTEVfQ1NTX1ZBUklBQkxFUz0wJywKKyAgICAgICdFTkFCTEVfQ1NTX1ZBUklBQkxF Uz0xJywKICAgICAgICdFTkFCTEVfQ1VTVE9NX1NDSEVNRV9IQU5ETEVSPTAnLAogICAgICAgJ0VO QUJMRV9EQVRBTElTVD0xJywKICAgICAgICdFTkFCTEVfREFTSEJPQVJEX1NVUFBPUlQ9MCcsCg==