91692 2012-07-18 16:24:02 -0700 [chromium] Add histogram for tracking compositor-thread frame rate 2012-07-18 18:08:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nduca nduca cc-bugs enne jamesr webkit.review.bot wiltzius oldest_to_newest 672937 0 nduca 2012-07-18 16:24:02 -0700 [chromium] Add histogram for tracking compositor-thread frame rate 672939 1 153130 nduca 2012-07-18 16:26:10 -0700 Created attachment 153130 Patch 672966 2 153130 enne 2012-07-18 16:37:49 -0700 Comment on attachment 153130 Patch What's the histogram for non-threaded mode? 672991 3 nduca 2012-07-18 17:04:16 -0700 its in RenderWidget either Renderer4.AccelDoDeferredUpdateDelay or Software 672998 4 153130 enne 2012-07-18 17:14:14 -0700 Comment on attachment 153130 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153130&action=review > Source/WebCore/platform/graphics/chromium/cc/CCFrameRateCounter.cpp:65 > + WebKit::Platform::current()->histogramCustomCounts("Renderer4.CompositorThreadImplDrawDelay", static_cast<int>(drawDelay), 1, 60, 30); Isn't drawDelay in seconds? 672999 5 153141 nduca 2012-07-18 17:14:24 -0700 Created attachment 153141 Patch 673000 6 153141 enne 2012-07-18 17:16:00 -0700 Comment on attachment 153141 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153141&action=review > Source/WebCore/platform/graphics/chromium/cc/CCFrameRateCounter.cpp:65 > + WebKit::Platform::current()->histogramCustomCounts("Renderer4.CompositorThreadImplDrawDelay", static_cast<int>(drawDelay), 1, 120, 60); Is there a reason not to use the same bucket spread as AccelDoDeferredUpdateDelay? The previous patch seemed better. 673004 7 153143 nduca 2012-07-18 17:18:13 -0700 Created attachment 153143 Patch 673008 8 enne 2012-07-18 17:21:35 -0700 (In reply to comment #6) > (From update of attachment 153141 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=153141&action=review > > > Source/WebCore/platform/graphics/chromium/cc/CCFrameRateCounter.cpp:65 > > + WebKit::Platform::current()->histogramCustomCounts("Renderer4.CompositorThreadImplDrawDelay", static_cast<int>(drawDelay), 1, 120, 60); > > Is there a reason not to use the same bucket spread as AccelDoDeferredUpdateDelay? The previous patch seemed better. Same question applies to this latest patch. 673012 9 nduca 2012-07-18 17:23:49 -0700 > Is there a reason not to use the same bucket spread as AccelDoDeferredUpdateDelay? The previous patch seemed better. Hehe yep. I'm boosting the range on those in this changelist: http://codereview.chromium.org/10802026/ Reason is, on those, with 0-60, 20% of the samples clip out at >60ms. I'd like to know how far that goes. 673015 10 153143 enne 2012-07-18 17:24:44 -0700 Comment on attachment 153143 Patch R=me. 673038 11 153143 webkit.review.bot 2012-07-18 18:08:36 -0700 Comment on attachment 153143 Patch Clearing flags on attachment: 153143 Committed r123056: <http://trac.webkit.org/changeset/123056> 673039 12 webkit.review.bot 2012-07-18 18:08:41 -0700 All reviewed patches have been landed. Closing bug. 153130 2012-07-18 16:26:10 -0700 2012-07-18 17:14:21 -0700 Patch bug-91692-20120718162610.patch text/plain 2010 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyODcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjMwYmViNDcyODBjMWJl NDUzZGQ0Mjc5Y2MzNTRmZGYwYTcwYWE1Zi4uMzQxNjM1N2MxNzJmNmQxYTFhNGM5MDA4MmZhZGFk MGIxYWE2YzU3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTE4ICBOYXQg RHVjYSAgPG5kdWNhQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEFkZCBoaXN0 b2dyYW0gZm9yIHRyYWNraW5nIGNvbXBvc2l0b3ItdGhyZWFkIGZyYW1lIHJhdGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNjkyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCB0cmFja3Mg dGhlIGludGVydmFsIGJldHdlZW4gY29tcG9zaXRvciB0aHJlYWQgZnJhbWVzCisgICAgICAgIGFu ZCBwdXNoZXMgaXQgaW50byBhIHBsYXRmb3JtIGhpc3RvZ3JhbS4gVGhpcyBhbGxvd3MgdXMgdG8g dHJhY2sKKyAgICAgICAgY29tcG9zaXRvci10aHJlYWQgZnJhbWUgcmF0ZSBpbiB0aGUgd2lsZC4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDRnJhbWVSYXRlQ291 bnRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDQ0ZyYW1lUmF0ZUNvdW50ZXI6Om1hcmtCZWdp bm5pbmdPZkZyYW1lKToKKwogMjAxMi0wNy0xNyAgTWF4IFZ1am92aWMgIDxtdnVqb3ZpY0BhZG9i ZS5jb20+CiAKICAgICAgICAgVXBkYXRlIEFOR0xFIGluIFdlYktpdApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NGcmFtZVJhdGVDb3Vu dGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0ND RnJhbWVSYXRlQ291bnRlci5jcHAKaW5kZXggZDZkZmYwNmFiMGNiMTg1MDc0NDIxNzQyYTExZTg0 NjUwNmUyM2VlOS4uZDE0YTc4ODE3ZDQ3ODI1YWI4MzYyNGFlYzYxZDg2NTRkZDMxMmYxOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NG cmFtZVJhdGVDb3VudGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9jYy9DQ0ZyYW1lUmF0ZUNvdW50ZXIuY3BwCkBAIC0yOCw2ICsyOCw3IEBACiAj aW5jbHVkZSAiQ0NGcmFtZVJhdGVDb3VudGVyLmgiCiAKICNpbmNsdWRlICJDQ1Byb3h5LmgiCisj aW5jbHVkZSA8cHVibGljL1BsYXRmb3JtLmg+CiAjaW5jbHVkZSA8d3RmL0N1cnJlbnRUaW1lLmg+ CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTU3LDYgKzU4LDEzIEBAIENDRnJhbWVSYXRlQ291 bnRlcjo6Q0NGcmFtZVJhdGVDb3VudGVyKCkKIAogdm9pZCBDQ0ZyYW1lUmF0ZUNvdW50ZXI6Om1h cmtCZWdpbm5pbmdPZkZyYW1lKGRvdWJsZSB0aW1lc3RhbXApCiB7CisgICAgaWYgKENDUHJveHk6 Omhhc0ltcGxUaHJlYWQoKSAmJiBtX2N1cnJlbnRGcmFtZU51bWJlciA+IDApIHsKKyAgICAgICAg ZG91YmxlIGxhc3RGcmFtZVRpbWVzdGFtcCA9IGZyYW1lSW5kZXgobV9jdXJyZW50RnJhbWVOdW1i ZXIgLSAxKTsKKyAgICAgICAgZG91YmxlIGRyYXdEZWxheSA9IHRpbWVzdGFtcCAtIGxhc3RGcmFt ZVRpbWVzdGFtcDsKKworICAgICAgICBXZWJLaXQ6OlBsYXRmb3JtOjpjdXJyZW50KCktPmhpc3Rv Z3JhbUN1c3RvbUNvdW50cygiUmVuZGVyZXI0LkNvbXBvc2l0b3JUaHJlYWRJbXBsRHJhd0RlbGF5 Iiwgc3RhdGljX2Nhc3Q8aW50PihkcmF3RGVsYXkpLCAxLCA2MCwgMzApOworICAgIH0KKwogICAg IG1fdGltZVN0YW1wSGlzdG9yeVtmcmFtZUluZGV4KG1fY3VycmVudEZyYW1lTnVtYmVyKV0gPSB0 aW1lc3RhbXA7CiB9CiAK 153141 2012-07-18 17:14:24 -0700 2012-07-18 17:18:10 -0700 Patch bug-91692-20120718171424.patch text/plain 2011 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyODcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjMwYmViNDcyODBjMWJl NDUzZGQ0Mjc5Y2MzNTRmZGYwYTcwYWE1Zi4uMzQxNjM1N2MxNzJmNmQxYTFhNGM5MDA4MmZhZGFk MGIxYWE2YzU3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTE4ICBOYXQg RHVjYSAgPG5kdWNhQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEFkZCBoaXN0 b2dyYW0gZm9yIHRyYWNraW5nIGNvbXBvc2l0b3ItdGhyZWFkIGZyYW1lIHJhdGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNjkyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCB0cmFja3Mg dGhlIGludGVydmFsIGJldHdlZW4gY29tcG9zaXRvciB0aHJlYWQgZnJhbWVzCisgICAgICAgIGFu ZCBwdXNoZXMgaXQgaW50byBhIHBsYXRmb3JtIGhpc3RvZ3JhbS4gVGhpcyBhbGxvd3MgdXMgdG8g dHJhY2sKKyAgICAgICAgY29tcG9zaXRvci10aHJlYWQgZnJhbWUgcmF0ZSBpbiB0aGUgd2lsZC4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDRnJhbWVSYXRlQ291 bnRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDQ0ZyYW1lUmF0ZUNvdW50ZXI6Om1hcmtCZWdp bm5pbmdPZkZyYW1lKToKKwogMjAxMi0wNy0xNyAgTWF4IFZ1am92aWMgIDxtdnVqb3ZpY0BhZG9i ZS5jb20+CiAKICAgICAgICAgVXBkYXRlIEFOR0xFIGluIFdlYktpdApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NGcmFtZVJhdGVDb3Vu dGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0ND RnJhbWVSYXRlQ291bnRlci5jcHAKaW5kZXggZDZkZmYwNmFiMGNiMTg1MDc0NDIxNzQyYTExZTg0 NjUwNmUyM2VlOS4uYjg5YzAxNGY0MWZmYTMwYTc0YTcwYzgwNTYwN2ZiMTViZmIzNDM0NyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NG cmFtZVJhdGVDb3VudGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9jYy9DQ0ZyYW1lUmF0ZUNvdW50ZXIuY3BwCkBAIC0yOCw2ICsyOCw3IEBACiAj aW5jbHVkZSAiQ0NGcmFtZVJhdGVDb3VudGVyLmgiCiAKICNpbmNsdWRlICJDQ1Byb3h5LmgiCisj aW5jbHVkZSA8cHVibGljL1BsYXRmb3JtLmg+CiAjaW5jbHVkZSA8d3RmL0N1cnJlbnRUaW1lLmg+ CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTU3LDYgKzU4LDEzIEBAIENDRnJhbWVSYXRlQ291 bnRlcjo6Q0NGcmFtZVJhdGVDb3VudGVyKCkKIAogdm9pZCBDQ0ZyYW1lUmF0ZUNvdW50ZXI6Om1h cmtCZWdpbm5pbmdPZkZyYW1lKGRvdWJsZSB0aW1lc3RhbXApCiB7CisgICAgaWYgKENDUHJveHk6 Omhhc0ltcGxUaHJlYWQoKSAmJiBtX2N1cnJlbnRGcmFtZU51bWJlciA+IDApIHsKKyAgICAgICAg ZG91YmxlIGxhc3RGcmFtZVRpbWVzdGFtcCA9IGZyYW1lSW5kZXgobV9jdXJyZW50RnJhbWVOdW1i ZXIgLSAxKTsKKyAgICAgICAgZG91YmxlIGRyYXdEZWxheSA9IHRpbWVzdGFtcCAtIGxhc3RGcmFt ZVRpbWVzdGFtcDsKKworICAgICAgICBXZWJLaXQ6OlBsYXRmb3JtOjpjdXJyZW50KCktPmhpc3Rv Z3JhbUN1c3RvbUNvdW50cygiUmVuZGVyZXI0LkNvbXBvc2l0b3JUaHJlYWRJbXBsRHJhd0RlbGF5 Iiwgc3RhdGljX2Nhc3Q8aW50PihkcmF3RGVsYXkpLCAxLCAxMjAsIDYwKTsKKyAgICB9CisKICAg ICBtX3RpbWVTdGFtcEhpc3RvcnlbZnJhbWVJbmRleChtX2N1cnJlbnRGcmFtZU51bWJlcildID0g dGltZXN0YW1wOwogfQogCg== 153143 2012-07-18 17:18:13 -0700 2012-07-18 18:08:36 -0700 Patch bug-91692-20120718171812.patch text/plain 2077 nduca U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyODcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjMwYmViNDcyODBjMWJl NDUzZGQ0Mjc5Y2MzNTRmZGYwYTcwYWE1Zi4uMzQxNjM1N2MxNzJmNmQxYTFhNGM5MDA4MmZhZGFk MGIxYWE2YzU3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA3LTE4ICBOYXQg RHVjYSAgPG5kdWNhQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIEFkZCBoaXN0 b2dyYW0gZm9yIHRyYWNraW5nIGNvbXBvc2l0b3ItdGhyZWFkIGZyYW1lIHJhdGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNjkyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBwYXRjaCB0cmFja3Mg dGhlIGludGVydmFsIGJldHdlZW4gY29tcG9zaXRvciB0aHJlYWQgZnJhbWVzCisgICAgICAgIGFu ZCBwdXNoZXMgaXQgaW50byBhIHBsYXRmb3JtIGhpc3RvZ3JhbS4gVGhpcyBhbGxvd3MgdXMgdG8g dHJhY2sKKyAgICAgICAgY29tcG9zaXRvci10aHJlYWQgZnJhbWUgcmF0ZSBpbiB0aGUgd2lsZC4K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDRnJhbWVSYXRlQ291 bnRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDQ0ZyYW1lUmF0ZUNvdW50ZXI6Om1hcmtCZWdp bm5pbmdPZkZyYW1lKToKKwogMjAxMi0wNy0xNyAgTWF4IFZ1am92aWMgIDxtdnVqb3ZpY0BhZG9i ZS5jb20+CiAKICAgICAgICAgVXBkYXRlIEFOR0xFIGluIFdlYktpdApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NGcmFtZVJhdGVDb3Vu dGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0ND RnJhbWVSYXRlQ291bnRlci5jcHAKaW5kZXggZDZkZmYwNmFiMGNiMTg1MDc0NDIxNzQyYTExZTg0 NjUwNmUyM2VlOS4uZDVhN2Q0Mjk1NTgzZTAzZDgzMjE1ZjMxMzA1MzA0MWNmMDJkMzgwOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NG cmFtZVJhdGVDb3VudGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9jaHJvbWl1bS9jYy9DQ0ZyYW1lUmF0ZUNvdW50ZXIuY3BwCkBAIC0yOCw2ICsyOCw3IEBACiAj aW5jbHVkZSAiQ0NGcmFtZVJhdGVDb3VudGVyLmgiCiAKICNpbmNsdWRlICJDQ1Byb3h5LmgiCisj aW5jbHVkZSA8cHVibGljL1BsYXRmb3JtLmg+CiAjaW5jbHVkZSA8d3RmL0N1cnJlbnRUaW1lLmg+ CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTU3LDYgKzU4LDE0IEBAIENDRnJhbWVSYXRlQ291 bnRlcjo6Q0NGcmFtZVJhdGVDb3VudGVyKCkKIAogdm9pZCBDQ0ZyYW1lUmF0ZUNvdW50ZXI6Om1h cmtCZWdpbm5pbmdPZkZyYW1lKGRvdWJsZSB0aW1lc3RhbXApCiB7CisgICAgaWYgKENDUHJveHk6 Omhhc0ltcGxUaHJlYWQoKSAmJiBtX2N1cnJlbnRGcmFtZU51bWJlciA+IDApIHsKKyAgICAgICAg ZG91YmxlIGxhc3RGcmFtZVRpbWVzdGFtcCA9IGZyYW1lSW5kZXgobV9jdXJyZW50RnJhbWVOdW1i ZXIgLSAxKTsKKyAgICAgICAgZG91YmxlIGRyYXdEZWxheVNlY29uZHMgPSB0aW1lc3RhbXAgLSBs YXN0RnJhbWVUaW1lc3RhbXA7CisgICAgICAgIGRvdWJsZSBkcmF3RGVsYXlNcyA9IGRyYXdEZWxh eVNlY29uZHMgKiAxMDAwLjA7CisKKyAgICAgICAgV2ViS2l0OjpQbGF0Zm9ybTo6Y3VycmVudCgp LT5oaXN0b2dyYW1DdXN0b21Db3VudHMoIlJlbmRlcmVyNC5Db21wb3NpdG9yVGhyZWFkSW1wbERy YXdEZWxheSIsIHN0YXRpY19jYXN0PGludD4oZHJhd0RlbGF5TXMpLCAxLCAxMjAsIDYwKTsKKyAg ICB9CisKICAgICBtX3RpbWVTdGFtcEhpc3RvcnlbZnJhbWVJbmRleChtX2N1cnJlbnRGcmFtZU51 bWJlcildID0gdGltZXN0YW1wOwogfQogCg==