91689 2012-07-18 16:07:16 -0700 [BlackBerry] Only maintain the hole punch rect while html5 video is being renderered 2012-11-02 12:52:07 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified CLOSED FIXED P2 Normal --- 1 mfeil mfeil eric.carlson feature-media-reviews mifenton tonikitoo webkit.review.bot oldest_to_newest 672917 0 mfeil 2012-07-18 16:07:16 -0700 This is for PR160619. The hole punch rectangle needs to be present if and only if html5 video content is being rendered. Otherwise unwanted content may show through from behind the browser tab's window. 672926 1 153128 mfeil 2012-07-18 16:15:28 -0700 Created attachment 153128 Patch 673513 2 153128 tonikitoo 2012-07-19 07:58:37 -0700 Comment on attachment 153128 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=153128&action=review Good stuff Nit: comments in the code need period at the end. Please reupload with "Reviewed by Antonio Gomes" and only ask for commit-queue. No need to get it reviewed again. > Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:512 > + // Remove media player from platform layer (removes hole punch rect) comments are real sentenses > Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:525 > + // Create platform layer for video (creates hole punch rect) ditto 673742 3 153315 mfeil 2012-07-19 11:52:10 -0700 Created attachment 153315 Patch 673748 4 mfeil 2012-07-19 11:54:51 -0700 The only change in the latest patch is the addition of periods to the ends of comments, and setting "Antonio Gomes" as the reviewer in the changelog entry. 673813 5 153315 webkit.review.bot 2012-07-19 12:49:01 -0700 Comment on attachment 153315 Patch Clearing flags on attachment: 153315 Committed r123138: <http://trac.webkit.org/changeset/123138> 673814 6 webkit.review.bot 2012-07-19 12:49:13 -0700 All reviewed patches have been landed. Closing bug. 757490 7 mfeil 2012-11-02 12:50:53 -0700 Closing bug for patch that landed a long time ago. 757493 8 mfeil 2012-11-02 12:52:07 -0700 Closing bug for patch that landed a long time ago. 153128 2012-07-18 16:15:28 -0700 2012-07-19 11:52:06 -0700 Patch bug-91689-20120718191527.patch text/plain 3029 mfeil U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmMyYTFiZTI2Y2ZkOWQw MzlmY2Y1OThhNjdjMDM2YzJjYTAwYmJlMy4uYzc3MTkzYzVhYzBjZGYzZDVjMDE3MTRmMGI3MmU2 ODY3OWVjYmYxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA3LTE4ICBNYXgg RmVpbCAgPG1mZWlsQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIE9ubHkgbWFpbnRh aW4gdGhlIGhvbGUgcHVuY2ggcmVjdCB3aGlsZSBodG1sNSB2aWRlbyBpcyBiZWluZyByZW5kZXJl cmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTY4 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBo b2xlIHB1bmNoIHJlY3RhbmdsZSBuZWVkcyB0byBiZSBwcmVzZW50IGlmIGFuZCBvbmx5IGlmIGh0 bWw1CisgICAgICAgIHZpZGVvIGNvbnRlbnQgaXMgYmVpbmcgcmVuZGVyZWQuIE90aGVyd2lzZSB1 bndhbnRlZCBjb250ZW50IG1heQorICAgICAgICBzaG93IHRocm91Z2ggZnJvbSBiZWhpbmQgdGhl IGJyb3dzZXIgdGFiJ3Mgd2luZG93LgorCisgICAgICAgIEkgYW0gbm90IGFkZGluZyBhbnkgbmV3 IHRlc3RzIGJlY2F1c2UgdGhlIGRpZmZpY3VsdHkgb2YgdGVzdGluZworICAgICAgICBmb3IgdGhp cyBjYXNlIG91dHdlaWdocyB0aGUgYmVuZWZpdC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2JsYWNrYmVycnkvTWVkaWFQbGF5ZXJQcml2YXRlQmxhY2tCZXJyeS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGU6OnVwZGF0ZVN0YXRlcyk6CisKIDIwMTItMDct MTggIEFsZXhhbmRyZSBFbGlhcyAgPGFlbGlhc0Bnb29nbGUuY29tPgogCiAgICAgICAgIFtjaHJv bWl1bV0gVWJlcmNvbXA6IGFkZCBpZCB0byBTaGFyZWRRdWFkU3RhdGUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvTWVkaWFQbGF5ZXJQcml2 YXRlQmxhY2tCZXJyeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFj a2JlcnJ5L01lZGlhUGxheWVyUHJpdmF0ZUJsYWNrQmVycnkuY3BwCmluZGV4IDc4MWRmYzVjODhh NWM5MGQ4ZGQ1ZTI1NzM0ZTU5MzkzYzg0NTg0ZGQuLmVkZjAxMTViNzk2OTVjMmZlMWMxNzcwZWU1 NWQ0OTFjMTdhOTA3MjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2JsYWNrYmVycnkvTWVkaWFQbGF5ZXJQcml2YXRlQmxhY2tCZXJyeS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9NZWRpYVBsYXllclByaXZh dGVCbGFja0JlcnJ5LmNwcApAQCAtNTA5LDYgKzUwOSwxMSBAQCB2b2lkIE1lZGlhUGxheWVyUHJp dmF0ZTo6dXBkYXRlU3RhdGVzKCkKICNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCiAg ICAgICAgICAgICBzZXRCdWZmZXJpbmcoZmFsc2UpOwogICAgICAgICAgICAgbV9tZWRpYUlzQnVm ZmVyaW5nID0gZmFsc2U7CisgICAgICAgICAgICAvLyBSZW1vdmUgbWVkaWEgcGxheWVyIGZyb20g cGxhdGZvcm0gbGF5ZXIgKHJlbW92ZXMgaG9sZSBwdW5jaCByZWN0KQorICAgICAgICAgICAgaWYg KG1fcGxhdGZvcm1MYXllcikgeworICAgICAgICAgICAgICAgIHN0YXRpY19jYXN0PFZpZGVvTGF5 ZXJXZWJLaXRUaHJlYWQqPihtX3BsYXRmb3JtTGF5ZXIuZ2V0KCkpLT5zZXRNZWRpYVBsYXllcigw KTsKKyAgICAgICAgICAgICAgICBtX3BsYXRmb3JtTGF5ZXIuY2xlYXIoKTsKKyAgICAgICAgICAg IH0KICNlbmRpZgogICAgICAgICAgICAgaWYgKGlzRnVsbHNjcmVlbigpKQogICAgICAgICAgICAg ICAgIGVsZW1lbnQtPmV4aXRGdWxsc2NyZWVuKCk7CkBAIC01MTcsNiArNTIyLDkgQEAgdm9pZCBN ZWRpYVBsYXllclByaXZhdGU6OnVwZGF0ZVN0YXRlcygpCiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NP TVBPU0lUSU5HKQogICAgICAgICAgICAgbV9zaG93QnVmZmVyaW5nSW1hZ2UgPSBmYWxzZTsKICAg ICAgICAgICAgIG1fbWVkaWFJc0J1ZmZlcmluZyA9IGZhbHNlOworICAgICAgICAgICAgLy8gQ3Jl YXRlIHBsYXRmb3JtIGxheWVyIGZvciB2aWRlbyAoY3JlYXRlcyBob2xlIHB1bmNoIHJlY3QpCisg ICAgICAgICAgICBpZiAoIW1fcGxhdGZvcm1MYXllcikKKyAgICAgICAgICAgICAgICBtX3BsYXRm b3JtTGF5ZXIgPSBWaWRlb0xheWVyV2ViS2l0VGhyZWFkOjpjcmVhdGUobV93ZWJDb3JlUGxheWVy KTsKICNlbmRpZgogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgTU1SUGxheWVyOjpN UF9TVEFURV9VTlNVUFBPUlRFRDoKQEAgLTUyOSwxNCArNTM3LDggQEAgdm9pZCBNZWRpYVBsYXll clByaXZhdGU6OnVwZGF0ZVN0YXRlcygpCiAgICAgICAgICAgICBtX3JlYWR5U3RhdGUgPSBNZWRp YVBsYXllcjo6SGF2ZUVub3VnaERhdGE7CiAgICAgfQogCi0gICAgaWYgKG1fcmVhZHlTdGF0ZSAh PSBvbGRSZWFkeVN0YXRlKSB7CisgICAgaWYgKG1fcmVhZHlTdGF0ZSAhPSBvbGRSZWFkeVN0YXRl KQogICAgICAgICBtX3dlYkNvcmVQbGF5ZXItPnJlYWR5U3RhdGVDaGFuZ2VkKCk7Ci0jaWYgVVNF KEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQotICAgICAgICAvLyBDcmVhdGUgcGxhdGZvcm0gbGF5 ZXIgZm9yIHZpZGVvLgotICAgICAgICBpZiAoIW1fcGxhdGZvcm1MYXllcikKLSAgICAgICAgICAg IG1fcGxhdGZvcm1MYXllciA9IFZpZGVvTGF5ZXJXZWJLaXRUaHJlYWQ6OmNyZWF0ZShtX3dlYkNv cmVQbGF5ZXIpOwotI2VuZGlmCi0gICAgfQogICAgIGlmIChtX25ldHdvcmtTdGF0ZSAhPSBvbGRO ZXR3b3JrU3RhdGUpCiAgICAgICAgIG1fd2ViQ29yZVBsYXllci0+bmV0d29ya1N0YXRlQ2hhbmdl ZCgpOwogfQo= 153315 2012-07-19 11:52:10 -0700 2012-07-19 12:49:01 -0700 Patch bug-91689-20120719145209.patch text/plain 3028 mfeil U3VidmVyc2lvbiBSZXZpc2lvbjogMTIzMDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmMyYTFiZTI2Y2ZkOWQw MzlmY2Y1OThhNjdjMDM2YzJjYTAwYmJlMy4uMTAxODcxNjBlZDA2N2Y5ZjM1YzhhOWZlYTEzNDAy NDEzM2FlZjc3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA3LTE4ICBNYXgg RmVpbCAgPG1mZWlsQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIE9ubHkgbWFpbnRh aW4gdGhlIGhvbGUgcHVuY2ggcmVjdCB3aGlsZSBodG1sNSB2aWRlbyBpcyBiZWluZyByZW5kZXJl cmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTY4 OQorCisgICAgICAgIFJldmlld2VkIGJ5IEFudG9uaW8gR29tZXMuCisKKyAgICAgICAgVGhlIGhv bGUgcHVuY2ggcmVjdGFuZ2xlIG5lZWRzIHRvIGJlIHByZXNlbnQgaWYgYW5kIG9ubHkgaWYgaHRt bDUKKyAgICAgICAgdmlkZW8gY29udGVudCBpcyBiZWluZyByZW5kZXJlZC4gT3RoZXJ3aXNlIHVu d2FudGVkIGNvbnRlbnQgbWF5CisgICAgICAgIHNob3cgdGhyb3VnaCBmcm9tIGJlaGluZCB0aGUg YnJvd3NlciB0YWIncyB3aW5kb3cuCisKKyAgICAgICAgSSBhbSBub3QgYWRkaW5nIGFueSBuZXcg dGVzdHMgYmVjYXVzZSB0aGUgZGlmZmljdWx0eSBvZiB0ZXN0aW5nCisgICAgICAgIGZvciB0aGlz IGNhc2Ugb3V0d2VpZ2hzIHRoZSBiZW5lZml0LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvYmxhY2tiZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6dXBkYXRlU3RhdGVzKToKKwogMjAxMi0wNy0x OCAgQWxleGFuZHJlIEVsaWFzICA8YWVsaWFzQGdvb2dsZS5jb20+CiAKICAgICAgICAgW2Nocm9t aXVtXSBVYmVyY29tcDogYWRkIGlkIHRvIFNoYXJlZFF1YWRTdGF0ZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9NZWRpYVBsYXllclByaXZh dGVCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNr YmVycnkvTWVkaWFQbGF5ZXJQcml2YXRlQmxhY2tCZXJyeS5jcHAKaW5kZXggNzgxZGZjNWM4OGE1 YzkwZDhkZDVlMjU3MzRlNTkzOTNjODQ1ODRkZC4uMjdmZGY2NDkxMGQ0NDcyOGMzZTFhNDgxNTMw YzRjZTg5ODY5OGY3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvYmxhY2tiZXJyeS9NZWRpYVBsYXllclByaXZhdGVCbGFja0JlcnJ5LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L01lZGlhUGxheWVyUHJpdmF0 ZUJsYWNrQmVycnkuY3BwCkBAIC01MDksNiArNTA5LDExIEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2 YXRlOjp1cGRhdGVTdGF0ZXMoKQogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKICAg ICAgICAgICAgIHNldEJ1ZmZlcmluZyhmYWxzZSk7CiAgICAgICAgICAgICBtX21lZGlhSXNCdWZm ZXJpbmcgPSBmYWxzZTsKKyAgICAgICAgICAgIC8vIFJlbW92ZSBtZWRpYSBwbGF5ZXIgZnJvbSBw bGF0Zm9ybSBsYXllciAocmVtb3ZlIGhvbGUgcHVuY2ggcmVjdCkuCisgICAgICAgICAgICBpZiAo bV9wbGF0Zm9ybUxheWVyKSB7CisgICAgICAgICAgICAgICAgc3RhdGljX2Nhc3Q8VmlkZW9MYXll cldlYktpdFRocmVhZCo+KG1fcGxhdGZvcm1MYXllci5nZXQoKSktPnNldE1lZGlhUGxheWVyKDAp OworICAgICAgICAgICAgICAgIG1fcGxhdGZvcm1MYXllci5jbGVhcigpOworICAgICAgICAgICAg fQogI2VuZGlmCiAgICAgICAgICAgICBpZiAoaXNGdWxsc2NyZWVuKCkpCiAgICAgICAgICAgICAg ICAgZWxlbWVudC0+ZXhpdEZ1bGxzY3JlZW4oKTsKQEAgLTUxNyw2ICs1MjIsOSBAQCB2b2lkIE1l ZGlhUGxheWVyUHJpdmF0ZTo6dXBkYXRlU3RhdGVzKCkKICNpZiBVU0UoQUNDRUxFUkFURURfQ09N UE9TSVRJTkcpCiAgICAgICAgICAgICBtX3Nob3dCdWZmZXJpbmdJbWFnZSA9IGZhbHNlOwogICAg ICAgICAgICAgbV9tZWRpYUlzQnVmZmVyaW5nID0gZmFsc2U7CisgICAgICAgICAgICAvLyBDcmVh dGUgcGxhdGZvcm0gbGF5ZXIgZm9yIHZpZGVvIChjcmVhdGUgaG9sZSBwdW5jaCByZWN0KS4KKyAg ICAgICAgICAgIGlmICghbV9wbGF0Zm9ybUxheWVyKQorICAgICAgICAgICAgICAgIG1fcGxhdGZv cm1MYXllciA9IFZpZGVvTGF5ZXJXZWJLaXRUaHJlYWQ6OmNyZWF0ZShtX3dlYkNvcmVQbGF5ZXIp OwogI2VuZGlmCiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBNTVJQbGF5ZXI6Ok1Q X1NUQVRFX1VOU1VQUE9SVEVEOgpAQCAtNTI5LDE0ICs1MzcsOCBAQCB2b2lkIE1lZGlhUGxheWVy UHJpdmF0ZTo6dXBkYXRlU3RhdGVzKCkKICAgICAgICAgICAgIG1fcmVhZHlTdGF0ZSA9IE1lZGlh UGxheWVyOjpIYXZlRW5vdWdoRGF0YTsKICAgICB9CiAKLSAgICBpZiAobV9yZWFkeVN0YXRlICE9 IG9sZFJlYWR5U3RhdGUpIHsKKyAgICBpZiAobV9yZWFkeVN0YXRlICE9IG9sZFJlYWR5U3RhdGUp CiAgICAgICAgIG1fd2ViQ29yZVBsYXllci0+cmVhZHlTdGF0ZUNoYW5nZWQoKTsKLSNpZiBVU0Uo QUNDRUxFUkFURURfQ09NUE9TSVRJTkcpCi0gICAgICAgIC8vIENyZWF0ZSBwbGF0Zm9ybSBsYXll ciBmb3IgdmlkZW8uCi0gICAgICAgIGlmICghbV9wbGF0Zm9ybUxheWVyKQotICAgICAgICAgICAg bV9wbGF0Zm9ybUxheWVyID0gVmlkZW9MYXllcldlYktpdFRocmVhZDo6Y3JlYXRlKG1fd2ViQ29y ZVBsYXllcik7Ci0jZW5kaWYKLSAgICB9CiAgICAgaWYgKG1fbmV0d29ya1N0YXRlICE9IG9sZE5l dHdvcmtTdGF0ZSkKICAgICAgICAgbV93ZWJDb3JlUGxheWVyLT5uZXR3b3JrU3RhdGVDaGFuZ2Vk KCk7CiB9Cg==