91671 2012-07-18 14:27:51 -0700 [Chromium] WebView is missing isSelectionEditable and backgroundColor which are used by chromium-android 2012-07-19 11:10:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91648 1 abarth abarth dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 672757 0 abarth 2012-07-18 14:27:51 -0700 [Chromium] WebView is missing isSelectionEditable and backgroundColor which are used by chromium-android 672759 1 153089 abarth 2012-07-18 14:28:33 -0700 Created attachment 153089 Patch 672760 2 webkit.review.bot 2012-07-18 14:31:37 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 673701 3 153089 webkit.review.bot 2012-07-19 11:10:23 -0700 Comment on attachment 153089 Patch Clearing flags on attachment: 153089 Committed r123123: <http://trac.webkit.org/changeset/123123> 673702 4 webkit.review.bot 2012-07-19 11:10:28 -0700 All reviewed patches have been landed. Closing bug. 153089 2012-07-18 14:28:33 -0700 2012-07-19 11:10:23 -0700 Patch bug-91671-20120718142832.patch text/plain 4352 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyODU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGYxMTUxOTg5OWIwYzJkNTJkYWE1M2E3MTA4YTc3NDU3ODk3OWJiMTYuLmVlMzczMmQwN2I2NWQz MmNmNjY0Y2I3MTRmYjAyM2IyNWU0ODQ3ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjUgQEAKKzIwMTItMDctMTggIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9y Zz4KKworICAgICAgICBbQ2hyb21pdW1dIFdlYlZpZXcgaXMgbWlzc2luZyBpc1NlbGVjdGlvbkVk aXRhYmxlIGFuZCBiYWNrZ3JvdW5kQ29sb3Igd2hpY2ggYXJlIHVzZWQgYnkgY2hyb21pdW0tYW5k cm9pZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE2 NzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJIGhh dmVuJ3Qgc3R1ZGllZCB3aGF0IHRoZXNlIEFQSXMgYXJlIHVzZWQgZm9yIGRvd25zdHJlYW0sIGJ1 dCB0aGV5CisgICAgICAgIHNlZW0gaGFybWxlc3MgZW5vdWdoLgorCisgICAgICAgICogcHVibGlj L1dlYlZpZXcuaDoKKyAgICAgICAgKFdlYlZpZXcpOgorICAgICAgICAqIHB1YmxpYy9XZWJXaWRn ZXQuaDoKKyAgICAgICAgKFdlYldpZGdldCk6CisgICAgICAgIChXZWJLaXQ6OldlYldpZGdldDo6 YmFja2dyb3VuZENvbG9yKToKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3BwOgorICAgICAg ICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6aXNTZWxlY3Rpb25FZGl0YWJsZSk6CisgICAgICAgIChX ZWJLaXQpOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6YmFja2dyb3VuZENvbG9yKToK KyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuaDoKKyAgICAgICAgKFdlYlZpZXdJbXBsKToKKwog MjAxMi0wNy0xNyAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVu cmV2aWV3ZWQuICBSb2xsZWQgREVQUy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYlZpZXcuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlZp ZXcuaAppbmRleCAzYmE1ZGEyNGZhZTZlMGM3ZDZkNTYzNDI0MDY0YzM4ZjZiZjVlZWE1Li43ZGI2 ODdhNmUwNjIwMzU5MGJhNjMzN2ZhNzM1YTEyMDc4YmUwMzc4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9wdWJsaWMvV2ViVmlldy5oCkBAIC00NDYsNiArNDQ2LDggQEAgcHVibGljOgogCiAgICAg dmlydHVhbCBib29sIHNldEVkaXRhYmxlU2VsZWN0aW9uT2Zmc2V0cyhpbnQgc3RhcnQsIGludCBl bmQpID0gMDsKIAorICAgIHZpcnR1YWwgYm9vbCBpc1NlbGVjdGlvbkVkaXRhYmxlKCkgY29uc3Qg PSAwOworCiAgICAgLy8gRmlsbHMgaW4gYSBXZWJSZW5kZXJpbmdTdGF0cyBzdHJ1Y3QgY29udGFp bmluZyBpbmZvcm1hdGlvbiBhYm91dCB0aGUgc3RhdGUgb2YgdGhlIGNvbXBvc2l0b3IuCiAgICAg Ly8gVGhpcyBjYWxsIGlzIHJlbGF0aXZlbHkgZXhwZW5zaXZlIGluIHRocmVhZGVkIG1vZGUgYXMg aXQgYmxvY2tzIG9uIHRoZSBjb21wb3NpdG9yIHRocmVhZC4KICAgICB2aXJ0dWFsIHZvaWQgcmVu ZGVyaW5nU3RhdHMoV2ViUmVuZGVyaW5nU3RhdHMmKSBjb25zdCB7IH0KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYldpZGdldC5oIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViV2lkZ2V0LmgKaW5kZXggMDhiMmNkMDVhMjVhZGNiNGFmZDZkYmY0 OGFlMTM0YmIzNmZjN2VjZi4uNjAwYzUyM2Y4YWUyMGZiOGNlOGU1NTUwMTNiN2I4ODk1ZjgxMTRj NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViV2lkZ2V0LmgK KysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViV2lkZ2V0LmgKQEAgLTIyMSw2 ICsyMjEsMTAgQEAgcHVibGljOgogICAgIC8vIGZvbGxvd2luZyB0aGUgY2FsbCB0byBpbnN0cnVt ZW50QmVnaW5GcmFtZSgpLgogICAgIHZpcnR1YWwgdm9pZCBpbnN0cnVtZW50Q2FuY2VsRnJhbWUo KSB7IH0KIAorICAgIC8vIFRoZSBwYWdlIGJhY2tncm91bmQgY29sb3IuIENhbiBiZSB1c2VkIGZv ciBmaWxsaW5nIGluIGFyZWFzIHdpdGhvdXQKKyAgICAvLyBjb250ZW50LgorICAgIHZpcnR1YWwg V2ViQ29sb3IgYmFja2dyb3VuZENvbG9yKCkgY29uc3QgeyByZXR1cm4gMHhGRkZGRkZGRjsgLyog U0tfQ29sb3JXSElURSAqLyB9CisKIHByb3RlY3RlZDoKICAgICB+V2ViV2lkZ2V0KCkgeyB9CiB9 OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3Bw IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IGUzNDkx NTFmYWQxNDQ3OTgyMGVlYzY2ZmM2M2YxZDg0NWJjNmE2YWMuLmFjMTg4N2YyMDJhNTVmZTU2OWM2 MzdlNzgwZTBkMTllNGRhNGJiMzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJW aWV3SW1wbC5jcHAKQEAgLTIxNDgsNiArMjE0OCwyNSBAQCBib29sIFdlYlZpZXdJbXBsOjpzZXRF ZGl0YWJsZVNlbGVjdGlvbk9mZnNldHMoaW50IHN0YXJ0LCBpbnQgZW5kKQogICAgIHJldHVybiBl ZGl0b3ItPnNldFNlbGVjdGlvbk9mZnNldHMoc3RhcnQsIGVuZCk7CiB9CiAKK2Jvb2wgV2ViVmll d0ltcGw6OmlzU2VsZWN0aW9uRWRpdGFibGUoKSBjb25zdAoreworICAgIGNvbnN0IEZyYW1lKiBm cmFtZSA9IGZvY3VzZWRXZWJDb3JlRnJhbWUoKTsKKyAgICBpZiAoIWZyYW1lKQorICAgICAgICBy ZXR1cm4gZmFsc2U7CisgICAgcmV0dXJuIGZyYW1lLT5zZWxlY3Rpb24oKS0+aXNDb250ZW50RWRp dGFibGUoKTsKK30KKworV2ViQ29sb3IgV2ViVmlld0ltcGw6OmJhY2tncm91bmRDb2xvcigpIGNv bnN0Cit7CisgICAgaWYgKCFtX3BhZ2UpCisgICAgICAgIHJldHVybiBDb2xvcjo6d2hpdGU7Cisg ICAgRnJhbWVWaWV3KiB2aWV3ID0gbV9wYWdlLT5tYWluRnJhbWUoKS0+dmlldygpOworICAgIENv bG9yIGJhY2tncm91bmRDb2xvciA9IHZpZXctPmRvY3VtZW50QmFja2dyb3VuZENvbG9yKCk7Cisg ICAgaWYgKCFiYWNrZ3JvdW5kQ29sb3IuaXNWYWxpZCgpKQorICAgICAgICByZXR1cm4gQ29sb3I6 OndoaXRlOworICAgIHJldHVybiBiYWNrZ3JvdW5kQ29sb3IucmdiKCk7Cit9CisKIGJvb2wgV2Vi Vmlld0ltcGw6OmNhcmV0T3JTZWxlY3Rpb25SYW5nZShzaXplX3QqIGxvY2F0aW9uLCBzaXplX3Qq IGxlbmd0aCkKIHsKICAgICBjb25zdCBGcmFtZSogZm9jdXNlZCA9IGZvY3VzZWRXZWJDb3JlRnJh bWUoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBs LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCmluZGV4IDhmNmJk ZjQwYjgyMWQxYWJjNmFiZGFmMGM3YmUxOGJkZTAyYjFhNTAuLjZlNmViNzViMDUxOTMwNjFmMTVj NmY2MzYzZDdlNWM4NDEwYWQ1YjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmll d0ltcGwuaApAQCAtMTU5LDYgKzE1OSw4IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIFdlYlRleHRJ bnB1dEluZm8gdGV4dElucHV0SW5mbygpOwogICAgIHZpcnR1YWwgV2ViVGV4dElucHV0VHlwZSB0 ZXh0SW5wdXRUeXBlKCk7CiAgICAgdmlydHVhbCBib29sIHNldEVkaXRhYmxlU2VsZWN0aW9uT2Zm c2V0cyhpbnQgc3RhcnQsIGludCBlbmQpOworICAgIHZpcnR1YWwgYm9vbCBpc1NlbGVjdGlvbkVk aXRhYmxlKCkgY29uc3Q7CisgICAgdmlydHVhbCBXZWJDb2xvciBiYWNrZ3JvdW5kQ29sb3IoKSBj b25zdDsKICAgICB2aXJ0dWFsIGJvb2wgc2VsZWN0aW9uQm91bmRzKFdlYlJlY3QmIHN0YXJ0LCBX ZWJSZWN0JiBlbmQpIGNvbnN0OwogICAgIHZpcnR1YWwgYm9vbCBzZWxlY3Rpb25UZXh0RGlyZWN0 aW9uKFdlYlRleHREaXJlY3Rpb24mIHN0YXJ0LCBXZWJUZXh0RGlyZWN0aW9uJiBlbmQpIGNvbnN0 OwogICAgIHZpcnR1YWwgYm9vbCBjYXJldE9yU2VsZWN0aW9uUmFuZ2Uoc2l6ZV90KiBsb2NhdGlv biwgc2l6ZV90KiBsZW5ndGgpOwo=