91669 2012-07-18 14:22:41 -0700 Move WebAudioSourceProvider destructor from public to protected 2012-07-19 11:06:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 scherkus scherkus abarth dglazkov eric.carlson feature-media-reviews fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 672749 0 scherkus 2012-07-18 14:22:41 -0700 Move WebAudioSourceProvider destructor from public to protected 672751 1 153087 scherkus 2012-07-18 14:23:05 -0700 Created attachment 153087 Patch 672752 2 webkit.review.bot 2012-07-18 14:25:02 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 672756 3 153088 scherkus 2012-07-18 14:26:11 -0700 Created attachment 153088 Patch 673631 4 scherkus 2012-07-19 10:20:41 -0700 merci! 673692 5 153088 webkit.review.bot 2012-07-19 11:06:02 -0700 Comment on attachment 153088 Patch Clearing flags on attachment: 153088 Committed r123122: <http://trac.webkit.org/changeset/123122> 673693 6 webkit.review.bot 2012-07-19 11:06:07 -0700 All reviewed patches have been landed. Closing bug. 153087 2012-07-18 14:23:05 -0700 2012-07-18 14:26:07 -0700 Patch bug-91669-20120718142305.patch text/plain 1488 scherkus U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNhMDA0OTE2OGRkZTY1NWRmOGRkOTA3MmZkMGZkZjExNWVhYmEwZTguLmI5NmMyNjUzYmM3Y2E1 YTQ1ZWRlOWY4ZGRlMGMwN2FlZDA4YTVmZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTItMDctMTggIEFuZHJldyBTY2hlcmt1cyAgPHNjaGVya3VzQGNo cm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIE1vdmUgV2ViQXVkaW9Tb3VyY2VQcm92 aWRlciBkZXN0cnVjdG9yIGZyb20gcHVibGljIHRvIHByb3RlY3RlZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE2NjkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpdGlvbmFsIGluZm9ybWF0aW9uIG9m IHRoZSBjaGFuZ2Ugc3VjaCBhcyBhcHByb2FjaCwgcmF0aW9uYWxlLiBQbGVhc2UgYWRkIHBlci1m dW5jdGlvbiBkZXNjcmlwdGlvbnMgYmVsb3cgKE9PUFMhKS4KKworICAgICAgICAqIHB1YmxpYy9X ZWJBdWRpb1NvdXJjZVByb3ZpZGVyLmg6CisgICAgICAgIChXZWJBdWRpb1NvdXJjZVByb3ZpZGVy KToKKwogMjAxMi0wNy0xMyAgRXJpYyBQZW5uZXIgIDxlcGVubmVyQGdvb2dsZS5jb20+CiAKICAg ICAgICAgW2Nocm9taXVtXSBBZGQgJ3NlbGYtbWFuYWdlZCcgb3B0aW9uIHRvIENDUHJpb3JpdGl6 ZWRUZXh0dXJlIHRvIGVuYWJsZSByZW5kZXItc3VyZmFjZSBhbmQgY2FudmFzIHVzZSBjYXNlcy4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkF1ZGlvU291cmNl UHJvdmlkZXIuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkF1ZGlvU291cmNl UHJvdmlkZXIuaAppbmRleCBjMDAxMGY4MDYyN2Y2YWQxMDhhZDZmNmNiYTZkMzFlODNjMjlhMmFh Li45OGM3NjIyODRmY2Q3NTJiZmE3MWRmOTdmOWQzNTg1MzFjODM1Y2Q1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJBdWRpb1NvdXJjZVByb3ZpZGVyLmgKKysr IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQXVkaW9Tb3VyY2VQcm92aWRlci5o CkBAIC00MCw2ICs0MCw3IEBAIHB1YmxpYzoKICAgICAvLyBJZiBhIGNsaWVudCBpcyBzZXQsIHdl IGNhbGwgaXQgYmFjayB3aGVuIHRoZSBhdWRpbyBmb3JtYXQgaXMgYXZhaWxhYmxlLgogICAgIHZp cnR1YWwgdm9pZCBzZXRDbGllbnQoV2ViQXVkaW9Tb3VyY2VQcm92aWRlckNsaWVudCopIHsgfTsK IAorcHJvdGVjdGVkOgogICAgIHZpcnR1YWwgfldlYkF1ZGlvU291cmNlUHJvdmlkZXIoKSB7IH0K IH07CiAK 153088 2012-07-18 14:26:11 -0700 2012-07-19 11:06:02 -0700 Patch bug-91669-20120718142611.patch text/plain 1492 scherkus U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyNzE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGNhMDA0OTE2OGRkZTY1NWRmOGRkOTA3MmZkMGZkZjExNWVhYmEwZTguLjc2M2I3ZjUwNGIwYjZj Y2M2YzdmMDVjNTcwNDZkNGY1YTdhNGZiOGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMDctMTggIEFuZHJldyBTY2hlcmt1cyAgPHNjaGVya3VzQGNo cm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIE1vdmUgV2ViQXVkaW9Tb3VyY2VQcm92 aWRlciBkZXN0cnVjdG9yIGZyb20gcHVibGljIHRvIHByb3RlY3RlZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE2NjkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgbGlmZXRpbWUgb2YgYSBXZWJBdWRp b1NvdXJjZVByb3ZpZGVyIGlzIG1hbmFnZWQgYnkgdGhlIGltcGxlbWVudG9yCisgICAgICAgIGFu ZCBzaG91bGQgbmV2ZXIgYmUgZGVhbGxvY3RlZCBieSBXZWJLaXQuCisKKyAgICAgICAgKiBwdWJs aWMvV2ViQXVkaW9Tb3VyY2VQcm92aWRlci5oOgorICAgICAgICAoV2ViQXVkaW9Tb3VyY2VQcm92 aWRlcik6CisKIDIwMTItMDctMTMgIEVyaWMgUGVubmVyICA8ZXBlbm5lckBnb29nbGUuY29tPgog CiAgICAgICAgIFtjaHJvbWl1bV0gQWRkICdzZWxmLW1hbmFnZWQnIG9wdGlvbiB0byBDQ1ByaW9y aXRpemVkVGV4dHVyZSB0byBlbmFibGUgcmVuZGVyLXN1cmZhY2UgYW5kIGNhbnZhcyB1c2UgY2Fz ZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJBdWRpb1Nv dXJjZVByb3ZpZGVyLmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJBdWRpb1Nv dXJjZVByb3ZpZGVyLmgKaW5kZXggYzAwMTBmODA2MjdmNmFkMTA4YWQ2ZjZjYmE2ZDMxZTgzYzI5 YTJhYS4uOThjNzYyMjg0ZmNkNzUyYmZhNzFkZjk3ZjlkMzU4NTMxYzgzNWNkNSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQXVkaW9Tb3VyY2VQcm92aWRlci5o CisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkF1ZGlvU291cmNlUHJvdmlk ZXIuaApAQCAtNDAsNiArNDAsNyBAQCBwdWJsaWM6CiAgICAgLy8gSWYgYSBjbGllbnQgaXMgc2V0 LCB3ZSBjYWxsIGl0IGJhY2sgd2hlbiB0aGUgYXVkaW8gZm9ybWF0IGlzIGF2YWlsYWJsZS4KICAg ICB2aXJ0dWFsIHZvaWQgc2V0Q2xpZW50KFdlYkF1ZGlvU291cmNlUHJvdmlkZXJDbGllbnQqKSB7 IH07CiAKK3Byb3RlY3RlZDoKICAgICB2aXJ0dWFsIH5XZWJBdWRpb1NvdXJjZVByb3ZpZGVyKCkg eyB9CiB9OwogCg==