9166 2006-05-29 18:10:45 -0700 Setting iframe.src is not registered in history 2013-04-20 06:09:12 -0700 1 1 1 Unclassified WebKit History 420+ Mac OS X 10.4 RESOLVED FIXED HasReduction P2 Normal --- 36382 9150 1 ddkilzer fishd abarth andersca arturadib fishd ggaren kangax priyajeet.hora oldest_to_newest 43899 0 ddkilzer 2006-05-29 18:10:45 -0700 Setting iframe.src to load a page in an iframe does not cause that URL to be recorded in the history. When a link to the previously loaded page appears later, that link is rendered as unvisited rather than visited. In Firefox 1.5.0.3 on Mac OS X, a page loaded via iframe.src is recorded in history. In MSIE 6 on WinXP SP2, a page loaded via iframe.src is NOT recorded in history. This behavior occurs in Safari 2.0.3 (417.9.3) on Mac OS X 10.4.6 (8I127) as well as locally-built WebKit r14619. 43901 1 8599 ddkilzer 2006-05-29 18:18:54 -0700 Created attachment 8599 Test v1 Test demonstrating the problem with setting iframe.src. It may be possible to simplify this test. Note that there is commented-out code in the iframe.src-history.js file that will make the test run faster. It should be used in place of the slower code if this test is checked in. 9264 2 ddkilzer 2007-05-23 20:44:03 -0700 NOTE: I filed this bug because I noticed a difference in behavior between Safari/WebKit, Firefox and MSIE 6. I do not know what the correct behavior is. 4529 3 ddkilzer 2007-07-17 07:48:44 -0700 May be fixed by: http://trac.webkit.org/projects/webkit/changeset/24353 4001 4 ddkilzer 2007-07-22 20:36:19 -0700 (In reply to comment #3) > May be fixed by: http://trac.webkit.org/projects/webkit/changeset/24353 It was not fixed by this change. 57473 5 eric 2007-09-30 11:19:40 -0700 *** Bug 9145 has been marked as a duplicate of this bug. *** 61508 6 ddkilzer 2007-11-17 20:37:14 -0800 (In reply to comment #5) > *** Bug 9145 has been marked as a duplicate of this bug. *** Bug 9145 is the same issue of setting the src attribute on <frame> elements. 61509 7 17334 ddkilzer 2007-11-17 20:46:23 -0800 Created attachment 17334 Test case for frames This test case demonstrates behavior when frame.src (originally Bug 9145) is set either via user action (clicking a button) or through an automated JavaScript call (setTimeout()). Safari 3.0.4 (523.12) with its original WebKit (and Safari 2.0.4 w/original WebKit) - Both user-driven and JavaScript-driven tests "fail" because clicking the browser Back button takes the user back two load events (to the previous page) instead of just one (to the previous frame state). Firefox 2.0.0.9 and Opera 9.22 on Mac OS X 10.4.11; MSIE 7 on Win XP - Both user-driven and JavaScript-driven tests "pass" because clicking the browser Back button takes the user back one load event (to the previous frame state) instead of two (to the previous page). 89170 8 zachleatherman 2008-08-23 10:47:01 -0700 Not just the "src" attribute, I've seen changing location.hash of an iframe not registering in the history as well. Version 3.1.2 (525.21) 201693 9 fishd 2010-03-18 21:36:05 -0700 I have a patch for this. 201709 10 51122 fishd 2010-03-18 22:48:46 -0700 Created attachment 51122 v1 patch 201710 11 fishd 2010-03-18 22:50:40 -0700 This patch just mimics what we do for assignment to location.href in the case where the frame is already in the document. Otherwise, assignment to "src" behaves as it did before. This behavior is spec'd here: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#the-iframe-element 201746 12 51122 abarth 2010-03-19 00:14:17 -0700 Comment on attachment 51122 v1 patch Ugg. I dislike these infinite parameter lists, but I'll take care of that when I get back to working on FrameLoader. LGTM + svn:eol-style ^^ We don't usually set eol-style on tests. We're going to have a war of fixing four-digit bugs once I get around to fixing the Document.load bug. :) 201754 13 fishd 2010-03-19 00:26:57 -0700 (In reply to comment #12) > (From update of attachment 51122 [details]) > Ugg. I dislike these infinite parameter lists, but I'll take care of that when > I get back to working on FrameLoader. Yeah, it bugs me too. But, I decided to error in favor of consistency for now. > + svn:eol-style > ^^ We don't usually set eol-style on tests. That's probably my auto-props kicking in :-/ > We're going to have a war of fixing four-digit bugs once I get around to fixing > the Document.load bug. :) lol 201761 14 fishd 2010-03-19 00:32:15 -0700 Landed as http://trac.webkit.org/changeset/56223 201776 15 abarth 2010-03-19 01:27:27 -0700 Looks like your new test is flaky: fast/loader/frame-src-change-added-to-history.html -> failed --- /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/layout-test-results/fast/loader/frame-src-change-added-to-history-expected.txt 2010-03-19 01:16:25.000000000 -0700 +++ /Volumes/Big/WebKit-BuildSlave/leopard-intel-debug-tests/build/layout-test-results/fast/loader/frame-src-change-added-to-history-actual.txt 2010-03-19 01:16:25.000000000 -0700 @@ -1,3 +1,5 @@ + + -------- Frame: '<!--framePath //<!--frame0-->-->' -------- 233747 16 arturadib 2010-06-03 07:08:30 -0700 (In reply to comment #15) > Looks like your new test is flaky: > > fast/loader/frame-src-change-added-to-history.html -> failed > Hi, I was wondering what's the status of this fix? (Sorry, I'm not quite familiar with Changesets, and how and when they make their way to a nightly build). I have the most recent WebKit nightly build, and iframe.src doesn't seem to get added to the browser history. Thanks! 235455 17 fishd 2010-06-08 12:56:57 -0700 (In reply to comment #16) > (In reply to comment #15) > > Looks like your new test is flaky: > > > > fast/loader/frame-src-change-added-to-history.html -> failed > > > > Hi, I was wondering what's the status of this fix? (Sorry, I'm not quite familiar with Changesets, and how and when they make their way to a nightly build). The test result was corrected in http://trac.webkit.org/changeset/56240 > I have the most recent WebKit nightly build, and iframe.src doesn't seem to get added to the browser history. Hmm... I tested a tip-of-tree Chromium build, and I see that the visited state of the URLs is recorded, so that links to the page navigated to via frame.src assignment do show up as visited. Chromium purposely excludes subframe navigations from its global history system though. Perhaps Safari does something similar? 265748 18 priyajeet.hora 2010-08-17 13:56:54 -0700 Isn't this similar to this bug http://code.google.com/p/chromium/issues/detail?id=16810 8599 2006-05-29 18:18:54 -0700 2006-05-29 18:18:54 -0700 Test v1 bug-9166-test-v1.diff text/plain 2782 ddkilzer SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvaGlzdG9yeS9yZXNvdXJjZXMvaWZyYW1lLnNyYy1oaXN0 b3J5LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvaGlzdG9yeS9yZXNvdXJjZXMv aWZyYW1lLnNyYy1oaXN0b3J5LmpzCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9o aXN0b3J5L3Jlc291cmNlcy9pZnJhbWUuc3JjLWhpc3RvcnkuanMJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsMzAgQEAKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICBsYXlv dXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7Cit9CitmdW5jdGlvbiBjb3VudE9uZSgp IHsKKyAgICB2YXIgaWZyYW1lID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm15aWZyYW1lIik7 CisgICAgaWZyYW1lLnNyYyA9ICIuL3Jlc291cmNlcy9pZnJhbWUuc3JjLWhpc3RvcnktcGFnZTIu aHRtbCI7Cit9CitmdW5jdGlvbiBjb3VudFR3bygpIHsKKyAgICB2YXIgaWZyYW1lID0gZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoIm15aWZyYW1lIik7CisgICAgaWZyYW1lLnNyYyA9ICIuL3Jlc291 cmNlcy9pZnJhbWUuc3JjLWhpc3RvcnktcGFnZTEuaHRtbCI7Cit9Cit2YXIgY291bnQgPSAwOwor dmFyIHRpbWVvdXQgPSAxMDAwOworZnVuY3Rpb24gcnVuVGVzdCgpIHsKKyAgICAvL3ZhciBpZnJh bWUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgibXlpZnJhbWUiKTsKKyAgICBjb3VudCsrOwor ICAgIGlmIChjb3VudCA9PSAxKSB7CisgICAgICAgIHNldFRpbWVvdXQoJ2NvdW50T25lKCknLCB0 aW1lb3V0KTsKKyAgICAgICAgLy9pZnJhbWUuc3JjID0gIi4vcmVzb3VyY2VzL2lmcmFtZS5zcmMt aGlzdG9yeS1wYWdlMi5odG1sIjsKKyAgICB9CisgICAgZWxzZSBpZiAoY291bnQgPT0gMikgewor ICAgICAgICBzZXRUaW1lb3V0KCdjb3VudFR3bygpJywgdGltZW91dCk7CisgICAgICAgIC8vaWZy YW1lLnNyYyA9ICIuL3Jlc291cmNlcy9pZnJhbWUuc3JjLWhpc3RvcnktcGFnZTEuaHRtbCI7Cisg ICAgfQorICAgIGVsc2UgaWYgKGNvdW50ID09IDMpIHsKKyAgICAgICAgaWYgKHdpbmRvdy5sYXlv dXRUZXN0Q29udHJvbGxlcikgeworICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90 aWZ5RG9uZSgpOworICAgICAgICB9CisgICAgfQorfQpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9o aXN0b3J5L3Jlc291cmNlcy9pZnJhbWUuc3JjLWhpc3RvcnktcGFnZTEuaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2hpc3RvcnkvcmVzb3VyY2VzL2lmcmFtZS5zcmMtaGlzdG9y eS1wYWdlMS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9oaXN0b3J5L3Jl c291cmNlcy9pZnJhbWUuc3JjLWhpc3RvcnktcGFnZTEuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAs MCArMSw2IEBACis8aHRtbD4KKzxib2R5PgorPGRpdj5UaGUgZm9sbG93aW5nIGxpbmsgc2hvdWxk IGJlIHJlbmRlcmVkIGluIHRoZSB2aXNpdGVkIGxpbmsgY29sb3I6PC9kaXY+Cis8ZGl2PjxhIGlk PSJteWxpbmsiIGhyZWY9Ii4vaWZyYW1lLnNyYy1oaXN0b3J5LXBhZ2UyLmh0bWwiPi4vaWZyYW1l LnNyYy1oaXN0b3J5LXBhZ2UyLmh0bWw8L2E+PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L2hpc3RvcnkvcmVzb3VyY2VzL2lmcmFtZS5zcmMtaGlzdG9yeS1w YWdlMi5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvaGlzdG9yeS9yZXNvdXJj ZXMvaWZyYW1lLnNyYy1oaXN0b3J5LXBhZ2UyLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy9mYXN0L2hpc3RvcnkvcmVzb3VyY2VzL2lmcmFtZS5zcmMtaGlzdG9yeS1wYWdlMi5odG1s CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDUgQEAKKzxodG1sPgorPGJvZHk+Cis8ZGl2PlBhZ2Ug MiAtLSBUaGlzIHNob3VsZCBub3QgYXBwZWFyIGluIHRoZSByZW5kZXJlZCBwYWdlLjwvZGl2Pgor PC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9oaXN0b3J5L2lmcmFtZS5z cmMtaGlzdG9yeS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvaGlzdG9yeS9p ZnJhbWUuc3JjLWhpc3RvcnkuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3Qv aGlzdG9yeS9pZnJhbWUuc3JjLWhpc3RvcnkuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw3 IEBACis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9InJlc291cmNlcy9pZnJhbWUuc3JjLWhp c3RvcnkuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGRpdj48YSBocmVmPSJodHRwOi8vYnVnemls bGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTkxNjYiPkJ1ZyA5MTY2IFNldHRpbmcg aWZyYW1lLnNyYyBpcyBub3QgcmVnaXN0ZXJlZCBpbiBoaXN0b3J5PC9hPjwvZGl2PgorPGlmcmFt ZSBpZD0ibXlpZnJhbWUiIHNyYz0iLi9yZXNvdXJjZXMvaWZyYW1lLnNyYy1oaXN0b3J5LXBhZ2Ux Lmh0bWwiIG9ubG9hZD0icnVuVGVzdCgpOyI+PC9pZnJhbWU+Cis8L2h0bWw+Cg== 17334 2007-11-17 20:46:23 -0800 2007-11-17 20:46:23 -0800 Test case for frames bug-9145-test.tar.gz application/x-gzip 636 ddkilzer H4sICIfBP0cCA2J1Zy05MTQ1LXRlc3QudGFyAO2X3WrbMBSAfe2nOPimziiO/BdD6xiW0EFgsIts D6DYciLqWEaW52Wj7z75J0nLGL1ZswbOd6MgHR8rdr6jE9fZqX1hvClEMwuCfoxm4Yuxw/UCwyWR G0UB8SPPIK4f6mUgxgVoakUlgJFlj7z4yeTf4l5bH7/LabwSXAdiCjvJ8rnl9b8FK1kWPH2EPYun NHHMuEo+fVx9voNVDgfRgGQ03YHa8RoqumVAc8UkrBWrwHfiaZWYBnI1eO/A/5Cc/fdIOPjvo/+X IO5ef2LGO0YzPdSp5JVKzLwpU8VFCVthT8xfJmi+6+eUS7pnMIdMpM2elcrZMvVQsO7j4rDKbGt/ 6EOsyX1/Dc/B7iecWqYOLzP240tuW/5QaSYQA5nAkL7jFKpvcQwaEj2ZT2Y8PW4vno777S+omQIp 2npuheT2g3WcBp1HFzU6VrXjLM/mp12OIZshBERZCKqXdcKvfM9Eo+yb7gHc3EKo3+mkSzI93rLf Rf/wrtp/+vYF4DX/vSg8+x+Rzv/IR/8v4/8fxmeCK/soZauVFa1TUdnLrl0YdJRMNbKEnBY1u3+h pqcbik2jlM4kyrTrJObWkPJ5YzFEJCAktJQrCKFmqSizGppS8QKeGTiBdEfLLat1z8GgEC0by5CD jcY/8H/z//13yezc/7uz3n9vhv5fgvW35fJhvb6DRXeCarU2VCs6Ctxq6YcJUbLx7OdlrfTZCyLv J7u/ACji9eK/g/6fBN7g/ywIfY9g/3/R9w/DqdwdrpuxBizONQDdRhAEQRAEQRAEQRAEQRAEuU5+ A7NGF2EAKAAA 51122 2010-03-18 22:48:46 -0700 2010-03-19 00:14:17 -0700 v1 patch hist_1.txt text/plain 8086 fishd SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIExheW91dFRlc3Rz L0NoYW5nZUxvZwkocmV2aXNpb24gNTYyMTEpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMy0xOCAgRGFyaW4gRmlzaGVyICA8 ZGFyaW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIElmIGEgZnJhbWUgaXMgYWxyZWFkeSBpbiB0aGUgZG9jdW1lbnQsIHRoZW4g c2V0dGluZyBpdHMgInNyYyIgYXR0cmlidXRlCisgICAgICAgIHNob3VsZCBhZGQgdGhlIHJlc3Vs dGFudCBuYXZpZ2F0aW9uIHRvIGhpc3RvcnkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNjYKKworICAgICAgICAqIGZhc3QvbG9hZGVyL2ZyYW1l LXNyYy1jaGFuZ2UtYWRkZWQtdG8taGlzdG9yeS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvbG9hZGVyL2ZyYW1lLXNyYy1jaGFuZ2UtYWRkZWQtdG8taGlzdG9yeS5odG1sOiBB ZGRlZC4KKwogMjAxMC0wMy0xOCAgTGFzemxvIEdvbWJvcyAgPGxhc3psby4xLmdvbWJvc0Bub2tp YS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4u CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9mcmFtZS1zcmMtY2hhbmdlLWFkZGVkLXRv LWhpc3RvcnktZXhwZWN0ZWQudHh0DQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gTGF5b3V0VGVzdHMvZmFzdC9s b2FkZXIvZnJhbWUtc3JjLWNoYW5nZS1hZGRlZC10by1oaXN0b3J5LWV4cGVjdGVkLnR4dAkocmV2 aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvbG9hZGVyL2ZyYW1lLXNyYy1jaGFuZ2UtYWRk ZWQtdG8taGlzdG9yeS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTcgQEAK Ky0tLS0tLS0tCitGcmFtZTogJzwhLS1mcmFtZVBhdGggLy88IS0tZnJhbWUwLS0+LS0+JworLS0t LS0tLS0KKzEKKworPT09PT09PT09PT09PT0gQmFjayBGb3J3YXJkIExpc3QgPT09PT09PT09PT09 PT0KKyAgICAgICAgKGZpbGUgdGVzdCk6ZmFzdC9sb2FkZXIvZnJhbWUtc3JjLWNoYW5nZS1hZGRl ZC10by1oaXN0b3J5Lmh0bWwgICoqbmF2IHRhcmdldCoqCisgICAgICAgICAgICBhYm91dDpibGFu ayAoaW4gZnJhbWUgIjwhLS1mcmFtZVBhdGggLy88IS0tZnJhbWUwLS0+LS0+IikKKyAgICAgICAg KGZpbGUgdGVzdCk6ZmFzdC9sb2FkZXIvZnJhbWUtc3JjLWNoYW5nZS1hZGRlZC10by1oaXN0b3J5 Lmh0bWwKKyAgICAgICAgICAgIGRhdGE6LDQgKGluIGZyYW1lICI8IS0tZnJhbWVQYXRoIC8vPCEt LWZyYW1lMC0tPi0tPiIpICAqKm5hdiB0YXJnZXQqKgorICAgICAgICAoZmlsZSB0ZXN0KTpmYXN0 L2xvYWRlci9mcmFtZS1zcmMtY2hhbmdlLWFkZGVkLXRvLWhpc3RvcnkuaHRtbAorICAgICAgICAg ICAgZGF0YTosMyAoaW4gZnJhbWUgIjwhLS1mcmFtZVBhdGggLy88IS0tZnJhbWUwLS0+LS0+Iikg ICoqbmF2IHRhcmdldCoqCisgICAgICAgIChmaWxlIHRlc3QpOmZhc3QvbG9hZGVyL2ZyYW1lLXNy Yy1jaGFuZ2UtYWRkZWQtdG8taGlzdG9yeS5odG1sCisgICAgICAgICAgICBkYXRhOiwyIChpbiBm cmFtZSAiPCEtLWZyYW1lUGF0aCAvLzwhLS1mcmFtZTAtLT4tLT4iKSAgKipuYXYgdGFyZ2V0KioK K2N1cnItPiAgKGZpbGUgdGVzdCk6ZmFzdC9sb2FkZXIvZnJhbWUtc3JjLWNoYW5nZS1hZGRlZC10 by1oaXN0b3J5Lmh0bWwKKyAgICAgICAgICAgIGRhdGE6LDEgKGluIGZyYW1lICI8IS0tZnJhbWVQ YXRoIC8vPCEtLWZyYW1lMC0tPi0tPiIpICAqKm5hdiB0YXJnZXQqKgorPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KDQpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBM YXlvdXRUZXN0c1xmYXN0XGxvYWRlclxmcmFtZS1zcmMtY2hhbmdlLWFkZGVkLXRvLWhpc3Rvcnkt ZXhwZWN0ZWQudHh0DQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fDQpBZGRlZDogc3ZuOmVvbC1zdHlsZQ0KICAgKyBuYXRp dmUNCg0KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvbG9hZGVyL2ZyYW1lLXNyYy1jaGFuZ2UtYWRk ZWQtdG8taGlzdG9yeS5odG1sDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gTGF5b3V0VGVzdHMvZmFzdC9sb2Fk ZXIvZnJhbWUtc3JjLWNoYW5nZS1hZGRlZC10by1oaXN0b3J5Lmh0bWwJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9mcmFtZS1zcmMtY2hhbmdlLWFkZGVkLXRvLWhpc3Rv cnkuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwyOCBAQAorPGh0bWw+Cis8aGVhZD4KKzxz Y3JpcHQ+CisKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgbGF5b3V0VGVz dENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQ2hp bGRGcmFtZXNBc1RleHQoKTsKKyAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEJhY2tGb3J3YXJk TGlzdCgpOworICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7Cit9CisKK3Zh ciBjb3VudCA9IDQ7CisKK2Z1bmN0aW9uIGZyYW1lTG9hZGVkKCkgeworICBpZiAoY291bnQgPT0g MCkgeworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisgIH0gZWxzZSB7CisgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudHNCeVRhZ05hbWUoJ2lmcmFtZScpWzBdLnNyYyA9ICJkYXRhOiwiICsgY291bnQtLTsK KyAgfQorfQorCis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPGlmcmFtZSBvbmxvYWQ9InNl dFRpbWVvdXQoZnJhbWVMb2FkZWQsIDApIj48L2lmcmFtZT4KKzwvYm9keT4KKzwvaHRtbD4KDQpQ cm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0c1xmYXN0XGxvYWRlclxmcmFtZS1zcmMtY2hh bmdlLWFkZGVkLXRvLWhpc3RvcnkuaHRtbA0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXw0KQWRkZWQ6IHN2bjplb2wtc3R5 bGUNCiAgICsgTEYNCg0KSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0g V2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU2MjExKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyNCBAQAorMjAxMC0wMy0xOCAgRGFyaW4gRmlzaGVy ICA8ZGFyaW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIElmIGEgZnJhbWUgaXMgYWxyZWFkeSBpbiB0aGUgZG9jdW1lbnQsIHRo ZW4gc2V0dGluZyBpdHMgInNyYyIgYXR0cmlidXRlCisgICAgICAgIHNob3VsZCBhZGQgdGhlIHJl c3VsdGFudCBuYXZpZ2F0aW9uIHRvIGhpc3RvcnkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNjYKKworICAgICAgICBUaGlzIGJlaGF2aW9yIGlz IHNwZWNpZmllZCBpbiBzZWN0aW9uIDQuOC4yIG9mIHRoZSBIVE1MNSBzcGVjLgorCisgICAgICAg IFRlc3Q6IGZhc3QvbG9hZGVyL2ZyYW1lLXNyYy1jaGFuZ2UtYWRkZWQtdG8taGlzdG9yeS5odG1s CisKKyAgICAgICAgKiBodG1sL0hUTUxGcmFtZUVsZW1lbnRCYXNlLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkhUTUxGcmFtZUVsZW1lbnRCYXNlOjpvcGVuVVJMKToKKyAgICAgICAgKFdlYkNvcmU6 OkhUTUxGcmFtZUVsZW1lbnRCYXNlOjpzZXRMb2NhdGlvbik6CisgICAgICAgICogaHRtbC9IVE1M RnJhbWVFbGVtZW50QmFzZS5oOgorICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6cmVxdWVzdEZyYW1lKToKKyAgICAgICAgKiBs b2FkZXIvRnJhbWVMb2FkZXIuaDoKKwogMjAxMC0wMy0xOCAgS2VubmV0aCBSb2hkZSBDaHJpc3Rp YW5zZW4gIDxrZW5uZXRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4g QWRsZXIuCkluZGV4OiBXZWJDb3JlL2h0bWwvSFRNTEZyYW1lRWxlbWVudEJhc2UuY3BwDQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09DQotLS0gV2ViQ29yZS9odG1sL0hUTUxGcmFtZUVsZW1lbnRCYXNlLmNwcAkocmV2aXNp b24gNTYyMTApCisrKyBXZWJDb3JlL2h0bWwvSFRNTEZyYW1lRWxlbWVudEJhc2UuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC05MCw3ICs5MCw3IEBAIGJvb2wgSFRNTEZyYW1lRWxlbWVudEJhc2U6Omlz VVJMQWxsb3dlZCgKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAotdm9pZCBIVE1MRnJhbWVFbGVtZW50 QmFzZTo6b3BlblVSTCgpCit2b2lkIEhUTUxGcmFtZUVsZW1lbnRCYXNlOjpvcGVuVVJMKGJvb2wg bG9ja0hpc3RvcnksIGJvb2wgbG9ja0JhY2tGb3J3YXJkTGlzdCkKIHsKICAgICBBU1NFUlQoIW1f ZnJhbWVOYW1lLmlzRW1wdHkoKSk7CiAKQEAgLTEwNCw3ICsxMDQsNyBAQCB2b2lkIEhUTUxGcmFt ZUVsZW1lbnRCYXNlOjpvcGVuVVJMKCkKICAgICBpZiAoIXBhcmVudEZyYW1lKQogICAgICAgICBy ZXR1cm47CiAKLSAgICBwYXJlbnRGcmFtZS0+bG9hZGVyKCktPnJlcXVlc3RGcmFtZSh0aGlzLCBt X1VSTCwgbV9mcmFtZU5hbWUpOworICAgIHBhcmVudEZyYW1lLT5sb2FkZXIoKS0+cmVxdWVzdEZy YW1lKHRoaXMsIG1fVVJMLCBtX2ZyYW1lTmFtZSwgbG9ja0hpc3RvcnksIGxvY2tCYWNrRm9yd2Fy ZExpc3QpOwogICAgIGlmIChjb250ZW50RnJhbWUoKSkKICAgICAgICAgY29udGVudEZyYW1lKCkt PnNldEluVmlld1NvdXJjZU1vZGUodmlld1NvdXJjZU1vZGUoKSk7CiB9CkBAIC0yMzEsNyArMjMx LDcgQEAgdm9pZCBIVE1MRnJhbWVFbGVtZW50QmFzZTo6c2V0TG9jYXRpb24oYwogICAgIG1fVVJM ID0gQXRvbWljU3RyaW5nKHN0cik7CiAKICAgICBpZiAoaW5Eb2N1bWVudCgpKQotICAgICAgICBv cGVuVVJMKCk7CisgICAgICAgIG9wZW5VUkwoZmFsc2UsIGZhbHNlKTsKIH0KIAogYm9vbCBIVE1M RnJhbWVFbGVtZW50QmFzZTo6c3VwcG9ydHNGb2N1cygpIGNvbnN0CkluZGV4OiBXZWJDb3JlL2h0 bWwvSFRNTEZyYW1lRWxlbWVudEJhc2UuaA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYkNvcmUvaHRtbC9I VE1MRnJhbWVFbGVtZW50QmFzZS5oCShyZXZpc2lvbiA1NjIxMCkKKysrIFdlYkNvcmUvaHRtbC9I VE1MRnJhbWVFbGVtZW50QmFzZS5oCSh3b3JraW5nIGNvcHkpCkBAIC03Myw3ICs3Myw3IEBAIHBy aXZhdGU6CiAgICAgYm9vbCB2aWV3U291cmNlTW9kZSgpIGNvbnN0IHsgcmV0dXJuIG1fdmlld1Nv dXJjZTsgfQogCiAgICAgdm9pZCBzZXROYW1lQW5kT3BlblVSTCgpOwotICAgIHZvaWQgb3BlblVS TCgpOworICAgIHZvaWQgb3BlblVSTChib29sIGxvY2tIaXN0b3J5ID0gdHJ1ZSwgYm9vbCBsb2Nr QmFja0ZvcndhcmRMaXN0ID0gdHJ1ZSk7CiAKICAgICBzdGF0aWMgdm9pZCBzZXROYW1lQW5kT3Bl blVSTENhbGxiYWNrKE5vZGUqKTsKIApJbmRleDogV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIu Y3BwDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCShyZXZp c2lvbiA1NjIxMCkKKysrIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMzUyLDcgKzM1Miw3IEBAIHZvaWQgRnJhbWVMb2FkZXI6OnVybFNlbGVjdGVkKGNv bnN0IFJlc28KICAgICBtX3N1cHByZXNzT3BlbmVySW5OZXdGcmFtZSA9IGZhbHNlOwogfQogCi1i b29sIEZyYW1lTG9hZGVyOjpyZXF1ZXN0RnJhbWUoSFRNTEZyYW1lT3duZXJFbGVtZW50KiBvd25l ckVsZW1lbnQsIGNvbnN0IFN0cmluZyYgdXJsU3RyaW5nLCBjb25zdCBBdG9taWNTdHJpbmcmIGZy YW1lTmFtZSkKK2Jvb2wgRnJhbWVMb2FkZXI6OnJlcXVlc3RGcmFtZShIVE1MRnJhbWVPd25lckVs ZW1lbnQqIG93bmVyRWxlbWVudCwgY29uc3QgU3RyaW5nJiB1cmxTdHJpbmcsIGNvbnN0IEF0b21p Y1N0cmluZyYgZnJhbWVOYW1lLCBib29sIGxvY2tIaXN0b3J5LCBib29sIGxvY2tCYWNrRm9yd2Fy ZExpc3QpCiB7CiAgICAgLy8gU3VwcG9ydCBmb3IgPGZyYW1lIHNyYz0iamF2YXNjcmlwdDpzdHJp bmciPgogICAgIEtVUkwgc2NyaXB0VVJMOwpAQCAtMzY1LDcgKzM2NSw3IEBAIGJvb2wgRnJhbWVM b2FkZXI6OnJlcXVlc3RGcmFtZShIVE1MRnJhbWUKIAogICAgIEZyYW1lKiBmcmFtZSA9IG93bmVy RWxlbWVudC0+Y29udGVudEZyYW1lKCk7CiAgICAgaWYgKGZyYW1lKQotICAgICAgICBmcmFtZS0+ cmVkaXJlY3RTY2hlZHVsZXIoKS0+c2NoZWR1bGVMb2NhdGlvbkNoYW5nZSh1cmwuc3RyaW5nKCks IG1fb3V0Z29pbmdSZWZlcnJlciwgdHJ1ZSwgdHJ1ZSwgaXNQcm9jZXNzaW5nVXNlckdlc3R1cmUo KSk7CisgICAgICAgIGZyYW1lLT5yZWRpcmVjdFNjaGVkdWxlcigpLT5zY2hlZHVsZUxvY2F0aW9u Q2hhbmdlKHVybC5zdHJpbmcoKSwgbV9vdXRnb2luZ1JlZmVycmVyLCBsb2NrSGlzdG9yeSwgbG9j a0JhY2tGb3J3YXJkTGlzdCwgaXNQcm9jZXNzaW5nVXNlckdlc3R1cmUoKSk7CiAgICAgZWxzZQog ICAgICAgICBmcmFtZSA9IGxvYWRTdWJmcmFtZShvd25lckVsZW1lbnQsIHVybCwgZnJhbWVOYW1l LCBtX291dGdvaW5nUmVmZXJyZXIpOwogICAgIApJbmRleDogV2ViQ29yZS9sb2FkZXIvRnJhbWVM b2FkZXIuaA0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQ0KLS0tIFdlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmgJKHJl dmlzaW9uIDU2MjEwKQorKysgV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuaAkod29ya2luZyBj b3B5KQpAQCAtMjExLDcgKzIxMSw3IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgY2hhbmdlTG9jYXRp b24oY29uc3QgS1VSTCYsIGNvbnN0IFN0cmluZyYgcmVmZXJyZXIsIGJvb2wgbG9ja0hpc3Rvcnkg PSB0cnVlLCBib29sIGxvY2tCYWNrRm9yd2FyZExpc3QgPSB0cnVlLCBib29sIHVzZXJHZXN0dXJl ID0gZmFsc2UsIGJvb2wgcmVmcmVzaCA9IGZhbHNlKTsKICAgICB2b2lkIHVybFNlbGVjdGVkKGNv bnN0IFJlc291cmNlUmVxdWVzdCYsIGNvbnN0IFN0cmluZyYgdGFyZ2V0LCBQYXNzUmVmUHRyPEV2 ZW50PiwgYm9vbCBsb2NrSGlzdG9yeSwgYm9vbCBsb2NrQmFja0ZvcndhcmRMaXN0LCBib29sIHVz ZXJHZXN0dXJlLCBSZWZlcnJlclBvbGljeSk7Ci0gICAgYm9vbCByZXF1ZXN0RnJhbWUoSFRNTEZy YW1lT3duZXJFbGVtZW50KiwgY29uc3QgU3RyaW5nJiB1cmwsIGNvbnN0IEF0b21pY1N0cmluZyYg ZnJhbWVOYW1lKTsKKyAgICBib29sIHJlcXVlc3RGcmFtZShIVE1MRnJhbWVPd25lckVsZW1lbnQq LCBjb25zdCBTdHJpbmcmIHVybCwgY29uc3QgQXRvbWljU3RyaW5nJiBmcmFtZU5hbWUsIGJvb2wg bG9ja0hpc3RvcnkgPSB0cnVlLCBib29sIGxvY2tCYWNrRm9yd2FyZExpc3QgPSB0cnVlKTsKIAog ICAgIHZvaWQgc3VibWl0Rm9ybShjb25zdCBjaGFyKiBhY3Rpb24sIGNvbnN0IFN0cmluZyYgdXJs LAogICAgICAgICBQYXNzUmVmUHRyPEZvcm1EYXRhPiwgY29uc3QgU3RyaW5nJiB0YXJnZXQsIGNv bnN0IFN0cmluZyYgY29udGVudFR5cGUsIGNvbnN0IFN0cmluZyYgYm91bmRhcnksCg==