91654 2012-07-18 12:47:01 -0700 [Chromium] Recognize textareas and content-editable fields for the IME 2012-07-23 12:32:03 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91648 1 peter japhet abarth dglazkov fishd jamesr japhet olilan tkent+wkapi tony webkit.review.bot oldest_to_newest 672638 0 peter 2012-07-18 12:47:01 -0700 Textareas and elements which are contenteditable should trigger Android's IME functionalities. Downstream CL: https://gerrit-int.chromium.org/#change,9991 672755 1 abarth 2012-07-18 14:25:53 -0700 I think Nate is working on this bug. 672788 2 153095 japhet 2012-07-18 14:50:41 -0700 Created attachment 153095 patch 672793 3 webkit.review.bot 2012-07-18 14:54:33 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 672807 4 153095 abarth 2012-07-18 15:05:46 -0700 Comment on attachment 153095 patch Does this case any trouble for Chrome OS? 672819 5 japhet 2012-07-18 15:11:12 -0700 (In reply to comment #4) > (From update of attachment 153095 [details]) > Does this case any trouble for Chrome OS? Unless grep failed me, the new enum values should be treated exactly as the previous values were. 672869 6 153095 webkit.review.bot 2012-07-18 15:41:17 -0700 Comment on attachment 153095 patch Clearing flags on attachment: 153095 Committed r123036: <http://trac.webkit.org/changeset/123036> 672870 7 webkit.review.bot 2012-07-18 15:41:37 -0700 All reviewed patches have been landed. Closing bug. 673649 8 japhet 2012-07-19 10:38:02 -0700 (In reply to comment #7) > All reviewed patches have been landed. Closing bug. Reverted r123036 for reason: Triggers some DCHECKs in Chromium browser_tests Committed r123120: <http://trac.webkit.org/changeset/123120> 675810 9 abarth 2012-07-23 10:42:46 -0700 This should be ready to land again now that we've rolled Chromium DEPS, right? 675812 10 japhet 2012-07-23 10:46:06 -0700 (In reply to comment #9) > This should be ready to land again now that we've rolled Chromium DEPS, right? Yep, I just started a build to double-check locally. 675902 11 153095 webkit.review.bot 2012-07-23 12:31:58 -0700 Comment on attachment 153095 patch Clearing flags on attachment: 153095 Committed r123361: <http://trac.webkit.org/changeset/123361> 675903 12 webkit.review.bot 2012-07-23 12:32:03 -0700 All reviewed patches have been landed. Closing bug. 153095 2012-07-18 14:50:41 -0700 2012-07-23 12:31:57 -0700 patch inputevent.txt text/plain 1937 japhet SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlRleHRJbnB1dFR5cGUuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJUZXh0SW5wdXRU eXBlLmgJKHJldmlzaW9uIDEyMzAwMSkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYlRleHRJbnB1dFR5cGUuaAkod29ya2luZyBjb3B5KQpAQCAtNTQsNiArNTQsMTAgQEAKICAg ICBXZWJUZXh0SW5wdXRUeXBlTW9udGgsCiAgICAgV2ViVGV4dElucHV0VHlwZVRpbWUsCiAgICAg V2ViVGV4dElucHV0VHlwZVdlZWssCisgICAgV2ViVGV4dElucHV0VHlwZVRleHRBcmVhLAorCisg ICAgLy8gSW5wdXQgY2FyZXQgaXMgaW4gYSBjb250ZW50ZWRpdGFibGUgbm9kZSAobm90IGFuIElO UFVUIGZpZWxkKS4KKyAgICBXZWJUZXh0SW5wdXRUeXBlQ29udGVudEVkaXRhYmxlLAogfTsKIAog fSAvLyBuYW1lc3BhY2UgV2ViS2l0CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkocmV2 aXNpb24gMTIzMDIxKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxMi0wNy0xOCAgTmF0ZSBDaGFwaW4gIDxqYXBo ZXRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCBXZWJUZXh0SW5wdXRUeXBlIGVudW0gdmFs dWVzIGZvciB0ZXh0IGFyZWFzIGFuZAorICAgICAgICBjb250ZW50LWVkaXRhYmxlLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE2NTQKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5v IGJlaGF2aW9yIGNoYW5nZSB3aXRob3V0IGNvcnJlc3BvbmRpbmcgY2hyb21pdW0ub3JnIGNoYW5n ZXMuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViVGV4dElucHV0VHlwZS5oOgorICAgICAgICAqIHNy Yy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjp0ZXh0SW5w dXRUeXBlKToKKwogMjAxMi0wNy0xOCAgSm9zaHVhIEJlbGwgIDxqc2JlbGxAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIEluZGV4ZWREQjogRml4IHNvbWUgY29kaW5nIHN0eWxlIHZpb2xhdGlvbnMK SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHJldmlz aW9uIDEyMzAwMSkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMjA3MSwxMSArMjA3MSwxMSBAQAogICAgICAgICBpZiAodGV4 dGFyZWEtPnJlYWRPbmx5KCkgfHwgdGV4dGFyZWEtPmRpc2FibGVkKCkpCiAgICAgICAgICAgICBy ZXR1cm4gV2ViVGV4dElucHV0VHlwZU5vbmU7CiAKLSAgICAgICAgcmV0dXJuIFdlYlRleHRJbnB1 dFR5cGVUZXh0OworICAgICAgICByZXR1cm4gV2ViVGV4dElucHV0VHlwZVRleHRBcmVhOwogICAg IH0KIAogICAgIGlmIChub2RlLT5zaG91bGRVc2VJbnB1dE1ldGhvZCgpKQotICAgICAgICByZXR1 cm4gV2ViVGV4dElucHV0VHlwZVRleHQ7CisgICAgICAgIHJldHVybiBXZWJUZXh0SW5wdXRUeXBl Q29udGVudEVkaXRhYmxlOwogCiAgICAgcmV0dXJuIFdlYlRleHRJbnB1dFR5cGVOb25lOwogfQo=