91636 2012-07-18 10:17:23 -0700 [Soup] Unnecessary RefPtr usage and null check 2012-07-20 14:41:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 gustavo gustavo danw mrobinson rakuco webkit.review.bot oldest_to_newest 672479 0 gustavo 2012-07-18 10:17:23 -0700 [Soup] Unnecessary RefPtr usage and null check 672486 1 153037 gustavo 2012-07-18 10:22:05 -0700 Created attachment 153037 Patch 673166 2 153037 mrobinson 2012-07-18 22:13:27 -0700 Comment on attachment 153037 Patch Hrm. Why is the check unnecessary? The comment seems to suggest otherwise? 673408 3 gustavo 2012-07-19 05:28:15 -0700 Well, the function ends just after the check, so there's nothing else it could be doing other than return either way =) 673747 4 153037 mrobinson 2012-07-19 11:54:45 -0700 Comment on attachment 153037 Patch Good point! 674984 5 gustavo 2012-07-20 14:41:31 -0700 Committed r123265: <http://trac.webkit.org/changeset/123265> 153037 2012-07-18 10:22:05 -0700 2012-07-19 11:54:45 -0700 Patch bug-91636-20120718142204.patch text/plain 1820 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyODY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTZkYjA3NjczMDFhNTBh NmRlNTEyZGVlYjVhMjYyOGEwZWQwYzY1Zi4uNzdkYWY4ZTczNGI2ZDExM2FjYWM0MzBhY2QxZGU2 YzlkMGZmMjI2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA3LTE4ICBHdXN0 YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvbT4KKworICAg ICAgICBbU291cF0gVW5uZWNlc3NhcnkgUmVmUHRyIHVzYWdlIGFuZCBudWxsIGNoZWNrCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTYzNgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNtYWxsIGNsZWFuIHVw IG9mIGNvZGUgdGhhdCBpcyBub3QgbmVjZXNzYXJ5OyBubyBjaGFuZ2UgaW4gZnVuY3Rpb25hbGl0 eS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9Tb2NrZXRTdHJlYW1IYW5kbGVT b3VwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNvY2tldFN0cmVhbUhhbmRsZTo6Y29ubmVjdGVk KToKKwogMjAxMi0wNy0xNyAgU3RlcGhlbiBDaGVubmV5ICA8c2NoZW5uZXlAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIENyYXNoIGluIFNWR1N0b3BFbGVtZW50OjpzdG9wQ29sb3JJbmNsdWRpbmdP cGFjaXR5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAv U29ja2V0U3RyZWFtSGFuZGxlU291cC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL3NvdXAvU29ja2V0U3RyZWFtSGFuZGxlU291cC5jcHAKaW5kZXggYThjMmJhYTcwNTExYTA4 ZWZjOTVmYTM4YzA1Yzk1ZjBkODY1NGExOC4uN2FhNmNjY2I4ZmZlNDgxYzI3NTYxZmEwYTVlOWVj ZGRiMzFjNzUyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9z b3VwL1NvY2tldFN0cmVhbUhhbmRsZVNvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9Tb2NrZXRTdHJlYW1IYW5kbGVTb3VwLmNwcApAQCAtMTE2LDEyICsx MTYsOCBAQCB2b2lkIFNvY2tldFN0cmVhbUhhbmRsZTo6Y29ubmVjdGVkKEdTb2NrZXRDb25uZWN0 aW9uKiBzb2NrZXRDb25uZWN0aW9uLCBHRXJyb3IqCiAgICAgZ19pbnB1dF9zdHJlYW1fcmVhZF9h c3luYyhtX2lucHV0U3RyZWFtLmdldCgpLCBtX3JlYWRCdWZmZXIsIFJFQURfQlVGRkVSX1NJWkUs IEdfUFJJT1JJVFlfREVGQVVMVCwgMCwKICAgICAgICAgcmVpbnRlcnByZXRfY2FzdDxHQXN5bmNS ZWFkeUNhbGxiYWNrPihyZWFkUmVhZHlDYWxsYmFjayksIG1faWQpOwogCi0gICAgLy8gVGhlIGNs aWVudCBjYW4gY2xvc2UgdGhlIGhhbmRsZSwgcG90ZW50aWFsbHkgcmVtb3ZpbmcgdGhlIGxhc3Qg cmVmZXJlbmNlLgotICAgIFJlZlB0cjxTb2NrZXRTdHJlYW1IYW5kbGU+IHByb3RlY3QodGhpcyk7 IAogICAgIG1fc3RhdGUgPSBPcGVuOwogICAgIG1fY2xpZW50LT5kaWRPcGVuU29ja2V0U3RyZWFt KHRoaXMpOwotICAgIGlmICghbV9zb2NrZXRDb25uZWN0aW9uKSAvLyBDbGllbnQgY2xvc2VkIHRo ZSBjb25uZWN0aW9uLgotICAgICAgICByZXR1cm47CiB9CiAKIHZvaWQgU29ja2V0U3RyZWFtSGFu ZGxlOjpyZWFkQnl0ZXMoc2lnbmVkIGxvbmcgYnl0ZXNSZWFkLCBHRXJyb3IqIGVycm9yKQo=