91626 2012-07-18 07:34:08 -0700 [CMake][EFL] Should try to find the same libsoup version pulled by jhbuild 2012-07-18 21:48:17 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 Martin.Jansa cdumez cdumez gustavo gyuyoung.kim gyuyoung.kim kenneth lucas.de.marchi rakuco tmpsantos tonikitoo webkit.review.bot oldest_to_newest 672360 0 Martin.Jansa 2012-07-18 07:34:08 -0700 GTK version was bumped in https://bugs.webkit.org/show_bug.cgi?id=90332, but EFL is using cmake so bump it there too. 672362 1 153011 Martin.Jansa 2012-07-18 07:35:11 -0700 Created attachment 153011 OptionsEfl: bump libsoup requirements like autotools did in r121772 672363 2 tmpsantos 2012-07-18 07:35:51 -0700 LGTM 672364 3 tmpsantos 2012-07-18 07:36:09 -0700 (In reply to comment #2) > LGTM But you have to write a changelog. :) 672421 4 153011 cdumez 2012-07-18 09:16:00 -0700 Comment on attachment 153011 OptionsEfl: bump libsoup requirements like autotools did in r121772 View in context: https://bugs.webkit.org/attachment.cgi?id=153011&action=review I'm in the middle of something but I can take over this patch soon if needed. > Source/cmake/OptionsEfl.cmake:38 > +FIND_PACKAGE(LibSoup2 2.39.2 REQUIRED) We actually need 2.39.3. 672589 5 153062 cdumez 2012-07-18 11:46:04 -0700 Created attachment 153062 Patch The first tarball to contain the API we need is definitely v2.39.3 (not 2.39.2) although the version tag in GIT to contain the API is LIBSOUP_2_39_2 (Misleading): - http://ftp.acc.umu.se/pub/gnome/sources/libsoup/2.39/libsoup-2.39.3.news (Second bullet) I bumped the dependency in CMake and I also had to update our jhbuild config to pull in the v2.39.3 tarball as well since the GIT tag we where using was still versioned 2.39.2. This way we match the CMake requirements. 672667 6 153062 rakuco 2012-07-18 13:03:04 -0700 Comment on attachment 153062 Patch Looks good, thanks for looking at this. 672675 7 tmpsantos 2012-07-18 13:08:56 -0700 LGTM. Thanks Christophe! 673147 8 153062 webkit.review.bot 2012-07-18 21:48:10 -0700 Comment on attachment 153062 Patch Clearing flags on attachment: 153062 Committed r123069: <http://trac.webkit.org/changeset/123069> 673148 9 webkit.review.bot 2012-07-18 21:48:17 -0700 All reviewed patches have been landed. Closing bug. 153011 2012-07-18 07:35:11 -0700 2012-07-18 11:46:04 -0700 OptionsEfl: bump libsoup requirements like autotools did in r121772 0001-OptionsEfl-bump-libsoup-requirements-like-autotools-.patch text/plain 1742 Martin.Jansa RnJvbSA5YmFiMTg3MWE2MjU1MGFhOGRjNjhmM2Q2YmRiY2IzYmQyM2FhNzgwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gSmFuc2EgPE1hcnRpbi5KYW5zYUBnbWFpbC5jb20+ CkRhdGU6IFdlZCwgMTggSnVsIDIwMTIgMTY6MjA6MTkgKzAyMDAKU3ViamVjdDogW1BBVENIXSBP cHRpb25zRWZsOiBidW1wIGxpYnNvdXAgcmVxdWlyZW1lbnRzIGxpa2UgYXV0b3Rvb2xzIGRpZCBp bgogcjEyMTc3MgoKT3RoZXJ3aXNlIGNhbiBmYWlsIGxpa2UgdGhpczoKfCBzcmMvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL0Nvb2tpZUphclNvdXAuY3BwOiBJbiBmdW5jdGlv biAndm9pZCBXZWJDb3JlOjpzZXRDb29raWVzKFdlYkNvcmU6OkRvY3VtZW50KiwgY29uc3QgV2Vi Q29yZTo6S1VSTCYsIGNvbnN0IFdURjo6U3RyaW5nJiknOgp8IHNyYy9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2llSmFyU291cC5jcHA6OTk6ODY6IGVycm9yOiAnc291 cF9jb29raWVfamFyX2dldF9jb29raWVfbGlzdCcgd2FzIG5vdCBkZWNsYXJlZCBpbiB0aGlzIHNj b3BlCnwgc3JjL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9Db29raWVKYXJT b3VwLmNwcDoxMTc6OTI6IGVycm9yOiAnc291cF9jb29raWVfamFyX2FkZF9jb29raWVfd2l0aF9m aXJzdF9wYXJ0eScgd2FzIG5vdCBkZWNsYXJlZCBpbiB0aGlzIHNjb3BlCnwgc3JjL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9Db29raWVKYXJTb3VwLmNwcDogSW4gZnVuY3Rp b24gJ2Jvb2wgV2ViQ29yZTo6Z2V0UmF3Q29va2llcyhjb25zdCBXZWJDb3JlOjpEb2N1bWVudCos IGNvbnN0IFdlYkNvcmU6OktVUkwmLCBXVEY6OlZlY3RvcjxXZWJDb3JlOjpDb29raWU+JiknOgp8 IHNyYy9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2llSmFyU291cC5j cHA6MTY3OjEwMjogZXJyb3I6ICdzb3VwX2Nvb2tpZV9qYXJfaXNfcGVyc2lzdGVudCcgd2FzIG5v dCBkZWNsYXJlZCBpbiB0aGlzIHNjb3BlCnwgL09FL3Noci1jb3JlL3RtcC1lZ2xpYmMvc3lzcm9v dHMveDg2XzY0LWxpbnV4L3Vzci9iaW4vY21ha2UgLUUgY21ha2VfcHJvZ3Jlc3NfcmVwb3J0IHNy Yy9DTWFrZUZpbGVzCgpTaWduZWQtb2ZmLWJ5OiBNYXJ0aW4gSmFuc2EgPE1hcnRpbi5KYW5zYUBn bWFpbC5jb20+Ci0tLQogU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UgfCAgICAyICstCiAx IGZpbGVzIGNoYW5nZWQsIDEgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25z RWZsLmNtYWtlCmluZGV4IDg4OWYyMmUuLmQwYmMxMDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFr ZS9PcHRpb25zRWZsLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBA IC0zNSw3ICszNSw3IEBAIEZJTkRfUEFDS0FHRShaTElCIFJFUVVJUkVEKQogCiBGSU5EX1BBQ0tB R0UoR2xpYiAyLjMxLjggUkVRVUlSRUQpCiBGSU5EX1BBQ0tBR0UoR3RocmVhZCBSRVFVSVJFRCkK LUZJTkRfUEFDS0FHRShMaWJTb3VwMiAyLjM3LjkyIFJFUVVJUkVEKQorRklORF9QQUNLQUdFKExp YlNvdXAyIDIuMzkuMiBSRVFVSVJFRCkKIFNFVChFTkFCTEVfR0xJQl9TVVBQT1JUIE9OKQogCiBT RVQoV1RGX1VTRV9TT1VQIDEpCi0tIAoxLjcuOC42Cgo= 153062 2012-07-18 11:46:04 -0700 2012-07-18 21:48:10 -0700 Patch 91626_bump_libsoup.patch text/plain 2651 cdumez ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA2YzU2MDExLi44ZDViYzcz IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTItMDctMTggIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNv bT4KKworICAgICAgICBbQ01ha2VdW0VGTF0gU2hvdWxkIHRyeSB0byBmaW5kIHRoZSBzYW1lIGxp YnNvdXAgdmVyc2lvbiBwdWxsZWQgYnkgamhidWlsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE2MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBCdW1wIHJlcXVpcmVkIHZlcnNpb24gb2YgbGlic291cCBp biBDTWFrZSB0byAyLjM5LjMuIFRoaXMgaXMgdGhlIGZpcnN0CisgICAgICAgIHRhcmJhbGwgdmVy c2lvbiB0byBjb250YWluIHRoZSBBUEkgd2UgbmVlZCAoc291cF9jb29raWVfamFyX2dldF9jb29r aWVzKCkKKyAgICAgICAgYW5kIHNvdXBfY29va2llX2phcl9zZXRfY29va2llX3dpdGhfZmlyc3Rf cGFydHkoKSkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZToKKwog MjAxMi0wNy0xOCAgVGhpYWdvIE1hcmNvcyBQLiBTYW50b3MgIDx0aGlhZ28uc2FudG9zQGludGVs LmNvbT4KIAogICAgICAgICBbQ01ha2VdIE1ha2UgZ3Rlc3QgYSBzaGFyZWQgbGlicmFyeQpkaWZm IC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZQppbmRleCA4ODlmMjJlLi4wYTM5NTM0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv Y21ha2UvT3B0aW9uc0VmbC5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFr ZQpAQCAtMzUsNyArMzUsNyBAQCBGSU5EX1BBQ0tBR0UoWkxJQiBSRVFVSVJFRCkKIAogRklORF9Q QUNLQUdFKEdsaWIgMi4zMS44IFJFUVVJUkVEKQogRklORF9QQUNLQUdFKEd0aHJlYWQgUkVRVUlS RUQpCi1GSU5EX1BBQ0tBR0UoTGliU291cDIgMi4zNy45MiBSRVFVSVJFRCkKK0ZJTkRfUEFDS0FH RShMaWJTb3VwMiAyLjM5LjMgUkVRVUlSRUQpCiBTRVQoRU5BQkxFX0dMSUJfU1VQUE9SVCBPTikK IAogU0VUKFdURl9VU0VfU09VUCAxKQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9v bHMvQ2hhbmdlTG9nCmluZGV4IDZjYTc2ZGYuLmM2N2RiMmEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0No YW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wNy0x OCAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgorCisgICAg ICAgIFtDTWFrZV1bRUZMXSBTaG91bGQgdHJ5IHRvIGZpbmQgdGhlIHNhbWUgbGlic291cCB2ZXJz aW9uIHB1bGxlZCBieSBqaGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05MTYyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFVwZGF0ZSBqaGJ1aWxkIHRvIHB1bGwgbGlic291cCAyLjM5LjMgdGFyYmFs bCBmcm9tIEdub21lIEZUUCBpbnN0ZWFkCisgICAgICAgIG9mIGZldGNoaW5nIGEgdGFnIGZyb20g R25vbWUgR0lULiBXZSBuZWVkIHRvIGRvIHRoaXMgdG8gbWFwIHRoZSB2ZXJzaW9uCisgICAgICAg IG9mIGxpYnNvdXAgdGhhdCBpcyByZXF1aXJlZCBieSBvdXIgQ01ha2UgY29uZmlnLgorCisgICAg ICAgICogZWZsL2poYnVpbGQubW9kdWxlczoKKwogMjAxMi0wNy0xOCAgVGhpYWdvIE1hcmNvcyBQ LiBTYW50b3MgIDx0aGlhZ28uc2FudG9zQGludGVsLmNvbT4KIAogICAgICAgICBbQ01ha2VdW0VG TF0gQnVpbGQgYW5kIHJ1biBUZXN0V2ViS2l0QVBJIHVuaXQgdGVzdHMKZGlmZiAtLWdpdCBhL1Rv b2xzL2VmbC9qaGJ1aWxkLm1vZHVsZXMgYi9Ub29scy9lZmwvamhidWlsZC5tb2R1bGVzCmluZGV4 IDkwODRkNzkuLmE5MGFkNTkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2VmbC9qaGJ1aWxkLm1vZHVsZXMK KysrIGIvVG9vbHMvZWZsL2poYnVpbGQubW9kdWxlcwpAQCAtMTQ1LDkgKzE0NSwxMCBAQAogICAg IDxkZXBlbmRlbmNpZXM+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImdsaWItbmV0d29ya2luZyIvPgog ICAgIDwvZGVwZW5kZW5jaWVzPgotICAgIDxicmFuY2ggbW9kdWxlPSJsaWJzb3VwIiB2ZXJzaW9u PSIyLjM5LjIiCi0gICAgICAgICAgICByZXBvPSJnaXQuZ25vbWUub3JnIgotICAgICAgICAgICAg dGFnPSJMSUJTT1VQXzJfMzlfMiIvPgorICAgIDxicmFuY2ggbW9kdWxlPSIvcHViL2dub21lL3Nv dXJjZXMvbGlic291cC8yLjM5L2xpYnNvdXAtMi4zOS4zLnRhci54eiIgdmVyc2lvbj0iMi4zOS4z IgorICAgICAgICAgICAgcmVwbz0iZnRwLmdub21lLm9yZyIKKyAgICAgICAgICAgIGhhc2g9InNo YTI1NjpkYjkxMTk0ZjRlMGFhYTdlM2Y4NzYxMmMyMTA4NzViNWQ2NGM5Mjk3N2Y1YzcyYjY4Njcy ODgyZDM1NzJkNDVjIgorICAgICAgICAgICAgbWQ1c3VtPSJkMGU5NDEyNTc2MmI4NWFiOTk4Yzgx YjAxODdjZDM3MCIvPgogICA8L2F1dG90b29scz4KIAogICA8YXV0b3Rvb2xzIGlkPSJmb250Y29u ZmlnIiBhdXRvZ2VuLXNoPSJjb25maWd1cmUiPgo=