<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>91620</bug_id>
          
          <creation_ts>2012-07-18 05:50:35 -0700</creation_ts>
          <short_desc>Layout Test css3/filters/blur-filter-page-scroll-self.html is flaky on chromium since it was added.</short_desc>
          <delta_ts>2012-11-03 13:52:44 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Vsevolod Vlasov">vsevik</reporter>
          <assigned_to name="Stephen White">senorblanco</assigned_to>
          <cc>achicu</cc>
    
    <cc>enne</cc>
    
    <cc>jamesr</cc>
    
    <cc>leviw</cc>
    
    <cc>senorblanco</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>vangelis</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>672293</commentid>
    <comment_count>0</comment_count>
    <who name="Vsevolod Vlasov">vsevik</who>
    <bug_when>2012-07-18 05:50:35 -0700</bug_when>
    <thetext>The following layout test is flaky on chromium since it was added

css3/filters/blur-filter-page-scroll-self.html

Probable cause:
http://trac.webkit.org/changeset/122130/

Flakiness dashboard:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3%2Ffilters%2Fblur-filter-page-scroll-self.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>672543</commentid>
    <comment_count>1</comment_count>
    <who name="Alexandru Chiculita">achicu</who>
    <bug_when>2012-07-18 11:04:47 -0700</bug_when>
    <thetext>It looks like this is because of a previous test that runs in the same DRT process and enables some other feature on the WebView. Is there a way I could get the previous tests?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>673327</commentid>
    <comment_count>2</comment_count>
    <who name="Vsevolod Vlasov">vsevik</who>
    <bug_when>2012-07-19 02:16:16 -0700</bug_when>
    <thetext>You can click on any square in the flakiness dashboard and then click on the build log to open a builder log (e.g. http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux%2032/builds/21235)
There you can find stdio log for the webkit_tests step. All the tests that were run are listed there with their results.

Does that help you?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>673328</commentid>
    <comment_count>3</comment_count>
    <who name="Vsevolod Vlasov">vsevik</who>
    <bug_when>2012-07-19 02:16:37 -0700</bug_when>
    <thetext>stdio log example: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux%2032/builds/21235/steps/webkit_tests/logs/stdio</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>673700</commentid>
    <comment_count>4</comment_count>
    <who name="Alexandru Chiculita">achicu</who>
    <bug_when>2012-07-19 11:10:10 -0700</bug_when>
    <thetext>(In reply to comment #2)

&gt; Does that help you?

Thanks, it did help, I found the issue. Sorry, I didn&apos;t see the link initially. 

It&apos;s the following call that is made in compositing/layer-creation/fixed-position-out-of-view.html :

window.internals.settings.setEnableCompositingForFixedPosition(true);

Judging by the name of the API it enables compositing for fixed elements, and the test that fails is actually using a fixed element, so the blur is going to be applied in hardware instead of software, thus making it look slightly different.

There are two options:
1. Make the DRT reset that flag before each test.
2. Make my test reset the flag.

Which one do you think is best?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>674481</commentid>
    <comment_count>5</comment_count>
    <who name="Vsevolod Vlasov">vsevik</who>
    <bug_when>2012-07-20 05:37:22 -0700</bug_when>
    <thetext>I am not sure which one is better, adding vangelis@ who created this flag.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>703340</commentid>
    <comment_count>6</comment_count>
    <who name="Alexandru Chiculita">achicu</who>
    <bug_when>2012-08-23 14:04:56 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; I am not sure which one is better, adding vangelis@ who created this flag.

Any follow up on this bug?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>748731</commentid>
    <comment_count>7</comment_count>
    <who name="Levi Weintraub">leviw</who>
    <bug_when>2012-10-23 09:34:09 -0700</bug_when>
    <thetext>It&apos;s recently started crashing on Debug bots as well. Example backtraces:

Linux:
crash log for DumpRenderTree (pid 23041):
STDOUT: &lt;empty&gt;
STDERR: [23041:23041:18472271421893:FATAL:layer_impl.cc(498)] Check failed: m_filters.isEmpty(). 
STDERR: Backtrace:
STDERR: 	base::debug::StackTrace::StackTrace() [0x7f0f5150d09e]
STDERR: 	logging::LogMessage::~LogMessage() [0x7f0f5154124b]
STDERR: 	cc::LayerImpl::setFilter() [0x7f0f4f88c0b6]
STDERR: 	cc::Layer::pushPropertiesTo() [0x7f0f4f93439e]
STDERR: 	cc::TiledLayer::pushPropertiesTo() [0x7f0f4f9463ff]
STDERR: 	cc::TreeSynchronizer::synchronizeTreeRecursive() [0x7f0f4f94b2a8]
STDERR: 	cc::TreeSynchronizer::synchronizeTreeRecursive() [0x7f0f4f94b0dc]
STDERR: 

Win7:
crash log for DumpRenderTree (pid 3512):
STDOUT: CONSOLE MESSAGE: Invalid name for preference: WebKitAcceleratedCompositingEnabled
STDERR: [3512:1796:851718:FATAL:layer_impl.cc(498)] Check failed: m_filters.isEmpty(). 
STDERR: Backtrace:
STDERR: 	base::SysWideToMultiByte [0x6D4BDC81+2221027]
STDERR: 	base::SysWideToMultiByte [0x6D366A4E+815536]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8FF830+3016196]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8736EC+2442432]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A904F76+3038538]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8D52E0+2842804]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8D515C+2842416]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8D515C+2842416]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8D515C+2842416]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8D515C+2842416]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8D515C+2842416]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8D4926+2840314]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8618E0+2369204]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A893C15+2574825]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A894ECF+2579619]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8922C8+2568348]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8624BE+2372242]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A851633+2302983]
STDERR: 	WebKit::WebGeolocationPermissionRequestManager::remove [0x61BC8BCF+1275871]
STDERR: 	WebKit::WebGeolocationPermissionRequestManager::remove [0x61BC8DD6+1276390]
STDERR: 	(No symbol) [0x00113BD9]
STDERR: 	(No symbol) [0x00113F81]
STDERR: 	(No symbol) [0x000DEC75]
STDERR: 	(No symbol) [0x000EC617]
STDERR: 	(No symbol) [0x001503B2]
STDERR: 	(No symbol) [0x0014FB0C]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x62EB7DB0+16560288]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x62EB78F2+16559074]
STDERR: 	v8::Locker::StopPreemption [0x6CAD8210+2536496]
STDERR: 	v8::Locker::StopPreemption [0x6CAD2CE4+2514692]
STDERR: 	v8::Locker::StopPreemption [0x6CAD2C56+2514550]
STDERR: 
STDERR: Backtrace:
STDERR: 	base::SysWideToMultiByte [0x6D4A8751+2133683]
STDERR: 	base::SysWideToMultiByte [0x6D366D9D+816383]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8FF830+3016196]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8736EC+2442432]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A904F76+3038538]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8D52E0+2842804]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8D515C+2842416]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8D515C+2842416]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8D515C+2842416]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8D515C+2842416]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8D515C+2842416]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8D4926+2840314]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8618E0+2369204]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A893C15+2574825]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A894ECF+2579619]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8922C8+2568348]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A8624BE+2372242]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A851633+2302983]
STDERR: 	WebKit::WebGeolocationPermissionRequestManager::remove [0x61BC8BCF+1275871]
STDERR: 	WebKit::WebGeolocationPermissionRequestManager::remove [0x61BC8DD6+1276390]
STDERR: 	(No symbol) [0x00113BD9]
STDERR: 	(No symbol) [0x00113F81]
STDERR: 	(No symbol) [0x000DEC75]
STDERR: 	(No symbol) [0x000EC617]
STDERR: 	(No symbol) [0x001503B2]
STDERR: 	(No symbol) [0x0014FB0C]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x62EB7DB0+16560288]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x62EB78F2+16559074]
STDERR: 	v8::Locker::StopPreemption [0x6CAD8210+2536496]
STDERR: 	v8::Locker::StopPreemption [0x6CAD2CE4+2514692]
STDERR: 	v8::Locker::StopPreemption [0x6CAD2C56+2514550]
STDERR: 	v8::Locker::StopPreemption [0x6C8D42E5+423173]
STDERR: 	v8::Locker::StopPreemption [0x6C8D4064+422532]
STDERR: 	v8::Function::Call [0x6C8513EA+490]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x6291D68B+10684795]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x6291D43A+10684202]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x63124129+19100697]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x630451F2+18187490]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x63044EE8+18186712]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x623E8E0B+5226747]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x623E8BE4+5226196]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x62A20BB2+11746978]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x62A2081C+11746060]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x6243D54B+5572667]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x62437A50+5549376]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x628C7E24+10334484]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x628C7AEE+10333662]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x628C77FE+10332910]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x6244166A+5589338]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x626B55BE+8161454]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x6264CF7B+7733867]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x6264D05E+7734094]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x6264BCA5+7729045]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x6264D0C9+7734201]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x6264D223+7734547]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x6289FC73+10170211]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x62A02A94+11623812]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x62F670F0+17277920]
STDERR: 	WebKit::WebFilterOperation::WebFilterOperation [0x62DF8BE7+15777495]
STDERR: 	std::_Init_locks::operator= [0x637D454E+2398302]
STDERR: 	webkit::npapi::WebPluginImpl::willSendRequest [0x6A6B0E69+597053]
STDERR: 	(No symbol) [0x0028EB1B]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>757960</commentid>
    <comment_count>8</comment_count>
    <who name="Stephen White">senorblanco</who>
    <bug_when>2012-11-03 08:13:53 -0700</bug_when>
    <thetext>+enne, +jamesr for the compositor commit crash</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>757961</commentid>
    <comment_count>9</comment_count>
    <who name="Stephen White">senorblanco</who>
    <bug_when>2012-11-03 08:22:57 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; +enne, +jamesr for the compositor commit crash

Never mind; that was me.  It was the setFilter() ASSERT, fixed in http://src.chromium.org/viewvc/chrome?view=rev&amp;revision=163613.  Should no longer be crashing.

Curious about the window.internals.settings.setEnableCompositingForFixedPosition(true); thing above though; seems like the previous test (compositing/layer-creation/fixed-position-out-of-view.html) should also be resetting that flag on exit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>757969</commentid>
    <comment_count>10</comment_count>
      <attachid>172222</attachid>
    <who name="Stephen White">senorblanco</who>
    <bug_when>2012-11-03 09:44:09 -0700</bug_when>
    <thetext>Created attachment 172222
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>757982</commentid>
    <comment_count>11</comment_count>
      <attachid>172222</attachid>
    <who name="">jochen</who>
    <bug_when>2012-11-03 12:20:04 -0700</bug_when>
    <thetext>Comment on attachment 172222
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=172222&amp;action=review

&gt; Source/WebCore/ChangeLog:9
&gt; +        Covered by css3/filters/blur-filter-page-scroll-self.html

You could add a few words why you believe this fixes the problem, and what the problem actually is</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>757987</commentid>
    <comment_count>12</comment_count>
      <attachid>172224</attachid>
    <who name="Stephen White">senorblanco</who>
    <bug_when>2012-11-03 13:11:43 -0700</bug_when>
    <thetext>Created attachment 172224
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>757988</commentid>
    <comment_count>13</comment_count>
    <who name="Stephen White">senorblanco</who>
    <bug_when>2012-11-03 13:12:05 -0700</bug_when>
    <thetext>(In reply to comment #11)
&gt; (From update of attachment 172222 [details])
&gt; View in context: https://bugs.webkit.org/attachment.cgi?id=172222&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/ChangeLog:9
&gt; &gt; +        Covered by css3/filters/blur-filter-page-scroll-self.html
&gt; 
&gt; You could add a few words why you believe this fixes the problem, and what the problem actually is

Done.  Thanks for the review.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>757993</commentid>
    <comment_count>14</comment_count>
      <attachid>172224</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-11-03 13:52:40 -0700</bug_when>
    <thetext>Comment on attachment 172224
Patch for landing

Clearing flags on attachment: 172224

Committed r133399: &lt;http://trac.webkit.org/changeset/133399&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>757994</commentid>
    <comment_count>15</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-11-03 13:52:44 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>172222</attachid>
            <date>2012-11-03 09:44:09 -0700</date>
            <delta_ts>2012-11-03 13:11:38 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-91620-20121103124224.patch</filename>
            <type>text/plain</type>
            <size>2960</size>
            <attacher name="Stephen White">senorblanco</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMjYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjVjNDM4MjUzMGRmMDZi
MGMzZTc0M2IxZTBhODBmZThkNGVhODVmMC4uNzViM2Y3MGE0ZTcyMmIxOWZmYzZjZDU4NmViODY1
ZDMyZDliZmU5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTExLTAzICBTdGVw
aGVuIFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFNwZWN1bGF0
aXZlIGZpeCB0byBlbGltaW5hdGUgZmxha2luZXNzIGluCisgICAgICAgIGNzczMvZmlsdGVycy9i
bHVyLWZpbHRlci1wYWdlLXNjcm9sbC1zZWxmLmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNjIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBjc3MzL2ZpbHRlcnMvYmx1ci1maWx0
ZXItcGFnZS1zY3JvbGwtc2VsZi5odG1sCisKKyAgICAgICAgKiB0ZXN0aW5nL0ludGVybmFsU2V0
dGluZ3MuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW50ZXJuYWxTZXR0aW5nczo6QmFja3VwOjpC
YWNrdXApOgorICAgICAgICAoV2ViQ29yZTo6SW50ZXJuYWxTZXR0aW5nczo6QmFja3VwOjpyZXN0
b3JlVG8pOgorICAgICAgICAqIHRlc3RpbmcvSW50ZXJuYWxTZXR0aW5ncy5oOgorICAgICAgICAo
QmFja3VwKToKKwogMjAxMi0xMS0wMSAgU3RlcGhlbiBXaGl0ZSAgPHNlbm9yYmxhbmNvQGNocm9t
aXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTMzMjQ0LgpkaWZm
IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbFNldHRpbmdzLmNwcCBiL1Nv
dXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxTZXR0aW5ncy5jcHAKaW5kZXggMTVkZjc5ODM0
NzFmMTFmZjEzY2NhYTJmNjBlMGQ4ZTBlYWMzYWRmYi4uYjRmZDhlZmVmNzdhNDg3NjYzNWQ0YmUz
ZGYxYzM4Njg1ZTViMzU5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRl
cm5hbFNldHRpbmdzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFsU2V0
dGluZ3MuY3BwCkBAIC05Myw2ICs5Myw3IEBAIEludGVybmFsU2V0dGluZ3M6OkJhY2t1cDo6QmFj
a3VwKFBhZ2UqIHBhZ2UsIFNldHRpbmdzKiBzZXR0aW5ncykKICAgICAsIG1fb3JpZ2luYWxEaWFs
b2dFbGVtZW50RW5hYmxlZChSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpkaWFsb2dFbGVtZW50RW5h
YmxlZCgpKQogI2VuZGlmCiAgICAgLCBtX2NhblN0YXJ0TWVkaWEocGFnZS0+Y2FuU3RhcnRNZWRp
YSgpKQorICAgICwgbV9vcmlnaW5hbENvbXBvc2l0aW5nRm9yRml4ZWRQb3NpdGlvbkVuYWJsZWQo
c2V0dGluZ3MtPmFjY2VsZXJhdGVkQ29tcG9zaXRpbmdGb3JGaXhlZFBvc2l0aW9uRW5hYmxlZCgp
KQogICAgICwgbV9vcmlnaW5hbE1vY2tTY3JvbGxiYXJzRW5hYmxlZChzZXR0aW5ncy0+bW9ja1Nj
cm9sbGJhcnNFbmFibGVkKCkpCiAgICAgLCBtX2xhbmdBdHRyaWJ1dGVBd2FyZUZvcm1Db250cm9s
VUlFbmFibGVkKFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmxhbmdBdHRyaWJ1dGVBd2FyZUZvcm1D
b250cm9sVUlFbmFibGVkKCkpCiAgICAgLCBtX2ltYWdlc0VuYWJsZWQoc2V0dGluZ3MtPmFyZUlt
YWdlc0VuYWJsZWQoKSkKQEAgLTEzNSw2ICsxMzYsNyBAQCB2b2lkIEludGVybmFsU2V0dGluZ3M6
OkJhY2t1cDo6cmVzdG9yZVRvKFBhZ2UqIHBhZ2UsIFNldHRpbmdzKiBzZXR0aW5ncykKICAgICBS
dW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzZXREaWFsb2dFbGVtZW50RW5hYmxlZChtX29yaWdpbmFs
RGlhbG9nRWxlbWVudEVuYWJsZWQpOwogI2VuZGlmCiAgICAgcGFnZS0+c2V0Q2FuU3RhcnRNZWRp
YShtX2NhblN0YXJ0TWVkaWEpOworICAgIHNldHRpbmdzLT5zZXRBY2NlbGVyYXRlZENvbXBvc2l0
aW5nRm9yRml4ZWRQb3NpdGlvbkVuYWJsZWQobV9vcmlnaW5hbENvbXBvc2l0aW5nRm9yRml4ZWRQ
b3NpdGlvbkVuYWJsZWQpOwogICAgIHNldHRpbmdzLT5zZXRNb2NrU2Nyb2xsYmFyc0VuYWJsZWQo
bV9vcmlnaW5hbE1vY2tTY3JvbGxiYXJzRW5hYmxlZCk7CiAgICAgUnVudGltZUVuYWJsZWRGZWF0
dXJlczo6c2V0TGFuZ0F0dHJpYnV0ZUF3YXJlRm9ybUNvbnRyb2xVSUVuYWJsZWQobV9sYW5nQXR0
cmlidXRlQXdhcmVGb3JtQ29udHJvbFVJRW5hYmxlZCk7CiAgICAgc2V0dGluZ3MtPnNldEltYWdl
c0VuYWJsZWQobV9pbWFnZXNFbmFibGVkKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rl
c3RpbmcvSW50ZXJuYWxTZXR0aW5ncy5oIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5h
bFNldHRpbmdzLmgKaW5kZXggMTAyZTRhNGFhNmQ5MmMyMWEzZGNjNTA2MjY4N2I2N2I2MjVmYTZi
ZC4uMDI2NGViMTdkOGYwMjVlZTUwMTY3YzY5MjJjNDFjMWZhY2M4MTM4YSAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbFNldHRpbmdzLmgKKysrIGIvU291cmNlL1dl
YkNvcmUvdGVzdGluZy9JbnRlcm5hbFNldHRpbmdzLmgKQEAgLTc5LDYgKzc5LDcgQEAgcHVibGlj
OgogICAgICAgICBib29sIG1fb3JpZ2luYWxEaWFsb2dFbGVtZW50RW5hYmxlZDsKICNlbmRpZgog
ICAgICAgICBib29sIG1fY2FuU3RhcnRNZWRpYTsKKyAgICAgICAgYm9vbCBtX29yaWdpbmFsQ29t
cG9zaXRpbmdGb3JGaXhlZFBvc2l0aW9uRW5hYmxlZDsKICAgICAgICAgYm9vbCBtX29yaWdpbmFs
TW9ja1Njcm9sbGJhcnNFbmFibGVkOwogICAgICAgICBib29sIG1fbGFuZ0F0dHJpYnV0ZUF3YXJl
Rm9ybUNvbnRyb2xVSUVuYWJsZWQ7CiAgICAgICAgIGJvb2wgbV9pbWFnZXNFbmFibGVkOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>172224</attachid>
            <date>2012-11-03 13:11:43 -0700</date>
            <delta_ts>2012-11-03 13:52:40 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-91620-20121103160952.patch</filename>
            <type>text/plain</type>
            <size>3243</size>
            <attacher name="Stephen White">senorblanco</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMzk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODdiY2Q3N2NhNTMyOTky
NmJjZWFmOTQ1OWYxOWE3ODYwMjBhZDg0ZC4uOGI3ZWU0Mjg4ZDFlM2E3MmJkYTBjYTQxNDExNTBj
M2ZiYzRlMzZkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTExLTAzICBTdGVw
aGVuIFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFNwZWN1bGF0
aXZlIGZpeCB0byBlbGltaW5hdGUgZmxha2luZXNzIGluCisgICAgICAgIGNzczMvZmlsdGVycy9i
bHVyLWZpbHRlci1wYWdlLXNjcm9sbC1zZWxmLmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNjIwLgorICAgICAgICBTdXNwaWNpb24gaXMgdGhh
dCBhIHByaW9yIHRlc3QgaXMgc2V0dGluZworICAgICAgICB3aW5kb3cuaW50ZXJuYWxzLnNldHRp
bmdzLnNldEVuYWJsZUNvbXBvc2l0aW5nRm9yRml4ZWRQb3NpdGlvbih0cnVlKSwKKyAgICAgICAg
Y2F1c2luZyB0aGlzIHRlc3QgdG8gYmUgaW50ZXJtaXR0ZWx5IHJ1biBvbiB0aGUgR1BVLCBnaXZp
bmcgZGlmZmVyZW50CisgICAgICAgIHBpeGVsIHJlc3VsdHMgZGVwZW5kaW5nIG9uIHRlc3Qgb3Jk
ZXIuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSm9jaGVuIEVpc2luZ2VyLgorCisgICAgICAgIENv
dmVyZWQgYnkgY3NzMy9maWx0ZXJzL2JsdXItZmlsdGVyLXBhZ2Utc2Nyb2xsLXNlbGYuaHRtbAor
CisgICAgICAgICogdGVzdGluZy9JbnRlcm5hbFNldHRpbmdzLmNwcDoKKyAgICAgICAgKFdlYkNv
cmU6OkludGVybmFsU2V0dGluZ3M6OkJhY2t1cDo6QmFja3VwKToKKyAgICAgICAgKFdlYkNvcmU6
OkludGVybmFsU2V0dGluZ3M6OkJhY2t1cDo6cmVzdG9yZVRvKToKKyAgICAgICAgKiB0ZXN0aW5n
L0ludGVybmFsU2V0dGluZ3MuaDoKKyAgICAgICAgKEJhY2t1cCk6CisKIDIwMTItMTEtMDMgIERh
biBCZWFtICA8ZGJlYW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEltcGxlbWVudCBIVE1MRm9y
bUVsZW1lbnQjcmVxdWVzdEF1dG9jb21wbGV0ZSBhbmQgYXNzb2NpYXRlZCBldmVudHMKZGlmZiAt
LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxTZXR0aW5ncy5jcHAgYi9Tb3Vy
Y2UvV2ViQ29yZS90ZXN0aW5nL0ludGVybmFsU2V0dGluZ3MuY3BwCmluZGV4IDE1ZGY3OTgzNDcx
ZjExZmYxM2NjYWEyZjYwZTBkOGUwZWFjM2FkZmIuLmI0ZmQ4ZWZlZjc3YTQ4NzY2MzVkNGJlM2Rm
MWMzODY4NWU1YjM1OTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJu
YWxTZXR0aW5ncy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbFNldHRp
bmdzLmNwcApAQCAtOTMsNiArOTMsNyBAQCBJbnRlcm5hbFNldHRpbmdzOjpCYWNrdXA6OkJhY2t1
cChQYWdlKiBwYWdlLCBTZXR0aW5ncyogc2V0dGluZ3MpCiAgICAgLCBtX29yaWdpbmFsRGlhbG9n
RWxlbWVudEVuYWJsZWQoUnVudGltZUVuYWJsZWRGZWF0dXJlczo6ZGlhbG9nRWxlbWVudEVuYWJs
ZWQoKSkKICNlbmRpZgogICAgICwgbV9jYW5TdGFydE1lZGlhKHBhZ2UtPmNhblN0YXJ0TWVkaWEo
KSkKKyAgICAsIG1fb3JpZ2luYWxDb21wb3NpdGluZ0ZvckZpeGVkUG9zaXRpb25FbmFibGVkKHNl
dHRpbmdzLT5hY2NlbGVyYXRlZENvbXBvc2l0aW5nRm9yRml4ZWRQb3NpdGlvbkVuYWJsZWQoKSkK
ICAgICAsIG1fb3JpZ2luYWxNb2NrU2Nyb2xsYmFyc0VuYWJsZWQoc2V0dGluZ3MtPm1vY2tTY3Jv
bGxiYXJzRW5hYmxlZCgpKQogICAgICwgbV9sYW5nQXR0cmlidXRlQXdhcmVGb3JtQ29udHJvbFVJ
RW5hYmxlZChSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpsYW5nQXR0cmlidXRlQXdhcmVGb3JtQ29u
dHJvbFVJRW5hYmxlZCgpKQogICAgICwgbV9pbWFnZXNFbmFibGVkKHNldHRpbmdzLT5hcmVJbWFn
ZXNFbmFibGVkKCkpCkBAIC0xMzUsNiArMTM2LDcgQEAgdm9pZCBJbnRlcm5hbFNldHRpbmdzOjpC
YWNrdXA6OnJlc3RvcmVUbyhQYWdlKiBwYWdlLCBTZXR0aW5ncyogc2V0dGluZ3MpCiAgICAgUnVu
dGltZUVuYWJsZWRGZWF0dXJlczo6c2V0RGlhbG9nRWxlbWVudEVuYWJsZWQobV9vcmlnaW5hbERp
YWxvZ0VsZW1lbnRFbmFibGVkKTsKICNlbmRpZgogICAgIHBhZ2UtPnNldENhblN0YXJ0TWVkaWEo
bV9jYW5TdGFydE1lZGlhKTsKKyAgICBzZXR0aW5ncy0+c2V0QWNjZWxlcmF0ZWRDb21wb3NpdGlu
Z0ZvckZpeGVkUG9zaXRpb25FbmFibGVkKG1fb3JpZ2luYWxDb21wb3NpdGluZ0ZvckZpeGVkUG9z
aXRpb25FbmFibGVkKTsKICAgICBzZXR0aW5ncy0+c2V0TW9ja1Njcm9sbGJhcnNFbmFibGVkKG1f
b3JpZ2luYWxNb2NrU2Nyb2xsYmFyc0VuYWJsZWQpOwogICAgIFJ1bnRpbWVFbmFibGVkRmVhdHVy
ZXM6OnNldExhbmdBdHRyaWJ1dGVBd2FyZUZvcm1Db250cm9sVUlFbmFibGVkKG1fbGFuZ0F0dHJp
YnV0ZUF3YXJlRm9ybUNvbnRyb2xVSUVuYWJsZWQpOwogICAgIHNldHRpbmdzLT5zZXRJbWFnZXNF
bmFibGVkKG1faW1hZ2VzRW5hYmxlZCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90ZXN0
aW5nL0ludGVybmFsU2V0dGluZ3MuaCBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxT
ZXR0aW5ncy5oCmluZGV4IDEwMmU0YTRhYTZkOTJjMjFhM2RjYzUwNjI2ODdiNjdiNjI1ZmE2YmQu
LjAyNjRlYjE3ZDhmMDI1ZWU1MDE2N2M2OTIyYzQxYzFmYWNjODEzOGEgMTAwNjQ0Ci0tLSBhL1Nv
dXJjZS9XZWJDb3JlL3Rlc3RpbmcvSW50ZXJuYWxTZXR0aW5ncy5oCisrKyBiL1NvdXJjZS9XZWJD
b3JlL3Rlc3RpbmcvSW50ZXJuYWxTZXR0aW5ncy5oCkBAIC03OSw2ICs3OSw3IEBAIHB1YmxpYzoK
ICAgICAgICAgYm9vbCBtX29yaWdpbmFsRGlhbG9nRWxlbWVudEVuYWJsZWQ7CiAjZW5kaWYKICAg
ICAgICAgYm9vbCBtX2NhblN0YXJ0TWVkaWE7CisgICAgICAgIGJvb2wgbV9vcmlnaW5hbENvbXBv
c2l0aW5nRm9yRml4ZWRQb3NpdGlvbkVuYWJsZWQ7CiAgICAgICAgIGJvb2wgbV9vcmlnaW5hbE1v
Y2tTY3JvbGxiYXJzRW5hYmxlZDsKICAgICAgICAgYm9vbCBtX2xhbmdBdHRyaWJ1dGVBd2FyZUZv
cm1Db250cm9sVUlFbmFibGVkOwogICAgICAgICBib29sIG1faW1hZ2VzRW5hYmxlZDsK
</data>

          </attachment>
      

    </bug>

</bugzilla>