91614 2012-07-18 04:13:57 -0700 [GTK] Fix a crash due to an invalid assert 2012-07-18 04:30:50 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo mrobinson webkit.review.bot xan.lopez oldest_to_newest 672226 0 cgarcia 2012-07-18 04:13:57 -0700 In webkitWebViewBaseContainerAdd() there's ASSERT(priv->inspectorView); that should be the opposite, since we shoulnd't have an inspector view when the inspector view is added. 672231 1 152985 cgarcia 2012-07-18 04:17:07 -0700 Created attachment 152985 Patch 672232 2 152985 xan.lopez 2012-07-18 04:19:01 -0700 Comment on attachment 152985 Patch Please add the explanation from comment #1 in the ChangeLog. 672235 3 webkit.review.bot 2012-07-18 04:20:52 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 672238 4 cgarcia 2012-07-18 04:27:48 -0700 (In reply to comment #2) > (From update of attachment 152985 [details]) > Please add the explanation from comment #1 in the ChangeLog. Sure, thanks for reviewing. 672240 5 cgarcia 2012-07-18 04:30:50 -0700 Committed r122945: <http://trac.webkit.org/changeset/122945> 152985 2012-07-18 04:17:07 -0700 2012-07-18 04:19:00 -0700 Patch wk2-crash-invalid-assert.diff text/plain 1336 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4NWUzN2RiLi5hZDkwZjhlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTItMDctMTggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIEZpeCBhIGNyYXNoIGR1ZSB0byBhbiBpbnZhbGlkIGFzc2VydAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTE2MTQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcDoKKyAgICAgICAgKHdlYmtpdFdlYlZpZXdC YXNlQ29udGFpbmVyQWRkKToKKwogMjAxMi0wNy0xNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxj Z2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gRG9uJ3QgdXNlIGRlcHJlY2F0ZWQg c291cCBBUEkgaW4gV2ViS2l0MkFQSVRlc3RzL1Rlc3RSZXNvdXJjZXMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAppbmRl eCBiN2ZmYzk4Li5mNjVmYTk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv QVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCkBAIC0xODgsNyArMTg4LDcgQEAgc3Rh dGljIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VDb250YWluZXJBZGQoR3RrQ29udGFpbmVyKiBjb250 YWluZXIsIEd0a1dpZGdldCogd2kKIAogICAgIGlmIChXRUJLSVRfSVNfV0VCX1ZJRVdfQkFTRSh3 aWRnZXQpCiAgICAgICAgICYmIFdlYkluc3BlY3RvclByb3h5Ojppc0luc3BlY3RvclBhZ2UoV0VC S0lUX1dFQl9WSUVXX0JBU0Uod2lkZ2V0KS0+cHJpdi0+cGFnZVByb3h5LmdldCgpKSkgewotICAg ICAgICBBU1NFUlQocHJpdi0+aW5zcGVjdG9yVmlldyk7CisgICAgICAgIEFTU0VSVCghcHJpdi0+ aW5zcGVjdG9yVmlldyk7CiAgICAgICAgIHByaXYtPmluc3BlY3RvclZpZXcgPSB3aWRnZXQ7CiAg ICAgICAgIHByaXYtPmluc3BlY3RvclZpZXdIZWlnaHQgPSBnTWluaW11bUF0dGFjaGVkSW5zcGVj dG9ySGVpZ2h0OwogICAgIH0gZWxzZSB7Cg==