91603 2012-07-18 02:02:26 -0700 REGRESSION(r117738): [Forms] Default step base should be 0 (=1970-01) for input type month 2012-07-18 02:47:42 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 yosin yosin mifenton tkent webkit.review.bot oldest_to_newest 672144 0 yosin 2012-07-18 02:02:26 -0700 Before r117738, default step base for input type month is defined in InputType::defaultStepBase() as 0 (=1970-01). On r117738, it is defined in MonthInputType::createStepRange and it is DateComponents::minimumMonth() (=0001-01). 672148 1 152965 yosin 2012-07-18 02:16:23 -0700 Created attachment 152965 Patch 1 672149 2 152965 yosin 2012-07-18 02:17:21 -0700 Comment on attachment 152965 Patch 1 Could you review this patch? Thanks in advance. 672163 3 152965 tkent 2012-07-18 02:37:59 -0700 Comment on attachment 152965 Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=152965&action=review > Source/WebCore/ChangeLog:11 > + No new tests. Existing test(fast/forms/month-stepup-stepdown-from-renderer.html) fast/forms/month-stepup... -> fast/forms/month/month-stepup... 672165 4 152972 yosin 2012-07-18 02:40:59 -0700 Created attachment 152972 Patch 2 672166 5 152972 yosin 2012-07-18 02:41:58 -0700 Comment on attachment 152972 Patch 2 Could you review this patch? Thanks in advance. = Changes since last review = * Update path of existing test in ChangeLog 672168 6 152972 tkent 2012-07-18 02:45:26 -0700 Comment on attachment 152972 Patch 2 ok 672171 7 152972 yosin 2012-07-18 02:47:36 -0700 Comment on attachment 152972 Patch 2 Clearing flags on attachment: 152972 Committed r122937: <http://trac.webkit.org/changeset/122937> 672172 8 yosin 2012-07-18 02:47:42 -0700 All reviewed patches have been landed. Closing bug. 152965 2012-07-18 02:16:23 -0700 2012-07-18 02:40:55 -0700 Patch 1 bug-91603-20120718181622.patch text/plain 2306 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyOTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWFmMzUzNjI3NTA3MDAx NTAwYWJhYzFkYjk0N2ZmYjA5MTc4MmIwMi4uNDRjMmZlMzFiZTdmMWI5MDVmMmVlZjM4Y2I4ODdm OTkxZjIwMTg0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA3LTE4ICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MTE3NzM4KSBbRm9ybXNdIERlZmF1bHQgc3RlcCBiYXNlIHNob3VsZCBiZSAwICg9MTk3MC0wMSkg Zm9yIGlucHV0IHR5cGUgbW9udGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTkxNjAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGhpcyBwYXRjaCByZXN0b3JlcyBkZWZhdWx0IHN0ZXAgYmFzZSB2YWx1ZSB0 byAwICg9MTk3MC0wMSkgYXMgYmVmb3JlCisgICAgICAgIHIxMTc3MzguCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLiBFeGlzdGluZyB0ZXN0KGZhc3QvZm9ybXMvbW9udGgtc3RlcHVwLXN0ZXBkb3du LWZyb20tcmVuZGVyZXIuaHRtbCkKKyAgICAgICAgY292ZXJzIHRoaXMgY2FzZSwgYWx0aG91Z2gg aXQgaXMgZGlzYWJsZWQuCisKKyAgICAgICAgKiBodG1sL01vbnRoSW5wdXRUeXBlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6Ok1vbnRoSW5wdXRUeXBlOjpjcmVhdGVTdGVwUmFuZ2UpOiBDaGFuZ2Vk IGRlZmF1bHQgdmFsdWUgb2YKKyAgICAgICAgc3RlcCBiYXNlIHRvIGRlZmF1bHRNb250aFN0ZXBC YXNlIGluc3RlYWQgb2YgRGF0ZUNvbXBvbmVudHM6Om1pbmltdW1Nb250aCgpLgorCiAyMDEyLTA3 LTE4ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZM XSBDdXJzb3IgaXMgbm90IGRyYXduIHdoZW4gb3BlbmdsX3gxMSBiYWNrZW5kIGlzIGNob29zZW4u CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL01vbnRoSW5wdXRUeXBlLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvTW9udGhJbnB1dFR5cGUuY3BwCmluZGV4IGM5YmViYjEzNTZlMjhk NTlhZDJmZmYwNGZkYTIxMmIzYzYwYTg0ZmMuLjcwYWZhNjkyZTNlZmU2M2FiODEzMGYzNDI2OGU2 MWVkOTI3ZDg1MmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvTW9udGhJbnB1dFR5 cGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvTW9udGhJbnB1dFR5cGUuY3BwCkBAIC0x MDEsNyArMTAxLDcgQEAgU3RlcFJhbmdlIE1vbnRoSW5wdXRUeXBlOjpjcmVhdGVTdGVwUmFuZ2Uo QW55U3RlcEhhbmRsaW5nIGFueVN0ZXBIYW5kbGluZykgY29uc3QKIHsKICAgICBERUZJTkVfU1RB VElDX0xPQ0FMKGNvbnN0IFN0ZXBSYW5nZTo6U3RlcERlc2NyaXB0aW9uLCBzdGVwRGVzY3JpcHRp b24sIChtb250aERlZmF1bHRTdGVwLCBtb250aERlZmF1bHRTdGVwQmFzZSwgbW9udGhTdGVwU2Nh bGVGYWN0b3IsIFN0ZXBSYW5nZTo6UGFyc2VkU3RlcFZhbHVlU2hvdWxkQmVJbnRlZ2VyKSk7CiAK LSAgICBjb25zdCBEZWNpbWFsIHN0ZXBCYXNlID0gcGFyc2VUb051bWJlcihlbGVtZW50KCktPmZh c3RHZXRBdHRyaWJ1dGUobWluQXR0ciksIERlY2ltYWw6OmZyb21Eb3VibGUoRGF0ZUNvbXBvbmVu dHM6Om1pbmltdW1Nb250aCgpKSk7CisgICAgY29uc3QgRGVjaW1hbCBzdGVwQmFzZSA9IHBhcnNl VG9OdW1iZXIoZWxlbWVudCgpLT5mYXN0R2V0QXR0cmlidXRlKG1pbkF0dHIpLCBEZWNpbWFsOjpm cm9tRG91YmxlKG1vbnRoRGVmYXVsdFN0ZXBCYXNlKSk7CiAgICAgY29uc3QgRGVjaW1hbCBtaW5p bXVtID0gcGFyc2VUb051bWJlcihlbGVtZW50KCktPmZhc3RHZXRBdHRyaWJ1dGUobWluQXR0ciks IERlY2ltYWw6OmZyb21Eb3VibGUoRGF0ZUNvbXBvbmVudHM6Om1pbmltdW1Nb250aCgpKSk7CiAg ICAgY29uc3QgRGVjaW1hbCBtYXhpbXVtID0gcGFyc2VUb051bWJlcihlbGVtZW50KCktPmZhc3RH ZXRBdHRyaWJ1dGUobWF4QXR0ciksIERlY2ltYWw6OmZyb21Eb3VibGUoRGF0ZUNvbXBvbmVudHM6 Om1heGltdW1Nb250aCgpKSk7CiAgICAgY29uc3QgRGVjaW1hbCBzdGVwID0gU3RlcFJhbmdlOjpw YXJzZVN0ZXAoYW55U3RlcEhhbmRsaW5nLCBzdGVwRGVzY3JpcHRpb24sIGVsZW1lbnQoKS0+ZmFz dEdldEF0dHJpYnV0ZShzdGVwQXR0cikpOwo= 152972 2012-07-18 02:40:59 -0700 2012-07-18 02:47:36 -0700 Patch 2 bug-91603-20120718184058.patch text/plain 2312 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyOTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWFmMzUzNjI3NTA3MDAx NTAwYWJhYzFkYjk0N2ZmYjA5MTc4MmIwMi4uMjdiMDhlOTI3ZjllMjBhMTdhYmIwZGY4NjBlOTk1 YWVhYjdlNWZlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA3LTE4ICBZb3No aWZ1bWkgSW5vdWUgIDx5b3NpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MTE3NzM4KSBbRm9ybXNdIERlZmF1bHQgc3RlcCBiYXNlIHNob3VsZCBiZSAwICg9MTk3MC0wMSkg Zm9yIGlucHV0IHR5cGUgbW9udGgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTkxNjAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGhpcyBwYXRjaCByZXN0b3JlcyBkZWZhdWx0IHN0ZXAgYmFzZSB2YWx1ZSB0 byAwICg9MTk3MC0wMSkgYXMgYmVmb3JlCisgICAgICAgIHIxMTc3MzguCisKKyAgICAgICAgTm8g bmV3IHRlc3RzLiBFeGlzdGluZyB0ZXN0KGZhc3QvZm9ybXMvbW9udGgvbW9udGgtc3RlcHVwLXN0 ZXBkb3duLWZyb20tcmVuZGVyZXIuaHRtbCkKKyAgICAgICAgY292ZXJzIHRoaXMgY2FzZSwgYWx0 aG91Z2ggaXQgaXMgZGlzYWJsZWQuCisKKyAgICAgICAgKiBodG1sL01vbnRoSW5wdXRUeXBlLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6Ok1vbnRoSW5wdXRUeXBlOjpjcmVhdGVTdGVwUmFuZ2UpOiBD aGFuZ2VkIGRlZmF1bHQgdmFsdWUgb2YKKyAgICAgICAgc3RlcCBiYXNlIHRvIGRlZmF1bHRNb250 aFN0ZXBCYXNlIGluc3RlYWQgb2YgRGF0ZUNvbXBvbmVudHM6Om1pbmltdW1Nb250aCgpLgorCiAy MDEyLTA3LTE4ICBSeXVhbiBDaG9pICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KIAogICAgICAg ICBbRUZMXSBDdXJzb3IgaXMgbm90IGRyYXduIHdoZW4gb3BlbmdsX3gxMSBiYWNrZW5kIGlzIGNo b29zZW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL01vbnRoSW5wdXRUeXBlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvTW9udGhJbnB1dFR5cGUuY3BwCmluZGV4IGM5YmViYjEz NTZlMjhkNTlhZDJmZmYwNGZkYTIxMmIzYzYwYTg0ZmMuLjcwYWZhNjkyZTNlZmU2M2FiODEzMGYz NDI2OGU2MWVkOTI3ZDg1MmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvTW9udGhJ bnB1dFR5cGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvTW9udGhJbnB1dFR5cGUuY3Bw CkBAIC0xMDEsNyArMTAxLDcgQEAgU3RlcFJhbmdlIE1vbnRoSW5wdXRUeXBlOjpjcmVhdGVTdGVw UmFuZ2UoQW55U3RlcEhhbmRsaW5nIGFueVN0ZXBIYW5kbGluZykgY29uc3QKIHsKICAgICBERUZJ TkVfU1RBVElDX0xPQ0FMKGNvbnN0IFN0ZXBSYW5nZTo6U3RlcERlc2NyaXB0aW9uLCBzdGVwRGVz Y3JpcHRpb24sIChtb250aERlZmF1bHRTdGVwLCBtb250aERlZmF1bHRTdGVwQmFzZSwgbW9udGhT dGVwU2NhbGVGYWN0b3IsIFN0ZXBSYW5nZTo6UGFyc2VkU3RlcFZhbHVlU2hvdWxkQmVJbnRlZ2Vy KSk7CiAKLSAgICBjb25zdCBEZWNpbWFsIHN0ZXBCYXNlID0gcGFyc2VUb051bWJlcihlbGVtZW50 KCktPmZhc3RHZXRBdHRyaWJ1dGUobWluQXR0ciksIERlY2ltYWw6OmZyb21Eb3VibGUoRGF0ZUNv bXBvbmVudHM6Om1pbmltdW1Nb250aCgpKSk7CisgICAgY29uc3QgRGVjaW1hbCBzdGVwQmFzZSA9 IHBhcnNlVG9OdW1iZXIoZWxlbWVudCgpLT5mYXN0R2V0QXR0cmlidXRlKG1pbkF0dHIpLCBEZWNp bWFsOjpmcm9tRG91YmxlKG1vbnRoRGVmYXVsdFN0ZXBCYXNlKSk7CiAgICAgY29uc3QgRGVjaW1h bCBtaW5pbXVtID0gcGFyc2VUb051bWJlcihlbGVtZW50KCktPmZhc3RHZXRBdHRyaWJ1dGUobWlu QXR0ciksIERlY2ltYWw6OmZyb21Eb3VibGUoRGF0ZUNvbXBvbmVudHM6Om1pbmltdW1Nb250aCgp KSk7CiAgICAgY29uc3QgRGVjaW1hbCBtYXhpbXVtID0gcGFyc2VUb051bWJlcihlbGVtZW50KCkt PmZhc3RHZXRBdHRyaWJ1dGUobWF4QXR0ciksIERlY2ltYWw6OmZyb21Eb3VibGUoRGF0ZUNvbXBv bmVudHM6Om1heGltdW1Nb250aCgpKSk7CiAgICAgY29uc3QgRGVjaW1hbCBzdGVwID0gU3RlcFJh bmdlOjpwYXJzZVN0ZXAoYW55U3RlcEhhbmRsaW5nLCBzdGVwRGVzY3JpcHRpb24sIGVsZW1lbnQo KS0+ZmFzdEdldEF0dHJpYnV0ZShzdGVwQXR0cikpOwo=