91601 2012-07-18 01:12:49 -0700 Regression (r122913) webkitpy tests are failing 2012-07-18 01:39:42 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91542 1 tmpsantos tmpsantos abarth don.olmstead dpranke kkristof ojan webkit.review.bot oldest_to_newest 672107 0 tmpsantos 2012-07-18 01:12:49 -0700 [0/1447] webkit2.messages_unittest.HeaderTest.test_header [689/1447] webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_broken_pipe erred: Traceback (most recent call last): File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/port/server_process_unittest.py", line 129, in test_broken_pipe server_process.write("should break") File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/port/server_process.py", line 144, in write self.stop() File "/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Tools/Scripts/webkitpy/layout_tests/port/server_process.py", line 331, in stop timeout = time.time() + self._port.process_kill_time() AttributeError: 'TrivialMockPort' object has no attribute 'process_kill_time' 672113 1 152959 tmpsantos 2012-07-18 01:18:09 -0700 Created attachment 152959 Patch 672120 2 kkristof 2012-07-18 01:23:55 -0700 Sorry I didn't notice that you working on this. I was already done this in r122913 (http://trac.webkit.org/changeset/122932) 672125 3 kkristof 2012-07-18 01:26:49 -0700 (In reply to comment #2) > Sorry I didn't notice that you working on this. I was already done this in r122913 (http://trac.webkit.org/changeset/122932) And I have some problems with the numbers :) r122932 672131 4 tmpsantos 2012-07-18 01:39:42 -0700 (In reply to comment #2) > Sorry I didn't notice that you working on this. I was already done this in r122913 (http://trac.webkit.org/changeset/122932) No problem. But maybe next time would be nice to follow the standard patch submitting flow to avoid this kind of duplication. 152959 2012-07-18 01:18:09 -0700 2012-07-18 01:32:45 -0700 Patch bug-91601-20120718111807.patch text/plain 1358 tmpsantos U3VidmVyc2lvbiBSZXZpc2lvbjogMTIyOTI0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTlhNjI1ZmVjNGZhYWM1OGM2ZDQ4YjZlOGFiYTJlNDYy NmI4ZTdjMS4uOWQ0M2U2YWViOWI2NTA2YzBhZDgzZTIxNzExZWVlYWJkYzk0MWU5ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEyLTA3LTE4ICBUaGlhZ28gTWFyY29zIFAuIFNhbnRvcyAgPHRoaWFnby5zYW50b3NA aW50ZWwuY29tPgorCisgICAgICAgIFJlZ3Jlc3Npb24gKHIxMjI5MTMpIHdlYmtpdHB5IHRlc3Rz IGFyZSBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05MTYwMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9zZXJ2ZXJfcHJvY2Vzc191 bml0dGVzdC5weToKKyAgICAgICAgKFRyaXZpYWxNb2NrUG9ydC5wcm9jZXNzX2tpbGxfdGltZSk6 CisKIDIwMTItMDctMTcgIFhpYW56aHUgV2FuZyAgPHdhbmd4aWFuemh1QGNocm9taXVtLm9yZz4K IAogICAgICAgICBbQ2hyb21pdW0tQW5kcm9pZF0gUnVuIHJlZiB0ZXN0cyB0b2dldGhlciB0byBh dm9pZCBleHBlbnNpdmUgZHJpdmVyIHJlc3RhcnRzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3NlcnZlcl9wcm9jZXNzX3VuaXR0ZXN0LnB5IGIv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9zZXJ2ZXJfcHJvY2Vzc191 bml0dGVzdC5weQppbmRleCBjMDQyNmMxY2YzYWZjMDAyNGZhZTQ2YjY4ZGY4MGY0NGEwNjhhNGRl Li41OTFjZTE3MTcyMjcxMGNiZDQ5ZjNhMGIyZTczODFjYzBlNWNjZjkxIDEwMDY0NAotLS0gYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L3NlcnZlcl9wcm9jZXNzX3Vu aXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv c2VydmVyX3Byb2Nlc3NfdW5pdHRlc3QucHkKQEAgLTQ4LDYgKzQ4LDkgQEAgY2xhc3MgVHJpdmlh bE1vY2tQb3J0KG9iamVjdCk6CiAgICAgZGVmIGNoZWNrX2Zvcl9sZWFrcyhzZWxmLCBwcm9jZXNz X25hbWUsIHByb2Nlc3NfcGlkKToKICAgICAgICAgcGFzcwogCisgICAgZGVmIHByb2Nlc3Nfa2ls bF90aW1lKHNlbGYpOgorICAgICAgICByZXR1cm4gMy4wCisKIAogY2xhc3MgTW9ja0ZpbGUob2Jq ZWN0KToKICAgICBkZWYgX19pbml0X18oc2VsZiwgc2VydmVyX3Byb2Nlc3MpOgo=