91600 2012-07-18 01:08:11 -0700 [Qt] Modify the using of the QImage::Format enum to the appropriate functions from NativeImageQt 2012-07-18 05:50:57 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified All RESOLVED FIXED P2 Normal --- 1 zoltan zoltan cmarcelo menard noam webkit.review.bot oldest_to_newest 672100 0 zoltan 2012-07-18 01:08:11 -0700 Use NativeImageQt::defaultFormatForAlphaEnabledImages() and NativeImageQt::defaultFormatForOpaqueImages() instead of the direct imagetypes at the appropriate places. 672115 1 152960 zoltan 2012-07-18 01:21:31 -0700 Created attachment 152960 Patch 672285 2 152960 kling 2012-07-18 05:45:06 -0700 Comment on attachment 152960 Patch LGTM. 672294 3 152960 webkit.review.bot 2012-07-18 05:50:51 -0700 Comment on attachment 152960 Patch Clearing flags on attachment: 152960 Committed r122953: <http://trac.webkit.org/changeset/122953> 672295 4 webkit.review.bot 2012-07-18 05:50:57 -0700 All reviewed patches have been landed. Closing bug. 152960 2012-07-18 01:21:31 -0700 2012-07-18 05:50:51 -0700 Patch format_native.patch text/plain 6975 zoltan ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkYjkzOGU4Li4wMTk5NjdlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTItMDctMTggIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAg ICAgICAgW1F0XSBNb2RpZnkgdGhlIHVzaW5nIG9mIHRoZSBRSW1hZ2U6OkZvcm1hdCBlbnVtIHRv IHRoZSBhcHByb3ByaWF0ZSBmdW5jdGlvbnMgZnJvbSBOYXRpdmVJbWFnZVF0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05MTYwMAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSBOYXRpdmVJbWFnZVF0Ojpk ZWZhdWx0Rm9ybWF0Rm9yQWxwaGFFbmFibGVkSW1hZ2VzKCkgYW5kIE5hdGl2ZUltYWdlUXQ6OmRl ZmF1bHRGb3JtYXRGb3JPcGFxdWVJbWFnZXMoKQorICAgICAgICBpbnN0ZWFkIG9mIHRoZSBkaXJl Y3QgaW1hZ2V0eXBlcyBhdCB0aGUgYXBwcm9wcmlhdGUgcGxhY2VzLgorCisgICAgICAgIENvdmVy ZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9H cmFwaGljc0NvbnRleHQzRFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4 dDNEOjpwYWludFRvQ2FudmFzKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9xdC9QYXRo UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6c2NyYXRjaENvbnRleHQpOgorICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6VGV4dHVyZU1hcHBlckdMOjpkcmF3UmVwYWludENvdW50ZXIpOgorICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVySW1hZ2VCdWZmZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6Qml0bWFwVGV4dHVyZUltYWdlQnVmZmVyOjp1cGRhdGVDb250ZW50cyk6 CisKIDIwMTItMDctMTcgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29t PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjI4MzQuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4 dDNEUXQuY3BwCmluZGV4IDExMzZmYjguLjg5NWY3NjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3Bw CkBAIC0yOSw2ICsyOSw3IEBACiAjaW5jbHVkZSAiSG9zdFdpbmRvdy5oIgogI2luY2x1ZGUgIklt YWdlQnVmZmVyLmgiCiAjaW5jbHVkZSAiSW1hZ2VEYXRhLmgiCisjaW5jbHVkZSAiTmF0aXZlSW1h Z2VRdC5oIgogI2luY2x1ZGUgIk5vdEltcGxlbWVudGVkLmgiCiAjaW5jbHVkZSAiT3BlbkdMU2hp bXMuaCIKICNpbmNsdWRlICJRV2ViUGFnZUNsaWVudC5oIgpAQCAtNDY4LDcgKzQ2OSw3IEBAIGJv b2wgR3JhcGhpY3NDb250ZXh0M0Q6Om1ha2VDb250ZXh0Q3VycmVudCgpCiB2b2lkIEdyYXBoaWNz Q29udGV4dDNEOjpwYWludFRvQ2FudmFzKGNvbnN0IHVuc2lnbmVkIGNoYXIqIGltYWdlUGl4ZWxz LCBpbnQgaW1hZ2VXaWR0aCwgaW50IGltYWdlSGVpZ2h0LAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBpbnQgY2FudmFzV2lkdGgsIGludCBjYW52YXNIZWlnaHQsIFFQYWlu dGVyKiBjb250ZXh0KQogewotICAgIFFJbWFnZSBpbWFnZShpbWFnZVBpeGVscywgaW1hZ2VXaWR0 aCwgaW1hZ2VIZWlnaHQsIFFJbWFnZTo6Rm9ybWF0X0FSR0IzMl9QcmVtdWx0aXBsaWVkKTsKKyAg ICBRSW1hZ2UgaW1hZ2UoaW1hZ2VQaXhlbHMsIGltYWdlV2lkdGgsIGltYWdlSGVpZ2h0LCBOYXRp dmVJbWFnZVF0OjpkZWZhdWx0Rm9ybWF0Rm9yQWxwaGFFbmFibGVkSW1hZ2VzKCkpOwogICAgIGNv bnRleHQtPnNhdmUoKTsKICAgICBjb250ZXh0LT50cmFuc2xhdGUoMCwgaW1hZ2VIZWlnaHQpOwog ICAgIGNvbnRleHQtPnNjYWxlKDEsIC0xKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3F0L1BhdGhRdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9xdC9QYXRoUXQuY3BwCmluZGV4IDNiMGNhMWIuLjJlYWFmZjhmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9QYXRoUXQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L1BhdGhRdC5jcHAKQEAgLTM1LDYgKzM1 LDcgQEAKICNpbmNsdWRlICJGbG9hdFJlY3QuaCIKICNpbmNsdWRlICJHcmFwaGljc0NvbnRleHQu aCIKICNpbmNsdWRlICJJbWFnZUJ1ZmZlci5oIgorI2luY2x1ZGUgIk5hdGl2ZUltYWdlUXQuaCIK ICNpbmNsdWRlICJQbGF0Zm9ybVN0cmluZy5oIgogI2luY2x1ZGUgIlN0cm9rZVN0eWxlQXBwbGll ci5oIgogI2luY2x1ZGUgPFFQYWludGVyUGF0aD4KQEAgLTExOCw3ICsxMTksNyBAQCBib29sIFBh dGg6OmNvbnRhaW5zKGNvbnN0IEZsb2F0UG9pbnQmIHBvaW50LCBXaW5kUnVsZSBydWxlKSBjb25z dAogCiBzdGF0aWMgR3JhcGhpY3NDb250ZXh0KiBzY3JhdGNoQ29udGV4dCgpCiB7Ci0gICAgc3Rh dGljIFFJbWFnZSBpbWFnZSgxLCAxLCBRSW1hZ2U6OkZvcm1hdF9BUkdCMzJfUHJlbXVsdGlwbGll ZCk7CisgICAgc3RhdGljIFFJbWFnZSBpbWFnZSgxLCAxLCBOYXRpdmVJbWFnZVF0OjpkZWZhdWx0 Rm9ybWF0Rm9yQWxwaGFFbmFibGVkSW1hZ2VzKCkpOwogICAgIHN0YXRpYyBRUGFpbnRlciBwYWlu dGVyKCZpbWFnZSk7CiAgICAgc3RhdGljIEdyYXBoaWNzQ29udGV4dCogY29udGV4dCA9IG5ldyBH cmFwaGljc0NvbnRleHQoJnBhaW50ZXIpOwogICAgIHJldHVybiBjb250ZXh0OwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJH TC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1h cHBlckdMLmNwcAppbmRleCBjY2EyZTI3Li42ODhlMjZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNw cApAQCAtMzgsNiArMzgsNyBAQAogI2VuZGlmCiAKICNpZiBQTEFURk9STShRVCkKKyNpbmNsdWRl ICJOYXRpdmVJbWFnZVF0LmgiCiAjaWYgSEFWRShRVDUpCiAjaW5jbHVkZSA8UU9wZW5HTENvbnRl eHQ+CiAjZWxzZQpAQCAtMzc3LDcgKzM3OCw3IEBAIHZvaWQgVGV4dHVyZU1hcHBlckdMOjpkcmF3 UmVwYWludENvdW50ZXIoaW50IHZhbHVlLCBpbnQgcG9pbnRTaXplLCBjb25zdCBGbG9hdFBvCiAg ICAgSW50UmVjdCBzb3VyY2VSZWN0KEludFBvaW50Ojp6ZXJvKCksIHNpemUpOwogICAgIEludFJl Y3QgdGFyZ2V0UmVjdChyb3VuZGVkSW50UG9pbnQodGFyZ2V0UG9pbnQpLCBzaXplKTsKIAotICAg IFFJbWFnZSBpbWFnZShzaXplLCBRSW1hZ2U6OkZvcm1hdF9BUkdCMzJfUHJlbXVsdGlwbGllZCk7 CisgICAgUUltYWdlIGltYWdlKHNpemUsIE5hdGl2ZUltYWdlUXQ6OmRlZmF1bHRGb3JtYXRGb3JB bHBoYUVuYWJsZWRJbWFnZXMoKSk7CiAgICAgUVBhaW50ZXIgcGFpbnRlcigmaW1hZ2UpOwogICAg IHBhaW50ZXIuZmlsbFJlY3Qoc291cmNlUmVjdCwgUXQ6OmJsdWUpOyAvLyBTaW5jZSB3ZSB3b24n dCBzd2FwIFIrQiBmb3Igc3BlZWQsIHRoaXMgd2lsbCBwYWludCByZWQuCiAgICAgcGFpbnRlci5z ZXRGb250KGZvbnQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvdGV4bWFwL1RleHR1cmVNYXBwZXJJbWFnZUJ1ZmZlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckltYWdlQnVmZmVyLmNwcAppbmRl eCBkNTAxOWU2Li45YjBjOWE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckltYWdlQnVmZmVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckltYWdlQnVmZmVy LmNwcApAQCAtMjEsNiArMjEsMTAgQEAKICNpbmNsdWRlICJUZXh0dXJlTWFwcGVySW1hZ2VCdWZm ZXIuaCIKIAogI2luY2x1ZGUgIkZpbHRlckVmZmVjdFJlbmRlcmVyLmgiCisjaWYgUExBVEZPUk0o UVQpCisjaW5jbHVkZSAiTmF0aXZlSW1hZ2VRdC5oIgorI2VuZGlmCisKIAogI2lmIFVTRShURVhU VVJFX01BUFBFUikKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAgLTI4LDcgKzMyLDcgQEAgbmFtZXNw YWNlIFdlYkNvcmUgewogdm9pZCBCaXRtYXBUZXh0dXJlSW1hZ2VCdWZmZXI6OnVwZGF0ZUNvbnRl bnRzKGNvbnN0IHZvaWQqIGRhdGEsIGNvbnN0IEludFJlY3QmIHRhcmdldFJlY3QsIGNvbnN0IElu dFBvaW50JiBzb3VyY2VPZmZzZXQsIGludCBieXRlc1BlckxpbmUpCiB7CiAjaWYgUExBVEZPUk0o UVQpCi0gICAgUUltYWdlIGltYWdlKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3QgdWNoYXIqPihkYXRh KSwgdGFyZ2V0UmVjdC53aWR0aCgpLCB0YXJnZXRSZWN0LmhlaWdodCgpLCBieXRlc1BlckxpbmUs IFFJbWFnZTo6Rm9ybWF0X0FSR0IzMl9QcmVtdWx0aXBsaWVkKTsKKyAgICBRSW1hZ2UgaW1hZ2Uo cmVpbnRlcnByZXRfY2FzdDxjb25zdCB1Y2hhcio+KGRhdGEpLCB0YXJnZXRSZWN0LndpZHRoKCks IHRhcmdldFJlY3QuaGVpZ2h0KCksIGJ5dGVzUGVyTGluZSwgTmF0aXZlSW1hZ2VRdDo6ZGVmYXVs dEZvcm1hdEZvckFscGhhRW5hYmxlZEltYWdlcygpKTsKIAogICAgIFFQYWludGVyKiBwYWludGVy ID0gbV9pbWFnZS0+Y29udGV4dCgpLT5wbGF0Zm9ybUNvbnRleHQoKTsKICAgICBwYWludGVyLT5z YXZlKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cKaW5kZXggZWU3ODhlNDkuLmFhZjM1ZWYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMi0wNy0xOCAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Via2l0Lm9y Zz4KKworICAgICAgICBbUXRdIE1vZGlmeSB0aGUgdXNpbmcgb2YgdGhlIFFJbWFnZTo6Rm9ybWF0 IGVudW0gdG8gdGhlIGFwcHJvcHJpYXRlIGZ1bmN0aW9ucyBmcm9tIE5hdGl2ZUltYWdlUXQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTkxNjAwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIE5hdGl2ZUlt YWdlUXQ6OmRlZmF1bHRGb3JtYXRGb3JBbHBoYUVuYWJsZWRJbWFnZXMoKSBhbmQgTmF0aXZlSW1h Z2VRdDo6ZGVmYXVsdEZvcm1hdEZvck9wYXF1ZUltYWdlcygpCisgICAgICAgIGluc3RlYWQgb2Yg dGhlIGRpcmVjdCBpbWFnZXR5cGVzIGF0IHRoZSBhcHByb3ByaWF0ZSBwbGFjZXMuCisKKyAgICAg ICAgKiBTaGFyZWQvcXQvU2hhcmVhYmxlQml0bWFwUXQuY3BwOgorICAgICAgICAoV2ViS2l0OjpT aGFyZWFibGVCaXRtYXA6OmNyZWF0ZVFJbWFnZSk6CisKIDIwMTItMDctMTcgIENhcmxvcyBHYXJj aWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFBhc3RlIHBy aW1hcnkgc2VsZWN0aW9uIHdoZW4gbWlkZGxlIGNsaWNraW5nIGluIFgxMSBXZWJLaXQyCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvcXQvU2hhcmVhYmxlQml0bWFwUXQuY3BwIGIv U291cmNlL1dlYktpdDIvU2hhcmVkL3F0L1NoYXJlYWJsZUJpdG1hcFF0LmNwcAppbmRleCBiNmNl YjNlLi44OGU0ZDNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvcXQvU2hhcmVh YmxlQml0bWFwUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9xdC9TaGFyZWFibGVC aXRtYXBRdC5jcHAKQEAgLTI2LDYgKzI2LDcgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNs dWRlICJTaGFyZWFibGVCaXRtYXAuaCIKIAorI2luY2x1ZGUgIk5hdGl2ZUltYWdlUXQuaCIKICNp bmNsdWRlIDxRSW1hZ2U+CiAjaW5jbHVkZSA8UVBhaW50ZXI+CiAjaW5jbHVkZSA8UXRHbG9iYWw+ CkBAIC00MSw3ICs0Miw3IEBAIFFJbWFnZSBTaGFyZWFibGVCaXRtYXA6OmNyZWF0ZVFJbWFnZSgp CiB7CiAgICAgcmVmKCk7IC8vIEJhbGFuY2VkIGJ5IGRlcmVmIGluIHJlbGVhc2VTaGFyZWRNZW1v cnlEYXRhCiAgICAgcmV0dXJuIFFJbWFnZShyZWludGVycHJldF9jYXN0PHVjaGFyKj4oZGF0YSgp KSwgbV9zaXplLndpZHRoKCksIG1fc2l6ZS5oZWlnaHQoKSwgbV9zaXplLndpZHRoKCkgKiA0LAot ICAgICAgICAgICAgICAgICAgbV9mbGFncyAmIFN1cHBvcnRzQWxwaGEgPyBRSW1hZ2U6OkZvcm1h dF9BUkdCMzJfUHJlbXVsdGlwbGllZCA6IFFJbWFnZTo6Rm9ybWF0X1JHQjMyLAorICAgICAgICAg ICAgICAgICAgbV9mbGFncyAmIFN1cHBvcnRzQWxwaGEgPyBOYXRpdmVJbWFnZVF0OjpkZWZhdWx0 Rm9ybWF0Rm9yQWxwaGFFbmFibGVkSW1hZ2VzKCkgOiBOYXRpdmVJbWFnZVF0OjpkZWZhdWx0Rm9y bWF0Rm9yT3BhcXVlSW1hZ2VzKCksCiAgICAgICAgICAgICAgICAgICByZWxlYXNlU2hhcmVkTWVt b3J5RGF0YSwgdGhpcyk7CiB9CiAK